Re: Review Request: A usable system monitor plasmoid

and i'll post a thorough review then. cheers.. applets/graphmon/plasma-applet-graphmon.desktop <http://git.reviewboard.kde.org/r/104015/#comment8739> this needs to be properly namespaced. going into plasmaaddons, it can use the org.kde prefix: org.kde.graphmon - Aaron J. Seigo

Re: constraints and size hints

; (which inherits popupApplet) behave identically, remaining narrow and tall > in the panel. What is worse, it does not repaint on panel resize! There whe it is an icon, it behaves just fine here. do you eman when the icon is not being shown but instead the whole tab widget is put into a panel? -

Re: Newspaper layout problems and KNode bugs

r; this could be a change elsewhere that has affected the newspaper containment ... but it does, at first look anyways, seem to be an issue with events not being caught by the handle. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. __

Re: libplasma2 tasks for Saturday??

eworks branch,will we need Qt5? no. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: constraints and size hints

ning into is, just that you're running into some sizing issue on panels. spend less time letting off steam and more time communicating and we'll get further. -- Aaron J. Seigo, still working at 10:15 pm signature.asc Description: This is a digitally signed message part. ___

Re: ToolTip for a PopupApplet with QML

to be set to be the plasmoid object, and check for that in the C++ that lurks behind the bindings. we do this in a few places in the JS bindings ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel

Fwd: ToolTip for a PopupApplet with QML

ld specify for PlasmaCore.ToolTip.target. Thanks for the help in advance! Regards, Dimitar --------- -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasm

Re: Review Request: Wait for All Ignored Windows to Close in Controller

o have this property. - Aaron J. Seigo On Feb. 3, 2012, 1 p.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

erry-picking? it uses the diff of the current change; it doesn't need to replay all changes in between. of course, if a change touches code that this commit changes, then that change will need to be manually merged back. but generally git makes this as easy as it can be. > Another

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

binaries in the same moulde .. still ..) cheers ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: make UNC path work in krunner by mapping it to smb:// path

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103826/#review10472 --- Ship it! nce :) - Aaron J. Seigo On Jan. 29, 2012, 10

Re: Review Request: Improve the QML RunnerModel

nents/runnermodel/runnermodel.cpp <http://git.reviewboard.kde.org/r/103806/#comment8575> what are the use cases for these methods? i'm undecided whether i agree with them being here, but that really depends on what you plan on using them for :) - Aaron J. Seigo On Feb. 7, 2012, 11:23 p.

Re: Review Request: Fix folderview sorting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103895/#review10464 --- Ship it! Ship It! - Aaron J. Seigo On Feb. 9, 2012, 6:22

Re: FrameSVG manual reload on themeChanged()

d be wrong (in which case we need to fix it in libplasma). if you could confirm the number of paint events that actually get triggered that would be excellent. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___

Re: [RFC] File ending for packaged KWin effects and where to put them

(e.g. i don't want kwin, plasma-desktop, etc. etc. all implementing this on their own, which they would nominally have to at this point.) i'll rachet this up on my todo list since kwin would now be blocking on it. -- Aaron J. Seigo signature.asc Description: This is a digitally sign

Re: Data engine update issue in Javascript

just be able to begin debugging ... thanks. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: telling a data engine to reload a source

ion then the DataEngine needs to provide a Service (returned by serviceForSource in the DataEngine implementation) that can be used by the visualization. however, i would strongly encourage you to first ensure that the use case is actually correct. cheers ... -- Aaron J. Seigo signature.asc Descr

Re: Fwd: GSOC Mentor

nals (there's probably 3-4 of us, not all around all the time though) this might be a GSOC i'd pick up ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Python plasmoid and configChanged()

necessary in any case. and just in case something odd is going on .. the init function is indeed only being called once, correct? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasm

Re: dictionary widget QML

om the plasmoid. but this is where (again) the KConfigXt+Qt Designer pair let us down; they just aren't flexible enough in their current state. can we do better in libplasma2? i hope so :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.

Re: Python plasmoid and configChanged()

you call configChanged() from anywhere else in the plasmoid code? i tried just now with a C++ plasmoid, and it is not happening. tried again with a JS plasmoid, also not happening there either. so it seems this is something in your plasmoid or in the python bindings? -- Aaron J. Seigo signature.

Re: dictionary widget QML

Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KConfigXT default value code evaluation

es generation, compilation and execution of C++ code. obviously, this is a "no- go". it may be possible to run it in the runtime of the plasmoid (meaning it would become python in a python plasmoid, JS in a JS plasmoid, etc) but that would require a fair amount more work on the configxt s

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103860/#review10333 --- Ship it! Ship It! - Aaron J. Seigo On Feb. 3, 2012, 7:16

Re: Review Request: Add a link to the current desktop folder instead of an icon applet if the desktop is set to folderview on the "Add to Desktop" Kickoff action

Applet and which doesn't result in assumptions about what the source or targets are. plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <http://git.reviewboard.kde.org/r/103830/#comment8447> i would turn this into a an "else if" and get rid of one level of ind

Re: Review Request: Fix incorrect painting of Plasma::IconWidget on double-click with KDE set to double-click

ttp://git.reviewboard.kde.org/r/103831/#comment8446> this comment is misleading: in libplasma we do not care about "applets in panels". what matters is that someone is listening to the signal for clicked() which means that we have a specific use case that needs to be fulfilled. - Aaron J. Se

Re: Review Request: Add accepted signal to TextField

documentation. once the documentation is updated, this can go in.. cheers :) - Aaron J. Seigo On Jan. 26, 2012, 9:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Add accepted signal to TextField

g/r/103795/#comment8335> looks like this snuck in to the review... - Aaron J. Seigo On Jan. 26, 2012, 8:45 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Fwd: Forward porting policy

> 3. Should I just commit to 4.8 or wait for somebody else to do the > merge periodically (optimal solution IMHO)? please merge 4.8 into trunk after you've done your commit. i suppose we could set up someone as the "merge dude" who does this once a week, though. -- Aaron

Re: prep'ing the QML screenlocker for a merge into master

On Friday, January 20, 2012 15:31:52 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: > On Friday 20 January 2012 15:02:39 Aaron J. Seigo wrote: > > * the lock screen qml is currently stored in share/apps/kscreenlocker/ .. > > this seems ripe for file collisions in the case of multi

prep'ing the QML screenlocker for a merge into master

ing this happen. people willing to pitch in are welcome to do so! -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message p

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

/applets/folderview/iconview.cpp <http://git.reviewboard.kde.org/r/103735/#comment8220> hm can be cons. also, spaces around the + signs, please - Aaron J. Seigo On Jan. 19, 2012, 2:38 p.m., Ignat Semenov wrote: > > ---

Re: Review Request: Add some introspection to the Plasma::AbstractRunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103718/#review9916 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 17, 2012, 7:05

Re: Share-like-connect API?

ctivities there is a ResourceInstance class that your application should use. all the details are handled for you from there (dbus, etc) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development F

Re: Review Request: Fix the issues introduced with the iconshrink patch

the rect is aligned vertical and horizontal center, then it is moved to the top? plasma/applets/folderview/iconview.cpp <http://git.reviewboard.kde.org/r/103685/#comment8097> why 0.05? is this the amount the icon is shrunk by? - Aaron J. Seigo On Jan. 12, 2012, 7:40

Re: Access D-BUS through QML/JS

ervice in a DataEngine, and i'd recommend adding it to PowerManagementService in the powermanagement engine in kde-workspace/plasma/generic/dataengines/powermanagement/ -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE

Re: Review Request: Fix "Add to desktop" from Kickoff when you have several virtual desktops and you enable "Different widgets for each desktop"

ddity into plasma code. plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <http://git.reviewboard.kde.org/r/103645/#comment8045> spaces around the '-' please :) - Aaron J. Seigo On Jan. 6, 2012, 9

Re: Review Request: Add little margin to widget explorer in dashboard view

! switch this to use KDialog::marginHint() and commit. thanks. plasma/desktop/shell/dashboardview.cpp <http://git.reviewboard.kde.org/r/103564/#comment8044> where does the magic 13 come from? should probably be using the static int KDialog::marginHint() .. - Aaron J. Seigo On D

Re: Review Request: icon plasmoid - http url naming

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/#review9741 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 10, 2012, 1:41

Re: [kde-workspace] plasma/generic/tools/plasmoidviewer: Make plasmoidviewer have non-persistent applet config files.

eset, using the config dialog is often a viable and very simple optin too. so having the -pr flag[1] is great, the implementation looks fine, but the default is backwards. [1] does that even work? i thought those flags had to be single character? if that does work: neat and kudos to KCmdLineOpt

Re: Python: reading plasmoid configuration with KConfig XT

in your widget is called. reimplement that... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part.

Re: FolderView Overlay Incapsulation Question

ontinued testing ... finally discovered it is only broken in the case where it is being used as a containment. "when used as a containment" is a useful bit of information ;) i'm fixing it right now (problem is in kde-workspace/libs/plasmagenericshell, for the curious :) --

Re: Tooltip timeout question

h as this, where the contents want to cycle around, > displaying not just fixed content? tooltips can say they should not be hidden automatically by setting the appropriate flag in ToolTipContent. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2

Re: flowout proposal

ktop/containments/panel/ ... it would need to track where popups for applets are and not draw the border there. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signatur

Re: question about panel size guideline

On Tuesday, January 10, 2012 19:30:44 Reza Shah wrote: > On Sat, Dec 31, 2011 at 5:57 PM, Aaron J. Seigo wrote: > > On Tuesday, December 27, 2011 21:16:19 Reza Shah wrote: > >> so, do we have some guideline regarding the panel for example: > >> - minimum size or maximu

Re: Geolocation DataEngine broken?

On Saturday, December 31, 2011 09:50:30 Luca Beltrame wrote: > In data sabato 31 dicembre 2011 09:45:37, Aaron J. Seigo ha scritto: > > * fix the dataengine > > This poses the problem that the current service used by the dataengine now > requires an API key to operate, and

Re: question about panel size guideline

ks widget similarly does not scale visually down below 22px very nicely. the count below the arrow on groups is too tall, the frame too thick on small panels. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer spo

Re: Geolocation DataEngine broken?

* fix the dataengine * make it use JS for interacting with the web service so we can easily update it via synchrotron, including older (in the future ;) releases. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer spo

Re: Kickoff w/Breadcrumbs in QML

n find UX people have a blind spot for aesthetics and an emphasis on the theoretical over the practical. so ... everything with moderation. > included in Plasma by default. Available from KDE-Look, certainly, but > KDE3's days were long ago. we have people asking for it, and it's a

Re: Kickoff-QML and classic launcher

On Saturday, December 24, 2011 03:29:19 Kevin Kofler wrote: > Aaron J. Seigo wrote: > > it's really a horrible hack and i'd suggest getting rid of it. people can > > add the classic menu from the widget explorer like all the rest. > > This is just going to make it

Re: Kickoff-QML and classic launcher

manner". to remind everyone: please participate constructively and ensure your input is more than one-liner zingers, grumpiness and/or repeatition of whinging. thanks ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE

Re: Breadcrumbs in Kickoff

cross the tabs. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma

Re: Review Request: Integrate Plasma Scripting Console with KWin scripting

with the addition of a drop down in the toolbar to switch between modes easily - Aaron J. Seigo On Dec. 23, 2011, 2:24 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Kickoff-QML and classic launcher

but even if you don't i'd love it if you could work as a "client" for this work and help define what you would like to see in terms of integration and capabilities for the scripts you have and would like to write in the future. -- Aaron J. Seigo humru othro a kohnu se GPG

Re: Kickoff-QML and classic launcher

p people achieve the look and feel they want without having to painstakingly hand-craft it every time they install ... what do you think? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt De

Re: Kickoff-QML and classic launcher

dd a "Classic KDE" panel script option that creates a panel just like in KDE 3. heck, it could even change the desktop use icons only. this would be rather trivial to make happen for 4.9 .. thoughts? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6

Re: folderview broken

instead in this case and it works well.. thanks.. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed m

Re: 4.8 branch

On Wednesday, December 21, 2011 11:45:16 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: > Am 21.12.2011 11:20, schrieb Aaron J. Seigo: > > hi :) > > > > some of you will have noticed that there is now a KDE/4.8 branch in > > the > > modules. i would like to request

4.8 branch

resort to cherry-picking ... cheers :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part

Re: folderview broken

work properly at this point. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digital

Re: plasmapkg removing

you can be relatively confident others (e.g. upstream Plasma) won't use p.s. the collection of scripts is getting really rather impressive. i just checked out the svn module and will poke my nose around in their some more :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209

Re: Breadcrumbs in Kickoff

thousands of bridges in my life and continue to use them every day. so while the amount of feedback is a useful metric (and in this case, it's not very high), and listening to what the _problem_ is is useful .. usually the suggested solution content is less useful. in this particular

Re: Review Request: Update 'Pattern Wallpaper' configuration interface layout

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103365/#review9122 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 9, 2011, 2:42

Re: Breadcrumbs in Kickoff

he breadcrumbs are more consistent with what we see elsewhere (file dialog, dolphin, ..) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is

Re: Small QML related questions...

On Monday, December 19, 2011 06:32:17 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: > On Sunday 18 December 2011 22:07:46 Aaron J. Seigo wrote: > > On Sunday, December 18, 2011 18:43:06 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= > > > > wrote: > > > Hi all, > > >

Re: Small QML related questions...

ly and I think this could help in general to make it more clear > that these are Tabs. not really; this is where we need to decide to either: * think about how we want TabBar to look and make it so that it looks "more integrated" everywhere (ala kickoff) * or we decide not to, mak

Re: QML Activity List

On Sunday, December 18, 2011 11:31:26 Luiz =?ISO-8859-1?Q?Rom=E1rio?= Santana Rios wrote: > 2011/12/18 Aaron J. Seigo : > > On Sunday, December 18, 2011 01:28:38 Luiz =?ISO-8859-1?Q?Rom=E1rio?= > > Santana> > > Rios wrote: > >> 1 - As it's a regular applet t

Re: Review Request: Reset time format upon user request

ok at making KLocale work better for us here :) plasma/generic/applets/digital-clock/clock.cpp <http://git.reviewboard.kde.org/r/103434/#comment7475> this still realy ought to be done in klocale - Aaron J. Seigo On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

On Saturday, December 17, 2011 20:33:37 you wrote: > should i push? sure .. :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digita

Re: QML Activity List

what you want to do. there is documentation coming together for them in the kde-runtime module; there are examples in kdeexampls and there is additional QML / JS API dox on techbase ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43

Re: Breadcrumbs in Kickoff

would be able to buy and use > a mouse with Thumb buttons, "back" and "forward", and just whack the regardless of what is done elsewhere (breadcrumbs, etc) this would be a fine idea. Qt won't support more mouse buttons until Qt5, but perhaps we could put an x- specific

Re: qtcomponents documentation

On Saturday, December 17, 2011 18:11:06 Marco Martin wrote: > On Saturday 17 December 2011, Aaron J. Seigo wrote: > > On Saturday, December 17, 2011 13:39:05 Marco Martin wrote: > > > Hi all, > > > > > > I think we should do a real documentation sprint for the

Re: qtcomponents documentation

On Saturday, December 17, 2011 13:39:05 Marco Martin wrote: > Hi all, > > I think we should do a real documentation sprint for the plasma > qtcomponents, to have a good api doc for the 4.8 release. and ideas / preferences on when and where? -- Aaron J. Seigo humru othro a

Re: Review Request: Reset time format upon user request

s should be checking what has been changed and only changing on SettingsChanged. (we don't need to do this on, for instance, icon or cursor changes ;) - Aaron J. Seigo On Dec. 16, 2011, 6:35 p.m., Lamarque Vieira Souza wrote: > > --

Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

/activityengine.cpp <http://git.reviewboard.kde.org/r/103358/#comment7469> can be made const. - Aaron J. Seigo On Dec. 16, 2011, 12:25 a.m., Romário Rios wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

. - Aaron J. Seigo On Dec. 16, 2011, 12:12 p.m., Giorgos Tsiapaliwkas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

url is set twice in a row to a non-local file, then it will connect to this signal multiple times. this is easily controlled, however, by adding Qt::UniqueConnection to the parameters passed to connect. - Aaron J. Seigo On Dec. 16, 2011, 6:20 a.m., Sujith Haridasan

Re: problem with icontask and javascript

iguration group path, with each entry in the array representing a sub-group. This allows one to access trees of groups with code such as: widget.currentConfigGroup = new Array('topGroup', 'subGroupOfTopGroup'). An empty Array means the default (top-level) configuration gro

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

ttp://git.reviewboard.kde.org/r/103393/#comment7460> this much be before the if on line 408 otherwise the return statement will prevent this connection from being made, defeating the purpose of this :) also, Solid::Networking::shouldConnect() should just be shouldConnect() - Aaron J. Seigo

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

this way when the url changes from remote to local in the config, the signal is no longer listened for. - Aaron J. Seigo On Dec. 14, 2011, 3:21 a.m., Sujith Haridasan wrote: > > --- > This is an automatically genera

Re: 4.8.0 "Easy Jobs"

On Tuesday, December 13, 2011 21:05:29 Martin Klapetek wrote: > On Tue, Dec 13, 2011 at 13:36, Martin Gräßlin wrote: > > Am 13.12.2011 12:54, schrieb Aaron J. Seigo: > > On Tuesday, December 13, 2011 10:19:30 Martin > > =?ISO-8859-1?Q?Gräßlin?> > > >> wrote

Re: 4.8.0 "Easy Jobs"

On Tuesday, December 13, 2011 10:19:30 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: > Am 13.12.2011 09:51, schrieb Aaron J. Seigo: > > http://bugs.kde.org/287027 - update favorites when ksycoca changes > > due to the rather strong changes I already have in the models I would > ap

Re: 4.8.0 "Easy Jobs"

On Tuesday, December 13, 2011 10:19:30 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: > Am 13.12.2011 09:51, schrieb Aaron J. Seigo: > > http://bugs.kde.org/287027 - update favorites when ksycoca changes > > due to the rather strong changes I already have in the models I would > ap

Re: 4.8.0 "Easy Jobs"

... and one more here as well that i forgot to add to the list: https://bugs.kde.org/show_bug.cgi?id=280222 <-- in libplasmaclock, when disabling events, make the widget the calender is being shown in smaller. otherwise the calendar gets really wide and looks odd :) -- Aaron J. Seigo hu

Re: important issues to address for 4.8.0

one more: https://bugs.kde.org/show_bug.cgi?id=288873 <--- regression: custom activity icons are lost. Ivan: could you look into this as it seems this would be related to kactivitymanagerd -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2

4.8.0 "Easy Jobs"

attery::updateSlider in battery widget) http://bugs.kde.org/256064: world clock plasmoid does not grow in the panel http://bugs.kde.org/240198: take exiv2 code from kdeplasma- addons/applets/frame/imageloader.cpp and add it to kdelibs/plasma/wallpaperrenderthread.cpp -- Aaron J. Seigo humru

important issues to address for 4.8.0

lt;-- try to preserve unloadable applet configs https://bugs.kde.org/279935 <-- infinite resizing bug with looong texts on buttons in a linear layout https://bugs.kde.org/288827 <-- regression in device notifier -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1

Re: Runner runOptions Guidelines

nce parameters being set by these are > program- wide, this can be a complication. it is really hard for me to understand what you are trying to accomplish and how what you are doing works. perhaps you could just point us to the code for your runner and i could take a look directly? -- A

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

.org/r/103393/#comment7407> this needs to be indented properly. also, instead of a knotification, which will appear somewhere unrelated, try using the setMessage method that comes with Plasma::Applet - Aaron J. Seigo On Dec. 12, 2011, 3:40 p.m., Sujith

Re: Runner runOptions Guidelines

e no idea what you are refering to here. can you please be more technical and specific and/or include a screenshot? thanks. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks sign

Re: Review Request: plasmoid qalculate - menu button

_history.h <http://git.reviewboard.kde.org/r/103052/#comment7383> should be const. - Aaron J. Seigo On Dec. 8, 2011, 8:48 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Ghost entry in icontasks

oses. i don't know why, and while superficially the results look similar, it's not the same sort of issue at all -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks sig

Re: Review Request: Activity Dataengine: Delete the KActivities::Info when an activity is removed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103351/#review8779 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 7, 2011, 3:30

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

) rssnow/package/contents/ui/main.qml <http://git.reviewboard.kde.org/r/103347/#comment7352> this may be more easily / clearly expressed as: entryLIst.currentIndex = (entryList.currentIndex + 1) % entryList.count - Aaron J. Seigo On Dec. 6, 2011, 2:28 p.m., Giorgos T

Re: Review Request: plasmoid qalculate - menu button

ake m_output appear before m_historyButton in the layout, use insertItem instead of addItem :) - Aaron J. Seigo On Nov. 11, 2011, 5:41 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request: port dictionary qml to Plasma Components

> On Nov. 17, 2011, 11:34 a.m., Marco Martin wrote: > > dictionary/package/contents/ui/main.qml, line 80 > > > > > > clearbuttonShown is available again in the textfield api, so it can stay > > Giorgos Tsiapaliwkas

Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService

good to go. note that in frameworks, there is no packagemetadata anymore. - Aaron J. Seigo On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote: > > --- > This is an automatically generated e-mail. To reply, visi

bug triage motivational message ;)

d 4.10 dev cycles, we can try to half that number and reach the Big Goal that Martin proposed of getting it down to ~500 reports and then hold it there (or lower :) from that point going forward. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1

Re: Review Request: some fixes for cppcheck warnings

lves a crash, please put a comment in here explaining that the order of deletion matters so it doesn't get reintroduced at some point in the future. - Aaron J. Seigo On Dec. 4, 2011, 12:22 p.m., Jaime Torres Amate wrote: > > ---

Re: Krunner using both actions and runoptions

ve to force the action icon leftward, even if there be no runOptions > icon shown! backtraces are helpful, but 4.6.4 is missing all the fixes made to 4.7 since we started working on 4.8 ... so .. i'm not overly surprised... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8

<    7   8   9   10   11   12   13   14   15   16   >