D28338: [PowerDevil Runner] Remove unused KRun include

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28338

D28317: Adjust default color scheme and titlebar appearance for Tools Area

broulik added a comment. You are not changing the close button to not be a filled circle, are you? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ConfigEntries.qml:226 > case "disabled": > if (extraIndex > -1) { >

D28306: Make the hover state clarifying, but not main

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in Task.qml:331 > this is a bit longwinded, can we make a function in TasksTools? We can use ECMAScript 6 now, use spread syntax: return [ ...TaskTools.taskPrefix(etc), ...foo, ...bar ]; Note the `...`

D28308: [FormLayout] Set compression timer interval to 0

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f6e15f51cac7: [FormLayout] Set compression timer interval to 0 (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28308?vs=78546=78559

D28308: [FormLayout] Set compression timer interval to 0

broulik created this revision. broulik added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Apparently `Timer` default interval is `1000` :) TEST PLAN - Putting a `FormLayout` into a

D28277: [UrlButton] Disable when there is no URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d6cfab5bec74: [UrlButton] Disable when there is no URL (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28277?vs=78460=78538 REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik updated this revision to Diff 78521. broulik retitled this revision from "WIP: [Task Manager] Port backend to ApplicationLauncherJob" to "[Task Manager] Port backend to ApplicationLauncherJob". broulik edited the summary of this revision. broulik edited the test plan for this revision.

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

broulik planned changes to this revision. broulik added a comment. I'll look into creating a `KNotificationUiDelegate` or something along the lines REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: plasma-devel,

D28262: [applets/analog-clock] Optional minute hand

broulik added a comment. > I can not find a kcfg file in this applet to simply extend In applets it's the `config.xml` you edited, so from a technical POV patch is good. Not sure this option is very useful, however. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

broulik created this revision. broulik added reviewers: Plasma, hein, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In the process, port jump list actions from custom `KDesktopFile` parsing to

D28277: [UrlButton] Disable when there is no URL

broulik updated this revision to Diff 78460. broulik retitled this revision from "[UrlButton] Don't show tooltip if it would be empty" to "[UrlButton] Disable when there is no URL". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D28277: [UrlButton] Don't show tooltip if it would be empty

broulik created this revision. broulik added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN F8198260: Screenshot_20200325_141929.png None of these links

D28276: only add devices to the smb mount model that are network shares

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. This is because the device monitor emits all devices, not the query returning unwanted devices? REPOSITORY R102 KInfoCenter BRANCH smb-type-check2 REVISION DETAIL

D28270: [Colors KCM] Also save colors when active scheme was edited

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0f673d0e92b: [Colors KCM] Also save colors when active scheme was edited (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28270?vs=78431=78436#toc REPOSITORY R119

D28270: [Colors KCM] Also save colors when active scheme was edited

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I fixed the case that the "Apply" button wasn't enabled when the selected scheme didn't change

D28215: [RFC]: WIP: Make mobile broadband actually functional

broulik added inline comments. INLINE COMMENTS > mobileproviders.h:31 > > -class MobileProviders > +class MobileProviders : public QObject > { Needs `Q_OBJECT` macro > mobileproviders.h:38 > > -MobileProviders(); > +MobileProviders(QObject* parent = 0); > ~MobileProviders();

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf28d5d2b4f4: [VirtualDesktopInfo] Connect to rowsChanged singal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > webshortcutrunner.cpp:79 > const int delimIndex = term.indexOf(m_delimiter); > -if (delimIndex == term.length() - 1) > +if (delimIndex == -1 || delimIndex == term.length() - 1){ > return;

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than relying on KWin to have reconfigured, which isn't the case when merely changing

D28211: [applets/systemtray] Make Pin button a bit larger

broulik added a comment. F8194458: Screenshot_20200323_102203.png Gets pretty large here, surely bigger than `small` icon size. Maybe another PlasmaComponents 3 issue? REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched

D28209: [applets/notes] Actually hide button row when it's not visible

broulik added a comment. Wouldn't this cause the text field to resize and shift around? Perhaps set `enabled` to false instead. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, Orage, LeGast00n,

Re: Drag and drop to system tray

Hi, I think Martin means a behavior similar to the task manager where dragging a file over a window and waiting a little will raise that window so you can drag that file into the corresponding window. There's no plans to implement this and I personally think apps don't belong in System Tray

D28185: [applet/systemtray] Use model binding instead of copy

broulik added inline comments. INLINE COMMENTS > AbstractItem.qml:36 > property Item iconItem > -property int /*PlasmaCore.Types.ItemStatus*/ status > -property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus > +property int /*PlasmaCore.Types.ItemStatus*/ status:

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +add_definitions(-DTRANSLATION_DOMAIN=\"plasmauser-kcm\") > + This must match the `KAboutData` name (which is `kcm_user`) and what `Messages.sh` is actually extracting into. > ChangePassword.qml:29 > + >

D27166: Refactor converter runner

broulik added a comment. Sounds good! :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27166: Refactor converter runner

broulik added a comment. I just noticed another minor issue: when I activate a result with the old one it would copy the value into the text field, i.e. I type "5 EUR", select the 4.55 GBP result and then it would copy 4.55 into the text field. This is done for `InformationalMatch` types,

D27166: Refactor converter runner

broulik accepted this revision. broulik added a comment. Ship it! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27166: Refactor converter runner

broulik added a comment. Very nice! There's two minor nitpicks but then I think it should be good to go, thanks for your endurance :) INLINE COMMENTS > converterrunnertest.cpp:50 > +{ > +setlocale(LC_ALL, "C.utf8"); > +runner = new ConverterRunner(this, QVariantList()); This

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10c1a42b2cbf: [Cursor Theme KCM] Use standardized pointer and help cursor for preview (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28156: [Dialog] Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R858:eecb8f6402e8: [Dialog] Use `ShadowedRectangle` (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to XDG cursor spec [1] the names are "pointer" and "help" for the pointing hand and

D28156: [Dialog] Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive DropShadow layer. TEST PLAN I only just now found a place where it's

D28146: [applets/appmenu] Use libtaskmanager for appmenus

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appmenumodel.cpp:124 > +m_tasksModel->setScreenGeometry(geometry); > emit screenGeometryChanged(); > } I think you can just connect this signal to our

D28146: [applets/appmenu] Use libtaskmanager for appmenus

broulik added a comment. I love patches with a lot of red! When filtering by screen, this now means we get appmenu only when the active window is on the same screen? Not sure if this is what we want? (Perhaps we could do some clever "last window with menu" tracking so we can have

D27166: Refactor converter runner

broulik added inline comments. INLINE COMMENTS > converterrunner.cpp:74 > +const QString valueGroup = > QStringLiteral("(?P<%1>[0-9,./]+)").arg(valueKey); > +const QString unitGroups = > QStringLiteral("(?P<%1>[a-zA-Z/\"'^0-9\\p{Sc}²³]+)"); > +const QString sourceUnitGroup =

D27166: Refactor converter runner

broulik added a comment. Nice refactoring work! Quick testing suggests a few issues, however. I haven't verified if they have been present before or are in KUnitConversion, but: "5 EUR" produces: 4.6095 GBP, 5.467 USD7.8745 CAD (@sitter says this is some unrelated bug) "5 l/100km"

D28138: some static analyzer improvements for service runner

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > servicerunner.cpp:114 > +for(int i = 1; i < strList.size(); ++i) { > +const auto = strList[i]; > if (category ==

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fix those two minor nitpicks and then ship it. Well done! INLINE COMMENTS > broulik wrote in abstracttasksmodel.h:99 > `@since 5.19` This is plasma-workspace, not plasma-framework, so

D28103: Support multiple stacked Passive Notifications

broulik added inline comments. INLINE COMMENTS > PassiveNotification.qml:26 > + > +x: parent.width/2 - width/2 > +y: parent.height - height - Kirigami.Units.smallSpacing `Math.round` please > PassiveNotification.qml:35 > + > +topPadding: Kirigami.Units.smallSpacing > +

D28129: Read the new message string after rather than before

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:60 > Qt5::X11Extras > +XCB::XCB > KF5::IconThemes) Unused REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Nice job INLINE COMMENTS > abstracttasksmodel.h:99 > LastActivated,/**< The timestamp of the last time a task was the > active task. */ > +ApplicationMenuServiceName, /**< The DBus service name for the > application's menu. > +

D27985: Include s_kcrashErrorMessage in our traces

broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985

D28120: [Icons KCM] Floor delegate height

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9f545a3c537: [Icons KCM] Floor delegate height (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28120?vs=77895=77912 REVISION DETAIL

D28120: [Icons KCM] Floor delegate height

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded

D28116: Fix sizing of ComboBox and RadioButton

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b738ebbb6369: Fix sizing of CheckBox and RadioButton (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28116: Fix sizing of ComboBox and RadioButton

broulik updated this revision to Diff 77882. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added reviewers: mart, hpereiradacosta. broulik added a comment. - Use pixel metric for checkbox/radio button size and use the spacing. Only use

D28116: Fix sizing of ComboBox and RadioButton

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `KQuickStyleItem` manages its implicit size internally. Overriding it on the QML side makes this

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think if you added those properties `KWindowInfo`, you'd get change events, cache eviction, less manual X code basically for free :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think you should cache the X props, otherwise every `data` access causes a round trip to the X server. INLINE COMMENTS > xwindowtasksmodel.cpp:472 > > +static const QByteArray s_x11AppMenuServiceNamePropertyName = >

D28053: Make the animation slider more granular

broulik accepted this revision. broulik added a comment. Yeah go for it REPOSITORY R119 Plasma Desktop BRANCH more-granular-animation-speed-slider (branched from master) REVISION DETAIL https://phabricator.kde.org/D28053 To: pereira.alex, #plasma, #vdg, ngraham, davidedmundson,

D28029: Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R858:1bb57b10e7bd: Use `ShadowedRectangle` (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28029?vs=77573=77738

D27701: [ComboBox] Use transparent dimmer

broulik added a comment. In D27701#628321 , @ngraham wrote: > I can't reproduce the issue with the comboboxes on the system tray settings page, which are in a scrollview. Where can I see the original bug? e.g. KScreen's resolution

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

broulik added a comment. It would be nice not to mutate a list that's being deleted REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

broulik added a comment. Don't you access garbage then if the shadow is destroyed during `qDeleteAll`? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28068: Cleanup file resolving

broulik added inline comments. INLINE COMMENTS > kirigamiplugin.h:51 > #elif defined(KIRIGAMI_BUILD_TYPE_STATIC) > -return filePath; > +return QStringLiteral(":/org/kde/kirigami/") + path; > #else Doesn't that have to be `qrc` to be a valid URL? > kirigamiplugin.h:58 > +{

D28067: check for window existence

broulik added inline comments. INLINE COMMENTS > shadowedrectangle.h:161 > protected: > +void itemChange(QQuickItem::ItemChange change, const > QQuickItem::ItemChangeData ); > QSGNode *updatePaintNode(QSGNode *node, QQuickItem::UpdatePaintNodeData > *data) override; Missing

D28029: WIP: Use `ShadowedRectangle`

broulik added a comment. kirigamiplugin.cpp: // 2.12 qmlRegisterType(uri, 2, 12, "ShadowedRectangle"); REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28029 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage,

D28065: Add missing types to qrc

broulik added a comment. I was wondering, could this file be auto-generated by cmake? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28065 To: nicolasfella, apol Cc: broulik, keithzg, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. With that early return addressed please REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D24070 REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma,

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:83 > +} else if (pmSource.data.Battery.State === "NoCharge") { > +return i18n("Not charging") > +} // otherwise, don't add anything Why this early return? REPOSITORY R120 Plasma Workspace

D28029: WIP: Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive `DropShadow` layer. TEST PLAN - There's something funky going on with the

D28023: Fix color premultiply and alpha blending

broulik accepted this revision. broulik added a comment. `Qt.color(0,0,0,0.3)` now matches between `DropShadow` layer and the `ShadowedRectrangle`. Very nice! REPOSITORY R169 Kirigami BRANCH color_fix REVISION DETAIL https://phabricator.kde.org/D28023 To: ahiemstra, #kirigami, mart,

[kwrited] [Bug 418822] Notification flood blocks the broom icon

https://bugs.kde.org/show_bug.cgi?id=418822 Kai Uwe Broulik changed: What|Removed |Added Status|REPORTED|RESOLVED CC

D27978: [FormLayout] Propagate FormData.enabled also to label

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1a36705f9613: [FormLayout] Propagate FormData.enabled also to label (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27978?vs=77401=77541

D27972: [NightColor] fix for plasmoid status and tooltip subtext

broulik added a comment. I think this needs a VDG/Usability discussion. Having the icon show when color correction is active (the status quo) imho makes sense. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham Cc:

D27979: Added top area to notifications

broulik added a comment. Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications INLINE COMMENTS > NotificationPopup.qml:168 > // let the item bleed into the dialog margins

D27978: [FormLayout] Propagate FormData.enabled also to label

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to mark the section as disabled even when the control itself is not, e.g. when you have

Re: Proposal: Dynamic Wallpapers in Plasma

Hi, According to Qt documentation, if QImageReader::imageCount() returns a positive number, it means that the file contains an animated image. And that isn't even true. An ICO (windows icon file) has all its contained pixmap sizes and depths as a flat list. E.g. in the windows icon

D27958: [SystemTray] Fix item size for very narrow panel

broulik added a comment. Not sure if it is just me but the vertical alignment looks slightly off F8169131: Screenshot_20200310_172654.PNG Or maybe that's the random different sizes REPOSITORY R120 Plasma Workspace REVISION DETAIL

Re: Proposal: Dynamic Wallpapers in Plasma

Hi, you know I'm a big fan of your dynamic wallpaper work :) > It's worth to point out that there is an upstream patch to add one [2]. Given 5.15 is feature frozen already, I think we won't see this anytime soon. It could be worth a try contacting the author if they're willing to include it

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. For X check out the appmenu applet: https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Can we make the dbus service role name more generic? GTK has a generic DBus prop on the window, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n,

D27436: Use task rather than tabs

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. This will utterly break with every third party theme. If we were to do this we would need to introduce a dedicated "applet is open" highlight item or some property to tell it

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. > I believe that D26992 , moves the icons down. It looks like with that patch the icon sizes differ between plasmoids and SNIs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To:

D27886: Demote jump list actions to PossibleMatches

This revision was automatically updated to reflect the committed changes. Closed by commit R120:18422ededcc9: Demote jump list actions to PossibleMatches (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27886?vs=77079=77247

D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:503bf4f3a542: [gmenu-dbusmenu-proxy] Pass action target in invocation (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27879: Degrade qCInfo to qCDebug

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9a4f259c4820: Degrade qCInfo to qCDebug (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27879?vs=77063=77248 REVISION DETAIL

D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea358c896668: [gmenu-dbusmenu-proxy] Fix radio button state detection (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Plasma Sprint in Augsburg cancelled

Hi everyone, I regret to inform you that with Covid-19 spreading, large events and flights increasingly being cancelled on short notice, the situation in Italy worsening etc, we decided to call off the Plasma Sprint in Augsburg next month. If you have made travel arrangements, please see if

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. This causes layouting issues in narrow panels: F8167100: Screenshot_20200309_085328.PNG REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham

Re: Plasma Sprint 2020 in Augsburg, Germany

Hi, I'm discussing this with the board right now. Stay tuned. Am 06.03.20 um 09:35 schrieb Konrad Materka: Hi, What is the chance of this event being cancelled due to coronavirus? I have to book tickets on advance, unfortunately flight is the most reasonable. -- Regards, Konrad Materka

D27886: Demote jump list actions to PossibleMatches

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `HelperMatch` type was used to identify them in `run` but this also causes them to score way

D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of comparing the state of the action to the action name, compare it to the argument the

D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to documentation [1] a menu item has a `target` attribute, which is "the parameter to

D27879: Degrade qCInfo to qCDebug

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It just adds noise TEST PLAN 5.18 - No longer get a bunch of pointless messages about

Re: Problems in KWayland causes by API and ABI compatibility promises

Am 05.03.20 um 17:27 schrieb Nate Graham: What are the known users of KWayland outside of KWin? Are there any? Quick lxr suggests there's actually a bunch: In Plasma (for which we could do an "integration" library without Frameworks guarantees in plasma-workspace, similar to e.g.

D27874: Disable the audio stream indicator for IOTM

broulik added a comment. -1 to removing this feature. You also need to remove the checkbox on the settings page then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: broulik, cblack, plasma-devel, Orage, LeGast00n,

D27868: [plasma-session] Continue to start kdeinit

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fixes thumbnail generation and other issues for me. Short-term this is fine. But since this kdeinit stuff is layered in wrappers upon wrappers I think getting rid of it entirely is a

D27786: [notifications] Read appname from desktop file if no appname set

broulik added inline comments. INLINE COMMENTS > notification.cpp:333 > // This will have us show e.g. "Dr Konqi" instead of generic "Plasma > Desktop" > if (isDefaultEvent && !serviceName.isEmpty()) { > applicationName = serviceName; How about adjusting this

D27509: Introduce ProcessDataModel

broulik added inline comments. INLINE COMMENTS > extended_process_list.cpp:62 > +if (m_changeFlag != 0) { > +connect(parent, ::processChanged, this, > [=](KSysGuard::Process *process) { > +if (!process->changes().testFlag(m_changeFlag)) { Capture only

D27697: WIP: Added top area to notification header

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Also please `Math.round` when you divide sizes INLINE COMMENTS > NotificationItem.qml:114 > > -NotificationHeader { > -id: notificationHeading > -

D27701: [ComboBox] Use transparent dimmer

broulik updated this revision to Diff 76546. broulik edited the test plan for this revision. broulik added a comment. - Clarify comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27701?vs=76545=76546 REVISION DETAIL

D27701: [ComboBox] Use transparent dimmer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When not using `dim` it breaks "click outside" for `ComboBox` when in a `ScrollView`. I

D27689: Use correct connections for QQC2 controls

broulik added inline comments. INLINE COMMENTS > main.qml:223 > +onActivated: { > cA.modeStaged = currentIndex; > calcNeedsSave(); Change this to `index` (which is the signal argument). There's no guarantee that `currentIndex` will be

D27674: feat(kcm): show resolution aspect ratio

broulik added a comment. Projectors and VMs can be weird. We already have the concept of `preferredMode`, so adding an asterisk should be easy. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27674 To: broulik, romangg, #vdg Cc: apol, plasma-devel, Orage,

D27674: feat(kcm): show resolution aspect ratio

This revision was automatically updated to reflect the committed changes. Closed by commit R104:62042a990525: feat(kcm): show resolution aspect ratio (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27674?vs=76454=76461#toc REPOSITORY R104 KScreen CHANGES SINCE

D27674: feat(kcm): Show resolution aspect ratio

broulik created this revision. broulik added reviewers: romangg, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With a special case to prefer common "16:10" over "8:5" TEST PLAN F8133072:

D27645: [KCM]Align volume controls row

broulik added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + Eww. Can we fix the slider

<    1   2   3   4   5   6   7   8   9   10   >