D24743: Update GTK settings according to Plasma settings

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Good job! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-settings-in-respective-kcms REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, broulik,

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:c1d7ea734607: Fixup new Audio() constructor and apply autoplay prevention evasion to document. (authored by broulik).

D25309: [Notifications KCM] Fix keyboard navigation in apps list

broulik added inline comments. INLINE COMMENTS > SourcesPage.qml:147 > id: sourceDelegate > +focus: true > width: sourcesList.width Why this? > SourcesPage.qml:153 > +

Re: Clang Format Update

Hi, I've just ran make clang-format (thanks a lot for that tooling!) over plasma-workspace and checked my libnotificationmanager code which is pretty new, was only written a few months ago, and as such should be a good representation of modern KDE Frameworks-style code. The results were not

D25290: KCM launchfeedback : port to KConfig XT

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:45 > onToggled is called both when it is checked, and presumably when it is > unchecked (or another button is checked) > > I assume we want something more like: > > onToggled: {if (!checked) return;

D25290: KCM launchfeedback : port to KConfig XT

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:33 > This is a bit of a boolean trap. > > We could declare an enum in QML > setCursorSettings(Busy | Blinking) would be a bit nicer maybe? > > Up to you. Yes, I would prefer all of this to be abstracted away

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added a comment. There's also a lot of code duplication making the diff hard to read. Please group if statements together where it makes sense, e.g. avpod things like if (foo) { return plasmoid.title; } else if (foo) { return plasmoid.title; or

D25284: Make QmlComponentsPool one instance per engine

broulik added inline comments. INLINE COMMENTS > columnview.cpp:51 > +Q_ASSERT(engine); > +if(privateQmlComponentsPoolSelf->m_instances.contains(engine)) { > +return privateQmlComponentsPoolSelf->m_instances[engine]; Avoid double lookup: auto *componentPool =

D25281: [GTK3] Improve legibility of Firefox CSD colours

broulik added a comment. > However Once we implement the Breeze color scheme changes How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the colorscheme doesn't fix the underlying bug? REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D25277: [Tabs Runner] Filter on the host side already

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids allowing to query for all tabs easily and also reduces DBus traffic somewhat. TEST

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

broulik updated this revision to Diff 69638. broulik added a comment. - Also apply the same thing to Firefox REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24870?vs=69622=69638 REVISION DETAIL https://phabricator.kde.org/D24870

D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Does it make sense to have the option off by default, i.e. hiding the clock on idle by default? "Given that the setting will be off by default," is not true. By default the clock is shown, so nothing changes here, also given a static image is also our

D25223: Avoid side effects during menu initialization

broulik added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:27 > #include > +#include > Already included in the header file > kdeplatformsystemtrayicon.cpp:33 > : QPlatformMenu() > -, m_enabled(true) > -, m_visible(true) > -,

D25264: [Cursor Theme KCM] Elide size ComboBox text

This revision was automatically updated to reflect the committed changes. Closed by commit R119:582bd8e04af0: [Cursor Theme KCM] Elide size ComboBox text (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25264?vs=69602=69624

D25263: [ComboBox] Don't dim Popup

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d11ba447fa78: [ComboBox] Dont dim Popup (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25263?vs=69601=69623

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

broulik updated this revision to Diff 69622. broulik added a comment. - Add missing `play()` call REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24870?vs=69545=69622 REVISION DETAIL https://phabricator.kde.org/D24870 AFFECTED FILES

D25264: [Cursor Theme KCM] Elide size ComboBox text

broulik created this revision. broulik added reviewers: Plasma, IlyaBizyaev. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Vanilla `ItemDelegate` elides but this one has custom `contentItem` to add the

D25263: [ComboBox] Don't dim Popup

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The dimming only works with pure QML applications based on `ApplicationWindow` which is why

D25252: Fix binding loop in lockscreen media controls

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Clever! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25252 To: davidedmundson, #plasma, broulik Cc: broulik, filipf, plasma-devel,

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

broulik updated this revision to Diff 69545. broulik retitled this revision from "Apply autoplay prevention evasion also to document.createElement" to "Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement". broulik edited the summary of this revision.

D25205: Remove pointless QDBusServiceWatcher

broulik added inline comments. INLINE COMMENTS > KSMServer.cpp:45 > KSMServer::Private::Private(KSMServer *parent) > -: serviceWatcher(new QDBusServiceWatcher(this)) > -, kwin(nullptr) > +: kwin(new QDBusInterface(KWIN_SERVICE, QStringLiteral("/KWin"), >

D25222: [Lock Screen] Fix album art binding loop

broulik added a comment. Painted size depends on the aspect ratio of the loaded image. I think it should just be hard-coded to some icon size or grid unit rather than depend on the highly dynamic font rendering (which governs its size effectively as it's the layout's size) REPOSITORY

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

broulik added a comment. This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: F7748305: Screenshot_20191108_151344.png (note the

D25198: KCM Colors : port color scheme state management to KConfigXT

broulik added a comment. Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not. REPOSITORY R119 Plasma Desktop REVISION

D24893: [Lock Screen] Add option to hide clock when idle

This revision was automatically updated to reflect the committed changes. Closed by commit R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when idle (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24893?vs=68622=69386

D25176: Add a displayHint property to Action

broulik added inline comments. INLINE COMMENTS > leinir wrote in Action.qml:124 > Might be nice to have a DisplayHint.NoHint value, to make it more explicit > what that 0 means Isn't it more like a "no preference" value? Also, please document the default value REPOSITORY R169 Kirigami

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

broulik added inline comments. INLINE COMMENTS > ActionToolBar.qml:111 > +visible: details.visibleActions.indexOf(modelData) != -1 > + && (modelData.visible !== undefined && > modelData.visible) > + Shouldn't this be modelData.visible === undefined ||

D24879: [ComboBox] Follow focusPolicy

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b1452c37b49c: [ComboBox] Follow focusPolicy (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24879?vs=68586=69256#toc REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D24883: [ComboBox] Don't indicate focus when popup is open

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5dc1c74cad6f: [ComboBox] Dont indicate focus when popup is open (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24879: [ComboBox] Follow focusPolicy

broulik added a comment. Ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24879 To: broulik, #plasma Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik added a comment. I think it might make sense to move that to libnotification `Server` so the applet can get the same information without duplicating code there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 To: broulik, #plasma, #vdg Cc:

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik planned changes to this revision. broulik added a comment. Alright, will disable those REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik added a comment. > Would it makes sense to also disable all the controls in the KCM when either of these messages are open? I was wondering that, too, but not sure I want to artificially block those settings. Perhaps for the upper check boxes. Progress reporting is unaffected

D25096: [Digital Clock] Disable custom format input when date option is unchecked

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e477d80bbbc7: [Digital Clock] Disable custom format input when date option is unchecked (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I've seen people complaining about ugly notification popups when they were in fact running

D25096: [Digital Clock] Disable custom format input when date option is unchecked

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The `ComboBox` was disabled in this case but not the other options. TEST PLAN F7703371:

D25091: [Digital Clock] Add preview for date format

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6671c13d4cb6: [Digital Clock] Add preview for date format (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25091?vs=69104=69117

D24945: [ksmserver] Signal session management state to kwin directly

broulik added inline comments. INLINE COMMENTS > logout.cpp:194 > + > +auto reply = m_kwinInterface->setState(KWinSessionState::Saving); > +// we don't need to block as we wait for kwin to handle it's session 1 `reply` isn't actually used, remove? REPOSITORY R120 Plasma Workspace

D25091: [Digital Clock] Add preview for date format

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Especially for the custom one it's useful to have a live preview rather than trial and error

D25055: [containments/desktop] Delete the "Tweaks" page and its options

broulik added a comment. +1 INLINE COMMENTS > main.qml:268 > -property: "visible" > -value: plasmoid.configuration.showToolbox > -} A conf update isn't needed as it's this code hiding the toolbox when disabled, so without it it will just always show REPOSITORY R119

D24870: Apply autoplay prevention evasion also to document.createElement

broulik planned changes to this revision. broulik added a comment. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24744: Remove unneeded options in GTK KCM

broulik added a comment. > remove it from the view and always set it to "one page per click"? Absolutely not. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel,

D25043: [ResultDelegate] Use theme.disabledColor

This revision was automatically updated to reflect the committed changes. Closed by commit R112:eed4eb1ed5a1: [ResultDelegate] Use theme.disabledColor (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25043?vs=68970=68976 REVISION DETAIL

D25043: [ResultDelegate] Use theme.disabledColor

broulik added a comment. > in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: Make sure your plasma-framework is up to date > - it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is

D25043: [ResultDelegate] Use theme.disabledColor

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes text more readable on dark backgrounds by not changing the text `opacity`. Subtext

D24865: [SystemTray] Support for AttentionIcon

broulik added inline comments. INLINE COMMENTS > systemtray.cpp:354 > +{ > +if (!value.isValid() || value.isNull() || !value.canConvert()) { > +return false; I think you don't need any of that. If you convert it to a `QIcon` which it is not, it will return a default-constructed

D24997: [Lock Screen] Don't use black shadows with black text

broulik added inline comments. INLINE COMMENTS > LockScreenUi.qml:37 > readonly property bool softwareRendering: GraphicsInfo.api === > GraphicsInfo.Software > +readonly property bool lightBackground: > Math.max(PlasmaCore.ColorScope.backgroundColor.r, >

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > It's likely we'll encounter that ComboBox breakage at other places. we do :) https://cgit.kde.org/kscreen.git/tree/kcm/package/contents/ui/Panel.qml?id=7811411c6425dd52bcd732a5910d177fee4a89d2#n42 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > Ah somehow I thought we had a third more "clever" case of currentIndex moving. Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :( So best hack would be to have a c++ thing that sets the property without going

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > AFAICT it won't be pretty though. :-) I think it's pretty straightforward 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299 2.) the wheel handler must be changed to call

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel,

D24798: Migrate QQC1 to QQC2

broulik added a comment. That new time zone view lacks any form of keyboard navigation. I cannot use arrow keys to navigate it and neither can I hit space to toggle a checkbox. It also lacks a frame around its content area like the text field has. REPOSITORY R120 Plasma Workspace

D24934: [notifications] Center no notification text on mobile

broulik added inline comments. INLINE COMMENTS > FullRepresentation.qml:580 > PlasmaExtras.Heading { > width: list.width > +height: list.height Now you could have used an `anchors.fill` xD REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24934: [notifications] Center no notification text on mobile

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fix it, then ship it INLINE COMMENTS > FullRepresentation.qml:582 > +horizontalAlignment: Kirigami.Settings.isMobile ? > Text.AlignHCenter : Text.AlignLeft > +

D24934: [notifications] Center no notification text on mobile

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24926: [ResultsView] Expose limit

broulik closed this revision. broulik added a comment. https://cgit.kde.org/milou.git/commit/?id=eda3d274da1d502e61e24fa41f6b23b9f236baed REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D24926 To: broulik, #plasma, davidedmundson Cc: plasma-devel, LeGast00n,

D24926: [ResultsView] Expose limit

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Lets the user of the view decide how many items they want TEST PLAN - Can have more than the

D24893: [Lock Screen] Add option to hide clock when idle

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in WallpaperFader.qml:145 > Why are we changing this line? The clock shadow effectively renders the clock (shader effect with source hidden), so it has to be hidden. > davidedmundson wrote in config.qml:21 > One thing

D24894: notifier: Make action buttons translatable

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.17 branch please. While you cannot change strings, you can make previously accidentally untranslated strings translatable. REPOSITORY R134 Discover Software Store BRANCH

D24905: Use return early

broulik added a comment. I think all of thise `breaks` in loops must be `continue`s? INLINE COMMENTS > networkmodel.cpp:457 > +if (item->itemType() != NetworkModelItem::AvailableConnection) > +break; > + Shouldn't this be a `continue`? > networkmodel.cpp:843 > +

D24893: [Lock Screen] Add option to hide clock when idle

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to use it for a slideshow or something. TEST PLAN F7658739:

D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional? That's the trick! The config comes *from the theme* (similar to how plasmoids do it), so only our theme will have those check boxes.

D24889: Remove pointless textColor assignment

This revision was automatically updated to reflect the committed changes. Closed by commit R112:0e61b5053180: Remove pointless textColor assignment (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24889?vs=68603=68606 REVISION DETAIL

D24879: [ComboBox] Follow focusPolicy

broulik added a comment. In D24879#552657 , @apol wrote: > Wouldn't it make more sense to not accept the event then? Not sure. The main reason for the `MouseArea` (apart from wheel handling) seems to be opening the `ComboBox` on *press*.

D24847: KCM Icons fix theme selected when we hit delete theme

broulik added a comment. > Yes sure, by the way the new behavior is the one implemented on other kcm like desktop theme When I hit delete in desktop theme KCM I also have it move to the next theme? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847

D24883: [ComboBox] Don't indicate focus when popup is open

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Technically the `ComboBox` has focus but the user is interacting with the popup inside. This

D24879: [ComboBox] Follow focusPolicy

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a `MouseArea` in our `contentItem` stealing events from the underlying `Control`,

D24870: Apply autoplay prevention evasion also to document.createElement

broulik added a comment. I am not sure. I thought since a video is likely in the DOM or otherwise it won't be visible, the user can at least play it. But then I just remembered how Spotify used a `` tag for playing its music... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D24870: Apply autoplay prevention evasion also to document.createElement

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It affects audio player created this way the same as a `new Audio()` BUG: 411742 TEST

D24865: [SystemTray] Support for AttentionIcon

broulik added a comment. You might want to split that into a proper if statement otherwise it becomes somewhat hard to read. Something like source: { if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus && (AttentionIcon || AttentionIconName)) { return

D24865: [SystemTray] Support for AttentionIcon

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for following up! (Out of curiosity, do we not need to fall back to the regular icon in case it doesn't have an attention icon in needs attention state? Spec only says "can be

D24865: [SystemTray] Support for AttentionIcon

broulik added a comment. `PlasmaCore.IconItem` has a `status` property, so you probably need to explicitly check `taskIcon.status` then it should work with the proper enum REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma,

D24767: [SystemTray] Support for AttentionIcon

broulik added a comment. Doesn't this break the binding for `source`? My tray icons don't update anymore REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24767 To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham Cc: broulik, plasma-devel, LeGast00n,

D24854: [Desktop Toolbox] Add missing i18n domain

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c79902431d9a: [Desktop Toolbox] Add missing i18n domain (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24854?vs=68513=68515 REVISION

D24854: [Desktop Toolbox] Add missing i18n domain

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 413227 FIXED-IN: 5.17.1 TEST PLAN My toolbox is now ridiculously long "Werkzeugkasten

D24849: [Windows Runner] Gather window again when running result

This revision was automatically updated to reflect the committed changes. Closed by commit R120:549374ba5f1e: [Windows Runner] Gather window again when running result (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24849: [Windows Runner] Gather window again when running result

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we fixed `RunnerManager::teardown` to actually be emitted, the runner would throw away its

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

broulik added inline comments. INLINE COMMENTS > menu.cpp:146 > +// Only show "Unlock Widgets" in the UI, not "Lock Widgets" > +if (!(name == QLatin1String("lock widgets") && > c->corona()->immutability() == Plasma::Types::Mutable)) { > +

D24844: [Applet] Remove hamburger button and menu

broulik added a comment. Big -1 to removing it on similar grounds as I also quite frequently use the raise maximum volume feature. > which user feedback indicates nobody clicks on. So, we have KUserFeedback data already? > I believe you should put some more thoughts into how to

D24846: Port kcm icons to kconfigxt

broulik added inline comments. INLINE COMMENTS > main.cpp:141 > { > -return > KIconLoader::global()->theme()->querySizes(static_cast(group)); > +KIconTheme theme(m_model->selectedTheme()); > +return theme.querySizes(static_cast(group)); Does this `KIconTheme` instance need

D24847: KCM Icons fix theme selected when we hit delete theme

broulik added a comment. Hmm, let's see what #vdg thinks about that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24848: fix kcm fonts "typo" on connect

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Interesting, I thought Qt would/could static_assert that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24848 To: bport, #plasma, mart, ervin, broulik

D24845: KCM don't support icons effect anymore, clean-up config file

broulik added inline comments. INLINE COMMENTS > icons_remove_effects.upd:2 > +Version=5 > +Id=IconsRemoveEffect > +File=kdeglobals Effects REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24845 To: bport, #plasma, mart, broulik, ervin Cc: plasma-devel,

D24688: [KCM] Disallow dropping screen outside of reachable area

broulik added a comment. So, what about this now? Or is there an auto scale patch anywhere? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24688 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24818: Filter invalid services in most used model

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ec90e4066c16: Filter invalid services in most used model (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24818?vs=68401=68425

D24823: [startplasma] Pass actual variable to kapplymousetheme

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b59af69b6521: [startplasma] Pass actual variable to kapplymousetheme (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24823: [startplasma] Pass actual variable to kapplymousetheme

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Found this while debugging something. TEST PLAN 5.17? Compiles. No idea what this thing does

D24818: Filter invalid services in most used model

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise there'll be a blank spot. BUG: 413178 FIXED-IN: 5.17.1 TEST PLAN - Put a

D24816: [Applet] Make spinboxes editable

broulik added a comment. Does it also need a `valueFromText` function then? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24816 To: ngraham, #vdg, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24763: [kcms/nightcolor] Add hints to temperature slider direction

broulik added a comment. Nevermind I am an idiot and don't know how (colo(u)r) temperature works. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24763 To: davidedmundson, #plasma, ngraham Cc: broulik, ngraham, plasma-devel, LeGast00n,

D24763: [kcms/nightcolor] Add hints to temperature slider direction

broulik added a comment. In right to left layout the labels must be swapped. F7623875: Screenshot_20191018_194633.png REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24763 To: davidedmundson, #plasma,

D24758: [KEditFileType] Add a desktop file

broulik added a comment. Should this be `NoDisplay` since you can't just launch it without an argument REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D24758 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24757: Port away from KIconThemes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e06e897f9d45: Port away from KIconThemes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24757?vs=68232=68237 REVISION DETAIL

D24756: Port away from KIconThemes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:88c1f2093cac: Port away from KIconThemes (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24756?vs=68231=68236 REVISION DETAIL

D24757: Port away from KIconThemes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY At least where trivially possible. TEST PLAN T11637

D24756: Port away from KIconThemes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY At least where trivially possible. TEST PLAN T11637

D24260: [Style KCM] Don't explicitly reload KWin's configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:58fe6dabbb0f: [Style KCM] Dont explicitly reload KWins configuration (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24744: Remove unneeded options in GTK KCM

broulik added a comment. Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to position radios REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: broulik, filipf, GB_2,

D24740: [Media Controller] Multiple artists support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1be4bb880fde: [Media Controller] Multiple artists support (authored by lesf0, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24743: Update GTK settings according to Plasma settings

broulik added a comment. Pretty cool! Some minor nitpicks. Once all the KCMs have been ported to KConfigXT (XML config description, currently ongoing) we'll have a compile-time checked way to read KDE settings and easier way to get the default values. INLINE COMMENTS > CMakeLists.txt:9

<    4   5   6   7   8   9   10   11   12   13   >