markg added a comment.
In https://phabricator.kde.org/D10325#201884, @broulik wrote:
> > Would it be possible to show it as if it were locked? That would solve
all the issues with it, right?
>
> I don't get it. That "lock" feature is entirely a Dolphin invention. It
does exactly what
markg added a comment.
Why does it show the panel as if it were unlocked?
Your before image looks exactly like an unlocked frame in Dolphin.
Would it be possible to show it as if it were locked? That would solve all
the issues with it, right?
REPOSITORY
R241 KIO
REVISION DETAIL
ht
markg added a comment.
Hmm, weird. In my eyes the knovi thumbnail in the **before** image looks
sharper than the after one. It's just blurred in the after one, not better.
I'm guessing the QML smooth property has a fairly naive implementation (in
Qt).
REPOSITORY
R119 Plasma Desktop
BRAN
markg requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D10232
To: mart, #plasma, #konsole, markg
Cc: markg, hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, j
markg added a comment.
Please add a comment to the code for that.
It might be obvious now, but the next person that looks at that code without
knowledge of this change probably has a "huh, what is that?" moment and left
wondering why it's done.
REPOSITORY
R319 Konsole
REVISION DETAIL
markg added a comment.
Watch this: https://www.youtube.com/watch?v=T0Jj4lUm_p8
Apple really has done a marvelous job in making tags useful!
Anyhow, we can learn a couple things from there implementation of the sidebar.
1. It doesn't scroll "per panel", it scrolls for the whole sideb
markg added a comment.
-1 for the current version as well.
We've had those frames before. The benefit of locking docks is no frame (for
me that is the benefit).
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7957
To: ngraham, #breeze, #vdg
Cc: broulik, emmanuelp, e
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:f25c5e10d023: Fix deprecation warnings. setSelection ->
setSelectedUrl ui -> uiDelegate (authored by markg).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:4aef17e64f56: Replace Q_DECL_OVERRIDE with override.
(authored by markg).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5742?vs=14232&id=14546#toc
REPOSITORY
R135 Integration for Qt applica
markg added a comment.
I don't think adding a (rather massive) delay is the real fix here. It only
masks the actual issue.
What really happens (just opened the discover store for the first time ever)
is that entries can flow in at any point, that might be an issue.
Every batch can cont
markg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fix deprecation warnings.
TEST PLAN
autotest
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_deprecations (branched
markg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Override consistency
TEST PLAN
autotest
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
cpp11_override (branched from m
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:7a7dfffba98d: Implement QPlatformTheme::fileIconPixmap()
to make QFileIconProvider work. (authored by eshalygin, committed by markg).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGE
markg accepted this revision.
markg added a comment.
Oke by me. Commit lands in a few minutes.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg, graesslin
Cc: graesslin, ltoscano, broulik, markg, pla
markg added a comment.
I would prefer if someone else ships it on your behalf, my setup is rather
broken.
If nobody does it, i will somewhere next weekend.
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg
Cc: broulik, markg, plasma-devel, spstarr, progwolff
markg accepted this revision.
markg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> statusnotifieritemsource.cpp:393-399
> if (QSysInfo::ByteOrder == QSysInfo::LittleEndian) {
> uint *uintBuf = (uint *) image.data.data();
> for (uin
markg accepted this revision.
markg added a comment.
Ship it :)
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg
Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Looks good to me. Nice :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5582
To: broulik, #plasma, markg
Cc: markg, plasma-devel, spstarr, progwolff, Zren
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Looks OK to me.
Wait for a second accept though.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, mar
markg added a comment.
It pains me a bit to say this since it looks like you've spend quite a bit of
time writing that code.
But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on
reviewboard). Much of the code can likely be replaced by just using that
instead.
[
tps://git.reviewboard.kde.org/r/130094/#comment68568>
foreach OR for (... : qAsConst(m_standardPathItems))
Or use std::vector and keep the for as is..
qAsConst is in Qt since 5.7 so i think that's a bit to new to use.
- Mark Gaiser
On apr 21, 2017, 8:04 a.m., Eugene Sha
markg added inline comments.
INLINE COMMENTS
> main.qml:66-67
> var baseLocation =
> '/usr/share/plasma/plasmoids/org.kde.plasma.mycroftplasmoid/contents/ui/suggestion/';
> -var path = baseLocation + 'words1.txt';
> +var diclocation = '/usr/share/dict/'
> +var pa
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Fine by me :)
You did forgot an "&" (making it by reference). On the other hand, this is a
POD type where performance wise this wouldn't matter at all.
REPOSITORY
R108 KWin
BRANCH
n
markg added inline comments.
INLINE COMMENTS
> graesslin wrote in pointer_input.cpp:440
> > Just curious, why do you define end as opposed tho this:
>
> Because @broulik tends to point out that it is not cached.
>
> > Another route you can go which looks much cleaner imho (requires Qt 5.7
> >
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Imho, it looks a lot better! Nice job!
Don't push it just yet though. Wait for the VDG to chime in.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
T
markg added inline comments.
INLINE COMMENTS
> pointer_input.cpp:440
> +auto areButtonsPressed = [this] {
> +for (auto it = m_buttons.constBegin(), end = m_buttons.constEnd();
> it != end; it++) {
> +if (it.value() == InputRedirection::PointerButtonPressed) {
Just curiou
markg added a comment.
I'm just curious. Why is the day name determined in QML (in the lines you
edited, but was there before as well) and on the C++ side?
It smells like a redundancy.
As far as i can tell (only looked for a moment), the dayName on the C++ side
isn't used "in" the C++
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Fancy!
I learned something new, thank you :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5198
To: broulik, #plasma, hein, markg
Cc: markg, plasma-devel,
markg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5192
To: davidedmundson, #plasma, markg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
markg added inline comments.
INLINE COMMENTS
> screen.cpp:25
> #include
> +#include
>
Looks like its unused.
> screen.cpp:79
> +{
> +return = m_output ? (qreal)m_output->scale() : 1.0;
> +}
c cast... no no no!
static_cast(...)
REVISION DETAIL
https://phabricator.kde.org/D5172
To:
markg added a comment.
I really doubt the usefulness in supporting this "feature".
It smalls like something one distribution apparently wants, but the vast
majority is fine with having the hover effect there. In fact, they might even
consider it a bug - i would - if it doesn't change on hov
Hi,
This might be of interest for the IconItem and Frame stuf.
I couldn't find this in the Qt 5.9 documentation, but it most
certainly does exist [1]
I wonder how many more "shared" options the QML Image{} component is
going to add though. The current documentation already states:
(5.8 docs) "Ima
markg added a comment.
In https://phabricator.kde.org/D4491#88362, @anthonyfieroni wrote:
> I must investigate why elide does not work, margins are a bit different
from others like systray, kicker, etc.
> I figure out it, maximumLineCount or height sould be setted, i unsetted
height..
markg reopened this revision.
markg added a comment.
This revision is now accepted and ready to land.
So now i'm on the correct revision it seems.
I applied the diff locally to see how this change looks. It looks OK (can't
test it on a "retina" display), but still quite inconsistent with
markg added a comment.
In https://phabricator.kde.org/D3738#87617, @subdiff wrote:
> In https://phabricator.kde.org/D3738#87601, @markg wrote:
>
> > ...
>
>
> There has already been a commit to master tackling this issue:
https://phabricator.kde.org/D4491
That's great, t
markg reopened this revision.
markg added a comment.
This revision is now accepted and ready to land.
Hmm, i don't know if this is the appropriate way in a phabricator workflow.
But this does reach exactly those involved in this change which is what i
intent.
On to the point.
When this
markg added a comment.
Hi David,
You have an interesting approach here!
I've been struggling with something similar recently as well and also -
initially - had my own lookup table for int -> QAction. It worked, but the
added bookkeeping seemed silly so i searched for a more "elegant" s
markg accepted this revision.
markg added a reviewer: markg.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4028
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
markg accepted this revision.
markg added a reviewer: markg.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4031
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Ahh, now it's gone.
You're doing things in little pieces? hehe.
Ship it.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4030
EMAIL PREFERENCES
htt
markg requested changes to this revision.
markg added a reviewer: markg.
markg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> containmentconfigview.h:56
>
> +void setContainment(Plasma::Containment* containment);
> +
I think you forgot to remove thi
markg accepted this revision.
markg added a reviewer: markg.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4029
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Looks nice and clean to me now :)
Nice job!
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D4012
EMAIL PREFERENCES
https://phabricator.kde.org/settings
markg added inline comments.
INLINE COMMENTS
> tooltipdialog.cpp:116-118
> +if (KWindowSystem::isPlatformX11()) {
> flags = flags | Qt::BypassWindowManagerHint;
> }
Isn't this redundant anyway?
It's being set in the constructor as well.
The constructor only deviates in initial
markg requested changes to this revision.
markg added a reviewer: markg.
markg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> units.cpp:61
> SharedAppFilter *Units::s_sharedAppFilter = nullptr;
> +Units *Units::s_self = nullptr;
>
Remove this line if y
On Mon, Jan 2, 2017 at 10:46 AM, Ivan Čukić wrote:
> Hi Mark,
>
> An alternative to Niebler's range-v3 and cppitertools you might want
> to try is boost.range (it is a part of the default boost package, I
> don't know whether it has everything you'd need for this).
>
> I haven't seen where you us
Hi,
I saw some commits from Kai to enhance the calendar code (both C++ and
QML), apparently for performance reasons. It's great to see people
interested in performance optimizations ;)
Some weeks ago i was watching cppcon videos. One video [1] got me
interested in playing with constructing a cale
On Sun, Aug 21, 2016 at 10:58 PM, David Edmundson <
da...@davidedmundson.co.uk> wrote:
>
>
> On Sun, Aug 21, 2016 at 8:33 PM, Mark Gaiser wrote:
>
>> On Sun, Aug 21, 2016 at 4:25 PM, David Rosca wrote:
>>
>>> Hi,
>>>
>>> On S
On Sun, Aug 21, 2016 at 4:25 PM, David Rosca wrote:
> Hi,
>
> On Sun, Aug 21, 2016 at 4:16 PM, Mark Gaiser wrote:
> > Hi,
> >
>
> >
> > What i'd like for this thread is to consider loading
> > module-switch-on-connect by default (changing the line
Hi,
Disclaimer:
Specially on this list i tend to jump to conclusions or come across as rude
at times. I'm trying to be constructive here with a "what would the user
like best" point of view.
The background for this topic started ~2 years ago. I tried to get my USB
headphone to work with PulseAudi
On Tue, Jul 26, 2016 at 3:09 PM, Mark Gaiser wrote:
> On Tue, Jul 26, 2016 at 2:03 PM, Sebastian Kügler wrote:
>
>> Hey,
>>
>> [Please keep both lists addressed.]
>>
>> Debugging multiscreen issues is a nightmare:
>>
>> - there are at leas
On Tue, Jul 26, 2016 at 2:03 PM, Sebastian Kügler wrote:
> Hey,
>
> [Please keep both lists addressed.]
>
> Debugging multiscreen issues is a nightmare:
>
> - there are at least 4 different processes involved (kded, kcmshell /
> systemsettings, kscreen_backend_launcher and plasmashell)
> - some
On Mon, Jul 11, 2016 at 9:58 PM, Thomas Pfeiffer
wrote:
> On 07.07.2016 19:50, Kevin Ottens wrote:
>
>> There's two sides to that problem in fact, use from applications and the
>> service provided by our workspace.
>>
>> I think that for applications the answer is neither KSecretService nor
>> KW
On Sat, Jul 2, 2016 at 5:41 AM, Łukasz Sawicki wrote:
> Hi,
>
> Here is a Plasma 5.7 video lets call it rc for now ;) Since we still
> have a couple of days to final release feel free to post your
> opinions, comments etc about it, so I can still improve some things
> if there will be such a nee
> On jun 29, 2016, 11:05 a.m., Mark Gaiser wrote:
> > I think you found an undocumented feature.
> > The docs don't mention it, not even in the list of all members + inherited
> > ones: http://doc.qt.io/qt-5/qquickitem-members.html
> >
> > But if i add
ll!
I will report a bug against Qt notifying them about this missing function in
the documentation.
- Mark Gaiser
On jun 29, 2016, 10:40 a.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To re
On Fri, Jun 10, 2016 at 10:10 PM, Mark Gaiser wrote:
> On Fri, Jun 10, 2016 at 9:04 PM, Kai Uwe Broulik
> wrote:
>
>> Hi,
>>
>> > Could you please reconsider that implementation detail?
>>
>> Why? You still have the job progress in the notification
it73n5l2nqeu+state:results
[2] http://kde-look.org/content/show.php?content=33673
[3] http://www.galago-project.org/specs/notification/0.9/index.html
[4] https://wiki.ubuntu.com/Unity/LauncherAPI
[5] http://kde-look.org/content/show.php/SmartNotify?content=133472
On Fri, Jun 10, 2016 at 10:10 PM, Ma
On Fri, Jun 10, 2016 at 9:04 PM, Kai Uwe Broulik
wrote:
> Hi,
>
> > Could you please reconsider that implementation detail?
>
> Why? You still have the job progress in the notification area with time
> and controls by default. It's just that you need to disable them both for
> the legacy dialog t
On Fri, Jun 10, 2016 at 6:55 PM, Kai Uwe Broulik
wrote:
> Hi,
>
> oh, heh. Yeah I'm using the job dataengine and if there's any user of it
> the job view server will be started and job progress is sent there instead.
>
> You can disable the "show application status" thing in task manager
> settin
xander Potashev
wrote:
> CCed plasma-devel and Kai because your problem is probably tied with
> this commit:
>
>
> http://commits.kde.org/plasma-desktop/e284e9dc17051f22d05985e218fa44ddaba78de5
>
> --
> Alexander Potashev
>
> 2016-06-05 19:29 GMT+03:00 Mark Gaiser :
>
On Tue, May 31, 2016 at 2:29 PM, Sebastian Kügler wrote:
> Discussed with mgraesslin on IRC, preliminary conclusion below...
>
> On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> > reboot
> >
> > This bugrepo
aster?
Performance optimizations should always be benchmarked to make sure you're not
decreasing performance instead ;)
- Mark Gaiser
On mei 16, 2016, 9:36 a.m., Marco Martin wrote:
>
> ---
> This is an automatically generat
markg added inline comments.
INLINE COMMENTS
src/context.cpp:424 You can merge this one and the earlier isNew i think.
Something like:
```
auto result = m_sinkInputs.data().constFind(eventRoleIndex);
if (result == m_sinkInputs.data().constEnd()) {
emit m_sinkInputs.added(
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127862/#review95271
---
+1
- Mark Gaiser
On mei 7, 2016, 8:13 p.m., David
> On mei 8, 2016, 10:49 a.m., Mark Gaiser wrote:
> > Modules/energy/batterymodel.cpp, lines 33-38
> > <https://git.reviewboard.kde.org/r/127864/diff/1/?file=464499#file464499line33>
> >
> > just:
> > m_batteries =
> > Solid::Device:
esUdi is removed.. how can this
even ocmpile?)!
- Mark Gaiser
On mei 7, 2016, 8:22 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
On Wed, Apr 27, 2016 at 8:52 PM, David Rosca wrote:
> Hi,
>
> On Wed, Apr 27, 2016 at 8:26 PM, Mark Gaiser wrote:
> >
> >
> > Ahh, the code helps :)
> > I understand what should be happening, it just doesn't..
> > gdb isn't really
On Wed, Apr 27, 2016 at 8:04 PM, David Edmundson wrote:
>
>
> On Wed, Apr 27, 2016 at 6:51 PM, Mark Gaiser wrote:
>
>> On Wed, Apr 27, 2016 at 5:24 PM, David Edmundson <
>> da...@davidedmundson.co.uk> wrote:
>>
>>> export PLASMA_TRACK_STARTU
On Wed, Apr 27, 2016 at 5:25 PM, Luca Beltrame wrote:
> In data mercoledì 27 aprile 2016 17:13:30 CEST, Mark Gaiser ha scritto:
>
> > Any other pointers where i might need to look?
>
> Are you using SDDM? What happens if you use another login manager?
> (if it doesn't
On Wed, Apr 27, 2016 at 5:24 PM, David Edmundson wrote:
> export PLASMA_TRACK_STARTUP
> then you'll see a log file in /tmp with timestamps.
>
> It might show something
>
> Hi David,
I followed your advise, but i can't seem to get any additional logging in
/tmp..
I added the define in /etc/profi
Hi,
Recently since plasma 5.6(.3) i'm noticing a very slow plasma startup after
logging in via sddm.
The startup really takes about 20 seconds or so.
Right now i'm at the point where i'm beginning to add timestamp logs in
there to figure out what is slowing things down. But debugging that still
w
for making it look better.
- Mark Gaiser
On feb 7, 2016, 11:10 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126719/#review90990
---
Big +1 :)
- Mark Gaiser
On jan 11, 2016, 5:29 p.m., Kai
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126687/#review90868
---
+1
- Mark Gaiser
On jan 10, 2016, 10:03 p.m., Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126497/#review90054
---
Ship it!
Ship It!
- Mark Gaiser
On dec 24, 2015, 12:36
> On dec 22, 2015, 9:58 p.m., Kai Uwe Broulik wrote:
> > I suppose this is obsolete now.
>
> David Edmundson wrote:
> I don't think it is.
> The other patch was about removing a silly timer before loading a pixmap,
> however it still always has the fade when changing source.
Is that a
On Wed, Dec 23, 2015 at 1:52 PM, Philipp A. wrote:
> Sebastian Kügler schrieb am Di., 22. Dez. 2015 um
> 17:13 Uhr:
>
>> Avoiding top-posting makes your emails a bit easier to read. I took the
>> liberty to rearrange.
>>
>
> if i have only one paragraph to reply to i can’t be bothered to click
On Fri, Dec 18, 2015 at 1:41 PM, Sebastian Kügler wrote:
> Let me step in here.
>
> On Friday, December 18, 2015 00:42:50 Mark Gaiser wrote:
> > If i report font issues, nobody is looking at them anyway. See [1] for
> > oxygen.
>
> Mark,
>
> That's a hurt
On Fri, Dec 18, 2015 at 10:39 AM, Kai Uwe Broulik
wrote:
> > You can quite clearly see that the noto package adds a lot of extra
> spacing. If that wasn't bad enough, it's also slightly offset from the
> top.
>
> Fwiw, font rendering in your tab bar looks shitty in both screen shots.
> Chrome re
On Fri, Dec 18, 2015 at 9:31 AM, Martin Graesslin
wrote:
> On Friday, December 18, 2015 9:26:20 AM CET Mark Gaiser wrote:
> > I'm out of options here! I don't like forking (as I said before) but I
> just
> > see no other way to solve this in a somewhat stable manner
Op 18 dec. 2015 2:48 a.m. schreef "Martin Klapetek" <
martin.klape...@gmail.com>:
>
> On Thu, Dec 17, 2015 at 7:47 PM, Mark Gaiser wrote:
>>
>>
>> Frameworkintegration is hereby forked [1].
>>
>> I will keep this one in sync with frameworkin
On Fri, Dec 18, 2015 at 1:24 AM, Eike Hein wrote:
>
>
> On 12/18/2015 12:31 AM, Mark Gaiser wrote:
> > You will hear me when my workflow is severely interrupted and when i
> > find the cause of it.
>
> plasma-devel@kde.org is not mark-gaisers-workf...@kde.org.
>
&g
On Fri, Dec 18, 2015 at 1:24 AM, Eike Hein wrote:
>
>
> On 12/18/2015 12:31 AM, Mark Gaiser wrote:
> > You will hear me when my workflow is severely interrupted and when i
> > find the cause of it.
>
> plasma-devel@kde.org is not mark-gaisers-workf...@kde.org.
>
&g
On Fri, Dec 18, 2015 at 1:05 AM, Eike Hein wrote:
>
>
> On 12/18/2015 12:42 AM, Mark Gaiser wrote:
> > I consider that to be one of the biggest issues in plasma.
>
> It's a case-by-case thing. The actual installed size of Noto
> depends a lot on how a distro c
On Fri, Dec 18, 2015 at 12:00 AM, Kai Uwe Broulik
wrote:
> Hi,
>
> > It is a very hard forced dependency on that font.
>
> I'll send you a bigger hard drive for Christmas as you constantly complain
> about a few megs of dependencies without any runtime overhead. I'm glad
> that we enforce some r
On Thu, Dec 17, 2015 at 11:43 PM, Eike Hein wrote:
>
>
> On 12/17/2015 11:09 PM, Mark Gaiser wrote:
> > What you say might be true and might be the goal of that font.
> > But it is unusable for me at this moment and i'm not going to make bug
> > reports about tha
On Thu, Dec 17, 2015 at 10:09 PM, Eike Hein wrote:
>
> Hi Mark,
>
> I think you might not be entirely clear on what we're doing.
>
Perhaps.
>
> It's not a forced dependency/font, it's a default font setting
> which compells distro packagers to pull the font packages in as
> dependency. However
Hi,
I've (somewhat mildly) already stated that i do not like the oxygen fonts
at all! Just having those installed always screws up "something" on my
system.
So what i used to do was simply removing the oxygen fonts once an update
had the nerves to install it again. Which would be the frameworkint
oks ok" to me.
If nobody objects within - lets say 3 days - then just ship it.
- Mark Gaiser
On dec 4, 2015, 6:23 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.r
On Thu, Dec 10, 2015 at 10:20 AM, Martin Graesslin
wrote:
> On Thursday, December 10, 2015 9:54:15 AM CET Mark Gaiser wrote:
> > On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin
> >
> > wrote:
> > > On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote:
&g
On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin
wrote:
> On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote:
> > On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote:
> > > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin
> wrote:
> > >> On Tuesday
On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote:
> On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote:
> > I thought the frameworkintegration plugin was exactly that and usable for
> > any platform if they wish to use it.
> > Or is my assumption wrong and
On Tue, Dec 8, 2015 at 5:27 PM, Martin Graesslin wrote:
> On Tuesday, December 8, 2015 5:05:33 PM CET Mark Gaiser wrote:
> > It's not that black and white though. There are much more desktop
> > environments out there. Specifically (but not only) those that are also
> &
On Tue, Dec 8, 2015 at 7:49 AM, Martin Graesslin wrote:
> On Monday, December 7, 2015 3:54:31 PM CET Mark Gaiser wrote:
> > While at it. Why does frameworkintegration force [1] specific fonts upon
> > the user?
> >
> > It's fine that apparently some folks prefer O
On Mon, Dec 7, 2015 at 1:09 PM, Martin Graesslin wrote:
> Hi all,
>
> based on the discussion in [1] I propose that we split out platformtheme
> plugin from frameworkintegration into a dedicated repository and move it to
> kde/workspace to be released together with Plasma 5.6.
>
> The main reason
> On dec 2, 2015, 11:36 p.m., Mark Gaiser wrote:
> > I had this issue for quite a while!
> > It's in bug #349669, i have high hopes that this change fixes my case as
> > well :)
> >
> > Will try this out somewhere this weekend.
>
> Martin Klapetek
n bug #349669, i have high hopes that this change fixes my case as well :)
Will try this out somewhere this weekend.
- Mark Gaiser
On dec 2, 2015, 7:32 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-
cker/greeter/greeterapp.cpp (line 350)
<https://git.reviewboard.kde.org/r/124947/#comment58463>
idem
I can't really give a +1.. I just don't know this or the implications it might
have.
So just a style review then :)
- Mark Gaiser
(lines 21 - 24)
<https://git.reviewboard.kde.org/r/124646/#comment57726>
Completely unrelated, but it looks like plasma should update it's imports
statements by now. We are currently at 2.5. The others are outdated as well.
Looks OK to me, ship it.
- Mark Gaiser
On aug 6, 201
1 - 100 of 302 matches
Mail list logo
