Review Request 124072: Refactor the Calendar grid computation a bit

endar.qml 5308708 Diff: https://git.reviewboard.kde.org/r/124072/diff/ Testing --- Lots of 600x-zoom inspections and pixel counting. Tested both in Calendar applet and Digital Clock applet. Thanks, Martin Klapetek ___ Plasma-devel mailing li

Re: Review Request 124005: Add week numbers to calendar - Part 2

marked as submitted. Review request for Plasma. Changes --- Submitted with commit a500d06431fbe795374eb746a7e64d9b4addbe2c by Martin Klapetek to branch master. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's

Re: Review Request 124047: Improve clock's tooltip layout

) https://git.reviewboard.kde.org/media/uploaded/files/2015/06/10/70f71cc7-3433-4a9a-bd12-031b82d6ed05__clock-tooltip9.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

) https://git.reviewboard.kde.org/media/uploaded/files/2015/06/10/70f71cc7-3433-4a9a-bd12-031b82d6ed05__clock-tooltip9.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/fc93cc02-881b-4bca-96a5-e0356baf4e61__clock-tooltip3.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma

Re: Review Request 124052: Implement keyboard navigation for timezone settings

the search field again Fwiw, this does not work now either. It gets stuck in some focus loop between the apply-cancel-ok buttons. - Martin Klapetek On June 9, 2015, 8:12 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically

Re: Review Request 124005: Add week numbers to calendar - Part 2

> Yours looks much more beautiful and tidy than the old 4.x version which > > always confused me. > > Martin Klapetek wrote: > "Simple by default, powerful when needed" ;) It's not a feature everyone > wants/needs, but it's there when they do.

Re: Review Request 124047: Improve clock's tooltip layout

align='right'>%2<%1>%3".arg(isCurrent ? "th" : > > "td").arg(timezoneString).arg(Qt.formatTime(dateTime, main.timeFormat)); > > Marco Martin wrote: > what about instead of HTML implementing a different layout delefate > instead? so that wouldb

Re: Review Request 124047: Improve clock's tooltip layout

wouldbecome one single repeater and would perhaps be less > tricky for translations Marco: I can try overriding the default tooltip if that's preferred - Martin --- This is an automatically generated e-mail. To reply, visit: https://

Review Request 124047: Improve clock's tooltip layout

rd.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/fc93cc02-881b-4bca-96a5-e0356baf4e61__clock-tooltip3.png Thanks, Marti

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #15 from Martin Klapetek --- Yes, I was just looking for it. It's on the KDE forums -- https://forum.kde.org/viewtopic.php?f=285&t=125246 The repos are on github - gtk2: https://github.com/scionicspectre/BreezyGTK and gt

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #13 from Martin Klapetek --- This is a bug report in a bug reporting tool. Please refrain from any "bashing" or adding long unrelated comments that do not add any value to the actual bug report; this is not the proper venue

Re: Review Request 124021: Add clock kcm to context menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124021/#review81243 --- Ship it! Ship It! - Martin Klapetek On June 5, 2015, 8:17

Re: Review Request 124017: Set tooltipTextFormat in CompactApplet

\o/ - Martin Klapetek On June 5, 2015, 4:47 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124004: Add week numbers to calendar - Part 1

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5caba3cfaff270a1a1b376451a56c6506cb4e1ce by Martin Klapetek to branch master. Repository: plasma-framework Description --- One of the most requested features for Plasma5. The backend is all there*, it

Re: Review Request 124004: Add week numbers to calendar - Part 1

t.reviewboard.kde.org/r/124004/#review81226 --- On June 4, 2015, 10:29 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 124004: Add week numbers to calendar - Part 1

__calendar-weeks6.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124005: Add week numbers to calendar - Part 2

> Yours looks much more beautiful and tidy than the old 4.x version which > > always confused me. > > Martin Klapetek wrote: > "Simple by default, powerful when needed" ;) It's not a feature everyone > wants/needs, but it's there when they do.

Re: Review Request 124005: Add week numbers to calendar - Part 2

> Yours looks much more beautiful and tidy than the old 4.x version which > > always confused me. > > Martin Klapetek wrote: > "Simple by default, powerful when needed" ;) It's not a feature everyone > wants/needs, but it's there when they do.

Re: Review Request 124004: Add week numbers to calendar - Part 1

2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124005: Add week numbers to calendar - Part 2

> Yours looks much more beautiful and tidy than the old 4.x version which > > always confused me. > > Martin Klapetek wrote: > "Simple by default, powerful when needed" ;) It's not a feature everyone > wants/needs, but it's there when they do.

Re: Review Request 124004: Add week numbers to calendar - Part 1

> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote: > > You can use QJSArray. In fact it's quite faster as I think it's what V4 > > uses internally, so no casting happens. > > Martin Klapetek wrote: > There is no QJSArray; you mean QJSValue? Or Q

Re: Review Request 124004: Add week numbers to calendar - Part 1

rays but I don't > > think it does that for any other QList. > > Martin Klapetek wrote: > QList should still work, according to > http://doc.qt.io/qt-5/qtqml-cppintegration-data.html#sequence-type-to-javascript-array > > Kai Uwe Broulik wrote: > Oh, didn&#x

Re: Review Request 124004: Add week numbers to calendar - Part 1

-b341-bcaddaaeac85__calendar-weeks6.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124004: Add week numbers to calendar - Part 1

Or QJsonArray? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81169 --- On June 4, 2015, 11:53 a.

Re: Review Request 124004: Add week numbers to calendar - Part 1

it: https://git.reviewboard.kde.org/r/124004/#review81167 ------- On June 4, 2015, 11:53 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 124004: Add week numbers to calendar - Part 1

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124004/#review81162 ------- On June 4, 2015, 11:53 a.m., Martin Klapetek wrote: > > --- > This is an a

Re: Review Request 124005: Add week numbers to calendar - Part 2

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 11:55 a.m., Martin Klapetek wrote: > > -

Re: Review Request 123991: Select lockscreenpassword not until user can type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123991/#review81188 --- Ship it! Ah yes, that makes perfect sense. Thanks! - Martin

Review Request 124005: Add week numbers to calendar - Part 2

tents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Kla

Review Request 124004: Add week numbers to calendar - Part 1

sting --- File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kd

Re: Review Request 123991: Select lockscreenpassword not until user can type

> On June 3, 2015, 5:58 p.m., Martin Klapetek wrote: > > Can you please explain once again what the problem is and why this solves > > it? > > David Kahles wrote: > I forgot to mention that this refers to the lockscreen, sorry. > > If the user types

Re: Review Request 123991: Select lockscreenpassword not until user can type

this solves it? - Martin Klapetek On June 3, 2015, 4:29 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Powerdevil] [Bug 348082] monitor is randomly powered back on

https://bugs.kde.org/show_bug.cgi?id=348082 --- Comment #4 from Martin Klapetek --- In my case, my desktop machine is configured to never sleep/suspend. However, the cause may indeed be the same/related. -- You are receiving this mail because: You are the assignee for the bug

Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6b3900767b6c97916e0e82dd8aa8fa8029ca7616 by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to "P

Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

e undo notifications if you undo twice in a row. > > > Diffs > - > > dataengines/notifications/notificationsengine.cpp 509f349 > > Diff: https://git.reviewboard.kde.org/r/123926/diff/ > > > Testing > --- > > Now I get two separate Undo

Review Request 123926: Unbreak Undo notifications on Plasma delete

23926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

marked as submitted. Review request for Plasma. Changes --- Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- This puts the notifications coming from the Jobs applet through the same

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

/git.reviewboard.kde.org/r/123923/#review80924 --- On May 28, 2015, 3:27 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

://git.reviewboard.kde.org/r/123923/diff/ Testing --- Copy files, notification appears correctly, is closed correctly and everything works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

> On May 18, 2015, 10:46 a.m., Martin Klapetek wrote: > > Fwiw, I think it would be much better if the dataengine actually signalled > > the disk space change rather than polling, then the applet could just > > handle the incoming "changed" signals -> less

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

marked as submitted. Review request for Plasma. Changes --- Submitted with commit ba64ae775699ae5e7d18a70e29078cc4fc5e4ead by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- This returns the kde4 behavior of simply switching the icon for attention

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > I think we should always pulse, and if available, use the needs attention > > icon (but don't cycle between normal and attention icon) > > Martin Klapetek wrote: > If you don't cycle it's qu

Re: Review Request 123834: Switch the login sound to Phonon directly...for now

marked as submitted. Review request for Plasma. Changes --- Submitted with commit c445f99304bd0190a7a0b83e4700222132bc34d1 by Martin Klapetek to branch master. Repository: plasma-workspace Description --- With its current architecture, KNotification can cause crashes on logout (and

Re: Review Request 123731: Cleanup handling of notifications closing

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 35900a84a8e7de77747031c3ba26ed1ac61f389f by Martin Klapetek to branch master. Repository: knotifications Description --- While investigating the cause of crash of https

[Powerdevil] [Bug 348082] monitor is randomly powered back on

https://bugs.kde.org/show_bug.cgi?id=348082 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 123877: [digital-clock] Bring back font family and color options

option? - Martin Klapetek On May 21, 2015, 11:45 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 122488: Improved calendar navigation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review80706 --- Bump. Can we get this in for 5.4? - Martin Klapetek On Feb

[Breeze] [Bug 347547] Qt4 applications use wrong palette and icons w/ Breeze

https://bugs.kde.org/show_bug.cgi?id=347547 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #11 from

Re: Plasma 5 is awesome...and some help required with build instructions

system where I had to figure out all the deps. So I thought it might come handy to others and added it there. Nevertheless, I also hit the same problem as you did. I didn't solve it yet because my laptop has other (more severe) issues with Linux currently. Cheers -- Martin K

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

> On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: > > This fixes my boot. I wasn't able to boot for the whole day because it was > > showing a QWidget from the wrong thread. > > > > On a related note, let's port away from QDesktopWidget, it has thes

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit bbf19c13ee61fe0f09263d2fdd40207a71dca6fd by Martin Klapetek to branch master. Repository: knotifications Description --- The NotifyByPopup plugin is accessing QApplication::desktop

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

hese > > things... Ok, QScreen then? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/#review80575 ------- On May

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > I think we should always pulse, and if available, use the needs attention > > icon (but don't cycle between normal and attention icon) > > Martin Klapetek wrote: > If you don't cycle it's qu

Re: Review Request 122648: Make notifications --reverse aware

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 7253c12a2b089176d0354c6a3a88b536befb5653 by Martin Klapetek to branch Plasma/5.3. Bugs: 343251 https://bugs.kde.org/show_bug.cgi?id=343251 Repository: plasma-workspace Description --- Now it

Re: Review Request 123731: Cleanup handling of notifications closing

//git.reviewboard.kde.org/r/123731/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123836: Ensure KNotification can be used from a non-GUI thread

it's not. This is only for the popup fallback notifications, normal notifications work just fine. Diffs - src/notifybypopup.cpp 2f84ab0 Diff: https://git.reviewboard.kde.org/r/123836/diff/ Testing --- Tested with both multi-threaded and single-threaded codes. Thanks, M

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

actually signalled the disk space change rather than polling, then the applet could just handle the incoming "changed" signals -> less polling around. - Martin Klapetek On May 17, 2015, 1:01 p.m., Yoann Laissus wrote: > > -

Review Request 123834: Switch the login sound to Phonon directly...for now

fccad ksmserver/CMakeLists.txt c0543e2 ksmserver/shutdown.cpp 7600c30 ksmserver/startup.cpp f79fd4f Diff: https://git.reviewboard.kde.org/r/123834/diff/ Testing --- Login sound works as expected, logout sound as well. Also tested by couple other people. Thanks, Martin Kla

Re: Review Request 123770: Play the login sound in its own thread

n g_main_context_iteration () from > > /lib/x86_64-linux-gnu/libglib-2.0.so.0 > > #33 0x7f125a46bcec in QEventDispatcherGlib::processEvents > > (this=0x7f12380008c0, flags=...) > > at > > /opt/src/ksrc5/qt/stable/qtbase/src/corelib/kernel/qev

Re: Review Request 123770: Play the login sound in its own thread

marked as submitted. Review request for Plasma. Changes --- Submitted with commit b0fe26bfb314698693fcf011e59a28769bd9a437 by Martin Klapetek to branch master. Repository: plasma-workspace Description --- This feature was reverted back in the days as somehow it was blocking with

Re: Review Request 123770: Play the login sound in its own thread

> On May 13, 2015, 4:37 p.m., David Edmundson wrote: > > Ship It! > > Martin Klapetek wrote: > Stable? I'll push to master for now, we can cherry pick afterwards. - Martin --- This is an automatically gen

[Powerdevil] [Bug 347712] Backlight settings based on local time

https://bugs.kde.org/show_bug.cgi?id=347712 --- Comment #8 from Martin Klapetek --- Ah so it wasn't a patch, but a project proposal for the webcam --> http://marc.info/?l=kde-core-devel&m=133352645130676&w=2 -- You are receiving this mail because: You are the assi

Re: Review Request 123770: Play the login sound in its own thread

view80304 --- On May 13, 2015, 12:09 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 37590e2d2bd8965dea13876912afebc2fcf9f565 by Martin Klapetek to branch master. Bugs: 340326 http://bugs.kde.org/show_bug.cgi?id=340326 Repository: plasma-framework Description --- This gets the

Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

--- Folderview now has proper context menu action. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123770: Play the login sound in its own thread

> On May 13, 2015, 1:05 p.m., David Edmundson wrote: > > do you still have any backtraces of the original freeze? > > Martin Klapetek wrote: > I never had any, but Hrvoje and Mark had those problems as reported in > https://git.reviewboard.kde.org/r/118636/ [14:01:22

Re: Review Request 123770: Play the login sound in its own thread

- Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80290 --- On May 13, 2015, 12:09 p.m., Martin Klape

Review Request 123770: Play the login sound in its own thread

: https://git.reviewboard.kde.org/r/123770/diff/ Testing --- I was never able to reproduce the blocking, so I'm not sure if this actually fixes the problem. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 123740: Add timezone filtering by region too

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 72041b7c90c3f4e1d1ec6812813dee84952f3f89 by Martin Klapetek to branch Plasma/5.3. Bugs: 346681 https://bugs.kde.org/show_bug.cgi?id=346681 Repository: plasma-workspace Description --- Adds a

Re: Review Request 123740: Add timezone filtering by region too

https://git.reviewboard.kde.org/r/123740/#review80257 ------- On May 12, 2015, 10:05 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-ma

Review Request 123740: Add timezone filtering by region too

s are now correctly filtered by both city and region. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123727: [klipper] Ensure global shortcut actions work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123727/#review80232 --- Ship it! Ship It! - Martin Klapetek On May 12, 2015, 7:27

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

https://bugs.kde.org/show_bug.cgi?id=347532 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 123633: remove support for dbusmenuqt <4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123633/#review79853 --- Ship it! Ship It! - Martin Klapetek On May 4, 2015, 6:30

[Breeze] [Bug 347123] OSD is distracting and annoying

https://bugs.kde.org/show_bug.cgi?id=347123 --- Comment #7 from Martin Klapetek --- > That was the nice thing in the KDE4 OSD, one could place it elsewhere, > actually in all corners, top and bottom middle as well. We never had that in KDE4, it was always hardcoded at the same positio

[Breeze] [Bug 347123] OSD is distracting and annoying

https://bugs.kde.org/show_bug.cgi?id=347123 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #5 from Martin

Re: Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 2a8002d00713a7768eae3fde215efeadfe1aaa8d by Martin Klapetek to branch master. Bugs: 345973 https://bugs.kde.org/show_bug.cgi?id=345973 Repository: knotifications Description

Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

d block all other notifications from appearing (NotifyOSD supports only one popup at a time). Now everything behaves correctly. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123535: Visible error messagebox on fatal loading errors

tps://git.reviewboard.kde.org/r/123535/#comment54371> "No shell packages have been found ..." reads better I think - Martin Klapetek On April 27, 2015, 4:55 p.m., David Edmundson wrote: > > --- > This is an automatically g

Re: Review Request 123502: Manually keep track of jobs sources

no longer move in sync If this is desired, the indet. state could be reset on all the jobs that are in that state (like set it again or set different state and right back to indeterminate) when new indet. job appears - Martin Klapetek On April 26, 2015, 7:24 p.m., Kai Uwe Broulik wr

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

> On April 6, 2015, 3:12 p.m., Martin Klapetek wrote: > > autotests/globaltest.cpp, line 96 > > <https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96> > > > > This should be (1).txt? > > Ashish Bansal wrote: > imho if

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

e applet's config dialogs, the Apply will not become disabled but will stay enabled forever. - Martin Klapetek On April 21, 2015, 5:04 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > I think we should always pulse, and if available, use the needs attention > > icon (but don't cycle between normal and attention icon) > > Martin Klapetek wrote: > If you don't cycle it's qu

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

board.kde.org/r/123381/#review79045 --- On April 16, 2015, 1:23 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123381/ > ---

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

ontents/ui/TaskDelegate.qml f2738bd Diff: https://git.reviewboard.kde.org/r/123381/diff/ Testing --- I didn't test with animations off (I'm not sure how to set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works just like in the old times. Than

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

g/r/123381/diff/ Testing --- I didn't test with animations off (I'm not sure how to set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works just like in the old times. Thanks, Martin Klapetek ___ Plasma-devel

Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

27;m not sure how to set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works just like in the old times. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5b76b2385b35baa51d0df43cacc88aa3c8f7813e by Martin Klapetek to branch Plasma/5.3. Bugs: 346033 https://bugs.kde.org/show_bug.cgi?id=346033 Repository: plasma-workspace Description --- Currently

Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

calendar switch dates and also watched tooltip properly update after midnight Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123332: Timer: Added config ui for notification and title text

> On April 11, 2015, 5 p.m., David Edmundson wrote: > > applets/timer/package/contents/ui/configAppearance.qml, line 91 > > > > > > use Layout.fillWith: true ? > > Bernhard Friedreich wrote: > using QtLayouts

Re: System Settings app design freshening

back. Eg. if the user bothers with many settings, then does one wrong, thinks undo undoes that one step but all his setting get reset after pressing it. I think that particular change is rather a step back (heh). Cheers -- Martin Klapetek | KDE Developer _

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

, the NeedsAttention state of KSNI will do just nothing? That is seriously bad if that's the case; it should at least fallback to the NeedsAttention icon that the spec defines. It is called "needs attention" after all, it should always do something to get the users attention I bel

Re: Review Request 123046: Use own copy of org.kde.JobView.xml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123046/#review78685 --- Ship it! Ship It! - Martin Klapetek On April 7, 2015, 8

Review Request 123300: Make the dataengine alignment timer more precise

ivate/datacontainer_p.cpp d9d33d7 Diff: https://git.reviewboard.kde.org/r/123300/diff/ Testing --- Been running it for a bit of time (heh), so far no 1s delay. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/ma

[Powerdevil] [Bug 345940] Move "Enable Power Management" checkbox to the top as other applets

https://bugs.kde.org/show_bug.cgi?id=345940 Martin Klapetek changed: What|Removed |Added Resolution|INVALID |--- Ever confirmed|0

Re: Review Request 123271: improve kickoff representation on vertical panels

> On April 7, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > What when I place it on the desktop? I'd like it to fill the entire room > > there. If I want a massive Kickoff button on my desktop, that's up to me :) +1; it should really be iff vertical == true - Martin -

Re: PIM Sprint this Weekend

no features for users. (Also KCalCore is a beast nobody has managed to port properly to frameworks yet iirc) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123271: improve kickoff representation on vertical panels

all over the panel seems like a waste of space to me... applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 43) <https://git.reviewboard.kde.org/r/123271/#comment53753> This should use the "plasmoid.configuration.icon" I believe - Martin Klapetek On Apr

Re: Review Request 122842: Allow selecting notifications position on screen

marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 9429c845ae3fee1d65b026b2d496aae1305db232 by Martin Klapetek to branch master. Bugs: 344841 https://bugs.kde.org/show_bug.cgi?id=344841 Repository: plasma-workspace Description

<    1   2   3   4   5   6   7   8   9   10   >