Re: Review Request 122411: Prevent notifications from accessing the network

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122411/#review75344 --- Ship it! Ship It! - Martin Klapetek On Feb. 3, 2015, 7:44

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Klapetek
lation string? klipper/org.kde.plasma.clipboard.operations <https://git.reviewboard.kde.org/r/122402/#comment52086> pixelSSS (same below) - Martin Klapetek On Feb. 3, 2015, 12:03 p.m., Martin Gräßlin wrote: > > --- > Thi

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Klapetek
ith my phone (yes we do;) but it "looks" wrong and maybe some devices might struggle. - Martin Klapetek On Feb. 3, 2015, 10:59 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-03 Thread Martin Klapetek
> On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). > > Martin Gräßlin wrote: > Unfortunately I couldn't find out why we support up to 2048 items. Commit

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-03 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #10 from Martin Klapetek --- Please let's not turn this into Gnome bashing report. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread Martin Klapetek
tps://git.reviewboard.kde.org/r/122400/#comment52061> I guess this meant irrelevant? - Martin Klapetek On Feb. 3, 2015, 9:40 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 122314: Sanitize whitespace in notification popups

2015-02-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122314/#review75248 --- bump - Martin Klapetek On Jan. 30, 2015, 12:37 p.m

Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

2015-02-02 Thread Martin Klapetek
other qt-only apps not using KSNI directly, I'd advise to test those first too - Martin Klapetek On Feb. 2, 2015, 4:48 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Minutes Monday Plasma Hangout

2015-02-02 Thread Martin Klapetek
t; interacting > with systray > Can you please share some more info about these^? Or is it somewhere noted down in public? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122370: Prevent icon transition in tooltip

2015-02-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122370/#review75201 --- +1 - Martin Klapetek On Feb. 1, 2015, 8:36 p.m., Kai Uwe

Re: Review Request 122342: Don't let notification popup accept focus

2015-02-02 Thread Martin Klapetek
this (by you even?) so please close it too - Martin Klapetek On Jan. 31, 2015, 7:44 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-01-30 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #3 from Martin Klapetek --- > What you said is very misleading Well I said "Iirc Hugo said that gtk3 is deprecating theme engines" which is very true as you just confirmed, then I said "so proper gtk3 port is...unlike

Re: Review Request 122314: Sanitize whitespace in notification popups

2015-01-30 Thread Martin Klapetek
Diff: https://git.reviewboard.kde.org/r/122314/diff/ Testing --- Now I'm able to see the message sent with wall. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-01-30 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343555 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle

2015-01-29 Thread Martin Klapetek
g/r/122319/#comment51940> Use qWarning rather than qDebug, I'd say it's a warning after all... src/kded/kdedactions.cpp <https://git.reviewboard.kde.org/r/122319/#comment51941> If this is not needed anymore, just remove it altogether - Martin Klapetek On Ja

Re: Review Request 122314: Sanitize whitespace in notification popups

2015-01-29 Thread Martin Klapetek
y generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122314/#review75004 ------- On Jan. 29, 2015, 8:14 p.m., Martin Klapetek wrote: > > --- > Thi

Review Request 122314: Sanitize whitespace in notification popups

2015-01-29 Thread Martin Klapetek
history anyway. Diffs - dataengines/notifications/notificationsengine.cpp 6e566b4 Diff: https://git.reviewboard.kde.org/r/122314/diff/ Testing --- Now I'm able to see the message sent with wall. Thanks, Martin Klapetek ___ Plasma-

[plasmashell] [Bug 343532] empty notification string on wall messages

2015-01-29 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343532 Martin Klapetek changed: What|Removed |Added Version|unspecified |master Assignee|plasma-devel

[kwrited] [Bug 343532] empty notification string on wall messages

2015-01-29 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343532 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 122259: [ksld/greeter] Disable all IM modules

2015-01-26 Thread Martin Klapetek
> On Jan. 26, 2015, 1:41 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 56 > > > > > > qunsetenv? > > Martin Gräßlin wrote: > see bug report: Eike explicitly suggested to set i

Re: Review Request 122230: Continuously update notification timestamp

2015-01-23 Thread Martin Klapetek
> On Jan. 23, 2015, 11:13 p.m., David Edmundson wrote: > > applets/notifications/package/contents/ui/NotificationItem.qml, line 94 > > > > > > why 15 seconds? It goes "now", if (time < 20 seconds) "10 seconds", i

Re: Review Request 122230: Continuously update notification timestamp

2015-01-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122230/#review74630 --- Ship it! Ship It! - Martin Klapetek On Jan. 23, 2015, 8

Re: Review Request 122229: Smooth the battery remaining time with moving average

2015-01-23 Thread Martin Klapetek
powerdevil, the backend (for this), with the raw data and only "correct" them in the UI. But if you think otherwise, it can sure be moved there. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git

Review Request 122229: Smooth the battery remaining time with moving average

2015-01-23 Thread Martin Klapetek
1e068__chart_2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-23 Thread Martin Klapetek
properly formats the remaining time based on the passed flags. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2 tars are up

2015-01-22 Thread Martin Klapetek
s/plasma-5.2.0.php Marco improved the applet's position after undo, may we take that gif again with fixed things? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
But my guess would be they don't. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74548 --- On Jan. 22,

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
properly formats the remaining time based on the passed flags. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
remaining time based on the passed flags. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
Diffs - src/qmlcontrols/kcoreaddons/formats.cpp 256778f src/qmlcontrols/kcoreaddons/formats.h 59537bf Diff: https://git.reviewboard.kde.org/r/122200/diff/ Testing --- KFormat now properly formats the remaining time based on the passed flags. Than

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-18 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #43 from Martin Klapetek --- Fwiw (with regards to those sddm comments) I use lightdm and have never seen this issue. -- You are receiving this mail because: You are the assignee for the bug

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-15 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=337674 Martin Klapetek changed: What|Removed |Added Ever confirmed|0 |1 Version|unspecified

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-15 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #31 from Martin Klapetek --- *** Bug 341775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing

[Powerdevil] [Bug 341775] Powerdevil kded triggers kded5 loop

2015-01-15 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=341775 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org Status

Re: Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-14 Thread Martin Klapetek
ckage/contents/ui/JobDetailsItem.qml 8b18356 Diff: https://git.reviewboard.kde.org/r/121945/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-13 Thread Martin Klapetek
https://git.reviewboard.kde.org/r/121945/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

2015-01-13 Thread Martin Klapetek
Solid already offers backends (so we > don't have to implement this in kscreen) and we don't have to expose > powerdevil internals. > > So this is a -1 from my side (if the only reason to add this is KSCreen). > > Martin Klapetek wrote: > > 2-It

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-12 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=337674 Martin Klapetek changed: What|Removed |Added Target Milestone|1.0 |--- Version|master

Re: Review Request 122018: Center the logout remaining time label

2015-01-12 Thread Martin Klapetek
3 Diff: https://git.reviewboard.kde.org/r/122018/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122018: Center the logout remaining time label

2015-01-12 Thread Martin Klapetek
- Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122018/#review73868 --- On Jan. 12, 2015, 4:22 p.m., Martin Klape

Re: Review Request 122018: Center the logout remaining time label

2015-01-12 Thread Martin Klapetek
utScreen.qml 511dac3 Diff: https://git.reviewboard.kde.org/r/122018/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122018: Center the logout remaining time label

2015-01-12 Thread Martin Klapetek
511dac3 Diff: https://git.reviewboard.kde.org/r/122018/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122018: Center the logout remaining time label

2015-01-12 Thread Martin Klapetek
--- As per the discussion and Andrew's "go" in https://bugs.kde.org/show_bug.cgi?id=338083 Diffs - lookandfeel/contents/components/LogoutScreen.qml 511dac3 Diff: https://git.reviewboard.kde.org/r/122018/diff/ Testing --- Thanks,

Re: Qt 5.4 again

2015-01-12 Thread Martin Klapetek
still testing against 5.3? So we know who to ping in case we need something tested... Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-12 Thread Martin Klapetek
r 5.2. I'll ask for an exception (and review). Diffs (updated) - applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 Diff: https://git.reviewboard.kde.org/r/121945/diff/ Testing --- Thanks, Martin Klapetek ___ Pl

Re: Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-12 Thread Martin Klapetek
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121945/#review73715 --- On Jan. 9, 2015, 2:55 p.m., Martin Klapetek wrote: > >

Re: Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-12 Thread Martin Klapetek
ent form, even if the sorting is random/not ideal. In this case, imo the looks outweight the negative of the grid as you get the same (moreless) negatives in the Natural look. Do you have a link to the VDG thread btw? Cheers -- Martin Klapetek | KDE Developer

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-10 Thread Martin Klapetek
not around at that time. Is there a thread somewhere? Also what exactly does suck about it? Can it be improved without a full rewrite? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

2015-01-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/#review73643 --- Ship it! Ship It! - Martin Klapetek On Jan. 9, 2015, 8:48

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Martin Klapetek
at's what --> http://paste.opensuse.org/images/4207e18f.png There are also still the text labels over the window, so if you cannot tell a window by the thumb size, you can just read it (that imo works well). Cheers -- Martin Klapetek | KDE Developer ___

RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Martin Klapetek
e imo fits into that. Pic here: http://paste.opensuse.org/images/ac9f8f90.png So I'd like to propose changing the default of Present Windows effect to the grid setting. What do you think? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-

Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

2015-01-09 Thread Martin Klapetek
> On Jan. 9, 2015, 12:25 p.m., Àlex Fiestas wrote: > > Where do you plan to use this? We are not maintaining compatibility (so > > far) in our dbus apis, so why add this at all? > > Daniel Vrátil wrote: > KScreen. For now we are listening to UPower, which IMO sucks and we > should use Powe

Re: Review Request 121948: When initializing plasma, add to the system tray the plasmoids marked as EnabledByDefault

2015-01-09 Thread Martin Klapetek
tps://git.reviewboard.kde.org/r/121948/#comment51250> I think this comment should to the xml as people/distros wanting to customize it will look only at the xml file, not here So should be explained there what the default value is - Martin Klapetek On Jan. 9, 2015, 4:09 p.m., Ale

Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-09 Thread Martin Klapetek
/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Martin Klapetek
> On Jan. 7, 2015, 7:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CO

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-07 Thread Martin Klapetek
sfgn sodifgj asodfgnsdlfgdf g"; done executed from 4 terminals at once, all works fine and as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-07 Thread Martin Klapetek
121360/diff/ > > > Testing > --- > > Tested whole day plus stress-tested with something like for i in {1..200}; do > notify-send "$i - $RANDOM" "$RANDOM sdf sdf sdfwefhsdjfnskdfbkwefnos igodsfgn > sodifgj asodfgnsdlfgdf g"; done executed from 4 terminals at once

Re: [kde-promo] Plasma naming scheme

2015-01-07 Thread Martin Klapetek
> > But don't fear as the kde-promo team is mostly inexistent atm it doesn't > make > much difference ;-( > > And I think it would make sense to update it of course so as soon as we > agree > I volunteer (if nobody beats me, I'm not really bored atm ;-) to update

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
Klapetek On Jan. 6, 2015, 2:32 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
> On Jan. 3, 2015, 9:08 p.m., Kai Uwe Broulik wrote: > > applets/notifications/plugin/notificationshelper.cpp, line 51 > > <https://git.reviewboard.kde.org/r/121360/diff/2/?file=337844#file337844line51> > > > > Use QScopedPointer > > Martin Klapetek

Re: Review Request 121887: Replace Q_WS_* macros in kglobalaccel/

2015-01-06 Thread Martin Klapetek
7bd39d7 Diff: https://git.reviewboard.kde.org/r/121887/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Martin Klapetek
- CMakeLists.txt 834de83 Diff: https://git.reviewboard.kde.org/r/121882/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121887: Replace Q_WS_* macros in kglobalaccel/

2015-01-06 Thread Martin Klapetek
, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-promo] Plasma naming scheme

2015-01-06 Thread Martin Klapetek
Originally we went for "Plasma by KDE" format to get further from the idea that Plasma = KDE and make the rebranding clearer. Was that dropped? Or just forgotten? Imho puts a nicer touch to the name than "KDE Plasma" (which still supports the Plasma = KDE) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Martin Klapetek
--- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
odfgnsdlfgdf g"; done executed from 4 terminals at once, all works fine and as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
> > signal we're processing, not the last method call made. > > > > I suggest maybe > > > > connect(m_dispatchTimer, &QTimer::timeout, this, > > [this]{m_busy=false ; processQueues()} > > > > instead > > M

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
> > signal we're processing, not the last method call made. > > > > I suggest maybe > > > > connect(m_dispatchTimer, &QTimer::timeout, this, > > [this]{m_busy=false ; processQueues()} > > > > instead > > M

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
sit: https://git.reviewboard.kde.org/r/121360/#review73170 --- On Jan. 5, 2015, 2:33 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
> On Jan. 3, 2015, 9:08 p.m., Kai Uwe Broulik wrote: > > applets/notifications/plugin/notificationshelper.cpp, line 51 > > <https://git.reviewboard.kde.org/r/121360/diff/2/?file=337844#file337844line51> > > > > Use QScopedPointer > > Martin Klapetek

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
ike for i in {1..200}; do notify-send "$i - $RANDOM" "$RANDOM sdf sdf sdfwefhsdjfnskdfbkwefnos igodsfgn sodifgj asodfgnsdlfgdf g"; done executed from 4 terminals at once, all works fine and as expected. Thanks, Martin Klapetek _

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-05 Thread Martin Klapetek
a QML signal, I'm not sure that's possible...? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/#review73046 --

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-02 Thread Martin Klapetek
odfgnsdlfgdf g"; done executed from 4 terminals at once, all works fine and as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Black Screen on Login

2015-01-02 Thread Martin Klapetek
's not waiting for it to appear. Or did you mean other notifications? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121774: Let month menu navigate in current year

2015-01-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/#review72936 --- Ship it! Ship It! - Martin Klapetek On Dec. 31, 2014, 11

Re: Gerrit and GMail

2014-12-30 Thread Martin Klapetek
in plasma-framework" and apply the same label as for other plasma-devel mails. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2014-12-25 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=340063 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #4 from Martin

Re: Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Martin Klapetek
On Wed, Dec 17, 2014 at 11:50 AM, Jonathan Riddell wrote: > > On Wed, Dec 17, 2014 at 11:47:13AM +0100, Martin Klapetek wrote: > >Hey, > >so I'm about to move kglobalacceld from plasma-workspace to the > >kglobalaccel framework. > >However, this

Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Martin Klapetek
aemon in plasma-workspace and check for the framework version that was found, then build if < 5.6? Please advise Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121360: Rework Plasma's notification positioning code

2014-12-15 Thread Martin Klapetek
mutexes there. I'll change to Recursive. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/#review71438 ------

Re: Review Request 121529: Let others know that we support persistent notifications

2014-12-15 Thread Martin Klapetek
> On Dec. 15, 2014, 10:59 a.m., Martin Klapetek wrote: > > This spec is however gnome's own extension of the original spec, which has > > no such stuff. Is there an actual use case why this would be needed? > > > > More general question - should we be impleme

Re: Review Request 121529: Let others know that we support persistent notifications

2014-12-15 Thread Martin Klapetek
ginal spec, which has no such stuff. Is there an actual use case why this would be needed? More general question - should we be implementing their extensions? - Martin Klapetek On Dec. 15, 2014, 10:37 a.m., Jan Grulich wrote: > > --- &

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-12 Thread Martin Klapetek
es/settings-hardware-input.desktop ddc3204 Diff: https://git.reviewboard.kde.org/r/121449/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
we have config modules "human"? ;) What's a non-human input device anyway? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71814 ---

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/#review71832 --- Ship it! Even worse when seconds are on... - Martin

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
o. It's not dismissing, it's iterating ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71808 -----

Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
1449/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Martin Klapetek
? Good spot otherwise! - Martin Klapetek On Dec. 11, 2014, 9:26 a.m., Dmitry Shachnev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121421: Make the OSD timeout a bit shorter

2014-12-10 Thread Martin Klapetek
Diff: https://git.reviewboard.kde.org/r/121421/diff/ Testing --- Feels better and gets out of the way sooner, but not too soon. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121421: Make the OSD timeout a bit shorter

2014-12-10 Thread Martin Klapetek
leix Pol Gonzalez wrote: > I don't really have an opinion, still wanted to remind that maybe what we > want is to find different solutions in case it really gets annoying, like > making it disappear on click or key press, for example. > > Martin Klapetek wrote: >

Re: Review Request 121421: Make the OSD timeout a bit shorter

2014-12-10 Thread Martin Klapetek
cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121421/#review71678 ------- On Dec. 9, 2014, 11:52 p.m., Martin Klapetek wrote: > > --- >

Review Request 121421: Make the OSD timeout a bit shorter

2014-12-09 Thread Martin Klapetek
of the way sooner, but not too soon. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121360: Rework Plasma's notification positioning code

2014-12-05 Thread Martin Klapetek
ess-tested with something like for i in {1..200}; do notify-send "$i - $RANDOM" "$RANDOM sdf sdf sdfwefhsdjfnskdfbkwefnos igodsfgn sodifgj asodfgnsdlfgdf g"; done executed from 4 terminals at once, all works fine and as expected. Thanks, Martin Klapetek ___

Change in plasma-framework[master]: Fix the platformstatus kded module

2014-12-02 Thread Martin Klapetek (Code Review)
Martin Klapetek has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/197 Change subject: Fix the platformstatus kded module .. Fix the platformstatus kded module The module .desktop file has a typo in

Re: Review Request 121296: Escape ampersands in notifications

2014-11-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121296/#review71132 --- Ship it! Ship It! - Martin Klapetek On Nov. 30, 2014, 9

[Breeze] [Bug 341291] Issues with vertical spacing between items in tree views

2014-11-26 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=341291 --- Comment #3 from Martin Klapetek --- ...was a *wrong* bug number, not first...eheh. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel

[Breeze] [Bug 341291] Issues with vertical spacing between items in tree views

2014-11-26 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=341291 --- Comment #2 from Martin Klapetek --- The first duplicate was a first bug number, sorry :) *** This bug has been marked as a duplicate of bug 340999 *** -- You are receiving this mail because: You are the assignee for the bug

[Breeze] [Bug 341291] Issues with vertical spacing between items in tree views

2014-11-26 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=341291 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org Resolution

[Breeze] [Bug 340623] Breeze Widget style is very boxy and spacious. Takes too much space.

2014-11-26 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=340623 Martin Klapetek changed: What|Removed |Added CC||kf...@kde.org --- Comment #4 from Martin

Re: Review Request 121228: Fix minimum height in notifications

2014-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121228/#review70905 --- Ship it! Ship It! - Martin Klapetek On Nov. 24, 2014, 4

<    3   4   5   6   7   8   9   10   11   12   >