Check before trying subindexing.
Signed-off-by: Ken CC ken.c...@gmail.com
---
hw/pci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a09fbac..f6f00c6 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -675,6 +675,10 @@ static PCIDevice
Check before trying subindexing.
Signed-off-by: Ken CC ken.c...@gmail.com
---
hw/pci.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index a09fbac..f6f00c6 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -675,6 +675,10 @@ static PCIDevice
On 08/23/2010 12:06 AM, Anthony Liguori wrote:
On 08/22/2010 03:33 PM, Avi Kivity wrote:
On 08/22/2010 11:03 PM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware
On 08/23/2010 12:07 AM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely how hardware works..
Well, I agree, but I honestly lost the context. How does this relate
to the APIC
On Mon, Aug 23, 2010 at 2:55 AM, Yoshiaki Tamura
tamura.yoshi...@lab.ntt.co.jp wrote:
Currently qemu_set_fd_handler2() is only setting ioh-deleted upon
deleting. This may cause a crash when a read handler calls
qemu_set_fd_handler2() to delete handlers, but a write handler is
still invoked
On 08/22/2010 11:50 PM, Anthony Liguori wrote:
On 08/11/2010 04:56 PM, Paolo Bonzini wrote:
Currently -qmp stdio (or the equivalent -mon/-chardev combination) sets
up the terminal attributes even though it does not go through readline
to actually do I/O. As a result, echo is disabled and you
On 08/17/2010 01:29 PM, Avi Kivity wrote:
On 08/12/2010 06:29 PM, Paolo Bonzini wrote:
Nothing earth shattering. :)
Paolo Bonzini (3):
move kvm_set_irqfd to kvm-stub.c
This touches kvm-all.c, so should be against uq/master.
kvm_set_irqfd is not in upstream qemu, should I add it there even
On 08/23/2010 09:45 AM, Paolo Bonzini wrote:
On 08/17/2010 01:29 PM, Avi Kivity wrote:
On 08/12/2010 06:29 PM, Paolo Bonzini wrote:
Nothing earth shattering. :)
Paolo Bonzini (3):
move kvm_set_irqfd to kvm-stub.c
This touches kvm-all.c, so should be against uq/master.
kvm_set_irqfd is
On 08/22/2010 08:56 PM, Blue Swirl wrote:
On Sun, Aug 22, 2010 at 6:41 PM, Anthony Liguorianth...@codemonkey.ws wrote:
On 08/22/2010 11:49 AM, Jes Sorensen wrote:
While wasting time for historical reasons is certainly better than
wasting time for the heck of it, it's arguably worse than
On 08/22/10 20:35, malc wrote:
On Sun, 22 Aug 2010, Blue Swirl wrote:
What's the ultimate editor? I'd love to drop Emacs, which is annoying
but does its job better than the others that I've tried.
ed
ed is for sissies, real developers use cat, echo, and sed.
Jes
On 08/22/10 20:13, Blue Swirl wrote:
Well, consider for example mass braces conversion to the One Style,
whichever that is. Would it be better to do it in one commit or
multiple commits? If the latter, push all commits back-to-back or just
one at a time now and then?
At the extreme end, we
Hi
I was wondering if qemu's user mode emulation could be tweaked to generate
callgraph.
Today was the first time I tried the user mode emulation - I ran into the
below issue
[u...@kashyap lab]$ qemu-x86_64 -cpu qemu64 ./a.out
ERROR: ioctl(SNDCTL_DSP_MAPINBUF): target=0x80085013 host=0x80105013
On 08/22/10 20:39, malc wrote:
Disregarding my own stance on the braces, braces around single statement
is actually helpful w.r.t. debugging imaging trying to set a break point
on said singlesttement, plain impossible in following case:
if (a) b;
Oh there is no talk about suggesting we
Am 22.08.2010 20:42, schrieb Anthony Liguori:
On 08/22/2010 01:36 PM, malc wrote:
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYLE that is widely appreciated and
so all bikeshedding will cease? Enforce current style?
I would
On 08/21/10 16:20, Kevin O'Connor wrote:
On Fri, Aug 20, 2010 at 09:39:10AM -0500, Anthony Liguori wrote:
On 08/20/2010 09:09 AM, Gerd Hoffmann wrote:
Been there, tried that. It isn't *that* easy. The PCI ID in the
option rom header doesn't match the PCI ID of the emulated lsi, so
seabios
Avi Kivity wrote:
On 08/23/2010 12:06 AM, Anthony Liguori wrote:
On 08/22/2010 03:33 PM, Avi Kivity wrote:
On 08/22/2010 11:03 PM, Anthony Liguori wrote:
On 08/22/2010 02:44 PM, Avi Kivity wrote:
No more MI diamond and all devices have DeviceStates.
Coincidentally, it matches more closely
On Sun, Aug 22, 2010 at 04:54:06PM -0500, Anthony Liguori wrote:
On 08/19/2010 07:48 PM, Amit Shah wrote:
If the machine is stopped and 'info balloon' is invoked, the monitor
process just hangs waiting for info from the guest. Return the most
recent balloon data in that case.
See
On 08/23/2010 12:09 PM, Jan Kiszka wrote:
Okay, okay. But then there's a need explicitly not to instantiate it
when modelling a 486 or lower.
...plus the need to instantiate it (as a dedicated device) when modeling
486 SMP.
In short, if we want our model to be perfect, we have to fix
How did you trigger the bug?
I suppose parse_pci_devfn() in qdev-properties should check the error.
Although I'm not objecting this patch itself, it's caller's bug.
Just assert(devfn PCIBUS_MAX_DEVICES)?
On Mon, Aug 23, 2010 at 01:56:31PM +0800, Ken CC wrote:
Check before trying subindexing.
Hi all,
this is the second version of the patch series that adds xen device
model support in qemu.
This is the list of changes we made on top of the last version:
- we modified the first patch to add support to the new libxc interface
without removing support for the old one;
- we converted the
From: Anthony PERARD anthony.per...@citrix.com
Update the libxenctrl calls in Qemu to use the new interface, otherwise
Qemu wouldn't be able to build against new versions of the library.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com
This patch adds a new Xen device model target to Qemu, called
target-xen.
The new target makes use of the previously introduced xen_machine_fv.
In order to have a fully working Xen device model we still need
functionalities introduced by the
From: Anthony PERARD anthony.per...@citrix.com
Introduce a new emulated PCI device, specific to fully virtualized Xen
guests. The device is necessary for PV on HVM drivers to work.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com
Add the Xen FV (Fully Virtualized) machine to Qemu;
this is groundwork to add Xen device model support in Qemu.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
From: Anthony PERARD anthony.per...@citrix.com
Introduce a xen_dm_init function that opens the xenctrl interface; call
xen_dm_init from xen_machine_fv.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
Makefile.target
From: Anthony PERARD anthony.per...@citrix.com
This options will check if the target is build with Xen support.
---
Makefile.target |3 +++
hw/xen.h|8
qemu-options.hx |9 +
vl.c| 11 +++
4 files changed, 31 insertions(+), 0 deletions(-)
From: Anthony PERARD anthony.per...@citrix.com
Introduce a 8259 Interrupt Controller for target-xen; every set_irq
call makes a Xen hypercall.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
Makefile.target
From: Anthony PERARD anthony.per...@citrix.com
Add an handler to process xenstore events.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
target-xen/xenstore.c | 30 +-
1 files changed,
From: Anthony PERARD anthony.per...@citrix.com
This patch introduces Xen specific call in piix_pci.
The specific part for Xen is in write_config, set_irq and get_pirq.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
From: Anthony PERARD anthony.per...@citrix.com
Introduce two functions qemu_shutdown_requested_get and
qemu_reset_requested_get to get the value of shutdown/reset_requested
without reset it.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com
Introduce functions to read and write the state of the VM in xenstore.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
hw/xen_machine_fv.c |9
From: Anthony PERARD anthony.per...@citrix.com
Open and bind event channels; map ioreq and buffered ioreq rings.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
hw/xen_machine_fv.c | 21 +++
target-xen/cpu.h
From: Anthony PERARD anthony.per...@citrix.com
Handle shutdown and reset requests in helper.c.
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
---
target-xen/helper.c | 15 +++
1 files changed, 15
From: Anthony PERARD anthony.per...@citrix.com
Introduce a mapcache to handle the 64bit address space of the guest
from a 32bit userland process (Qemu).
The mapcache maps chucks of guest memory on demand, unmaps them when
they are not needed anymore.
Signed-off-by: Anthony PERARD
On Sun, Aug 22, 2010 at 04:38:36PM -0500, Anthony Liguori wrote:
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
+linetoh_nop()
+{
+local name args
+name=$(get_name $1)
+args=$(get_args $1)
+
+# Define an empty function for the trace event
+catEOF
+static inline void
From: Anthony PERARD anthony.per...@citrix.com
Xen currently uses a different BIOS (hvmloader + rombios) therefore the
Qemu acpi_piix4 implementation wouldn't work correctly with Xen.
We plan on fixing this properly but at the moment we are just adding a
new Xen specific acpi_piix4
On Sun, Aug 22, 2010 at 04:41:44PM -0500, Anthony Liguori wrote:
ram_addr_t is not necessarily an unsigned long. It's actually a
uint64_t. Integer promotion should handle this in most cases but
having the definition in two different places worries me a bit.
I thought it is unsigned long:
** Changed in: qemu-kvm (Ubuntu Lucid)
Assignee: (unassigned) = Thierry Carrez (ttx)
--
KVM segmentation fault, using SCSI+writeback and linux 2.4 guest
https://bugs.launchpad.net/bugs/595438
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
On 08/23/2010 01:11 PM, Alexander Graf wrote:
On 23.08.2010, at 11:25, Avi Kivity wrote:
On 08/23/2010 12:09 PM, Jan Kiszka wrote:
Okay, okay. But then there's a need explicitly not to instantiate it
when modelling a 486 or lower.
...plus the need to instantiate it (as a dedicated device)
On 23.08.2010, at 11:25, Avi Kivity wrote:
On 08/23/2010 12:09 PM, Jan Kiszka wrote:
Okay, okay. But then there's a need explicitly not to instantiate it
when modelling a 486 or lower.
...plus the need to instantiate it (as a dedicated device) when modeling
486 SMP.
In short, if we
On 23.08.2010, at 12:15, Avi Kivity wrote:
On 08/23/2010 01:11 PM, Alexander Graf wrote:
On 23.08.2010, at 11:25, Avi Kivity wrote:
On 08/23/2010 12:09 PM, Jan Kiszka wrote:
Okay, okay. But then there's a need explicitly not to instantiate it
when modelling a 486 or lower.
...plus the
On Sun, Aug 22, 2010 at 04:47:17PM -0500, Anthony Liguori wrote:
Please add some information about the restrictions on types.
Clearly, you can't specify just any type in the trace file so what
set of types are allowed?
Sure, will fix in v2.
Stefan
On 08/23/2010 01:18 PM, Alexander Graf wrote:
I certainly don't, but others may.
However, the problem remains: every time real hardware doesn't fit our pretty
model we'll drop support for that hardware?
No, every time real hardware doesn't fit out pretty model and nobody really
cares, we
Any reason why this (and its sister patch) were never picked up?
jch
On 27/07/10 15:54, Stefano Stabellini wrote:
Any comments?
On Wed, 21 Jul 2010, Stefano Stabellini wrote:
From: John Haxbyjohn.ha...@oracle.com
Introduce a new 'connected' xendev op called when Connected.
Rename the
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/vmware_vga.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 12bff48..682f287 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -114,14 +114,12 @@ struct
Hi,
This patch series will put the new vgabios (patches posted to the list
last week) into use for stdvga and vmware_vga.
For obvious reasons it depends on the new vgabios binaries being
present, i.e. vgabios patches being committed to vgabios.git, subtree
being updated and vgabios binaries
Make stdvga provide the new vgabios binary (with pcibios support)
using the PCI option rom bar. Seabios will happily load it from
there. The new vga bios will also lookup the framebuffer address
in pci config space, so the magic bochs lfb @ 0xe000 is not
needed any more - zap it.
Without
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
Makefile |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index f95cc2f..867e038 100644
--- a/Makefile
+++ b/Makefile
@@ -154,8 +154,9 @@ ar de en-us fi fr-be hr it lv nl
Avi Kivity a...@redhat.com writes:
On 08/22/2010 07:40 PM, Jes Sorensen wrote:
I totally agree with Markus
that it seems like wasted effort to come up with new tools and having to
maintain them when there are good ones out there like the ones from the
Linux kernel.
scripts/Lindent is
On 08/23/2010 02:01 PM, Markus Armbruster wrote:
Avi Kivitya...@redhat.com writes:
On 08/22/2010 07:40 PM, Jes Sorensen wrote:
I totally agree with Markus
that it seems like wasted effort to come up with new tools and having to
maintain them when there are good ones out there like the
stefano.stabell...@eu.citrix.com wrote:
From: Anthony PERARD anthony.per...@citrix.com
Xen currently uses a different BIOS (hvmloader + rombios) therefore the
Qemu acpi_piix4 implementation wouldn't work correctly with Xen.
We plan on fixing this properly but at the moment we are just adding
stefano.stabell...@eu.citrix.com wrote:
From: Anthony PERARD anthony.per...@citrix.com
This patch adds a new Xen device model target to Qemu, called
target-xen.
The new target makes use of the previously introduced xen_machine_fv.
In order to have a fully working Xen device model we still
On 08/20/2010 12:00 PM, Markus Armbruster wrote:
Alex Williamsonalex.william...@redhat.com writes:
Several devices rely on their reset() function being called to
initialize device state, e1000 and rtl8139 in particular. When
the device is hot added, the reset doesn't occur, often leaving
On 08/23/2010 07:00 AM, Avi Kivity wrote:
Off-topic, but what's the reason for dev-hotplugged's existence? A
device is either plugged or not, it is either hotpluggable or not, but
is there a way to tell, from looking at a plugged device, whether it
has been hotplugged in the past?
AFAICT it
On 08/23/2010 05:21 AM, John Haxby wrote:
Any reason why this (and its sister patch) were never picked up?
jch
It was likely missed originally because there wasn't a [PATCH] in the
subject. Can you resubmit? It's not obvious to me what it's sister
patch is so I'd suggest resubmitting
On Mon, 23 Aug 2010, Juan Quintela wrote:
+register_savevm(NULL, gpe, 0, 1, gpe_save, gpe_load, s);
Please port this to VMSTATE.
If possible (i.e. not problems with backwards compatibility), something like:
+for ( i = 0; i ACPI_GPE0_BLK_LEN / 2; i++ ) {
+
On 08/23/2010 05:10 AM, Stefan Hajnoczi wrote:
On Sun, Aug 22, 2010 at 04:41:44PM -0500, Anthony Liguori wrote:
ram_addr_t is not necessarily an unsigned long. It's actually a
uint64_t. Integer promotion should handle this in most cases but
having the definition in two different places
On 08/23/2010 12:46 AM, Avi Kivity wrote:
On 08/23/2010 12:02 AM, Anthony Liguori wrote:
On 08/22/2010 03:28 PM, Avi Kivity wrote:
On 08/20/2010 09:38 PM, Anthony Liguori wrote:
While that might be useful, I don't quite see what makes CPUs so
special
that they need to be kept out of qdev.
On 08/23/2010 06:25 AM, Paolo Bonzini wrote:
On 08/20/2010 08:12 PM, Anthony Liguori wrote:
+/* Returns false to terminate walk; true to continue */
+typedef int (qdev_walkerfn)(DeviceState *dev, void *opaque);
+
Since you're introducing qbus_walk_children, I suggest a different
interface:
On 08/23/2010 04:23 PM, Anthony Liguori wrote:
This is really a fundamental discussion. If you look closely at
qdev in it's current form, what it actually models is a device with
GPIO input and output whereas the GPIO input and output correspond
to qemu_irqs which really model pins that can
On 08/23/2010 08:42 AM, Avi Kivity wrote:
GPIO is just one way for a device to talk, same as
(*bus)_phys_memory_rw() or its netdev or its chardev or its timers.
It doesn't need to have special status within DeviceState, but it
doesn't hurt so much that I can tell.
Everything extra hurts
On 08/22/10 20:42, Anthony Liguori wrote:
On 08/22/2010 01:36 PM, malc wrote:
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYLE that is widely appreciated and
so all bikeshedding will cease? Enforce current style?
I would suggest
On 08/22/10 22:39, Avi Kivity wrote:
On 08/22/2010 10:44 PM, malc wrote:
There is the problem that some patch submitters are reminded of
CODING_STYLE while others aren't. Some don't need to be reminded but
they are not part of the problem.
And to this i fully subscribe.
I agree.
From
On 08/23/2010 04:48 PM, Anthony Liguori wrote:
The fundamental issue is: every function (minus trivial ones) in the
device models code should have a state reference. That state
reference should inherit from a DeviceState. If this statement
isn't true, then the device has been modelled in
On 08/23/2010 04:55 PM, Jes Sorensen wrote:
Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats in CODING_STYLE, even if it means that what you
apply is completely different to
On 08/23/10 16:03, Avi Kivity wrote:
On 08/23/2010 04:55 PM, Jes Sorensen wrote:
Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats in CODING_STYLE, even if it means that what
On 08/23/2010 05:07 PM, Jes Sorensen wrote:
On 08/23/10 16:03, Avi Kivity wrote:
On 08/23/2010 04:55 PM, Jes Sorensen wrote:
Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats
Jes Sorensen wrote:
On 08/22/10 20:39, malc wrote:
Disregarding my own stance on the braces, braces around single statement
is actually helpful w.r.t. debugging imaging trying to set a break point
on said singlesttement, plain impossible in following case:
if (a) b;
Oh there is
Jes Sorensen wrote:
On 08/22/10 20:35, malc wrote:
On Sun, 22 Aug 2010, Blue Swirl wrote:
What's the ultimate editor? I'd love to drop Emacs, which is annoying
but does its job better than the others that I've tried.
ed
ed is for sissies, real developers use cat, echo, and sed.
On 08/23/2010 09:00 AM, Avi Kivity wrote:
On 08/23/2010 04:48 PM, Anthony Liguori wrote:
The fundamental issue is: every function (minus trivial ones) in
the device models code should have a state reference. That state
reference should inherit from a DeviceState. If this statement
isn't
Am 22.08.2010 00:47, schrieb Loïc Minier:
Signed-off-by: Loïc Minier loic.min...@linaro.org
Thanks, applied to the block patch.
How did you find this one? From a quick look it seems that the pattern
that name is intentionally overflowed to access extension is still there
in some places. So if
On 08/23/2010 09:32 AM, Avi Kivity wrote:
Is bad? The answer would depend on whether OtherState implemented
methods or not. If OtherState has no methods, it's fine. If it has
methods, it's bad.
I don't see why. As long as you can manipulate all of MyDevice's
state via MyDeviceState
On 08/23/2010 05:26 PM, Anthony Liguori wrote:
On 08/23/2010 09:00 AM, Avi Kivity wrote:
On 08/23/2010 04:48 PM, Anthony Liguori wrote:
The fundamental issue is: every function (minus trivial ones) in
the device models code should have a state reference. That state
reference should inherit
On Mon, Aug 23, 2010, Kevin Wolf wrote:
How did you find this one? From a quick look it seems that the pattern
that name is intentionally overflowed to access extension is still there
in some places. So if this caused some real bug, I think we'll have to
fix the other ones, too.
Compiler
You lost me. A few messages upthread.
What's the *practical* problem again?
On 08/23/2010 05:47 PM, Anthony Liguori wrote:
Devices can contain references to structs and objects. If a Device
contains a reference to an object, the object should be stored in a
BusState which is a container of Devices. Therefore, the object
should inherit from Device.
I disagree.
I tried this
On 08/23/2010 10:14 AM, Avi Kivity wrote:
On 08/23/2010 05:47 PM, Anthony Liguori wrote:
Devices can contain references to structs and objects. If a Device
contains a reference to an object, the object should be stored in a
BusState which is a container of Devices. Therefore, the object
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug.
I believe the right short term way to fix this is to take the local APIC
off of
On Mon, Aug 23, 2010 at 12:49 AM, Avi Kivity a...@redhat.com wrote:
On 08/23/2010 09:45 AM, Paolo Bonzini wrote:
On 08/17/2010 01:29 PM, Avi Kivity wrote:
On 08/12/2010 06:29 PM, Paolo Bonzini wrote:
Nothing earth shattering. :)
Paolo Bonzini (3):
move kvm_set_irqfd to kvm-stub.c
This
Anthony Liguori anth...@codemonkey.ws writes:
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug.
I believe the right short term way
On 08/23/2010 12:36 PM, Markus Armbruster wrote:
Anthony Liguorianth...@codemonkey.ws writes:
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus
You're host kernel is 64-bit? Please show the full command line you use
to launch qemu.
--
qemu not able to run 64 bit OS when -enable-kvm is used with a 64 bit processor
https://bugs.launchpad.net/bugs/621950
You received this bug notification because you are a member of qemu-
devel-ml, which
Anthony Liguori wrote:
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug.
I believe the right short term way to fix this is to take
On 08/23/2010 01:24 PM, Jan Kiszka wrote:
Anthony Liguori wrote:
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug.
I
What does
file `which qemu-system-x86_64`
say?
--
qemu not able to run 64 bit OS when -enable-kvm is used with a 64 bit processor
https://bugs.launchpad.net/bugs/621950
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU:
Hey guys,
this patch set adds support for hotplug add on S390. Apparently it's the first
non-x86 platform receiving so much love in Qemu, so I've stumbled over some
very basic #if defined(TARGET_I386) cases that just shouldn't be there.
I'm open for suggestions, comments, improvements, etc. on
While booting a recent guest, I realized that we're know spawning 2x 64 vrings.
Each vring occupies 3 * PAGE_SIZE size and we only reserved 256 * PAGE_SIZE
bytes where some additional meta info also has to fit in.
This is obviously too little. So let's increase the amount of reserved pages
to a
The monitor command for hotplugging is in i386 specific code. This is just
plain wrong, as S390 just learned how to do hotplugging too and needs to
get drives for that.
So let's add a generic copy to generic code that handles drive_add in a
way that doesn't have pci dependencies.
I'm not fully
I just submitted a few patches that enable the s390 virtio bus to receive
a hotplug add event. This patch implements the qemu side of it, so that new
hotplug events can be submitted to the guest.
Signed-off-by: Alexander Graf ag...@suse.de
---
hw/s390-virtio-bus.c |9 +
All guest targets could potentially implement hotplugging. With the next
patches in this set I will also reflect this in the monitor interface.
So let's always compile it in. It shouldn't hurt.
Signed-off-by: Alexander Graf ag...@suse.de
---
Makefile.target |5 -
1 files changed, 4
All architectures can now use drive_add on the monitor. This of course
does not mean that there is hotplug support for the specific platform,
so in order to actually make use of the new drives you still need to
have a hotplug capable device.
Signed-off-by: Alexander Graf ag...@suse.de
---
On 08/23/2010 05:02 PM, Alexander Graf wrote:
The monitor command for hotplugging is in i386 specific code. This is just
plain wrong, as S390 just learned how to do hotplugging too and needs to
get drives for that.
So let's add a generic copy to generic code that handles drive_add in a
way that
On 24.08.2010, at 00:21, Anthony Liguori wrote:
On 08/23/2010 05:02 PM, Alexander Graf wrote:
The monitor command for hotplugging is in i386 specific code. This is just
plain wrong, as S390 just learned how to do hotplugging too and needs to
get drives for that.
So let's add a generic
Please send in any agenda items you are interested in covering.
thanks,
-chris
On 24.08.2010, at 00:23, Alexander Graf wrote:
On 24.08.2010, at 00:21, Anthony Liguori wrote:
On 08/23/2010 05:02 PM, Alexander Graf wrote:
The monitor command for hotplugging is in i386 specific code. This is just
plain wrong, as S390 just learned how to do hotplugging too and needs to
On 08/23/2010 05:45 PM, Alexander Graf wrote:
Device_add already works with this set and only required minor changes the s390
specific code. So that part was pretty slick :). The part that didn't work was
the drive_add one.
What is blockdev_add supposed to be? drive_add without IF_SCSI?
On 24.08.2010, at 00:50, Anthony Liguori wrote:
On 08/23/2010 05:45 PM, Alexander Graf wrote:
Device_add already works with this set and only required minor changes the
s390 specific code. So that part was pretty slick :). The part that didn't
work was the drive_add one.
What is
This patch allows to connect Qemu using NBD protocol to an nbd-server
using named exports.
For instance, if on the host isoserver, in /etc/nbd-server/config, you have:
[generic]
[debian-500-ppc-netinst]
exportname = /ISO/debian-500-powerpc-netinst.iso
[Fedora-10-ppc-netinst]
On Mon, Aug 23, 2010 at 06:56:56PM +0900, Isaku Yamahata wrote:
How did you trigger the bug?
I suppose parse_pci_devfn() in qdev-properties should check the error.
Although I'm not objecting this patch itself, it's caller's bug.
Just assert(devfn PCIBUS_MAX_DEVICES)?
assign pci addr 30,
1 - 100 of 104 matches
Mail list logo
