A new fsdev parameter "readonly" is introduced to control accessing 9p export.
readonly=on|off can be used to specify the access type. By default rw access
is given to 9p export.
Signed-off-by: M. Mohan Kumar
---
Changes from previous version:
* Use "readonly" option instead of "access"
* Change
On 05/23/2011 09:38 PM, Blue Swirl wrote:
While touching the code, please add braces.
Done. However, both changes you requested touch several patches, so I
cannot just send follow-ups for the two you replied to. Is it ok to
just send a pull request for v5?
Paolo
Am 23.05.2011 18:01, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 23.05.2011 12:00, schrieb Stefan Hajnoczi:
>>> On Mon, May 23, 2011 at 8:04 AM, Supriya Kannery
>>> wrote:
On 05/20/2011 01:50 PM, Stefan Hajnoczi wrote:
>
> On Thu, May 19, 2011 at 10:38:03PM +0530, Supri
Kevin Wolf writes:
> Am 23.05.2011 18:01, schrieb Markus Armbruster:
>> Kevin Wolf writes:
>>
>>> Am 23.05.2011 12:00, schrieb Stefan Hajnoczi:
On Mon, May 23, 2011 at 8:04 AM, Supriya Kannery
wrote:
> On 05/20/2011 01:50 PM, Stefan Hajnoczi wrote:
>>
>> On Thu, May 19,
On Mon, May 23, 2011 at 11:49 PM, Jamie Lokier wrote:
> Markus Armbruster wrote:
>> Anthony Liguori writes:
>>
>> > On 05/23/2011 05:30 AM, Daniel P. Berrange wrote:
>> >> It feels to me that turning the current block driver code which just does
>> >> open(2) on files, into something which issues
On 05/23/11 16:11, Kevin Wolf wrote:
Am 23.05.2011 14:34, schrieb Christoph Egger:
if given a block device, use the character device instead.
From: Manuel Bouyer
Signed-off-by: Christoph Egger
A useful commit message would explain why you're doing that.
How about this:
On NetBSD, the PV b
On Tue, May 24, 2011 at 8:16 AM, M. Mohan Kumar wrote:
> @@ -192,6 +196,9 @@ QemuOptsList qemu_virtfs_opts = {
> }, {
> .name = "security_model",
> .type = QEMU_OPT_STRING,
> + }, {
> + .name = "readonly",
> + .type = QEMU_OPT_STRING,
S
Hi there,
I'm having a problem with 9p virtfs mounts going away when I savevm,
quit, then restart with -loadvm. The mount seems to cause the guest
kernel to hang if I interact with it in any way that causes a stat(2).
I'm also unable to mount a 9p filesystem after a snapshot restart.
Is this expe
Am 24.05.2011 10:36, schrieb Christoph Egger:
> On 05/23/11 16:11, Kevin Wolf wrote:
>> Am 23.05.2011 14:34, schrieb Christoph Egger:
>>>
>>> if given a block device, use the character device instead.
>>>
>>> From: Manuel Bouyer
>>> Signed-off-by: Christoph Egger
>>
>> A useful commit message would
On 05/24/11 11:10, Kevin Wolf wrote:
Am 24.05.2011 10:36, schrieb Christoph Egger:
On 05/23/11 16:11, Kevin Wolf wrote:
Am 23.05.2011 14:34, schrieb Christoph Egger:
if given a block device, use the character device instead.
From: Manuel Bouyer
Signed-off-by: Christoph Egger
A useful commi
On NetBSD a userland process is better with the character device
interface. In addition, a block device can't be opened twice; if a Xen
backend opens it, qemu can't and vice-versa.
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 6b72470..64dceb1 100644
--- a/block/raw-posix.c
+++ b/bloc
>> - cycles fed into advance_ccount may (and on real hardware actually
>> do) depend on executed commands/pipeline/cache hits. Most of this
>> stuff may be counted at the translation time;
>
> Since CCOUNT, as seen by any one thread of execution, on real hw depends
> on cache hits, interrupts, and
On Mon, May 9, 2011 at 4:51 PM, Kevin Wolf wrote:
> I hope the intentions of each change are clear, but feel free to ask if they
> aren't. Also when I wasn't if/how exactly to specify things, I left a TODO in
> some places.
Here is what I've picked up on and a summary for lazy readers who
don't w
Am 24.05.2011 12:41, schrieb Stefan Hajnoczi:
> 3. Zero clusters
>
> Cluster descriptor bit 0 can mark clusters as zero. This prevents
> access to the backing file and instead reads zeroes.
>
> This is not really compatible with sub-clusters because it works at
> cluster granularity?
Right, tha
On Mon, 23 May 2011, Aurelien Jarno wrote:
>
> Thanks for this patch series. Your approach to solve this issue is
> really different than mine. Instead I added more state to the dead/live
> states, and use them to mark some input deads even for global, and mark
> some output arguments to be syn
On Sun, May 22, 2011 at 02:02:39PM +0200, Stefan Weil wrote:
> Thanks to Tobias Hoffmann for this patch.
>
> Signed-off-by: Stefan Weil
> ---
> hw/pflash_cfi02.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial-patches tree:
http://repo.or.cz/w/qemu/
On Sun, May 22, 2011 at 02:02:40PM +0200, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> tcg/tcg.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial-patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
This series fixes some problems with spapr's qdev interface. Patch
1 is the important one, which makes it possible to use -device
to create vio devices. The other two are cosmetic.
Paolo Bonzini (3):
spapr: allow creating devices with -device
spapr: prepare for qdevification of irq
spapr:
Restructure common properties for sPAPR devices so that IRQ definitions
can be added in one place.
Signed-off-by: Paolo Bonzini
Cc: Alexander Graf
Cc: David Gibson
---
hw/spapr_llan.c |4 +---
hw/spapr_vio.h |5 +
hw/spapr_vscsi.c |4 +---
hw/spapr_vty.c |2 +-
4 files
Right now the spapr devices cannot be instantiated with -device,
because the IRQs need to be passed to the spapr_*_create functions.
Do this instead in the bus's init wrapper.
This is particularly important with the conversion from scsi-disk
to scsi-{cd,hd} that Markus made. After his patches, if
Signed-off-by: Paolo Bonzini
Cc: Alexander Graf
Cc: David Gibson
---
hw/spapr_vio.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
index be535d6..fee4c46 100644
--- a/hw/spapr_vio.c
+++ b/hw/spapr_vio.c
@@ -52,6 +52,10 @@
static
Hi John,
a general remark first: KVM related patches usually flow via uq/master
of the qemu-kvm.git. Maintainers are Avi and Marcelo, so you need to
address them and include the kvm mailing list.
On 2011-05-23 23:46, john cooper wrote:
> Allow an optional qemu_early_init_vcpu() such that
> kvm_ar
Starting with this patch, the series lacks proper subjects. Please also
avoid such long subject lines. The background can be explained in the
introduction mail (threading your mails would be nice as well, check git
format-patch). Rather us short tags for the patches, describing the
subsystem/target
A new fsdev parameter "readonly" is introduced to control accessing 9p export.
readonly=on|off can be used to specify the access type. By default rw access
is given to 9p export.
Signed-off-by: M. Mohan Kumar
---
Change from previous version V2:
* QEMU_OPT_BOOL is used for readdonly parameter
Ch
On Mon, May 23, 2011 at 05:47:19PM -0400, john cooper wrote:
> This patch was intended to address the replicated feature
> flags in cpuid 8000_0001:edx from cpuid _0001:edx.
> This is due to AMD's definition where these flags are
> mostly cloned in the 8000_0001:edx cpuid function.
> qemu64 att
On Tue, May 24, 2011 at 1:21 PM, M. Mohan Kumar wrote:
> A new fsdev parameter "readonly" is introduced to control accessing 9p export.
> readonly=on|off can be used to specify the access type. By default rw access
> is given to 9p export.
>
> Signed-off-by: M. Mohan Kumar
> ---
> Change from pre
On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote:
> This aligns the code to what the documentation claims: Allow everything
> but requests that would have to be routed outside of the virtual LAN.
>
> So we need to drop the unneeded IP-level filter, allow TFTP requests,
> and add the miss
On Tue, May 24, 2011 at 03:31:11PM +0400, Kirill Batuzov wrote:
>
>
> On Mon, 23 May 2011, Aurelien Jarno wrote:
>
> >
> > Thanks for this patch series. Your approach to solve this issue is
> > really different than mine. Instead I added more state to the dead/live
> > states, and use them to m
On 2011-05-24 14:37, Gleb Natapov wrote:
> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote:
>> This aligns the code to what the documentation claims: Allow everything
>> but requests that would have to be routed outside of the virtual LAN.
>>
>> So we need to drop the unneeded IP-level f
@Serge,
I am getting error when build in PPA :-
make[2]: Entering directory `/build/buildd/spice-gtk-0.6/po'
cd .. \
&& CONFIG_FILES=po/Makefile.in CONFIG_HEADERS= CONFIG_LINKS= \
/bin/bash ./config.status
config.status: creating po/Makefile.in
./config.status: line 1509:
On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote:
> On 2011-05-24 14:37, Gleb Natapov wrote:
> > On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote:
> >> This aligns the code to what the documentation claims: Allow everything
> >> but requests that would have to be routed outside
Am 20.05.2011 19:43, schrieb Paolo Bonzini:
> On 05/20/2011 06:04 PM, Christoph Hellwig wrote:
>>> -void scsi_req_enqueue(SCSIRequest *req)
>>> +int32_t scsi_req_enqueue(SCSIRequest *req, uint8_t *buf)
>>> {
>>> +int32_t rc;
>>> assert(!req->enqueued);
>>> scsi_req_ref(req);
>>>
Paolo Bonzini writes:
> Right now the spapr devices cannot be instantiated with -device,
> because the IRQs need to be passed to the spapr_*_create functions.
> Do this instead in the bus's init wrapper.
>
> This is particularly important with the conversion from scsi-disk
> to scsi-{cd,hd} that
Paolo Bonzini writes:
> This series fixes some problems with spapr's qdev interface. Patch
> 1 is the important one, which makes it possible to use -device
> to create vio devices. The other two are cosmetic.
Looks good to spapr-ignorant me.
Juan Quintela wrote:
> Please send in any agenda items you are interested in covering.
As there have been any items for the agenda, call gets cancelled.
Have a nice week, Juan.
On 05/24/2011 03:03 PM, Markus Armbruster wrote:
> This is particularly important with the conversion from scsi-disk
> to scsi-{cd,hd} that Markus made. After his patches, if you
> specify a scsi-cd device attached to an if=none drive, the default
> VSCSI controller will not be created and,
On 05/24/2011 03:05 PM, Kevin Wolf wrote:
Maybe the callback should be done from a BH then? It sounds like this
could cause more bugs than what you're fixing here.
Not sure, after all it makes sense to answer some queries synchronously
(e.g. TEST_UNIT_READY). It's just the convoluted control
On Tue, May 24, 2011 at 1:31 PM, Kirill Batuzov wrote:
[...]
> Gathered statistics shows some interesting things too. I've run matrix
> multiplication benchmark (guest - ARM, host - x86, linux-user mode, with
> my patches applied) and here are the results:
>
> spill count 3916
> real spil
On Tue, 24 May 2011, Laurent Desnogues wrote:
> On Tue, May 24, 2011 at 1:31 PM, Kirill Batuzov wrote:
> [...]
> > Gathered statistics shows some interesting things too. I've run matrix
> > multiplication benchmark (guest - ARM, host - x86, linux-user mode, with
> > my patches applied) and here
On 2011-05-24 15:01, Gleb Natapov wrote:
> On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote:
>> On 2011-05-24 14:37, Gleb Natapov wrote:
>>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote:
This aligns the code to what the documentation claims: Allow everything
but re
Paolo Bonzini writes:
> On 05/24/2011 03:03 PM, Markus Armbruster wrote:
>> > This is particularly important with the conversion from scsi-disk
>> > to scsi-{cd,hd} that Markus made. After his patches, if you
>> > specify a scsi-cd device attached to an if=none drive, the default
>> > VSCSI
From: Anthony PERARD
Hi,
This two patches provides the support for sync dirty bitmap, especially useful
for the VGA output. The sync dirty bitmap is not provided for Xen 3.3.
Change v2 -> v3:
* use the new log_dirty parameter of set_memory clients.
* fix some mistakes related to the use of
From: Anthony PERARD
This function will be used to support sync dirty bitmap.
This come with a check against every Xen release, and special
implementation for Xen version that doesn't have this specific call.
This function will not be usable with Xen 3.3 because the behavior is
different.
Sign
From: Anthony PERARD
This patch introduces phys memory client for Xen.
Only sync dirty_bitmap and set_memory are actually implemented.
migration_log will stay empty for the moment.
Xen can only log one range for bit change, so only the range in the
first call will be synced.
Signed-off-by: Ant
On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote:
> On 2011-05-24 15:01, Gleb Natapov wrote:
> > On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote:
> >> On 2011-05-24 14:37, Gleb Natapov wrote:
> >>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote:
> This aligns t
If qcow2_cache_put returns an error during cluster allocation and the
allocation fails, it must be removed from the list of in-flight allocations.
Otherwise we'd get a loop in the list when the ACB is used for the next
allocation.
Luckily, this qcow2_cache_put shouldn't fail anyway because the L2
Please move this thread to a wiki.ubuntu.com wiki page and a
private or different mailing list.
Since gawk is needed for the build, you need to add gawk to
the build-depends line in debian/control.
-serge
Quoting Boris Derzhavets (723...@bugs.launchpad.net):
> @Serge,
>
> I am getting error whe
On 05/23/2011 04:20 PM, Max Filippov wrote:
> I probably just don't get what you call 'out-of-line'. In fact
> do_unaligned_access will be called for every unaligned access, and
> alignment condition will be checked for every access. It just happens
> in other place. Does it have more chances to be
On 05/24/2011 03:28 AM, Max Filippov wrote:
>>> - cycles fed into advance_ccount may (and on real hardware actually
>>> do) depend on executed commands/pipeline/cache hits. Most of this
>>> stuff may be counted at the translation time;
>>
>> Since CCOUNT, as seen by any one thread of execution, on
Am 17.05.2011 18:04, schrieb Christoph Hellwig:
> Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache,
> but no writeback semantics. All existing callers are changed to also
> specify BDRV_O_CACHE_WB to give them writeback semantics.
>
> Signed-off-by: Christoph Hellwig
Thanks,
- cycles fed into advance_ccount may (and on real hardware actually
do) depend on executed commands/pipeline/cache hits. Most of this
stuff may be counted at the translation time;
>>>
>>> Since CCOUNT, as seen by any one thread of execution, on real hw depends
>>> on cache hits, inte
On 23 May 2011 22:42, Aurelien Jarno wrote:
> Now that target-i386 uses softfloat, floatx80 is always available and
> there is no need anymore to have code handling both float64 and floax80.
>
> Signed-off-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Stefan Hajnoczi wrote:
> On Mon, May 23, 2011 at 11:49 PM, Jamie Lokier wrote:
> > Being able to override the backing file path would be useful anyway.
> >
> > I've already had problems when moving established qcow2 files between
> > systems, that for historical reasons contain either an absolute
On 2011-05-24 16:37, Gleb Natapov wrote:
> On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote:
>> On 2011-05-24 15:01, Gleb Natapov wrote:
>>> On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote:
On 2011-05-24 14:37, Gleb Natapov wrote:
> On Mon, May 23, 2011 at 04:48:16PM +
Hi Gerd,
could you provide a single patch file for the new USB files against the
released qemu 0.14.0 or 0.14.1? I tried to create that file by assembling
the patch emails but no real success.
Feedback on the patch is guaranteed :-)
Thanks a lot!
Best regards,
Erik
On 23 May 2011 22:42, Aurelien Jarno wrote:
> This patch adds support for FPU exceptions. It keeps the exception in
> the softfloat status, and copy them back to env->fpus when needed by
> oring them. When loading a new value to env->fpus, it starts with a
> clean softfloat status.
>
> Signed-off-
On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote:
> From: Jan Kiszka
>
> -machine somehow suggests that it selects the machine, but it doesn't.
> Fix that before this command is set in stone.
>
> Actually, -machine should supersede -M and allow to introduce arbitrary
> per-machine options to
On 05/24/2011 04:31 AM, Kirill Batuzov wrote:
>
>
> On Mon, 23 May 2011, Aurelien Jarno wrote:
>
>>
>> Thanks for this patch series. Your approach to solve this issue is
>> really different than mine. Instead I added more state to the dead/live
>> states, and use them to mark some input deads ev
ccid_initfn() allocates CCIDBus dynamically, but there is no exit
callback to free it.
Fix by getting rid of the allocation.
Signed-off-by: Markus Armbruster
---
hw/usb-ccid.c | 28
1 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/hw/usb-ccid.c b/hw
Hi,
I'm trying to see if I can I do a derivative snapshot as a means of
versioning. I wish to do this vs dd or cp as it's much faster. I do not
intend to apply a snapshot back to an original volume.
So, let's say I have original_volume.img and I create a snapshot using the
b option: "qemu-img cr
On 2011-05-24 18:06, Ian Campbell wrote:
> On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote:
>> From: Jan Kiszka
>>
>> -machine somehow suggests that it selects the machine, but it doesn't.
>> Fix that before this command is set in stone.
>>
>> Actually, -machine should supersede -M and allow t
On Tue, May 24, 2011 at 06:09:10PM +0200, Markus Armbruster wrote:
> ccid_initfn() allocates CCIDBus dynamically, but there is no exit
> callback to free it.
>
> Fix by getting rid of the allocation.
>
> Signed-off-by: Markus Armbruster
Tested-by: Alon Levy
> ---
> hw/usb-ccid.c | 28 +
linux/kvm.h is not always available for compilation.
Neither linux/kvm.h nor kvm.h are needed, so remove both
which also fixes the build problem for non-linux hosts.
Cc: Alexander Graf
Signed-off-by: Stefan Weil
---
target-s390x/helper.c |5 -
1 files changed, 0 insertions(+), 5 deleti
On 24.05.2011, at 19:42, Stefan Weil wrote:
> linux/kvm.h is not always available for compilation.
>
> Neither linux/kvm.h nor kvm.h are needed, so remove both
> which also fixes the build problem for non-linux hosts.
>
> Cc: Alexander Graf
> Signed-off-by: Stefan Weil
Thanks :). Applied to
On 05/24/2011 03:54 AM, Alex Young wrote:
Hi there,
I'm having a problem with 9p virtfs mounts going away when I savevm,
quit, then restart with -loadvm. The mount seems to cause the guest
kernel to hang if I interact with it in any way that causes a stat(2).
I'm also unable to mount a 9p filesy
This patchset moves the complexity of the rbd format into librbd and
adds truncation support.
Changes since v3:
* trivially rebased
* updated copyright header
Changes since v2:
* return values are checked in rbd_aio_rw_vector
* bdrv_truncate added
Josh Durgin (4):
rbd: use the higher level
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]]
Each option is used to configure rados, and may be any Ceph option, or "conf".
The "conf" option specifies a Ceph configuration file to read.
This allows rbd volumes from more than one Ceph cluster to be used by
speci
Signed-off-by: Josh Durgin
---
block/rbd.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index c9f32e4..015ae8e 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -687,6 +687,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *b
If scheduling fails, the number of outstanding I/Os must be correct,
or there will be a hang when waiting for everything to be flushed.
Reported-by: Stefan Hajnoczi
Signed-off-by: Josh Durgin
---
block/rbd.c | 24
1 files changed, 20 insertions(+), 4 deletions(-)
dif
librbd stacks on top of librados to provide access
to rbd images.
Using librbd simplifies the qemu code, and allows
qemu to use new versions of the rbd format
with few (if any) changes.
Signed-off-by: Josh Durgin
Signed-off-by: Yehuda Sadeh
---
block/rbd.c | 790 +++-
On Tue, May 24, 2011 at 12:31 AM, Marcelo Tosatti wrote:
> Mirrored writes are used by live block copy.
>
> Signed-off-by: Marcelo Tosatti
>
> Index: qemu-block-copy/block/blkmirror.c
> ===
> --- /dev/null
> +++ qemu-block-copy/block
On Tue, May 24, 2011 at 12:31 AM, Marcelo Tosatti wrote:
> Support live image copy + switch. That is, copy an image backing
> a guest hard disk to a destination image (destination image must
> be created separately), and switch to this copy.
>
> Command syntax:
>
> block_copy device filename [-i]
Daniel P. Berrange wrote:
> On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote:
> > On 05/11/2011 03:05 PM, Anthony Liguori wrote:
> > >>
> > >>A very slow way, too (on Windows at least if you use qemu_cond...).
> > >
> > >That doesn't mean you can't do a fiber implementation for Windows
Should it be possible to use dynamically linked binaries under
sparc*-linux-user?
Under qemu-system-sparc the Debian 4.08r1 initrd works fine, but:
master$ sparc-linux-user/qemu-sparc -strace -L
../debian-4.08r1-initrd/ ../debian-4.08r1-initrd/bin/busybox
14004 uname(0x409ffbae) = 0
14004 brk(NULL
Stefan Hajnoczi wrote:
> On Thu, May 12, 2011 at 10:51 AM, Jan Kiszka wrote:
> > On 2011-05-11 12:15, Stefan Hajnoczi wrote:
> >> From: Kevin Wolf
> >>
> >> Asynchronous code is becoming very complex. At the same time
> >> synchronous code is growing because it is convenient to write.
> >> Somet
On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote:
> Daniel P. Berrange wrote:
> > On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote:
> > > On 05/11/2011 03:05 PM, Anthony Liguori wrote:
> > > >>
> > > >>A very slow way, too (on Windows at least if you use qemu_cond...).
> >
Stefan Hajnoczi wrote:
> My current plan is to try using sigaltstack(2) instead of
> makecontext()/swapcontext() as a hack since OpenBSD doesn't have
> makecontext()/swapcontext().
sigaltstack() is just a system call to tell the system about an
alternative signal stack - that you have allocated yo
Venkateswararao Jujjuri wrote:
> This model makes the code simple and also in one shot we can convert
> all v9fs_do_syscalls into asynchronous threads. But as Aneesh raised
> will there be any additional overhead for the additional jumps? We
> can quickly test it out too.
I'm not sure if this is
On 05/24/2011 02:58 PM, Stefan Hajnoczi wrote:
On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote:
Thanks, I read about that but didn't try to implement special cases
because I don't have relevant OSes here to test against.
My current plan is to try using sigaltstack(2) instead of
make
On 05/24/2011 02:58 PM, Stefan Hajnoczi wrote:
On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote:
Daniel P. Berrange wrote:
On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote:
On 05/11/2011 03:05 PM, Anthony Liguori wrote:
A very slow way, too (on Windows at least if yo
The vmdk code is sloppy when handling the header descriptor during
creation of an image. Fix all header accesses in the create path to
either store native endianness or convert it when appropriate.
Reported-by: Yury Tsarev
Signed-off-by: Alexander Graf
---
block/vmdk.c | 22 ++
AHCI provides two ways of reading/writing data:
1) NCQ
2) ATA commands with the LBA in the command FIS
In the second code path, we didn't handle any LBAs that were bigger than
16 bits, so whenever a guest that used high LBA numbers wanted to access
data, the LBA got truncated down to 16 bits, g
On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> Cc: Alexander Graf
> Cc: David Gibson
> ---
> hw/spapr_vio.c |8 +++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
> index be535d6..fee
On Tue, May 24, 2011 at 01:45:05PM +0200, Paolo Bonzini wrote:
> Right now the spapr devices cannot be instantiated with -device,
> because the IRQs need to be passed to the spapr_*_create functions.
> Do this instead in the bus's init wrapper.
>
> This is particularly important with the conversio
On 25.05.2011, at 00:46, Alexander Graf wrote:
> AHCI provides two ways of reading/writing data:
>
> 1) NCQ
> 2) ATA commands with the LBA in the command FIS
>
> In the second code path, we didn't handle any LBAs that were bigger than
> 16 bits, so whenever a guest that used high LBA numbers wa
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/es1370.c | 24 +++-
1 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/hw/es1370.c b/hw/es1370.c
index 40cb48c..1ed62b7 100644
--- a/hw/es1370.c
+++ b/hw/es1370.c
@@ -998,21 +998,9 @@ st
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ioh3420.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 95adf09..a6bfbb9 100644
--- a/hw/ioh3420.c
+++ b/hw/ioh3420.c
@@ -104,12 +104,8 @@ static int ioh34
vender id/device id... in configuration space are read-only registers
which are commonly defined for all pci devices.
So move those initialization into common place.
Signed-off-by: Isaku Yamahata
---
changes v1 -> v2:
- dropped prog_interface, header_type
- added assert() for header type = 1
---
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/e1000.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index f160bfc..96d84f9 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1164,12 +1164,8 @@ static int pci_e1000_in
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/vmware_vga.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 4656767..354c221 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1280,15 +128
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ide/via.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ide/via.c b/hw/ide/via.c
index 04f3290..3474c37 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -160,11 +160,7 @@ static int vt82
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/lsi53c895a.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index be4df58..6b9c904 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -2212,15 +221
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/dec_pci.c | 26 +++---
1 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/hw/dec_pci.c b/hw/dec_pci.c
index bf88f2a..a35f382 100644
--- a/hw/dec_pci.c
+++ b/hw/dec_pci.c
@@ -50,28 +50,16
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/intel-hda.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/intel-hda.c b/hw/intel-hda.c
index 5485745..0ce 100644
--- a/hw/intel-hda.c
+++ b/hw/intel-hda.c
@@ -1138,10 +1138,6 @@ sta
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ide/cmd646.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 5d5464a..56302b5 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -226,14 +226,8 @
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/sun4u.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/sun4u.c b/hw/sun4u.c
index 5eb38cf..d7dcaf0 100644
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -553,15 +553,11 @@ pci_ebus_init1(PCIDevice
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/piix4.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw/piix4.c b/hw/piix4.c
index 71f1f84..9590e7b 100644
--- a/hw/piix4.c
+++ b/hw/piix4.c
@@ -86,15 +86,8 @@ static const VMStateDescr
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/pcnet-pci.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c
index 9415a1e..216cf81 100644
--- a/hw/pcnet-pci.c
+++ b/hw/pcnet-pci.c
@@ -265,12 +265,8 @@ stati
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ide/piix.c | 32 ++--
1 files changed, 10 insertions(+), 22 deletions(-)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index c349644..84f72b0 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/piix.c
@@ -1
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/grackle_pci.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c
index d35701f..cee07e0 100644
--- a/hw/grackle_pci.c
+++ b/hw/grackle_pci.c
@@ -104,11 +104,
1 - 100 of 128 matches
Mail list logo
