Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/4] spapr: disable hotplugging without OS

2017-05-30 Thread David Gibson
On Tue, May 30, 2017 at 12:15:59PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-05-24 22:16:26) > > On Wed, May 24, 2017 at 12:40:37PM -0500, Michael Roth wrote: > > > Quoting Laurent Vivier (2017-05-24 11:02:30) > > > > On 24/05/2017 17:54, Greg Kurz wrote: > > > > > On Wed, 24 May 2017

Re: [Qemu-devel] [Qemu-ppc] [PULL 11/18] pseries: Split CAS PVR negotiation out into a separate function

2017-05-30 Thread David Gibson
On Mon, May 29, 2017 at 11:14:08PM +0200, Greg Kurz wrote: > On Thu, 25 May 2017 13:51:25 +1000 > David Gibson wrote: > > > Guests of the qemu machine type go through a feature negotiation process > > known as "client architecture support" (CAS) during early boot. This does > > a number of thing

[Qemu-devel] [PATCH v3] exec: fix address_space_get_iotlb_entry page mask

2017-05-30 Thread Peter Xu
The IOTLB that it returned didn't guarantee that page_mask is indeed a so-called page mask. That won't affect current usage since now only vhost is using it (vhost API allows arbitary IOTLB range). However we have IOTLB scemantic and we should best follow it. This patch fixes this issue to make sur

[Qemu-devel] [PATCH v2 2/6] tcg: move translate-all.c to tcg/ subdirectory

2017-05-30 Thread Yang Zhong
tcg: move translate-all.c to tcg/ subdirectory and also update related trace-events file. Signed-off-by: Yang Zhong --- Makefile.objs | 1 + Makefile.target| 3 ++- tcg/trace-events | 6 ++ translate-all.c => tcg/translat

[Qemu-devel] [PATCH v2 6/6] tcg: change tcg related file's compile definition

2017-05-30 Thread Yang Zhong
tcg: move tcg related compile definitions form Makefile.target to tcg/Makefile.objs Signed-off-by: Yang Zhong --- Makefile.target | 7 +-- tcg/Makefile.objs | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) create mode 100644 tcg/Makefile.objs diff --git a/Makefile.target b/Makefi

[Qemu-devel] [PATCH v2 5/6] tcg: move tci.c to tcg/ subdirectory

2017-05-30 Thread Yang Zhong
tcg: move tci.c to tcg/ subdirectory Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tci.c => tcg/tci.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tci.c => tcg/tci.c (100%) diff --git a/Makefile.target b/Makefile.target index 648e61e..8561132 100644 --- a/Makefile.targ

[Qemu-devel] [PATCH v2 4/6] tcg: move translate-common.c to tcg/ subdirectory

2017-05-30 Thread Yang Zhong
tcg: move translate-common.c to tcg/ subdirectory Signed-off-by: Yang Zhong --- Makefile.target | 2 +- translate-common.c => tcg/translate-common.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename translate-common.c => tcg/translate-common.c (100%) diff

[Qemu-devel] [PATCH v2 1/6] tcg: move tcg-runtime.c to tcg/ subdirectory

2017-05-30 Thread Yang Zhong
tcg: move tcg-runtime.c to tcg/ subdirectory Signed-off-by: Yang Zhong --- Makefile.target| 2 +- tcg-runtime.c => tcg/tcg-runtime.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tcg-runtime.c => tcg/tcg-runtime.c (100%) diff --git a/Makefile.target b/Makefile.

[Qemu-devel] [PATCH v2 3/6] tcg: move tcg header file

2017-05-30 Thread Yang Zhong
tcg: move translate-all.h to tcg/ subdirectory Signed-off-by: Yang Zhong --- translate-all.h => tcg/translate-all.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename translate-all.h => tcg/translate-all.h (100%) diff --git a/translate-all.h b/tcg/translate-all.h similarity index 100%

[Qemu-devel] [PATCH v2 0/6] tcg: move the tcg files into tcg/ subdirectory.

2017-05-30 Thread Yang Zhong
Move the tcg related files into tcg/ subdirectory, which will make the code more clean in qemu. Next step, we will base on those changes to disable tcg. Yang Zhong (6): tcg: move tcg-runtime.c to tcg/ subdirectory tcg: move translate-all.c to tcg/ subdirectory tcg: move tcg header file tc

Re: [Qemu-devel] [PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

2017-05-30 Thread Haozhong Zhang
On 05/30/17 10:16 +0100, Stefan Hajnoczi wrote: > On Fri, May 26, 2017 at 10:24:38AM +0800, Haozhong Zhang wrote: > > file_ram_alloc() currently maps the backend file via mmap to a virtual > > address aligned to the value returned by qemu_fd_getpagesize(). When a > > DAX device (e.g. /dev/dax0.0) i

Re: [Qemu-devel] [PATCH v2] exec: fix address_space_get_iotlb_entry page mask

2017-05-30 Thread Peter Xu
On Tue, May 30, 2017 at 06:23:14PM +0200, Paolo Bonzini wrote: > > > On 29/05/2017 06:02, Peter Xu wrote: > > The IOTLB that it returned didn't guarantee that page_mask is indeed a > > so-called page mask. That won't affect current usage since now only > > vhost is using it (vhost API allows arbi

[Qemu-devel] [PATCH] help: Add newline to end of thread option help text

2017-05-30 Thread Suraj Jitindar Singh
The help text for the thread sub option of the accel option is missing a newline at the end. This is annoying as it makes it hard to see the help text for the next option. Add the new line so that the following option help text (-smp) is displayed on a new line rather on the same line and directly

Re: [Qemu-devel] [PATCH 1/2] nvdimm: warn if the backend is not a DAX device

2017-05-30 Thread Haozhong Zhang
On 05/30/17 10:15 +0100, Stefan Hajnoczi wrote: > On Fri, May 26, 2017 at 10:24:37AM +0800, Haozhong Zhang wrote: > > Applications in Linux guest that use device-dax never trigger flush > > that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not > > device-dax, QEMU cannot guarantee

Re: [Qemu-devel] [Qemu devel v5 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-05-30 Thread Philippe Mathieu-Daudé
Hi Subbaraya, On 05/16/2017 12:38 PM, Subbaraya Sundeep wrote: Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep --- hw/arm/Makefile.objs | 1 + hw/arm/msf2-som.c| 89 2 files changed, 90 in

Re: [Qemu-devel] [Qemu devel v5 PATCH 4/5] msf2: Add Smartfusion2 SoC.

2017-05-30 Thread Philippe Mathieu-Daudé
Hi Subbaraya, So far so good! On 05/16/2017 12:38 PM, Subbaraya Sundeep wrote: Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep --- default-configs/arm-softm

Re: [Qemu-devel] [Qemu devel v5 PATCH 0/5] Add support for Smartfusion2 SoC

2017-05-30 Thread Philippe Mathieu-Daudé
Hi Sundeep, On 05/29/2017 02:28 AM, sundeep subbaraya wrote: Hi Philippe, Any update on this? I will wait for your comments too and send next iteration fixing Alistair comments. Sorry I'm supposed to be in holidays ;) Thanks, Sundeep On Wed, May 17, 2017 at 3:09 PM, sundeep subbaraya mail

Re: [Qemu-devel] [PATCH v2 5/6] cputlb: add trace events

2017-05-30 Thread Philippe Mathieu-Daudé
On 05/17/2017 11:52 AM, Alex Bennée wrote: Given the range of costs for various SoftMMU TLB operations from deferring work for the currently running vCPU to bring the whole emulated machine to a stop for synchronised updates simple counters are less useful. Instead we log events via the trace inf

Re: [Qemu-devel] [PATCH risu] ppc64.risu: Fix broken constraints

2017-05-30 Thread Nikunj A Dadhania
Peter Maydell writes: > Commit c10b97092 changed some field names in rldicr and rldimi patterns > but forgot to update the constraints to match the change. Since the > field (previously 'rb' and now 'sh') is an immediate rather than a > register number, the correct fix is to just delete the const

Re: [Qemu-devel] [PATCH risu v2] ppc64: Fix patterns for rotate doubleword instructions

2017-05-30 Thread Nikunj A Dadhania
Peter Maydell writes: > On 30 May 2017 at 16:39, Peter Maydell wrote: >> On 30 May 2017 at 16:26, Nikunj A Dadhania wrote: >>> Sandipan Das writes: >>> The patterns for the following instructions are fixed: * Rotate Left Doubleword then Clear Right (rldcr[.]) * Rotate Left Dou

Re: [Qemu-devel] [PATCH v2 1/6] scripts/replay-dump.py: replay log dumper

2017-05-30 Thread Philippe Mathieu-Daudé
On 05/17/2017 11:52 AM, Alex Bennée wrote: This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand. It currently understands two different log formats as the audio record/replay support was

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

2017-05-30 Thread David Gibson
On Tue, May 30, 2017 at 06:04:45PM +0200, Laurent Vivier wrote: > For QEMU, a hotlugged device is a device added using the HMP/QMP > interface. > For SPAPR, a hotplugged device is a device added while the > machine is running. In this case QEMU doesn't update internal > state but relies on the OS f

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

2017-05-30 Thread David Gibson
On Tue, May 30, 2017 at 10:01:36AM +0200, Greg Kurz wrote: > On Tue, 30 May 2017 16:18:52 +1000 > David Gibson wrote: > > > On Tue, May 30, 2017 at 01:14:16AM +0200, Greg Kurz wrote: > > > On Fri, 26 May 2017 15:23:14 +1000 > > > David Gibson wrote: > > > > > > [...] > > > > > > > > > > > >

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-30 Thread gengdongjiu
Laszlo, very sorry for that, it was my mistake that missing your name. when I reply mail, I copy the "CC" list to the mail reply list, but forget to copy the "To" list. I will check your comments in detailed later and reply you. thanks again. On 2017/5/30 0:03, Laszlo Ersek wrote: > Hi, > >

Re: [Qemu-devel] [PATCH] pci-bridge/i82801b11: Convert to realize

2017-05-30 Thread Mao Zhongyi
Hi, Marcel & Markus On 05/29/2017 07:37 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 27/05/2017 9:58, Mao Zhongyi wrote: On 05/26/2017 10:08 PM, Marcel Apfelbaum wrote: On 26/05/2017 15:15, Mao Zhongyi wrote: The pci-birdge device i82801b11 still implements the old PCIDevic

Re: [Qemu-devel] [PATCH v2 3/6] scripts/qemu-gdb/tcg: new helper to dump tcg state

2017-05-30 Thread Philippe Mathieu-Daudé
On 05/17/2017 11:52 AM, Alex Bennée wrote: This adds a simple helper to dump lock state within TCG. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- scripts/qemu-gdb.py| 3 ++- scripts/qemugdb/tcg.py | 46 ++ 2 files chang

Re: [Qemu-devel] [PATCH] pci: Set err to errp directly rather than through error_porpagate()

2017-05-30 Thread Mao Zhongyi
Hi, Markus On 05/29/2017 03:51 PM, Markus Armbruster wrote: Igor Mammedov writes: On Fri, 26 May 2017 16:29:25 +0800 Mao Zhongyi wrote: ioh3420_interrupts_init() and its callers, rp_realize() and pci_qdev_realize() fill error message to local_err, then propagate it to errp by error_porpaga

Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt-acpi-build: build SLIT when needed

2017-05-30 Thread Shannon Zhao
On 2017/5/30 1:37, Andrew Jones wrote: > Cc: Shannon Zhao > Signed-off-by: Andrew Jones Reviewed-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index e5852067f5bd..2079828c2

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: fdt: generate distance-map when needed

2017-05-30 Thread Shannon Zhao
On 2017/5/30 1:37, Andrew Jones wrote: > This is based on patch Shannon Zhao originally posted. > > Cc: Shannon Zhao > Signed-off-by: Andrew Jones Reviewed-by: Shannon Zhao > --- > hw/arm/virt.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/hw/arm/virt.c b

Re: [Qemu-devel] [PATCH v2 6/6] new script/analyse-tlb-flushes-simpletrace.py

2017-05-30 Thread Pranith Kumar
Hi Alex, Please find some comments and questions below: On Wed, May 17, 2017 at 10:52 AM, Alex Bennée wrote: > This is a simple helper script to extract TLB flush stats from the a > simpletrace file and plot the results. > > Signed-off-by: Alex Bennée > > --- > v2 > - re-factored for new trac

Re: [Qemu-devel] [Qemu devel v5 PATCH 4/5] msf2: Add Smartfusion2 SoC.

2017-05-30 Thread Alistair Francis
On Sun, May 28, 2017 at 10:17 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Sat, May 27, 2017 at 5:18 AM, Alistair Francis > wrote: >> >> On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep >> wrote: >> > Smartfusion2 SoC has hardened Microcontroller subsystem >> > and flash based FPGA fabri

Re: [Qemu-devel] [Qemu devel v5 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-05-30 Thread Alistair Francis
On Sun, May 28, 2017 at 10:26 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Sat, May 27, 2017 at 5:30 AM, Alistair Francis > wrote: >> >> On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep >> wrote: >> > Emulated Emcraft's Smartfusion2 System On Module starter >> > kit. >> > >> > Signed-off

Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > - do not goto into switch block from outer block This sentence didn't quite make sense. Better might be: - do not use 'goto error_reply' outside a switch to jump into the middle of the switch's default case label > - reduce code dupl

Re: [Qemu-devel] [PATCH 09/19] nbd/server: rename rc to ret

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > For consistency use 'ret' name for saving return code everywhere > in the file. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 d

Re: [Qemu-devel] [PATCH 08/19] nbd/server: get rid of fail: return rc

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > "goto fail" error handling scheme is not needed for just returning > error code. Better is return it immediately. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 28 > 1 file changed

Re: [Qemu-devel] [PATCH 06/19] nbd/server: remove NBDClientNewData

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > "co" field of NBDClientNewData is unused, so let's just use client > pointer instead of extra structure. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 25 +++-- > 1 file changed, 7 insertio

Re: [Qemu-devel] [PATCH 05/19] nbd/server: refactor nbd_co_receive_request

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Move function tail, about receiving next request out of the function. > Error path is simplified and nbd_co_receive_request becomes more > corresponding to its name. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c

Re: [Qemu-devel] [PATCH v3 10/16] block/qcow2: Lock s->lock in preallocate()

2017-05-30 Thread Eric Blake
On 05/26/2017 11:55 AM, Max Reitz wrote: > preallocate() is and will be called only from places that do not lock Maybe: "that do not otherwise need to lock" > s->lock: Currently that is qcow2_create2(), as of a future patch it will > be called from qcow2_truncate(), too. > > It therefore makes s

Re: [Qemu-devel] [PATCH v3 09/16] block/qcow2: Generalize preallocate()

2017-05-30 Thread Eric Blake
On 05/26/2017 11:55 AM, Max Reitz wrote: > This patch adds two new parameters to the preallocate() function so we > will be able to use it not just for preallocating a new image but also > for preallocated image growth. > > The offset parameter allows the caller to specify a virtual offset from >

[Qemu-devel] [RFC] q35/mch: implement extended TSEG sizes

2017-05-30 Thread Laszlo Ersek
The q35 machine type currently lets the guest firmware select a 1MB, 2MB or 8MB TSEG (basically, SMRAM) size. In edk2/OVMF, we use 8MB, but even that is not enough when a lot of VCPUs (more than approx. 224) are configured -- SMRAM footprint scales largely proportionally with VCPU count. Introduce

Re: [Qemu-devel] [PATCH v2 5/6] vhost-user: add slave-req-fd support

2017-05-30 Thread Maxime Coquelin
On 05/30/2017 08:17 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:57PM +0200, Maxime Coquelin wrote: From: Marc-André Lureau Learn to give a socket to the slave to let him make requests to the master. Signed-off-by: Marc-André Lureau Signed-off-by: Maxime Coquelin --- docs/sp

Re: [Qemu-devel] [PATCH 07/19] nbd/server: nbd_negotiate: fix error path

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Current code will return 0 on this write_sync fail, as rc is 0 > after successful nbd_negotiate_options. Fix this. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 3 ++- > 1 file changed, 2 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH v2 3/6] vhost: extend ring information update for IOTLB to all rings

2017-05-30 Thread Maxime Coquelin
On 05/30/2017 11:06 PM, Maxime Coquelin wrote: Hi Michael, On 05/30/2017 08:12 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:55PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need needs to receive IOTLB entry for used ring information early, which is done by triggerin

Re: [Qemu-devel] [PATCH v2 3/6] vhost: extend ring information update for IOTLB to all rings

2017-05-30 Thread Maxime Coquelin
Hi Michael, On 05/30/2017 08:12 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:55PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need needs to receive IOTLB entry for used ring information early, which is done by triggering a miss event on its address. This patch extends

Re: [Qemu-devel] [PATCH 04/19] nbd/server: get rid of EAGAIN dead code

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > For now read_sync never returns EAGAIN. So, don't handle it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > I had to go re-read your

Re: [Qemu-devel] [PATCH v3 04/16] qemu-img: Expose PreallocMode for resizing

2017-05-30 Thread Eric Blake
On 05/26/2017 11:55 AM, Max Reitz wrote: > Add a --preallocation command line option to qemu-img resize which can > be used to set the PreallocMode parameter of blk_truncate(). > > Signed-off-by: Max Reitz > --- > qemu-img.c| 33 ++--- > qemu-img.texi | 7 ++-

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

2017-05-30 Thread Eric Blake
On 05/30/2017 03:24 PM, Kashyap Chamarthy wrote: > First, thanks for the quick feedback! > > On Tue, May 30, 2017 at 02:24:40PM -0500, Eric Blake wrote: >> On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: >>> This edition documents all four operations: > >>> + >>> +(1) `Disk image backing chain

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

2017-05-30 Thread Kashyap Chamarthy
First, thanks for the quick feedback! On Tue, May 30, 2017 at 02:24:40PM -0500, Eric Blake wrote: > On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: > > This edition documents all four operations: [...] > s/occurance/occurrence/ > > > use raw JSON; for subsequent occurances, use 'qmp-shell'

Re: [Qemu-devel] [PATCH 03/19] nbd/server: refactor nbd_co_send_reply

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > As write_sync never returns value > 0, we can get rid of extra ret. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Er

Re: [Qemu-devel] [PATCH 02/19] nbd/server: get rid of ssize_t

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Now read_sync and friends return int, so get rid of ssize_t. In particular, it was your earlier commit "nbd: read_sync and friends: return 0 on success" that changed the semantics of the return value to just be 0 instead of a size; and

Re: [Qemu-devel] [PATCH v2 29/29] target/s390x: update maximum TCG model to z800

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: At the same time fix the TCG version of get_max_cpu_model to return the maximum model like on KVM. Remove the long-displacement facility from the additional features as it is included in the z800. Signed-off-by: Aurelien Jarno --- target/s390x/cpu_

Re: [Qemu-devel] [PATCH v2 24/29] target/s390x: implement PACK UNICODE

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 30 +

Re: [Qemu-devel] [PATCH v2 22/29] target/s390x: implement MOVE LONG UNICODE

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 47 -- target/s390x/translate.c | 21 + 4 fil

Re: [Qemu-devel] [PATCH v2 21/29] target/s390x: implement COMPARE LOGICAL LONG UNICODE

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 +

Re: [Qemu-devel] [PATCH v2 19/29] target/s390x: fix adj_len_to_page

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [Qemu-devel] [PATCH v2 20/29] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Signed-off-by: Aurelien Jarno --- target/s39

Re: [Qemu-devel] [PATCH v2 18/29] target/s390x: implement COMPARE LOGICAL LONG

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/

Re: [Qemu-devel] [PATCH v2 17/29] target/s390x: fix COMPARE LOGICAL LONG EXTENDED

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Functions nbd_negotiate_{read,write,drop_sync} were introduced in > 1a6245a5b, when nbd_wr_syncv was working through qemu_co_sendv_recvv, There is no qemu_co_sendv_recvv. Did you mean qemu_co_recv/qemu_co_send? > which just yields, wit

Re: [Qemu-devel] [PATCH v2 14/29] target/s390x: improve 24-bit and 31-bit addresses read

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function. Rename

Re: [Qemu-devel] [PATCH v2 09/29] target/s390x: implement COMPARE AND SIGNAL

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +DEF_HELPER_FLAGS_3(keb, TCG_CALL_NO_WG_SE, i32, env, i64, i64) +DEF_HELPER_FLAGS_3(kdb, TCG_CALL_NO_WG_SE, i32, env, i64, i64) +DEF_HELPER_FLAGS_5(kxb, TCG_CALL_NO_WG_SE, i32, env, i64, i64, i64, i64) They do have side effects -- recording the exce

Re: [Qemu-devel] [PATCH v2 08/29] target/s390x: implement STORE PAIR TO QUADWORD

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +TCGMemOpIdx oi = make_memop_idx(MO_TEQ, mem_idx); Similarly, alignment. r~

Re: [Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 06:24:02PM +0200, Igor Mammedov wrote: > Calculating default node-ids for CPUs in possible_cpu_arch_ids() > is rather fragile since defaults calculation uses nb_numa_nodes but > callback might be potentially called early before all -numa CLI > options are parsed, which would

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

2017-05-30 Thread Vlad Yasevich
On 05/30/2017 03:35 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> It is now potentially possible to issue annouce-self command in a tight >> loop. Instead of doing nother, we can reset the timeout pararameters, >> especially since each instance may provid

Re: [Qemu-devel] [PATCH v2 07/29] target/s390x: implement LOAD PAIR FROM QUADWORD

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +TCGMemOpIdx oi = make_memop_idx(MO_TEQ, mem_idx); MO_TEQ | MO_ALIGN_16 as it's a specification error for the address to be unaligned. r~

Re: [Qemu-devel] [PATCH v2 04/29] target/s390x: implement TEST AND SET

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 05/29] target/s390x: implement TEST ADDRESSING MODE

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

2017-05-30 Thread Aurelien Jarno
On 2017-05-30 12:42, Richard Henderson wrote: > On 05/30/2017 12:25 PM, Aurelien Jarno wrote: > > On 2017-05-30 09:45, Richard Henderson wrote: > > > On 05/29/2017 04:17 AM, Aurelien Jarno wrote: > > > > On 2017-05-26 10:10, Richard Henderson wrote: > > > > > On 05/25/2017 02:05 PM, Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 03/29] target/s390x: implement local-TLB-clearing in IPTE

2017-05-30 Thread Richard Henderson
On 05/29/2017 12:24 PM, Aurelien Jarno wrote: And at the same time make IPTE SMP aware. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 19 --- target/s390x/translate.c | 6 +- 3 files changed, 18 insertions(+), 9 deleti

Re: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 06:23:55PM +0200, Igor Mammedov wrote: > changelog since v2: > (Eduardo) > - keep original logic in when moving numa part into helper > numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr > - drop "numa: fallback to default NUMA node instead of n

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 6/7] spapr: cleanup spapr_fixup_cpu_numa_dt() usage

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 06:40:22PM +0200, Greg Kurz wrote: > On Tue, 30 May 2017 18:24:01 +0200 > Igor Mammedov wrote: > > > even though spapr_fixup_cpu_numa_dt() has no effect on FDT > > if numa is disabled, don't call it uselessly. It makes it > > obvious at call sites that function is need onl

Re: [Qemu-devel] [PATCH v3 5/7] numa: move numa_node from CPUState into target specific classes

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 11:30:27AM -0500, Eric Blake wrote: > On 05/30/2017 11:24 AM, Igor Mammedov wrote: > > Move vcpu's assocciated numa_node field out of generic CPUState > > s/assocciated/associated/ > > > into inherited classes that actually care about cpu<->numa mapping, > > i.e: ARMCPU, P

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

2017-05-30 Thread Richard Henderson
On 05/30/2017 12:25 PM, Aurelien Jarno wrote: On 2017-05-30 09:45, Richard Henderson wrote: On 05/29/2017 04:17 AM, Aurelien Jarno wrote: On 2017-05-26 10:10, Richard Henderson wrote: On 05/25/2017 02:05 PM, Aurelien Jarno wrote: +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

2017-05-30 Thread Dr. David Alan Gilbert
* Vladislav Yasevich (vyase...@redhat.com) wrote: > It is now potentially possible to issue annouce-self command in a tight > loop. Instead of doing nother, we can reset the timeout pararameters, > especially since each instance may provide it's own values. This > allows the user to extend or cu

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

2017-05-30 Thread Vlad Yasevich
On 05/30/2017 03:19 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> Switch qemu_announce_self and virtio annoucements to use >> the announcement timer framework. This makes sure that both >> timers use the same timeouts and number of annoucement attempts >>

Re: [Qemu-devel] [PATCH 07/12] migration: Allow for a limited number of announce timers

2017-05-30 Thread Dr. David Alan Gilbert
* Vladislav Yasevich (vyase...@redhat.com) wrote: > We currently create a new announcement timer every time > qemu_announce_self() is called. Since this is now a qmp > command, this can lead to abuse. Limit the number of > timers that are created. Give QMP interface and migration > process 1 ti

Re: [Qemu-devel] How do you -sd squashfs.img without truncating?

2017-05-30 Thread Rob Landley
On 05/30/2017 07:17 AM, Peter Maydell wrote: > On 8 May 2017 at 06:08, Rob Landley wrote: >> As far as I can tell "qemu-system-arm -M vexpress-a9" only implements sd >> card, not any conventional hard drive, and it uses an sdcard block size >> of 262144 bytes rounded down. This means when I create

Re: [Qemu-devel] [PATCH] linux-user: Fix TARGET_MAP* and TARGET_F_??LCK for hppa arch

2017-05-30 Thread Helge Deller
On 19.05.2017 15:59, Riku Voipio wrote: > On Sun, Mar 12, 2017 at 08:17:46AM +1000, Richard Henderson wrote: >> On 03/12/2017 03:50 AM, Helge Deller wrote: >>> TARGET_MAP_TYPE needs to be 0x03 instead of 0x0f on the hppa >>> architecture, otherwise it conflicts with MAP_FIXED which is 0x04. >>> >>>

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

2017-05-30 Thread Eric Blake
On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: > This edition documents all four operations: > > - `block-stream` > - `block-commit` > - `drive-mirror` (& `blockdev-mirror`) > - `drive-backup` (& `blockdev-backup`) > > Things considered while writing this document: > > - Use reStruct

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

2017-05-30 Thread Aurelien Jarno
On 2017-05-30 09:45, Richard Henderson wrote: > On 05/29/2017 04:17 AM, Aurelien Jarno wrote: > > On 2017-05-26 10:10, Richard Henderson wrote: > > > On 05/25/2017 02:05 PM, Aurelien Jarno wrote: > > > > +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2, > > > > +

[Qemu-devel] [PULL v2 3/5] target/sh4: introduce DELAY_SLOT_MASK

2017-05-30 Thread Aurelien Jarno
This will make easier the introduction of a new flag in the next patches. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/cpu.h | 3 ++- target/sh4/helper.c| 4 ++-- target/sh4/translate.c | 17 - 3 fil

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

2017-05-30 Thread Dr. David Alan Gilbert
* Vladislav Yasevich (vyase...@redhat.com) wrote: > Switch qemu_announce_self and virtio annoucements to use > the announcement timer framework. This makes sure that both > timers use the same timeouts and number of annoucement attempts > > Based on work by Dr. David Alan Gilbert > > Signed-off

[Qemu-devel] [PULL v2 5/5] target/sh4: fix RTE instruction delay slot

2017-05-30 Thread Aurelien Jarno
The ReTurn from Exception (RTE) instruction loads the system register (SR) with the saved system register (SSR). It has a delay slot, and behaves specially according to the SH4 manual: The SR value accessed by the instruction in the RTE delay slot is the value restored from SSR by the RTE inst

[Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches

2017-05-30 Thread Aurelien Jarno
The following changes since commit 0748b3526e8cb78b9cd64208426bfc3d54a72b04: Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-30 14:15:15 +0100) are available in the git repository at: git://git.aurel32.net/qemu.git tags/pull-target-sh4-20170530

[Qemu-devel] [PULL v2 4/5] target/sh4: ignore interrupts in a delay slot

2017-05-30 Thread Aurelien Jarno
Delay slots are indivisible, therefore avoid scheduling an interrupt in the delay slot. However exceptions are possible. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/helper.c | 12 ++-- 1 file changed, 10 insertions(+),

Re: [Qemu-devel] [RESEND PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

2017-05-30 Thread Dan Williams
On Tue, May 30, 2017 at 5:17 AM, Paolo Bonzini wrote: > > > On 26/05/2017 16:24, Dan Williams wrote: >>> For DAX device only, QEMU can figure out the proper alignment by >>> itself. However, I'm not sure whether there are other non-DAX cases >>> requiring non-default alignment, so I think it's bet

[Qemu-devel] [PULL v2 1/5] target/sh4: log unauthorized accesses using qemu_log_mask

2017-05-30 Thread Aurelien Jarno
qemu_log_mask() is preferred over fprintf() for logging errors. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/helper.c b/target/sh4/helper.c

[Qemu-devel] [PULL v2 2/5] target/sh4: fix reset when using a kernel and an initrd

2017-05-30 Thread Aurelien Jarno
When a masked exception happens, the SH4 CPU generates a non-masked reset exception, which then jumps to the reset vector at address 0xA000. While this is emulated correctly in QEMU, this does not work when using a kernel and initrd as this address then contain an illegal instruction (and there

[Qemu-devel] [PULL 2/2] numa: Fix format string for "Invalid node" message

2017-05-30 Thread Eduardo Habkost
Some compilers complain about the PRIu16 format string with the MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM version 7.3.0 (clang-703.0.31): numa.c:236:20: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat] M

[Qemu-devel] [PULL 1/2] numa-test: fix query-cpus leaks

2017-05-30 Thread Eduardo Habkost
From: Marc-André Lureau Fix test leaks introduced in commit 2941020a476. (and small extra space removed) Spotted by ASAN. Signed-off-by: Marc-André Lureau Message-Id: <20170526110456.32004-1-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- tests/numa-

[Qemu-devel] [PULL 0/2] NUMA fixes, 2017-05-30

2017-05-30 Thread Eduardo Habkost
The following changes since commit 0748b3526e8cb78b9cd64208426bfc3d54a72b04: Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-30 14:15:15 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/numa-pull-request for you to fetch ch

Re: [Qemu-devel] [PATCH] numa: Fix format string for "Invalid node" message

2017-05-30 Thread Eric Blake
On 05/30/2017 01:40 PM, Eduardo Habkost wrote: > Some compilers complain about the PRIu16 format string with the > MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM > version 7.3.0 (clang-703.0.31): > ^~~ > MAX(src, dst) promotes the src and dst arguments t

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

2017-05-30 Thread Dr. David Alan Gilbert
* Vladislav Yasevich (vyase...@redhat.com) wrote: > Add parameters that control RARP/GARP announcement timeouts. > The parameters structure is added to the QAPI and a qmp command > is added to set/get the parameter data. > > Based on work by "Dr. David Alan Gilbert" > > Signed-off-by: Vladislav

Re: [Qemu-devel] Commit b2a575a1c652 broke i486 support.

2017-05-30 Thread Rob Landley
On 05/29/2017 05:14 AM, Richard W.M. Jones wrote: > I see in the disassembly use of cmovne (new in Pentium Pro) and > bswap (new in 486). > [http://cse.unl.edu/~goddard/Courses/CSCE351/IntelArchitecture/InstructionSetSummary.pdf] > > The cmovne instruction is generated by the compiler (GCC in my c

Re: [Qemu-devel] [PATCH Risu v3 4/4] build: Add support to PowerPC BE and remove ARCH

2017-05-30 Thread joserz
On Tue, May 30, 2017 at 03:27:33PM +0100, Peter Maydell wrote: > On 25 May 2017 at 20:10, Jose Ricardo Ziviani > wrote: > > Essentialy the code for PowerPC BE and LE are the same, so this patch > > renames all *ppc64le.* files to *ppc64.* and reflects such in the > > Makefile. > > > > Due to the

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

2017-05-30 Thread Dr. David Alan Gilbert
* Vlad Yasevich (vyase...@redhat.com) wrote: > On 05/26/2017 12:03 AM, Jason Wang wrote: > > > > On 2017年05月25日 02:05, Vladislav Yasevich wrote: > >> Add parameters that control RARP/GARP announcement timeouts. > >> The parameters structure is added to the QAPI and a qmp command > >> is added to s

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/4] qemu-iotests: Block migration test

2017-05-30 Thread Jeff Cody
On Tue, May 30, 2017 at 06:57:05PM +0200, Kevin Wolf wrote: > Am 30.05.2017 um 17:52 hat Jeff Cody geschrieben: > > On Tue, May 30, 2017 at 05:22:53PM +0200, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf > > > --- > > > tests/qemu-iotests/183 | 143 > > > +

[Qemu-devel] [PATCH] numa: Fix format string for "Invalid node" message

2017-05-30 Thread Eduardo Habkost
Some compilers complain about the PRIu16 format string with the MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM version 7.3.0 (clang-703.0.31): numa.c:236:20: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat] M

Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-30 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> There is no reason for having the loadvm_handlers at all. There is >> only one use, and we can use the savevm handlers. >> >> We will remove the loadvm handlers on a following patch. > > > >> trace_qemu_loadv

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

2017-05-30 Thread Eric Blake
On 05/30/2017 01:10 PM, Eduardo Habkost wrote: > On Tue, May 30, 2017 at 10:28:21AM -0500, Eric Blake wrote: >> On 05/30/2017 09:01 AM, Eduardo Habkost wrote: >> The OSX compiler is pickier about format strings than gcc, and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. >>> >

  1   2   3   4   5   >