Re: [Qemu-devel] [Qemu devel v5 PATCH 4/5] msf2: Add Smartfusion2 SoC.

Hi Subbaraya, So far so good! On 05/16/2017 12:38 PM, Subbaraya Sundeep wrote: Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep ---

Re: [Qemu-devel] [Qemu devel v5 PATCH 0/5] Add support for Smartfusion2 SoC

Hi Sundeep, On 05/29/2017 02:28 AM, sundeep subbaraya wrote: Hi Philippe, Any update on this? I will wait for your comments too and send next iteration fixing Alistair comments. Sorry I'm supposed to be in holidays ;) Thanks, Sundeep On Wed, May 17, 2017 at 3:09 PM, sundeep subbaraya

Re: [Qemu-devel] [PATCH v2 5/6] cputlb: add trace events

On 05/17/2017 11:52 AM, Alex Bennée wrote: Given the range of costs for various SoftMMU TLB operations from deferring work for the currently running vCPU to bring the whole emulated machine to a stop for synchronised updates simple counters are less useful. Instead we log events via the trace

Re: [Qemu-devel] [PATCH risu] ppc64.risu: Fix broken constraints

Peter Maydell writes: > Commit c10b97092 changed some field names in rldicr and rldimi patterns > but forgot to update the constraints to match the change. Since the > field (previously 'rb' and now 'sh') is an immediate rather than a > register number, the correct fix

Re: [Qemu-devel] [PATCH risu v2] ppc64: Fix patterns for rotate doubleword instructions

Peter Maydell writes: > On 30 May 2017 at 16:39, Peter Maydell wrote: >> On 30 May 2017 at 16:26, Nikunj A Dadhania wrote: >>> Sandipan Das writes: >>> The patterns for the following

Re: [Qemu-devel] [PATCH v2 1/6] scripts/replay-dump.py: replay log dumper

On 05/17/2017 11:52 AM, Alex Bennée wrote: This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand. It currently understands two different log formats as the audio record/replay support

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

On Tue, May 30, 2017 at 06:04:45PM +0200, Laurent Vivier wrote: > For QEMU, a hotlugged device is a device added using the HMP/QMP > interface. > For SPAPR, a hotplugged device is a device added while the > machine is running. In this case QEMU doesn't update internal > state but relies on the OS

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

On Tue, May 30, 2017 at 10:01:36AM +0200, Greg Kurz wrote: > On Tue, 30 May 2017 16:18:52 +1000 > David Gibson wrote: > > > On Tue, May 30, 2017 at 01:14:16AM +0200, Greg Kurz wrote: > > > On Fri, 26 May 2017 15:23:14 +1000 > > > David Gibson

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

Laszlo, very sorry for that, it was my mistake that missing your name. when I reply mail, I copy the "CC" list to the mail reply list, but forget to copy the "To" list. I will check your comments in detailed later and reply you. thanks again. On 2017/5/30 0:03, Laszlo Ersek wrote: > Hi, >

Re: [Qemu-devel] [PATCH] pci-bridge/i82801b11: Convert to realize

Hi, Marcel & Markus On 05/29/2017 07:37 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 27/05/2017 9:58, Mao Zhongyi wrote: On 05/26/2017 10:08 PM, Marcel Apfelbaum wrote: On 26/05/2017 15:15, Mao Zhongyi wrote: The pci-birdge device i82801b11 still

Re: [Qemu-devel] [PATCH v2 3/6] scripts/qemu-gdb/tcg: new helper to dump tcg state

On 05/17/2017 11:52 AM, Alex Bennée wrote: This adds a simple helper to dump lock state within TCG. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- scripts/qemu-gdb.py| 3 ++- scripts/qemugdb/tcg.py | 46

Re: [Qemu-devel] [PATCH] pci: Set err to errp directly rather than through error_porpagate()

Hi, Markus On 05/29/2017 03:51 PM, Markus Armbruster wrote: Igor Mammedov writes: On Fri, 26 May 2017 16:29:25 +0800 Mao Zhongyi wrote: ioh3420_interrupts_init() and its callers, rp_realize() and pci_qdev_realize() fill error message to

Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt-acpi-build: build SLIT when needed

On 2017/5/30 1:37, Andrew Jones wrote: > Cc: Shannon Zhao > Signed-off-by: Andrew Jones Reviewed-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: fdt: generate distance-map when needed

On 2017/5/30 1:37, Andrew Jones wrote: > This is based on patch Shannon Zhao originally posted. > > Cc: Shannon Zhao > Signed-off-by: Andrew Jones Reviewed-by: Shannon Zhao > --- > hw/arm/virt.c | 21

Re: [Qemu-devel] [PATCH v2 6/6] new script/analyse-tlb-flushes-simpletrace.py

Hi Alex, Please find some comments and questions below: On Wed, May 17, 2017 at 10:52 AM, Alex Bennée wrote: > This is a simple helper script to extract TLB flush stats from the a > simpletrace file and plot the results. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [Qemu devel v5 PATCH 4/5] msf2: Add Smartfusion2 SoC.

On Sun, May 28, 2017 at 10:17 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Sat, May 27, 2017 at 5:18 AM, Alistair Francis > wrote: >> >> On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep >> wrote: >> > Smartfusion2 SoC

Re: [Qemu-devel] [Qemu devel v5 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

On Sun, May 28, 2017 at 10:26 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Sat, May 27, 2017 at 5:30 AM, Alistair Francis > wrote: >> >> On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep >> wrote: >> > Emulated

Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > - do not goto into switch block from outer block This sentence didn't quite make sense. Better might be: - do not use 'goto error_reply' outside a switch to jump into the middle of the switch's default case label > - reduce code

Re: [Qemu-devel] [PATCH 09/19] nbd/server: rename rc to ret

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > For consistency use 'ret' name for saving return code everywhere > in the file. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 38 +++--- > 1 file

Re: [Qemu-devel] [PATCH 08/19] nbd/server: get rid of fail: return rc

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > "goto fail" error handling scheme is not needed for just returning > error code. Better is return it immediately. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 28

Re: [Qemu-devel] [PATCH 06/19] nbd/server: remove NBDClientNewData

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > "co" field of NBDClientNewData is unused, so let's just use client > pointer instead of extra structure. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 25 +++-- >

Re: [Qemu-devel] [PATCH 05/19] nbd/server: refactor nbd_co_receive_request

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Move function tail, about receiving next request out of the function. > Error path is simplified and nbd_co_receive_request becomes more > corresponding to its name. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 10/16] block/qcow2: Lock s->lock in preallocate()

On 05/26/2017 11:55 AM, Max Reitz wrote: > preallocate() is and will be called only from places that do not lock Maybe: "that do not otherwise need to lock" > s->lock: Currently that is qcow2_create2(), as of a future patch it will > be called from qcow2_truncate(), too. > > It therefore makes

Re: [Qemu-devel] [PATCH v3 09/16] block/qcow2: Generalize preallocate()

On 05/26/2017 11:55 AM, Max Reitz wrote: > This patch adds two new parameters to the preallocate() function so we > will be able to use it not just for preallocating a new image but also > for preallocated image growth. > > The offset parameter allows the caller to specify a virtual offset from >

[Qemu-devel] [RFC] q35/mch: implement extended TSEG sizes

The q35 machine type currently lets the guest firmware select a 1MB, 2MB or 8MB TSEG (basically, SMRAM) size. In edk2/OVMF, we use 8MB, but even that is not enough when a lot of VCPUs (more than approx. 224) are configured -- SMRAM footprint scales largely proportionally with VCPU count.

Re: [Qemu-devel] [PATCH v2 5/6] vhost-user: add slave-req-fd support

On 05/30/2017 08:17 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:57PM +0200, Maxime Coquelin wrote: From: Marc-André Lureau Learn to give a socket to the slave to let him make requests to the master. Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH 07/19] nbd/server: nbd_negotiate: fix error path

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Current code will return 0 on this write_sync fail, as rc is 0 > after successful nbd_negotiate_options. Fix this. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 3 ++- > 1 file

Re: [Qemu-devel] [PATCH v2 3/6] vhost: extend ring information update for IOTLB to all rings

On 05/30/2017 11:06 PM, Maxime Coquelin wrote: Hi Michael, On 05/30/2017 08:12 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:55PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need needs to receive IOTLB entry for used ring information early, which is done by

Re: [Qemu-devel] [PATCH v2 3/6] vhost: extend ring information update for IOTLB to all rings

Hi Michael, On 05/30/2017 08:12 PM, Michael S. Tsirkin wrote: On Fri, May 26, 2017 at 04:28:55PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need needs to receive IOTLB entry for used ring information early, which is done by triggering a miss event on its address. This patch

Re: [Qemu-devel] [PATCH 04/19] nbd/server: get rid of EAGAIN dead code

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > For now read_sync never returns EAGAIN. So, don't handle it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) >

Re: [Qemu-devel] [PATCH v3 04/16] qemu-img: Expose PreallocMode for resizing

On 05/26/2017 11:55 AM, Max Reitz wrote: > Add a --preallocation command line option to qemu-img resize which can > be used to set the PreallocMode parameter of blk_truncate(). > > Signed-off-by: Max Reitz > --- > qemu-img.c| 33 ++--- >

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

On 05/30/2017 03:24 PM, Kashyap Chamarthy wrote: > First, thanks for the quick feedback! > > On Tue, May 30, 2017 at 02:24:40PM -0500, Eric Blake wrote: >> On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: >>> This edition documents all four operations: > >>> + >>> +(1) `Disk image backing chain

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

First, thanks for the quick feedback! On Tue, May 30, 2017 at 02:24:40PM -0500, Eric Blake wrote: > On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: > > This edition documents all four operations: [...] > s/occurance/occurrence/ > > > use raw JSON; for subsequent occurances, use

Re: [Qemu-devel] [PATCH 03/19] nbd/server: refactor nbd_co_send_reply

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > As write_sync never returns value > 0, we can get rid of extra ret. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 02/19] nbd/server: get rid of ssize_t

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Now read_sync and friends return int, so get rid of ssize_t. In particular, it was your earlier commit "nbd: read_sync and friends: return 0 on success" that changed the semantics of the return value to just be 0 instead of a size; and

Re: [Qemu-devel] [PATCH v2 29/29] target/s390x: update maximum TCG model to z800

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: At the same time fix the TCG version of get_max_cpu_model to return the maximum model like on KVM. Remove the long-displacement facility from the additional features as it is included in the z800. Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 24/29] target/s390x: implement PACK UNICODE

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++

Re: [Qemu-devel] [PATCH v2 22/29] target/s390x: implement MOVE LONG UNICODE

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 47 -- target/s390x/translate.c | 21

Re: [Qemu-devel] [PATCH v2 21/29] target/s390x: implement COMPARE LOGICAL LONG UNICODE

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Signed-off-by: Aurelien Jarno ---

Re: [Qemu-devel] [PATCH v2 19/29] target/s390x: fix adj_len_to_page

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 20/29] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Signed-off-by: Aurelien

Re: [Qemu-devel] [PATCH v2 18/29] target/s390x: implement COMPARE LOGICAL LONG

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 +

Re: [Qemu-devel] [PATCH v2 17/29] target/s390x: fix COMPARE LOGICAL LONG EXTENDED

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after

Re: [Qemu-devel] [PATCH 01/19] nbd/server: get rid of nbd_negotiate_read and friends

On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Functions nbd_negotiate_{read,write,drop_sync} were introduced in > 1a6245a5b, when nbd_wr_syncv was working through qemu_co_sendv_recvv, There is no qemu_co_sendv_recvv. Did you mean qemu_co_recv/qemu_co_send? > which just yields,

Re: [Qemu-devel] [PATCH v2 14/29] target/s390x: improve 24-bit and 31-bit addresses read

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function.

Re: [Qemu-devel] [PATCH v2 09/29] target/s390x: implement COMPARE AND SIGNAL

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +DEF_HELPER_FLAGS_3(keb, TCG_CALL_NO_WG_SE, i32, env, i64, i64) +DEF_HELPER_FLAGS_3(kdb, TCG_CALL_NO_WG_SE, i32, env, i64, i64) +DEF_HELPER_FLAGS_5(kxb, TCG_CALL_NO_WG_SE, i32, env, i64, i64, i64, i64) They do have side effects -- recording the

Re: [Qemu-devel] [PATCH v2 08/29] target/s390x: implement STORE PAIR TO QUADWORD

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +TCGMemOpIdx oi = make_memop_idx(MO_TEQ, mem_idx); Similarly, alignment. r~

Re: [Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

On Tue, May 30, 2017 at 06:24:02PM +0200, Igor Mammedov wrote: > Calculating default node-ids for CPUs in possible_cpu_arch_ids() > is rather fragile since defaults calculation uses nb_numa_nodes but > callback might be potentially called early before all -numa CLI > options are parsed, which

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

On 05/30/2017 03:35 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> It is now potentially possible to issue annouce-self command in a tight >> loop. Instead of doing nother, we can reset the timeout pararameters, >> especially since each instance may

Re: [Qemu-devel] [PATCH v2 07/29] target/s390x: implement LOAD PAIR FROM QUADWORD

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: +TCGMemOpIdx oi = make_memop_idx(MO_TEQ, mem_idx); MO_TEQ | MO_ALIGN_16 as it's a specification error for the address to be unaligned. r~

Re: [Qemu-devel] [PATCH v2 04/29] target/s390x: implement TEST AND SET

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 05/29] target/s390x: implement TEST ADDRESSING MODE

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

On 2017-05-30 12:42, Richard Henderson wrote: > On 05/30/2017 12:25 PM, Aurelien Jarno wrote: > > On 2017-05-30 09:45, Richard Henderson wrote: > > > On 05/29/2017 04:17 AM, Aurelien Jarno wrote: > > > > On 2017-05-26 10:10, Richard Henderson wrote: > > > > > On 05/25/2017 02:05 PM, Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 03/29] target/s390x: implement local-TLB-clearing in IPTE

On 05/29/2017 12:24 PM, Aurelien Jarno wrote: And at the same time make IPTE SMP aware. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 19 --- target/s390x/translate.c | 6 +- 3 files changed, 18

Re: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes

On Tue, May 30, 2017 at 06:23:55PM +0200, Igor Mammedov wrote: > changelog since v2: > (Eduardo) > - keep original logic in when moving numa part into helper > numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr > - drop "numa: fallback to default NUMA node instead of

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 6/7] spapr: cleanup spapr_fixup_cpu_numa_dt() usage

On Tue, May 30, 2017 at 06:40:22PM +0200, Greg Kurz wrote: > On Tue, 30 May 2017 18:24:01 +0200 > Igor Mammedov wrote: > > > even though spapr_fixup_cpu_numa_dt() has no effect on FDT > > if numa is disabled, don't call it uselessly. It makes it > > obvious at call sites

Re: [Qemu-devel] [PATCH v3 5/7] numa: move numa_node from CPUState into target specific classes

On Tue, May 30, 2017 at 11:30:27AM -0500, Eric Blake wrote: > On 05/30/2017 11:24 AM, Igor Mammedov wrote: > > Move vcpu's assocciated numa_node field out of generic CPUState > > s/assocciated/associated/ > > > into inherited classes that actually care about cpu<->numa mapping, > > i.e: ARMCPU,

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

On 05/30/2017 12:25 PM, Aurelien Jarno wrote: On 2017-05-30 09:45, Richard Henderson wrote: On 05/29/2017 04:17 AM, Aurelien Jarno wrote: On 2017-05-26 10:10, Richard Henderson wrote: On 05/25/2017 02:05 PM, Aurelien Jarno wrote: +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1,

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

* Vladislav Yasevich (vyase...@redhat.com) wrote: > It is now potentially possible to issue annouce-self command in a tight > loop. Instead of doing nother, we can reset the timeout pararameters, > especially since each instance may provide it's own values. This > allows the user to extend or

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

On 05/30/2017 03:19 PM, Dr. David Alan Gilbert wrote: > * Vladislav Yasevich (vyase...@redhat.com) wrote: >> Switch qemu_announce_self and virtio annoucements to use >> the announcement timer framework. This makes sure that both >> timers use the same timeouts and number of annoucement attempts

Re: [Qemu-devel] [PATCH 07/12] migration: Allow for a limited number of announce timers

* Vladislav Yasevich (vyase...@redhat.com) wrote: > We currently create a new announcement timer every time > qemu_announce_self() is called. Since this is now a qmp > command, this can lead to abuse. Limit the number of > timers that are created. Give QMP interface and migration > process 1

Re: [Qemu-devel] How do you -sd squashfs.img without truncating?

On 05/30/2017 07:17 AM, Peter Maydell wrote: > On 8 May 2017 at 06:08, Rob Landley wrote: >> As far as I can tell "qemu-system-arm -M vexpress-a9" only implements sd >> card, not any conventional hard drive, and it uses an sdcard block size >> of 262144 bytes rounded down. This

Re: [Qemu-devel] [PATCH] linux-user: Fix TARGET_MAP* and TARGET_F_??LCK for hppa arch

On 19.05.2017 15:59, Riku Voipio wrote: > On Sun, Mar 12, 2017 at 08:17:46AM +1000, Richard Henderson wrote: >> On 03/12/2017 03:50 AM, Helge Deller wrote: >>> TARGET_MAP_TYPE needs to be 0x03 instead of 0x0f on the hppa >>> architecture, otherwise it conflicts with MAP_FIXED which is 0x04. >>>

Re: [Qemu-devel] [PATCH] live-block-ops.txt: Rewrite and improve it

On 05/30/2017 10:38 AM, Kashyap Chamarthy wrote: > This edition documents all four operations: > > - `block-stream` > - `block-commit` > - `drive-mirror` (& `blockdev-mirror`) > - `drive-backup` (& `blockdev-backup`) > > Things considered while writing this document: > > - Use

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

On 2017-05-30 09:45, Richard Henderson wrote: > On 05/29/2017 04:17 AM, Aurelien Jarno wrote: > > On 2017-05-26 10:10, Richard Henderson wrote: > > > On 05/25/2017 02:05 PM, Aurelien Jarno wrote: > > > > +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2, > > > > +

[Qemu-devel] [PULL v2 3/5] target/sh4: introduce DELAY_SLOT_MASK

This will make easier the introduction of a new flag in the next patches. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/cpu.h | 3 ++- target/sh4/helper.c| 4

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

* Vladislav Yasevich (vyase...@redhat.com) wrote: > Switch qemu_announce_self and virtio annoucements to use > the announcement timer framework. This makes sure that both > timers use the same timeouts and number of annoucement attempts > > Based on work by Dr. David Alan Gilbert

[Qemu-devel] [PULL v2 5/5] target/sh4: fix RTE instruction delay slot

The ReTurn from Exception (RTE) instruction loads the system register (SR) with the saved system register (SSR). It has a delay slot, and behaves specially according to the SH4 manual: The SR value accessed by the instruction in the RTE delay slot is the value restored from SSR by the RTE

[Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches

The following changes since commit 0748b3526e8cb78b9cd64208426bfc3d54a72b04: Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-30 14:15:15 +0100) are available in the git repository at: git://git.aurel32.net/qemu.git tags/pull-target-sh4-20170530 for you

[Qemu-devel] [PULL v2 4/5] target/sh4: ignore interrupts in a delay slot

Delay slots are indivisible, therefore avoid scheduling an interrupt in the delay slot. However exceptions are possible. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno ---

Re: [Qemu-devel] [RESEND PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

On Tue, May 30, 2017 at 5:17 AM, Paolo Bonzini wrote: > > > On 26/05/2017 16:24, Dan Williams wrote: >>> For DAX device only, QEMU can figure out the proper alignment by >>> itself. However, I'm not sure whether there are other non-DAX cases >>> requiring non-default

[Qemu-devel] [PULL v2 1/5] target/sh4: log unauthorized accesses using qemu_log_mask

qemu_log_mask() is preferred over fprintf() for logging errors. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/helper.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL v2 2/5] target/sh4: fix reset when using a kernel and an initrd

When a masked exception happens, the SH4 CPU generates a non-masked reset exception, which then jumps to the reset vector at address 0xA000. While this is emulated correctly in QEMU, this does not work when using a kernel and initrd as this address then contain an illegal instruction (and

[Qemu-devel] [PULL 2/2] numa: Fix format string for "Invalid node" message

Some compilers complain about the PRIu16 format string with the MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM version 7.3.0 (clang-703.0.31): numa.c:236:20: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]

[Qemu-devel] [PULL 1/2] numa-test: fix query-cpus leaks

From: Marc-André Lureau Fix test leaks introduced in commit 2941020a476. (and small extra space removed) Spotted by ASAN. Signed-off-by: Marc-André Lureau Message-Id: <20170526110456.32004-1-marcandre.lur...@redhat.com> Reviewed-by:

[Qemu-devel] [PULL 0/2] NUMA fixes, 2017-05-30

The following changes since commit 0748b3526e8cb78b9cd64208426bfc3d54a72b04: Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-30 14:15:15 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/numa-pull-request for you to fetch

Re: [Qemu-devel] [PATCH] numa: Fix format string for "Invalid node" message

On 05/30/2017 01:40 PM, Eduardo Habkost wrote: > Some compilers complain about the PRIu16 format string with the > MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM > version 7.3.0 (clang-703.0.31): > ^~~ > MAX(src, dst) promotes the src and dst arguments

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

* Vladislav Yasevich (vyase...@redhat.com) wrote: > Add parameters that control RARP/GARP announcement timeouts. > The parameters structure is added to the QAPI and a qmp command > is added to set/get the parameter data. > > Based on work by "Dr. David Alan Gilbert" > >

Re: [Qemu-devel] Commit b2a575a1c652 broke i486 support.

On 05/29/2017 05:14 AM, Richard W.M. Jones wrote: > I see in the disassembly use of cmovne (new in Pentium Pro) and > bswap (new in 486). > [http://cse.unl.edu/~goddard/Courses/CSCE351/IntelArchitecture/InstructionSetSummary.pdf] > > The cmovne instruction is generated by the compiler (GCC in my

Re: [Qemu-devel] [PATCH Risu v3 4/4] build: Add support to PowerPC BE and remove ARCH

On Tue, May 30, 2017 at 03:27:33PM +0100, Peter Maydell wrote: > On 25 May 2017 at 20:10, Jose Ricardo Ziviani > wrote: > > Essentialy the code for PowerPC BE and LE are the same, so this patch > > renames all *ppc64le.* files to *ppc64.* and reflects such in the > >

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

* Vlad Yasevich (vyase...@redhat.com) wrote: > On 05/26/2017 12:03 AM, Jason Wang wrote: > > > > On 2017年05月25日 02:05, Vladislav Yasevich wrote: > >> Add parameters that control RARP/GARP announcement timeouts. > >> The parameters structure is added to the QAPI and a qmp command > >> is added to

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/4] qemu-iotests: Block migration test

On Tue, May 30, 2017 at 06:57:05PM +0200, Kevin Wolf wrote: > Am 30.05.2017 um 17:52 hat Jeff Cody geschrieben: > > On Tue, May 30, 2017 at 05:22:53PM +0200, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf > > > --- > > > tests/qemu-iotests/183 | 143 > > >

[Qemu-devel] [PATCH] numa: Fix format string for "Invalid node" message

Some compilers complain about the PRIu16 format string with the MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM version 7.3.0 (clang-703.0.31): numa.c:236:20: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]

Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> There is no reason for having the loadvm_handlers at all. There is >> only one use, and we can use the savevm handlers. >> >> We will remove the loadvm handlers on a following patch. > > > >>

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

On 05/30/2017 01:10 PM, Eduardo Habkost wrote: > On Tue, May 30, 2017 at 10:28:21AM -0500, Eric Blake wrote: >> On 05/30/2017 09:01 AM, Eduardo Habkost wrote: >> The OSX compiler is pickier about format strings than gcc, and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. >>>

Re: [Qemu-devel] [PATCH v2 0/6] vhost-user: Specify and implement device IOTLB support

On Fri, May 26, 2017 at 04:28:52PM +0200, Maxime Coquelin wrote: > This series aims at specifying ans implementing the protocol update > required to support device IOTLB with user backends. > > In this second non-RFC version, main changes are: > - spec fixes and clarification > - rings

Re: [Qemu-devel] [PATCH v2 5/6] vhost-user: add slave-req-fd support

On Fri, May 26, 2017 at 04:28:57PM +0200, Maxime Coquelin wrote: > From: Marc-André Lureau > > Learn to give a socket to the slave to let him make requests to the > master. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Maxime

Re: [Qemu-devel] [PATCH v2 3/6] vhost: extend ring information update for IOTLB to all rings

On Fri, May 26, 2017 at 04:28:55PM +0200, Maxime Coquelin wrote: > Vhost-kernel backend need needs > to receive IOTLB entry for used ring > information early, which is done by triggering a miss event on > its address. > > This patch extends this behaviour to all rings information, to be >

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

On Tue, May 30, 2017 at 10:28:21AM -0500, Eric Blake wrote: > On 05/30/2017 09:01 AM, Eduardo Habkost wrote: > > >> The OSX compiler is pickier about format strings than gcc, > >> and neither "MAX_NODES" nor "MAX(anything)" are uint16_t type. > > > > src and dst are both uint16_t, so MAX(src,

Re: [Qemu-devel] [PATCH v2 6/6] spec/vhost-user spec: Add IOMMU support

On Fri, May 26, 2017 at 04:28:58PM +0200, Maxime Coquelin wrote: > This patch specifies and implements the master/slave communication > to support device IOTLB in slave. > > The vhost_iotlb_msg structure introduced for kernel backends is > re-used, making the design close between the two

Re: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1496161442-96665-1-git-send-email-imamm...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/7] numa: code consolidation and fixes Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy

* Juan Quintela (quint...@redhat.com) wrote: > There is no reason for having the loadvm_handlers at all. There is > only one use, and we can use the savevm handlers. > > We will remove the loadvm handlers on a following patch. > trace_qemu_loadvm_state_section_partend(section_id); > -

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/4] spapr: disable hotplugging without OS

Quoting David Gibson (2017-05-24 22:16:26) > On Wed, May 24, 2017 at 12:40:37PM -0500, Michael Roth wrote: > > Quoting Laurent Vivier (2017-05-24 11:02:30) > > > On 24/05/2017 17:54, Greg Kurz wrote: > > > > On Wed, 24 May 2017 12:14:02 +0200 > > > > Igor Mammedov wrote: > >

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

On Tue, May 30, 2017 at 06:08:04PM +0100, Peter Maydell wrote: > On 30 May 2017 at 15:01, Eduardo Habkost wrote: > > On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: > >> Hi all; I'm afraid this patch breaks compilation on OSX: > > > > It looks like this wasn't

Re: [Qemu-devel] [PULL 02/29] numa: Allow setting NUMA distance for different NUMA nodes

On 30 May 2017 at 15:01, Eduardo Habkost wrote: > On Tue, May 30, 2017 at 11:45:55AM +0100, Peter Maydell wrote: >> Hi all; I'm afraid this patch breaks compilation on OSX: > > It looks like this wasn't detected by travis-ci because the build > is not using -Werror: >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/4] qemu-iotests: Block migration test

Am 30.05.2017 um 17:52 hat Jeff Cody geschrieben: > On Tue, May 30, 2017 at 05:22:53PM +0200, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/183 | 143 > > + > > tests/qemu-iotests/183.out | 46

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile

On Tue, 30 May 2017 18:34:46 +0200 Christian Borntraeger wrote: > On 05/30/2017 05:04 PM, Greg Kurz wrote: > > The docker-run-test-build@debian-s390x-cross target fails with: > > > > strip --strip-unneeded s390-ccw.elf -o s390-ccw.img > > strip: Unable to recognise the

Re: [Qemu-devel] [PATCH 21/26] target/s390x: implement PACK UNICODE

On 05/29/2017 04:22 AM, Aurelien Jarno wrote: On 2017-05-26 09:35, Richard Henderson wrote: On 05/25/2017 02:05 PM, Aurelien Jarno wrote: +} else if (srclen > ssize) { b = cpu_ldub_data_ra(env, src, ra) & 0x0f; -src--; -srclen--; +src

Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

On 05/29/2017 04:17 AM, Aurelien Jarno wrote: On 2017-05-26 10:10, Richard Henderson wrote: On 05/25/2017 02:05 PM, Aurelien Jarno wrote: +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2, + uint32_t sizes) +{ +uintptr_t ra = GETPC(); +int dsize =

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 6/7] spapr: cleanup spapr_fixup_cpu_numa_dt() usage

On Tue, 30 May 2017 18:24:01 +0200 Igor Mammedov wrote: > even though spapr_fixup_cpu_numa_dt() has no effect on FDT > if numa is disabled, don't call it uselessly. It makes it > obvious at call sites that function is need only when numa s/need/needed > is enabled. > >

  1   2   3   4   5   >