Re: [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs

2018-05-01 Thread Thomas Huth
On 30.04.2018 14:46, Stefan Hajnoczi wrote: > From: Joe Perches > > Some find using utf-8 in commit logs inappropriate. > > Some patch commit logs contain unintended utf-8 characters when doing > things like copy/pasting compilation output. > > Look for the start of any

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-05-01 Thread Thomas Huth
On 01.05.2018 15:04, Stefan Hajnoczi wrote: > On Mon, Apr 30, 2018 at 05:56:30AM -0700, no-re...@patchew.org wrote: >> === OUTPUT BEGIN === >> Checking PATCH 1/5: checkpatch: add a --strict check for utf-8 in commit >> logs... >> WARNING: line over 80 characters >> #101: FILE:

[Qemu-devel] [PATCH qemu] vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages

2018-05-01 Thread Alexey Kardashevskiy
At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU pages and POWER8 CPU supports the exact same set of page size so so far things worked fine. However POWER9 supports different set of sizes - 4K/64K/2M/1G and the last two - 2M and 1G - are not even allowed in the paravirt

[Qemu-devel] [Bug 1751422] Re: some instructions translate error in x86

2018-05-01 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1751422 Title: some

Re: [Qemu-devel] [PATCH] linux-user: remove useless padding in flock64 structure

2018-05-01 Thread Richard Henderson
On 05/01/2018 04:53 PM, Laurent Vivier wrote: > Since commit 8efb2ed5ec ("linux-user: Correct signedness of > target_flock l_start and l_len fields"), flock64 structure uses > abi_llong for l_start and l_len in place of "unsigned long long" > this should force them to be aligned accordingly to the

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-05-01 Thread Peter Xu
On Fri, Apr 27, 2018 at 06:40:09PM +0800, Xiao Guangrong wrote: > > > On 04/27/2018 05:31 PM, Peter Xu wrote: > > On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: > > > > > > > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > > > > On 04/26/2018 04:15 AM, guangrong.x...@gmail.com

Re: [Qemu-devel] [PATCH] migration: fix saving normal page even if it's been compressed

2018-05-01 Thread Peter Xu
On Sat, Apr 28, 2018 at 04:10:45PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Fix the bug introduced by da3f56cb2e767016 (migration: remove > ram_save_compressed_page()), It should be 'return' rather than > 'res' > > Sorry for this stupid

Re: [Qemu-devel] [PATCH v3 2/5] platform-bus-device: use device plug callback instead of machine_done notifier

2018-05-01 Thread David Gibson
On Tue, May 01, 2018 at 02:08:39PM +0200, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on ordering

Re: [Qemu-devel] [PATCH] net: Fix memory leak in net_param_nic()

2018-05-01 Thread Jason Wang
On 2018年04月30日 15:26, Thomas Huth wrote: The early exits in case of errors leak the memory allocated for nd_id. Fix it by using a "goto out" to the cleanup at the end of the function instead. Signed-off-by: Thomas Huth --- net/net.c | 6 -- 1 file changed, 4

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-01 Thread Alexey Kardashevskiy
On 1/5/18 11:01 pm, Eric Blake wrote: > On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy >> --- > > There is no rationale in the commit body (a good commit message has a > one-line summary of "what", then a paragraph stating "why", making

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-01 Thread Alexey Kardashevskiy
On 30/4/18 7:39 pm, Paolo Bonzini wrote: > On 30/04/2018 08:52, Alexey Kardashevskiy wrote: >> diff --git a/qapi/misc.json b/qapi/misc.json >> index 5636f4a..399ec74 100644 >> --- a/qapi/misc.json >> +++ b/qapi/misc.json >> @@ -1491,6 +1491,10 @@ >> # >> # List properties associated with a

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 5/5] make sure that we aren't overwriting mc->get_hotplug_handler by accident

2018-05-01 Thread Philippe Mathieu-Daudé
On 05/01/2018 09:08 AM, Igor Mammedov wrote: > Suggested-by: Eduardo Habkost > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c | 1 + > hw/i386/pc.c | 1 + >

Re: [Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

2018-05-01 Thread Philippe Mathieu-Daudé
Hi Bastian, On 05/01/2018 11:22 AM, Bastian Koppelmann wrote: > this includes the Makefile and linker script to build all the tests. > > Signed-off-by: Bastian Koppelmann > --- > tests/tcg/tricore/Makefile | 30 +++ >

[Qemu-devel] [RFC PATCH] docker: add debian/tricore image

2018-05-01 Thread Philippe Mathieu-Daudé
TriCore binutils is built from Bastian Koppelmann repository. Note: There is no TriCore compiler in this image (only assembler/linker). Signed-off-by: Philippe Mathieu-Daudé --- See http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg00074.html $ docker images --format

[Qemu-devel] [PATCH] linux-user: remove useless padding in flock64 structure

2018-05-01 Thread Laurent Vivier
Since commit 8efb2ed5ec ("linux-user: Correct signedness of target_flock l_start and l_len fields"), flock64 structure uses abi_llong for l_start and l_len in place of "unsigned long long" this should force them to be aligned accordingly to the target rules. So we can remove the padding field and

Re: [Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Eric Blake
On 05/01/2018 05:05 PM, Max Reitz wrote: Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block job respect block-job-cancel's @force flag: With that flag set, it would now always really cancel, even post-READY. Unfortunately, it had a side effect: Without that flag set, it would

Re: [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Eric Blake
On 05/01/2018 05:05 PM, Max Reitz wrote: Currently, you cannot cancel a mirror job without the @force flag set. This is intentional once source and target are in sync, but probably not so much before that happens. The main reason for me thinking this is because it is an undocumented change in

Re: [Qemu-devel] [PATCH] RISC-V: Fix missing break statement in disassembler

2018-05-01 Thread Philippe Mathieu-Daudé
On 04/29/2018 08:18 PM, Michael Clark wrote: > This fixes an issue when disassembling rv128 c.sqsp, > where the code erroneously fell through to c.swsp. > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann

Re: [Qemu-devel] [Qemu-block] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-01 Thread John Snow
On 04/21/2018 12:54 PM, Max Reitz wrote: > Looking at the qcow2 code that is riddled with error_report() calls, > this is really how it should have been from the start. > > Signed-off-by: Max Reitz > --- > include/block/block.h | 3 +- > include/block/block_int.h |

[Qemu-devel] [PATCH 2/2] iotests: Add test for cancelling a mirror job

2018-05-01 Thread Max Reitz
We already have an extensive mirror test (041) which does cover cancelling a mirror job, especially after it has emitted the READY event. However, it does not check what exact events are emitted after block-job-cancel is executed. More importantly, it does not use throttling to ensure that it

[Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Max Reitz
Currently, you cannot cancel a mirror job without the @force flag set. This is intentional once source and target are in sync, but probably not so much before that happens. The main reason for me thinking this is because it is an undocumented change in 2.12.0 in respect to 2.11.

[Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Max Reitz
Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block job respect block-job-cancel's @force flag: With that flag set, it would now always really cancel, even post-READY. Unfortunately, it had a side effect: Without that flag set, it would now never cancel, not even before READY.

Re: [Qemu-devel] [RFC PATCH 7/7] avocado: Add tests booting the Malta machine

2018-05-01 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/avocado/test_linux-boot-console.py | 92 +++ > .../parameters.yaml | 2 + > 2 files changed, 94 insertions(+) > > diff

[Qemu-devel] [PATCH 3/4] nbd/client: Support requests of additional block sizing info

2018-05-01 Thread Eric Blake
The NBD spec is clarifying [1] that a server may want to advertise different limits for READ/WRITE (in our case, 32M) than for TRIM/ZERO (in our case, nearly 4G). Implement the client side support for these alternate limits, by always requesting the new information (a compliant server must ignore

Re: [Qemu-devel] [RFC PATCH 6/7] avocado: Add a test parsing Linux kernel booting console

2018-05-01 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > Booting an Alpha DP264 machine. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/avocado/test_linux-boot-console.py | 88 +++ > .../parameters.yaml | 3 + > 2 files

[Qemu-devel] [PATCH 2/4] nbd/client: Refactor in preparation for more limits

2018-05-01 Thread Eric Blake
The next patch will ask the server for more items of NBD_INFO. However, the server is free to respond with INFO items in a different order than what we request, so performing any sanity checks about constraints that occur between multiple INFO items must be done after all items have been received.

Re: [Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-05-01 Thread Eric Blake
On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a

[Qemu-devel] [PATCH 0/4] Support larger NBD_CMD_WRITE_ZEROES

2018-05-01 Thread Eric Blake
This is my counterproposal for: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02107.html where Edgar pointed out that NBD write zero requests are rather inefficient because the NBD spec was ambiguous on whether we could exceed an advertised maximum request size even when the command

[Qemu-devel] [PATCH 1/4] nbd: Prepare for additional block sizing info

2018-05-01 Thread Eric Blake
The NBD spec is clarifying [1] that a server may want to advertise different limits for READ/WRITE (in our case, 32M) than for TRIM/ZERO (in our case, nearly 4G). Add the constants and name lookups for new NBD_INFO_ fields used during handshake to convey this additional information. Note that

[Qemu-devel] [PATCH 4/4] nbd/server: Support requests of additional block sizing info

2018-05-01 Thread Eric Blake
The NBD spec is clarifying [1] that a server may want to advertise different limits for READ/WRITE (in our case, 32M) than for TRIM/ZERO (in our case, nearly 4G). Implement the server side support for these alternate limits, by always advertising the new information (a compliant client must

Re: [Qemu-devel] [Bug 1768246] [NEW] cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-05-01 Thread John Paul Adrian Glaubitz
On 05/01/2018 05:31 PM, Alex Bennée wrote: >> Haven't bi-sected the issue yet, but will do so later. > > Hmm that's ominous - arguably the assert should be inside the > CONFIG_USER but I'm not sure how you get to the point where icount isn't > < 0 after receiving a TB_EXIT_REQUESTED. git bisect

Re: [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP command

2018-05-01 Thread Samuel Thibault
Hello, I'm sorry I didn't find the time to have a look at it before. In general it looks good, just a few things: Samuel Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit: > +if (!net_hub_id_for_client(>nc, )) { That makes me think that IIUC, we shouldn't call them vlan, as

Re: [Qemu-devel] [PATCH 0/3] Update linux-headers to v4.17-rc3

2018-05-01 Thread David Airlie
On Wed, May 2, 2018 at 2:25 AM, Alex Williamson wrote: > This series is based on Michael's series moving kvm_para.h out to > standard headers, which resolves the conflict in definitions of > KVM_HINTS_DEDICATED between QEMU and kernel. > > Additionally, this series

Re: [Qemu-devel] [PATCH] nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE

2018-05-01 Thread Eric Blake
On 05/01/2018 10:55 AM, Vladimir Sementsov-Ogievskiy wrote: 01.05.2018 18:46, Eric Blake wrote: A missing space makes for poor error messages.  Also, we missed diagnosing a server that sends a maximum block size less than the minimum. Fixes: 081dd1fe CC: qemu-sta...@nongnu.org Signed-off-by:

Re: [Qemu-devel] [PATCH for 2.13] linux-user: introduce target_sigsp() and target_save_altstack()

2018-05-01 Thread Richard Henderson
On 04/11/2018 12:23 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > Based-on: <20180411185651.21351-1-laur...@vivier.eu> > "[PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c > to arch directories" Reviewed-by: Richard Henderson

Re: [Qemu-devel] [RFC PATCH 5/7] avocado: Add an optional flag 'login' to get_console()

2018-05-01 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > Not all consoles require users to log in :/ > You're breaking a lot of assumptions here (in a good way) ;). > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/avocado/avocado_qemu/test.py | 23 ---

Re: [Qemu-devel] [RFC PATCH 3/7] qemu.py: Check console arch is supported before calling mktemp()

2018-05-01 Thread Cleber Rosa
On 05/01/2018 03:30 PM, Cleber Rosa wrote: > > > On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> scripts/qemu.py | 20 ++-- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git

Re: [Qemu-devel] [RFC PATCH 4/7] qemu.py: Avoid deprecated tempfile.mktemp()

2018-05-01 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > We already have secure temporary directory created with tempfile.mkdtemp(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/qemu.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [RFC PATCH 3/7] qemu.py: Check console arch is supported before calling mktemp()

2018-05-01 Thread Cleber Rosa
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/qemu.py | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index

Re: [Qemu-devel] [PATCH 2/2] hw/net/smc91c111: Convert away from old_mmio

2018-05-01 Thread Richard Henderson
On 04/27/2018 10:36 AM, Peter Maydell wrote: > Convert the smc91c111 device away from using the old_mmio field of > MemoryRegionOps. This device is used by several Arm board models. > > Signed-off-by: Peter Maydell > --- > hw/net/smc91c111.c | 54

Re: [Qemu-devel] [PATCH 1/2] hw/usb/tusb6010: Convert away from old_mmio

2018-05-01 Thread Richard Henderson
On 04/27/2018 10:36 AM, Peter Maydell wrote: > Convert the tusb6010 device away from using the old_mmio field > of MemoryRegionOps. This device is used only in the n800 and n810 > boards. > > Signed-off-by: Peter Maydell > --- > hw/usb/tusb6010.c | 40

[Qemu-devel] [PATCH 1/1] target/arm: Correct MPUIR privilege level in register_cp_regs_for_features() conditional case

2018-05-01 Thread Mathew Maidment
The duplication of id_tlbtr_reginfo was unintentionally added within 3281af8114c6b8ead02f08b58e3c36895c1ea047 which should have been id_mpuir_reginfo. Signed-off-by: Mathew Maidment --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/1] target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

2018-05-01 Thread Mathew Maidment
Hey there! This is my first time sending a patch via a mailing list so hopefully I didn't bungle this up *too* badly. Mat Mathew Maidment (1): target/arm: Correct MPUIR privilege level in register_cp_regs_for_features() target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH v3] tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st

2018-05-01 Thread Richard Henderson
On 04/29/2018 04:58 PM, Laurent Vivier wrote: > ppc64 uses a BC instruction to call the tcg_out_qemu_ld/st > slow path. BC instruction uses a relative address encoded > on 14 bits. > > The slow path functions are added at the end of the generated > instructions buffer, in the reverse order of the

Re: [Qemu-devel] [PATCH] RISC-V: Fix missing break statement in disassembler

2018-05-01 Thread Richard Henderson
On 04/29/2018 04:18 PM, Michael Clark wrote: > This fixes an issue when disassembling rv128 c.sqsp, > where the code erroneously fell through to c.swsp. > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

2018-05-01 Thread Richard Henderson
On 05/01/2018 08:47 AM, Alex Bennée wrote: > I've also pushed the fix to sqrt_f16 (passing cpu_env rather than fpst). Oops. > Are you happy rolling my fixes into your v2? Yes, I can do that. r~

Re: [Qemu-devel] [PATCH 2/2] iotests: Test post-backing convert target behavior

2018-05-01 Thread Eric Blake
On 05/01/2018 11:57 AM, Max Reitz wrote: This adds a test case to 122 for what happens when you convert to a target with a backing file that is shorter than the target, and the image format does not support efficient zero writes (as is the case with qcow2 v2). Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Special post-backing convert handling

2018-05-01 Thread Eric Blake
On 05/01/2018 11:57 AM, Max Reitz wrote: Currently, qemu-img convert writes zeroes when it reads zeroes. Sometimes it does not because the target is initialized to zeroes anyway, so we do not need to overwrite (and thus potentially allocate) it. This is never the case for targets with backing

[Qemu-devel] [PATCH 2/2] target/arm: Tidy condition in disas_simd_two_reg_misc

2018-05-01 Thread Richard Henderson
Path analysis shows that size == 3 && !is_q has been eliminated. Fixes: Coverity CID1385853 Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c

[Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups

2018-05-01 Thread Richard Henderson
The first patch covers four related false positives. However, we check the same condition twice and we certainly don't need to that. Plus the assert might just help documentation-wise. The second patch covers dead code. I believe that Coverity is right and that there are no paths that have

[Qemu-devel] [PATCH 1/2] target/arm: Tidy conditions in handle_vec_simd_shri

2018-05-01 Thread Richard Henderson
The (size > 3 && !is_q) condition is identical to the preceeding test of bit 3 in immh; eliminate it. For the benefit of Coverity, assert that size is within the bounds we expect. Fixes: Coverity CID1385846 Fixes: Coverity CID1385849 Fixes: Coverity CID1385852 Fixes: Coverity CID1385857

Re: [Qemu-devel] [PATCH v2 0/4] vfio/quirks: ioeventfd support

2018-05-01 Thread Alex Williamson
On Tue, 1 May 2018 09:56:27 -0700 (PDT) no-re...@patchew.org wrote: > Hi, > > This series failed docker-build@min-glib build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > Type: series >

[Qemu-devel] [Bug 1768295] Re: VLLDM/VLSTM trigger UsageFault in the Secure Mode

2018-05-01 Thread Peter Maydell
Yes, you're right -- I hadn't noticed this wrinkle of the architecture. I'll put this on my todo list -- it should be straightforward. Do you have a convenient test binary that I could use as a test case? -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH 2/2] iotests: Test post-backing convert target behavior

2018-05-01 Thread Max Reitz
This adds a test case to 122 for what happens when you convert to a target with a backing file that is shorter than the target, and the image format does not support efficient zero writes (as is the case with qcow2 v2). Signed-off-by: Max Reitz --- tests/qemu-iotests/122

[Qemu-devel] [PATCH 1/2] qemu-img: Special post-backing convert handling

2018-05-01 Thread Max Reitz
Currently, qemu-img convert writes zeroes when it reads zeroes. Sometimes it does not because the target is initialized to zeroes anyway, so we do not need to overwrite (and thus potentially allocate) it. This is never the case for targets with backing files, though. But even them may have an

[Qemu-devel] [PATCH 0/2] qemu-img: Special post-backing convert handle

2018-05-01 Thread Max Reitz
This is the issue: $ qemu-img create -f qcow2 base.qcow2 512M Formatting 'base.qcow2', fmt=qcow2 size=536870912 cluster_size=65536 lazy_refcounts=off refcount_bits=16 $ qemu-img create -f qcow2 -b base.qcow2 source.qcow2 1G Formatting 'source.qcow2', fmt=qcow2 size=1073741824

Re: [Qemu-devel] [PATCH v2 0/4] vfio/quirks: ioeventfd support

2018-05-01 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180501162901.28940.1075.st...@gimli.home Subject: [Qemu-devel] [PATCH v2 0/4]

[Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-01 Thread Alex Williamson
With vfio ioeventfd support, we can program vfio-pci to perform a specified BAR write when an eventfd is triggered. This allows the KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding userspace handling for these events. On the same micro-benchmark where the ioeventfd got us to

[Qemu-devel] [PATCH v2 2/4] vfio/quirks: Add quirk reset callback

2018-05-01 Thread Alex Williamson
Quirks can be self modifying, provide a hook to allow them to cleanup on device reset if desired. Reviewed-by: Eric Auger Reviewed-by: Peter Xu Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 15 +++

[Qemu-devel] [PATCH v2 3/4] vfio/quirks: ioeventfd quirk acceleration

2018-05-01 Thread Alex Williamson
The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found in device MMIO space. Normally PCI config space is considered a slow path and further optimization is unnecessary, however NVIDIA uses a register here to enable the MSI interrupt to re-trigger. Exiting to QEMU for this MSI-ACK

[Qemu-devel] [PATCH v2 1/4] vfio/quirks: Add common quirk alloc helper

2018-05-01 Thread Alex Williamson
This will later be used to include list initialization. Reviewed-by: Eric Auger Reviewed-by: Peter Xu Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 48 +--- 1 file

[Qemu-devel] [PATCH v2 0/4] vfio/quirks: ioeventfd support

2018-05-01 Thread Alex Williamson
Now that vfio ioeventfd support is in v4.17-rc kernels, let's push forward with this series. I've posted the linux-headers update separate as it was rather an ordeal with conflicting defines, non- upstream defines, and inveted types that don't exist. Dependencies to build this series:

[Qemu-devel] [Bug 1768295] [NEW] VLLDM/VLSTM trigger UsageFault in the Secure Mode

2018-05-01 Thread YVT
Public bug reported: The VLLDM/VLSTM instructions trigger UsageFault when they are supposed to behave as NOP. Version: $ qemu-system-arm --version QEMU emulator version 2.11.93 VLLDM and VLSTM are instructions newly

[Qemu-devel] [PATCH 3/3] linux-headers: Update to v4.17-rc3

2018-05-01 Thread Alex Williamson
Run scripts/update-linux-headers.sh against v4.17-rc3 tag. Signed-off-by: Alex Williamson --- include/standard-headers/linux/ethtool.h| 36 ++ include/standard-headers/linux/input.h |4 include/standard-headers/linux/pci_regs.h |7

[Qemu-devel] [PATCH 1/3] virtio-gpu-3d: Define VIRTIO_GPU_CAPSET_VIRGL2 elsewhere

2018-05-01 Thread Alex Williamson
Commit 5643cc94ac1c ("virtio-gpu-3d: add support for second capability set (v4)") updated virtio_gpu.h with a define that does not yet(?) exist upstream resulting in build breakage every time Linux headers are updated via the standard update script. Conditionally define this within QEMU code

[Qemu-devel] [PATCH 0/3] Update linux-headers to v4.17-rc3

2018-05-01 Thread Alex Williamson
This series is based on Michael's series moving kvm_para.h out to standard headers, which resolves the conflict in definitions of KVM_HINTS_DEDICATED between QEMU and kernel. Additionally, this series moves the definition of VIRTIO_GPU_CAPSET_VIRGL2 into QEMU code as the definition does not exist

[Qemu-devel] [PATCH 2/3] scripts/update-linux-headers: Update handling of __aligned_u64

2018-05-01 Thread Alex Williamson
We'll currently replace any 'u64' with a 'uint64_t' including when it's embedded in an '__aligned_u64', creating a '__aligned_uint64_t' which doesn't exist. Add another sed entry to find these and convert them back to their original form. Signed-off-by: Alex Williamson

Re: [Qemu-devel] Introducing a nanoMIPS port for QEMU

2018-05-01 Thread Stefan Hajnoczi
On Tue, May 1, 2018 at 4:07 PM, Matthew Fortune wrote: > QEMU specific details > > > The nanoMIPS QEMU port borrows a significant amount of logic from the MIPS > port. Most instructions in nanoMIPS exist in one of the other MIPS ISAs, which > allows

[Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-01 Thread Auger Eric
Hi, I would like to resume the discussion on extending the number of PCI buses to 256 (as in Q35) as a follow-up of past discussions: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03631.html. With the current 16MB ECAM region we are limited to 16 PCIe busses. Could we envision to

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-05-01 Thread Cédric Le Goater
On 05/01/2018 08:39 AM, David Gibson wrote: > On Thu, Apr 26, 2018 at 09:20:11AM +0200, Cédric Le Goater wrote: >> On 04/26/2018 08:46 AM, David Gibson wrote: >>> On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: On 04/17/2018 09:17 AM, David Gibson wrote: > In

Re: [Qemu-devel] [PATCH] nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE

2018-05-01 Thread Vladimir Sementsov-Ogievskiy
01.05.2018 18:46, Eric Blake wrote: A missing space makes for poor error messages. Also, we missed diagnosing a server that sends a maximum block size less than the minimum. Fixes: 081dd1fe CC: qemu-sta...@nongnu.org Signed-off-by: Eric Blake Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH for 2.13] linux-user: introduce target_sigsp() and target_save_altstack()

2018-05-01 Thread Laurent Vivier
Le 11/04/2018 à 21:23, Laurent Vivier a écrit : > Signed-off-by: Laurent Vivier > --- > Based-on: <20180411185651.21351-1-laur...@vivier.eu> > "[PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c > to arch directories" This patch can be applied now on

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Auger Eric
Hi Peter, On 05/01/2018 05:00 PM, Peter Maydell wrote: > On 1 May 2018 at 15:32, Auger Eric wrote: >> Hi Peter, >> >> On 05/01/2018 12:19 PM, Peter Maydell wrote: >>> Add more detail to the documentation for memory_region_init_iommu() >>> and other IOMMU-related functions

[Qemu-devel] [PATCH] nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE

2018-05-01 Thread Eric Blake
A missing space makes for poor error messages. Also, we missed diagnosing a server that sends a maximum block size less than the minimum. Fixes: 081dd1fe CC: qemu-sta...@nongnu.org Signed-off-by: Eric Blake --- nbd/client.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

2018-05-01 Thread Alex Bennée
Richard Henderson writes: > When running the gcc testsuite with current aarch64-linux-user, > the testsuite detects the presence of the fp16 extension and > enables lots of extra tests for builtins. > > Quite a few of these new tests fail because we missed

Re: [Qemu-devel] [PATCH 2/2] iotests: Repairing error during snapshot deletion

2018-05-01 Thread Max Reitz
On 2018-04-30 18:01, Eric Blake wrote: > On 04/28/2018 11:34 AM, Max Reitz wrote: >> This adds a test for an I/O error during snapshot deletion, and maybe >> more importantly, for how to repair the resulting image.  If the >> snapshot has been deleted before the error occurs, the only negative >>

Re: [Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

2018-05-01 Thread Alex Bennée
Bastian Koppelmann writes: > this includes the Makefile and linker script to build all the tests. > > Signed-off-by: Bastian Koppelmann > --- > tests/tcg/tricore/Makefile | 30 +++ > tests/tcg/tricore/link.ld

Re: [Qemu-devel] [Bug 1768246] [NEW] cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-05-01 Thread Alex Bennée
John Paul Adrian Glaubitz writes: > Public bug reported: > > OpenJDK no longer works on qemu-sh4, it previously did after #1735384 > was fixed. > > Crash indicates an assertion failure: > > (sid-sh4-sbuild)root@nofan:/# java --version > qemu-sh4-static:

Re: [Qemu-devel] [PULL 0/4] M68k for 2.13 patches

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 14:55, Laurent Vivier wrote: > The following changes since commit c2c768500f17fc8cdcfa44d169f089953bb22748: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging > (2018-04-30 10:43:41 +0100) > > are

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-05-01 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:05:17PM +0200, Igor Mammedov wrote: > New option will be used to allow commands, which are prepared/need > to run, during preconfig state. Other commands that should be able > to run in preconfig state, should be ameded to not expect machine > in initialized state or

Re: [Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests

2018-05-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 2018050114.19154-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option

2018-05-01 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:05:15PM +0200, Igor Mammedov wrote: > This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, > allowing the configuration of QEMU from QMP before the machine jumps > into board initialization code of machine_run_board_init() > > The intent is to allow

[Qemu-devel] Introducing a nanoMIPS port for QEMU

2018-05-01 Thread Matthew Fortune
Earlier today MIPS Tech announced the latest generation of the MIPS family of architectures called nanoMIPS [1]. As part of the development we have been designing all the open source tools necessary to support the architecture and, thanks to the speed with which we were able to prototype, we have

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 15:32, Auger Eric wrote: > Hi Peter, > > On 05/01/2018 12:19 PM, Peter Maydell wrote: >> Add more detail to the documentation for memory_region_init_iommu() >> and other IOMMU-related functions and data structures. >> >> Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-05-01 Thread Igor Mammedov
On Fri, 27 Apr 2018 17:05:30 -0500 Eric Blake wrote: > On 04/27/2018 10:05 AM, Igor Mammedov wrote: > > New option will be used to allow commands, which are prepared/need > > to run, during preconfig state. Other commands that should be able > > to run in preconfig state,

Re: [Qemu-devel] [PATCH v3 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-05-01 Thread Balamuruhan S
Hi, Dave, David and Juan if you guys are okay with the patch, please help to merge it. Thanks, Bala On Wed, Apr 25, 2018 at 12:40:40PM +0530, Balamuruhan S wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining would yeild it correct. It

Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

2018-05-01 Thread Daniel P . Berrangé
On Tue, May 01, 2018 at 04:21:01PM +0200, Knut Omang wrote: > On Tue, 2018-05-01 at 15:07 +0100, Daniel P. Berrangé wrote: > > On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote: > > > Hi Peter, > > > > > > Seems this test was lost along the way? > > > > > > I thought it got merged with

Re: [Qemu-devel] [PATCH v2 1/1] memory.h: Improve IOMMU related documentation

2018-05-01 Thread Auger Eric
Hi Peter, On 05/01/2018 12:19 PM, Peter Maydell wrote: > Add more detail to the documentation for memory_region_init_iommu() > and other IOMMU-related functions and data structures. > > Signed-off-by: Peter Maydell > --- > v1 -> v2 changes: > * documented replay

[Qemu-devel] [RFC PATCH 12/12] tests/tcg/tricore: Add muls test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_muls.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_muls.S diff --git a/tests/tcg/tricore/Makefile

[Qemu-devel] [RFC PATCH 01/12] hw/tricore: Add testdevice for tests in tests/tcg/

2018-05-01 Thread Bastian Koppelmann
this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Signed-off-by: Bastian Koppelmann --- hw/tricore/Makefile.objs

[Qemu-devel] [RFC PATCH 07/12] tests/tcg/tricore: Add fadd test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_fadd.S | 16 2 files changed, 17 insertions(+) create mode 100644 tests/tcg/tricore/test_fadd.S diff --git a/tests/tcg/tricore/Makefile

[Qemu-devel] [RFC PATCH 10/12] tests/tcg/tricore: Add madd test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/macros.h| 18 ++ tests/tcg/tricore/test_madd.S | 11 +++ 3 files changed, 30 insertions(+) create mode 100644 tests/tcg/tricore/test_madd.S

[Qemu-devel] [RFC PATCH 00/12] tests/tcg: Add TriCore tests

2018-05-01 Thread Bastian Koppelmann
Hi Alex, I finally came around converting some of my TriCore regression tests into actual tests, that don't require the proprietary Infineon simulator. These tests are heavily inspired by the riscv-tests [1]. I add macros that allow easy testing of single asm instructions. e.g. for add %d1,

[Qemu-devel] [RFC PATCH 11/12] tests/tcg/tricore: Add msub test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_msub.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_msub.S diff --git a/tests/tcg/tricore/Makefile

[Qemu-devel] [RFC PATCH 09/12] tests/tcg/tricore: Add ftoi test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/macros.h| 7 +++ tests/tcg/tricore/test_ftoi.S | 10 ++ 3 files changed, 18 insertions(+) create mode 100644 tests/tcg/tricore/test_ftoi.S diff --git

[Qemu-devel] [RFC PATCH 06/12] tests/tcg/tricore: Add dvstep test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/macros.h | 29 - tests/tcg/tricore/test_dvstep.S | 15 +++ 3 files changed, 44 insertions(+), 1 deletion(-) create mode

[Qemu-devel] [RFC PATCH 04/12] tests/tcg/tricore: Add bmerge test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/macros.h | 24 tests/tcg/tricore/test_bmerge.S | 8 3 files changed, 33 insertions(+) create mode 100644

[Qemu-devel] [RFC PATCH 05/12] tests/tcg/tricore: Add clz test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile | 1 + tests/tcg/tricore/test_clz.S | 9 + 2 files changed, 10 insertions(+) create mode 100644 tests/tcg/tricore/test_clz.S diff --git a/tests/tcg/tricore/Makefile

[Qemu-devel] [RFC PATCH 08/12] tests/tcg/tricore: Add fmul test

2018-05-01 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile| 1 + tests/tcg/tricore/test_fmul.S | 8 2 files changed, 9 insertions(+) create mode 100644 tests/tcg/tricore/test_fmul.S diff --git a/tests/tcg/tricore/Makefile

[Qemu-devel] [RFC PATCH 03/12] tests/tcg/tricore: Add macros to easily create tests and first test 'abs'

2018-05-01 Thread Bastian Koppelmann
This kind of tests is inspired by the riscv-tests repository. This adds macros that makes it easy to create single instruction self containing tests. This is achieved by macros that create a test sequence for an instruction and check for a supplied correct value. If the value is correct the next

  1   2   >