On 17 July 2012 20:24, Stefan Weil s...@weilnetz.de wrote:
The arguments why -Werror is a bad idea for some configure tests
are reasonable.
Nevertheless the QEMU community was able to produce thousands of
lines of code which compile without a warning, so we should be able
to create warning
Am 17.07.2012 21:24, schrieb Peter Maydell:
Don't run configure tests with -Werror in the compiler flags. The idea
of -Werror is that it makes problems very obvious to developers, so
they get fixed quickly. However, when running configure tests, failures
due to -Werror are far from obvious --
On 17.07.2012, at 21:24, Peter Maydell wrote:
Don't run configure tests with -Werror in the compiler flags. The idea
of -Werror is that it makes problems very obvious to developers, so
they get fixed quickly. However, when running configure tests, failures
due to -Werror are far from obvious
Am 17.07.2012 21:28, schrieb Peter Maydell:
On 17 July 2012 20:24, Stefan Weil s...@weilnetz.de wrote:
The arguments why -Werror is a bad idea for some configure tests
are reasonable.
Nevertheless the QEMU community was able to produce thousands of
lines of code which compile without a
Hi,
On Monday, July 16, 2012 12:07:58 PM Stefan Hajnoczi wrote:
On Sun, Jul 15, 2012 at 03:49:13PM +0200, Stefan Weil wrote:
One of the buildbot jobs should be configured with all sound options:
--audio-card-list¬97,es1370,sb16,cs4231a,adlib,gus,hda
--audio-drv-list=alsa,sdl,oss,esd,pa
On Sun, Jul 15, 2012 at 03:49:13PM +0200, Stefan Weil wrote:
One of the buildbot jobs should be configured with all sound options:
--audio-card-list=ac97,es1370,sb16,cs4231a,adlib,gus,hda
--audio-drv-list=alsa,sdl,oss,esd,pa
--enable-mixemu
That would have detected this bug (and more
On Sun, Jul 15, 2012 at 09:38:25PM +0200, Laszlo Ersek wrote:
... after commit 417c9d72 (configure: add -Werror to QEMU_CFLAGS early)
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial
On 07/15/2012 07:54 AM, Stefan Weil wrote:
Since commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests
normally run with -Werror. Some of these tests now fail because they
raised a compiler warning.
This patch fixes support for capabilities.
Signed-off-by: Stefan Weil
On 07/15/2012 01:54 PM, Stefan Weil wrote:
Am 15.07.2012 22:26, schrieb Mike Frysinger:
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from how we treat all other toolchain
On 16 July 2012 16:35, Eric Blake ebl...@redhat.com wrote:
On 07/15/2012 07:54 AM, Stefan Weil wrote:
Since commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests
normally run with -Werror. Some of these tests now fail because they
raised a compiler warning.
Nothing wrong with
Am 16.07.2012 17:39, schrieb Eric Blake:
On 07/15/2012 01:54 PM, Stefan Weil wrote:
Am 15.07.2012 22:26, schrieb Mike Frysinger:
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from
On 07/16/2012 05:40 PM, Peter Maydell wrote:
On 16 July 2012 16:35, Eric Blake ebl...@redhat.com wrote:
On 07/15/2012 07:54 AM, Stefan Weil wrote:
Since commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests
normally run with -Werror. Some of these tests now fail because they
On 16 July 2012 18:24, Alexander Graf ag...@suse.de wrote:
On 07/16/2012 05:40 PM, Peter Maydell wrote:
Hmm, good point -- unlike the actual program compile, failures
due to -Werror inside configure are silent and near-invisible.
Maybe we should back out 417c9d72 ?
So how do we deal with the
On 16.07.2012, at 20:28, Peter Maydell wrote:
On 16 July 2012 18:24, Alexander Graf ag...@suse.de wrote:
On 07/16/2012 05:40 PM, Peter Maydell wrote:
Hmm, good point -- unlike the actual program compile, failures
due to -Werror inside configure are silent and near-invisible.
Maybe we should
Since commit 417c9d72d48275d19c60861896efd4962d21aca2,
all configure tests normally run with -Werror.
Some of these tests now fail because they raised a compiler warning.
Here a build breakage for ALSA (configure --audio-drv-list=alsa) is fixed.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
Since commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests
normally run with -Werror. Some of these tests now fail because they
raised a compiler warning.
This patch fixes support for capabilities.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |2 +-
1 file
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from how we treat all other toolchain variables
that we get from the environment.
Ultimately, the point is that it breaks passing custom
... after commit 417c9d72 (configure: add -Werror to QEMU_CFLAGS early)
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 0a3896e..8a1b902 100755
--- a/configure
+++ b/configure
@@
Am 15.07.2012 22:26, schrieb Mike Frysinger:
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from how we treat all other toolchain variables
that we get from the environment.
On Sunday 15 July 2012 15:54:51 Stefan Weil wrote:
Am 15.07.2012 22:26, schrieb Mike Frysinger:
We should not quote the PKG_CONFIG setting as this deviates from the
canonical upstream behavior that gets integrated with all other build
systems, and deviates from how we treat all other
When just calling ./configure on my box, I always ran into the same issue:
In file included from /usr/include/nss3/pkcs11t.h:1780,
from /usr/include/nss3/keythi.h:41,
from /usr/include/nss3/keyt.h:41,
from /usr/include/nss3/pk11pub.h:43,
Am 09.07.2012 14:06, schrieb Alexander Graf:
When just calling ./configure on my box, I always ran into the same issue:
In file included from /usr/include/nss3/pkcs11t.h:1780,
from /usr/include/nss3/keythi.h:41,
from /usr/include/nss3/keyt.h:41,
On 07/09/12 14:06, Alexander Graf wrote:
When just calling ./configure on my box, I always ran into the same issue:
In file included from /usr/include/nss3/pkcs11t.h:1780,
from /usr/include/nss3/keythi.h:41,
from /usr/include/nss3/keyt.h:41,
On 09.07.2012, at 15:29, Gerd Hoffmann wrote:
On 07/09/12 14:06, Alexander Graf wrote:
When just calling ./configure on my box, I always ran into the same issue:
In file included from /usr/include/nss3/pkcs11t.h:1780,
from /usr/include/nss3/keythi.h:41,
We want all configure tests pass with -Werror if it is enabled. So we
need to update QEMU_CFLAGS early on to make sure we also pass it in to
all the compile test jobs.
This fixes a warning-became-error bug in nss for me with the default
configuration:
In file included from
On 07/09/12 14:23, Alexander Graf wrote:
We want all configure tests pass with -Werror if it is enabled. So we
need to update QEMU_CFLAGS early on to make sure we also pass it in to
all the compile test jobs.
Much better than v1
Acked-by: Gerd Hoffmann kra...@redhat.com
cheers,
Gerd
On Thu, Jun 28, 2012 at 05:56:37PM +0200, Stefan Weil wrote:
Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these
configure arguments. Now the help text for both is removed, too.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |2 --
1 file changed, 2 deletions(-)
Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these
configure arguments. Now the help text for both is removed, too.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |2 --
1 file changed, 2 deletions(-)
diff --git a/configure b/configure
index 1459c52..c3e09fc 100755
---
On 06/06/2012 04:03 AM, Avi Kivity wrote:
Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE;
so disable _FORTIFY_SOURCE when debugging.
Signed-off-by: Avi Kivitya...@redhat.com
Applied. Thanks.
Regards,
Anthony Liguori
---
configure |3 +--
1 file changed, 1
The typo did not cause an error because open_by_handle_at
was only compared to yes.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5d73c82..20a0fd3 100755
--- a/configure
+++ b/configure
Fixes build against uClibc.
uClibc provides 2 versions of clock_gettime(), one with realtime
support and one without (this is so you can avoid linking in -lrt
unless actually needed). This means that the clock_gettime() don't
need -lrt. We still need it for timer_create() so we check for this
On Fri, 8 Jun 2012, Stefano Stabellini wrote:
On Thu, 7 Jun 2012, Stefan Weil wrote:
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
Extend the check in configure to test both preconditions.
Signed-off-by: Stefan Weil s...@weilnetz.de
I have just noticed that
On Wed, Jun 06, 2012 at 12:03:18PM +0300, Avi Kivity wrote:
Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE;
so disable _FORTIFY_SOURCE when debugging.
Signed-off-by: Avi Kivity a...@redhat.com
I was bitten by this problem too. The patch fixes it for me.
Tested-by:
On Thu, 7 Jun 2012, Stefan Weil wrote:
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
Extend the check in configure to test both preconditions.
Signed-off-by: Stefan Weil s...@weilnetz.de
I have just noticed that this issue also affects QEMU 1.0.x, but we
don't have
On Thu, 7 Jun 2012, Stefan Weil wrote:
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
Extend the check in configure to test both preconditions.
Signed-off-by: Stefan Weil s...@weilnetz.de
It works for me. Also I think it is a better fix than the original
patch.
Quoting Stefano Stabellini (stefano.stabell...@eu.citrix.com):
On Thu, 7 Jun 2012, Stefan Weil wrote:
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
Extend the check in configure to test both preconditions.
Signed-off-by: Stefan Weil s...@weilnetz.de
It works
Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE;
so disable _FORTIFY_SOURCE when debugging.
Signed-off-by: Avi Kivity a...@redhat.com
---
configure |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configure b/configure
index 1f338f8..88d9c5b 100755
On 6 June 2012 10:03, Avi Kivity a...@redhat.com wrote:
Fedora 17's toolchain wants optimization enabled for _FORTIFY_SOURCE;
so disable _FORTIFY_SOURCE when debugging.
Well, that sucks, but it seems to be a deliberate change in
upstream glibc to make it warn now :-( I guess everybody
in the
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
Extend the check in configure to test both preconditions.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |4
1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index 799ad0f..f737f6c
On Thu, Apr 26, 2012 at 09:57, Andreas Färber andreas.faer...@web.de wrote:
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Bernhard Walle bernh...@bwalle.de
On 2012-04-25 14:20:12 -0500, Anthony Liguori wrote:
On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp
This broke the build:
http://spunk.home.kraxel.org/bb/builders/ubuntu-default/builds/52
It turned out that
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Bernhard Walle bernh...@bwalle.de
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Am 26.04.12 11:57, schrieb Andreas Färber:
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Bernhard Walle bernh...@bwalle.de
Thanks. I already stumbled over
Am 26.04.2012 12:30, schrieb Bernhard Walle:
Am 26.04.12 11:57, schrieb Andreas Färber:
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Bernhard Walle
On 2012-04-25 14:20:12 -0500, Anthony Liguori wrote:
On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp
This broke the build:
http://spunk.home.kraxel.org/bb/builders/ubuntu-default/builds/52
I cannot see IPv6
On 04/26/12 14:59, Kusanagi Kouichi wrote:
On 2012-04-25 14:20:12 -0500, Anthony Liguori wrote:
On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp
This broke the build:
Am 26.04.12 11:57, schrieb Andreas Färber:
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Bernhard Walle bernh...@bwalle.de
Tested-by: Bernhard Walle
Am 26.04.12 14:50, schrieb Andreas Färber:
Am 26.04.2012 12:30, schrieb Bernhard Walle:
Thanks. I already stumbled over this when trying to test your
uint16 fixes (they work for me, BTW).
In that case please add an appropriate tag (e.g., Tested-by) as reply
there (best with info on what
On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp
This broke the build:
http://spunk.home.kraxel.org/bb/builders/ubuntu-default/builds/52
Since the improve seems to be purely cosmetic, I'm going to revert this
On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichisl...@ac.auone-net.jp
Applied. Thanks.
Regards,
Anthony Liguori
---
configure |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index
Il 22/04/2012 12:16, Kusanagi Kouichi ha scritto:
Only proxy helper does.
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
---
configure |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 2d62d12..c8e6fe4 100755
--- a/configure
Only proxy helper does.
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
---
configure |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 2d62d12..c8e6fe4 100755
--- a/configure
+++ b/configure
@@ -2860,9 +2860,11 @@ tools=
if test
On 04/05/12 13:01, Paolo Bonzini wrote:
These are pretty sane requirements to move forward with glib usage.
2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
first version to support g_poll. Without g_poll, we cannot
integrate well with the glib main loop.
We have a glib-related
On 16 April 2012 12:08, Gerd Hoffmann kra...@redhat.com wrote:
On 04/05/12 13:01, Paolo Bonzini wrote:
These are pretty sane requirements to move forward with glib usage.
2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
first version to support g_poll. Without g_poll, we cannot
On Mon, Apr 16, 2012 at 01:08:01PM +0200, Gerd Hoffmann wrote:
On 04/05/12 13:01, Paolo Bonzini wrote:
These are pretty sane requirements to move forward with glib usage.
2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
first version to support g_poll. Without g_poll, we cannot
Our Python scripts require Python 2 and will fail on Python 3, eg:
File /home/petmay01/linaro/qemu-from-laptop/qemu/scripts/qapi-commands.py,
line 378
except getopt.GetoptError, err:
^
SyntaxError: invalid syntax
Add a check to configure that Python is
Peter Maydell peter.mayd...@linaro.org wrote:
Remove some useless uses of ARCH_CFLAGS -- this variable was never set
so will always be empty. The uses were accidental: in commit 0c439cbf8
Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
became QEMU_CFLAGS). However in
On Wed, Apr 04, 2012 at 05:03:15PM +0100, Peter Maydell wrote:
Remove some useless uses of ARCH_CFLAGS -- this variable was never set
so will always be empty. The uses were accidental: in commit 0c439cbf8
Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
became QEMU_CFLAGS).
On Thu, Apr 5, 2012 at 11:01, Paolo Bonzini pbonz...@redhat.com wrote:
These are pretty sane requirements to move forward with glib usage.
2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
first version to support g_poll. Without g_poll, we cannot
integrate well with the glib main
#abort is not a preprocessor statement. It aborts, but the preprocessor
statement #error is more common to abort a compilation.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index
Am 04.04.2012 18:03, schrieb Peter Maydell:
Remove some useless uses of ARCH_CFLAGS -- this variable was never set
so will always be empty. The uses were accidental: in commit 0c439cbf8
Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
became QEMU_CFLAGS). However in commit
These are pretty sane requirements to move forward with glib usage.
2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
first version to support g_poll. Without g_poll, we cannot
integrate well with the glib main loop.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure |
Remove some useless uses of ARCH_CFLAGS -- this variable was never set
so will always be empty. The uses were accidental: in commit 0c439cbf8
Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
became QEMU_CFLAGS). However in commit be17dc90 a use of it was
reintroduced
It's typical to prepend or append parameters to an argument string so
that other places in ./configure can add parameters without clobbering
the string. In the mingw32 libs_qga case there is a typo $lib_qga
instead of $libs_qga.
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
Am 27.03.2012 09:26, schrieb Stefan Hajnoczi:
It's typical to prepend or append parameters to an argument string so
that other places in ./configure can add parameters without clobbering
the string. In the mingw32 libs_qga case there is a typo $lib_qga
instead of $libs_qga.
Signed-off-by:
On Tue, Mar 27, 2012 at 08:26:18AM +0100, Stefan Hajnoczi wrote:
It's typical to prepend or append parameters to an argument string so
that other places in ./configure can add parameters without clobbering
the string. In the mingw32 libs_qga case there is a typo $lib_qga
instead of $libs_qga.
The MinGW toolchain on w32/w64 hosts does not create symbolic links,
but implements 'ln -s' similar to 'cp -r'.
In incremental out of tree builds, this resulted in files which
were not updated when their counterparts in the QEMU source tree
changed. Especially for Makefile* this happened very
On 17 March 2012 15:31, Stefan Weil s...@weilnetz.de wrote:
Macro symlink is also used with directories. To remove them on w32
hosts, a recursive rm is needed.
Where do we symlink directories? (I exclude the setting up
of the linux headers because that will only happen on Linux
hosts where we
Am 17.03.2012 16:49, schrieb Peter Maydell:
On 17 March 2012 15:31, Stefan Weils...@weilnetz.de wrote:
Macro symlink is also used with directories. To remove them on w32
hosts, a recursive rm is needed.
Where do we symlink directories? (I exclude the setting up
of the linux headers because
On 17 March 2012 15:59, Stefan Weil s...@weilnetz.de wrote:
Am 17.03.2012 16:49, schrieb Peter Maydell:
Where do we symlink directories? (I exclude the setting up
of the linux headers because that will only happen on Linux
hosts where we know we have working symlinks.)
pc-bios/keymaps
Oh
From: Stuart Yoder stuart.yo...@freescale.com
Previous check in configure's endian test was to determine if
this is a cross-compile build by testing whether --cross-prefix
was used. This does not work for cross build environments
like Yocto that may set CC instead of --cross-prefix.
From: Stuart Yoder stuart.yo...@freescale.com
Previous check in configure's endian test was to determine if
this is a cross-compile build by testing whether --cross-prefix
was used. This does not work for cross build environments
like Yocto that may set CC instead of --cross-prefix.
Instead,
2012/3/14 Paul Brook p...@codesourcery.com:
From: Stuart Yoder stuart.yo...@freescale.com
Previous check in configure's endian test was to determine if
this is a cross-compile build by testing whether --cross-prefix
was used. This does not work for cross build environments
like Yocto that
[added qemu-devel back again]
On 14 March 2012 17:51, Stuart Yoder b08...@gmail.com wrote:
On Wed, Mar 14, 2012 at 12:17 PM, Peter Maydell
peter.mayd...@linaro.org wrote:
Agreed. I think looking at the host CPUs we support the only ones
that aren't guaranteed either big or little endian are
Am 14.03.2012 19:09, schrieb Peter Maydell:
[added qemu-devel back again]
On 14 March 2012 17:51, Stuart Yoderb08...@gmail.com wrote:
On Wed, Mar 14, 2012 at 12:17 PM, Peter Maydell
peter.mayd...@linaro.org wrote:
Agreed. I think looking at the host CPUs we support the only ones
that aren't
Thanks, applied.
On Sat, Mar 10, 2012 at 10:14, Stefan Weil s...@weilnetz.de wrote:
MinGW-w64 and some versions of MinGW32 don't provide libiberty.a,
so add this library only if it was found.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure | 8 +++-
1 files changed, 7
MinGW-w64 and some versions of MinGW32 don't provide libiberty.a,
so add this library only if it was found.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index ca25250..bb16498
Am 10.03.2012 11:14, schrieb Stefan Weil:
MinGW-w64 and some versions of MinGW32 don't provide libiberty.a,
so add this library only if it was found.
What do we need it for at all then?
Andreas
Signed-off-by: Stefan Weil s...@weilnetz.de
---
configure |8 +++-
1 files changed, 7
Am 10.03.2012 17:28, schrieb Andreas Färber:
Am 10.03.2012 11:14, schrieb Stefan Weil:
MinGW-w64 and some versions of MinGW32 don't provide libiberty.a,
so add this library only if it was found.
What do we need it for at all then?
Andreas
Signed-off-by: Stefan Weil s...@weilnetz.de
---
On 8 February 2012 15:22, Gerd Hoffmann kra...@redhat.com wrote:
On 02/08/12 01:17, Rusty Russell wrote:
As featured on:
https://bugs.launchpad.net/qemu-linaro/+bug/928432
Since we compile with -Werror, the presence of spice headers breaks
compile. Yet except for x86-64, it doesn't
On 03/07/12 11:30, Peter Maydell wrote:
On 8 February 2012 15:22, Gerd Hoffmann kra...@redhat.com wrote:
On 02/08/12 01:17, Rusty Russell wrote:
As featured on:
https://bugs.launchpad.net/qemu-linaro/+bug/928432
Since we compile with -Werror, the presence of spice headers breaks
On 7 March 2012 11:38, Gerd Hoffmann kra...@redhat.com wrote:
On 03/07/12 11:30, Peter Maydell wrote:
Ping -- there seem to have been a couple of spice patch queue
pulls since but did this warning fix patch get lost?
commit f4a8a424fceb0f79bbd9f7ae4285c8a58eb5598e
Yeah, I just spotted this,
Use the same mechanism we use for printing the configure command
line to config-host.mak to print it to config.log. This fixes a
bug where the config.log version didn't quote arguments with spaces.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
If I'd noticed when I was adding the
On 7 March 2012 11:38, Gerd Hoffmann kra...@redhat.com wrote:
But it still doesn't build indeed.
Looks like new warnings sneaked in ...
Actually I get an outright compile error:
CCui/spice-display.o
ui/spice-display.c: In function ‘qemu_spice_add_memslot’:
ui/spice-display.c:79:42:
On Wed, Mar 7, 2012 at 12:16 PM, Peter Maydell peter.mayd...@linaro.org wrote:
Use the same mechanism we use for printing the configure command
line to config-host.mak to print it to config.log. This fixes a
bug where the config.log version didn't quote arguments with spaces.
Signed-off-by:
Hi,
git bisect blames commit 2e1a98c9c qxl: introduce QXLCookie.
Do we need a preprocessor guard so we don't try to use these
if the host's spice headers don't support them?
(My host is Ubuntu Oneiric with libspice-server-dev 0.8.2-2
and spice-protocol-dev 0.8.0-0ubuntu1.)
Hmm,
On Wed, Mar 07, 2012 at 01:43:36PM +0100, Gerd Hoffmann wrote:
Hi,
git bisect blames commit 2e1a98c9c qxl: introduce QXLCookie.
Do we need a preprocessor guard so we don't try to use these
if the host's spice headers don't support them?
(My host is Ubuntu Oneiric with
On 7 March 2012 13:01, Alon Levy al...@redhat.com wrote:
diff --git a/configure b/configure
index a5eb832..ecdfe9a 100755
--- a/configure
+++ b/configure
@@ -2544,6 +2544,7 @@ EOF
spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2/dev/null)
spice_libs=$($pkg_config
On 03/07/2012 05:40 AM, Stefan Hajnoczi wrote:
On Wed, Mar 7, 2012 at 12:16 PM, Peter Maydell peter.mayd...@linaro.org
wrote:
Use the same mechanism we use for printing the configure command
line to config-host.mak to print it to config.log. This fixes a
bug where the config.log version
On 7 March 2012 17:06, Eric Blake ebl...@redhat.com wrote:
# Print a helpful header at the top of config.log
echo # QEMU configure log $(date) config.log
-echo # produced by $0 $* config.log
This left a trailing newline,
+printf # Configured with: config.log
+printf '%s' $0 $@
On 7 March 2012 12:40, Stefan Hajnoczi stefa...@gmail.com wrote:
+printf # Configured with: config.log
+printf '%s' $0 $@ config.log
You use an interesting feature of printf(1)- it applies the (short)
format string as long as there are arguments. I checked that this is
in the
On 03/07/2012 02:16 PM, Peter Maydell wrote:
Use the same mechanism we use for printing the configure command
line to config-host.mak to print it to config.log. This fixes a
bug where the config.log version didn't quote arguments with spaces.
# Print a helpful header at the top of
On 03/07/2012 10:08 AM, Peter Maydell wrote:
If you look at the whole change, rather than just the
fragment Stefan quoted to comment on:
# Print a helpful header at the top of config.log
echo # QEMU configure log $(date) config.log
-echo # produced by $0 $* config.log
+printf #
On 7 March 2012 17:14, Avi Kivity a...@redhat.com wrote:
This still breaks if an argument has a single quote. bash's printf's %q
deals with this correctly, but not sure how portable it is.
True, but we've lived with it for the code that writes to config-host.mak
since 2008 (commit fd69fe2b)...
On 02/23/2012 10:20 AM, Peter Maydell wrote:
On some systems (notably ARM Linux) glibc provides implementations
of makecontext(), getcontext() and friends which are stubs which
always return failure. Make the configure test for makecontext()
also check for the presence of the __stub_makecontext
Improve the configure test for presence of ucontext functions by
making linker warnings fatal; this allows us to detect when we are
linked with a glibc which implements makecontext() to always return
ENOSYS.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
Compiling on an Ubuntu Natty
On 23 February 2012 16:16, Peter Maydell peter.mayd...@linaro.org wrote:
Improve the configure test for presence of ucontext functions by
making linker warnings fatal; this allows us to detect when we are
linked with a glibc which implements makecontext() to always return
ENOSYS.
Er, ignore
On some systems (notably ARM Linux) glibc provides implementations
of makecontext(), getcontext() and friends which are stubs which
always return failure. Make the configure test for makecontext()
also check for the presence of the __stub_makecontext macro which
indicates the presence of these
On 02/10/2012 02:59 PM, Brad Smith wrote:
Remove the OpenBSD workaround for the curses probe. This has not been
necessary for 5 releases now.
Signed-off-by: Brad Smithb...@comstyle.com
Applied. Thanks.
Regards,
Anthony Liguori
diff --git a/configure b/configure
index 763db24..c9729f8
Remove the OpenBSD workaround for the curses probe. This has not been
necessary for 5 releases now.
Signed-off-by: Brad Smith b...@comstyle.com
diff --git a/configure b/configure
index 763db24..c9729f8 100755
--- a/configure
+++ b/configure
@@ -1900,9 +1900,6 @@ if test $curses != no ; then
901 - 1000 of 1161 matches
Mail list logo
