Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 12:49:31PM +0200, Peter Lieven wrote: > this adds the proposed solution to add a generic mechanism to zeroize > a target in qemu-img if it has discard_zeroes but has_zero_init is 0. > > Peter Lieven (4): > block: add discard_zeroes and max_unmap to BlockDriverInfo > isc

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 17:12 schrieb Kevin Wolf : > Am 17.07.2013 um 16:53 hat Paolo Bonzini geschrieben: >> Il 17/07/2013 16:46, Peter Lieven ha scritto: >>> >>> Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : >>> Il 17/07/2013 16:18, Peter Lieven ha scritto: > That would be ok if the p

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 16:53 schrieb Paolo Bonzini : > Il 17/07/2013 16:46, Peter Lieven ha scritto: >> >> Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : >> >>> Il 17/07/2013 16:18, Peter Lieven ha scritto: That would be ok if the patches are merged first. Otherwise I could ask Ke

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Kevin Wolf
Am 17.07.2013 um 16:53 hat Paolo Bonzini geschrieben: > Il 17/07/2013 16:46, Peter Lieven ha scritto: > > > > Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : > > > >> Il 17/07/2013 16:18, Peter Lieven ha scritto: > >>> That would be ok if the patches are merged first. Otherwise I could >

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 16:46, Peter Lieven ha scritto: > > Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : > >> Il 17/07/2013 16:18, Peter Lieven ha scritto: >>> That would be ok if the patches are merged first. Otherwise I could ask >>> Kevin >>> to merge my old series (except the iscsi_co_wr

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 16:26 schrieb Paolo Bonzini : > Il 17/07/2013 16:18, Peter Lieven ha scritto: >> That would be ok if the patches are merged first. Otherwise I could ask >> Kevin >> to merge my old series (except the iscsi_co_write_zeroes patch as there >> obviously is still room

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 16:18, Peter Lieven ha scritto: >>> >> That would be ok if the patches are merged first. Otherwise I could ask >>> >> Kevin >>> >> to merge my old series (except the iscsi_co_write_zeroes patch as there >>> >> obviously is still room for discussion and improvement) and you could >>>

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 12:50 schrieb Paolo Bonzini : > Il 17/07/2013 12:40, Peter Lieven ha scritto: >> >> Am 17.07.2013 um 12:28 schrieb Paolo Bonzini : >> >>> Il 17/07/2013 12:23, Peter Lieven ha scritto: Am 16.07.2013 um 13:55 schrieb Paolo Bonzini : > Il 16/07/2013 13:40, Pe

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 12:40, Peter Lieven ha scritto: > > Am 17.07.2013 um 12:28 schrieb Paolo Bonzini : > >> Il 17/07/2013 12:23, Peter Lieven ha scritto: >>> >>> Am 16.07.2013 um 13:55 schrieb Paolo Bonzini : >>> Il 16/07/2013 13:40, Peter Lieven ha scritto: > > The conflict with your bloc

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 17.07.2013 um 12:28 schrieb Paolo Bonzini : > Il 17/07/2013 12:23, Peter Lieven ha scritto: >> >> Am 16.07.2013 um 13:55 schrieb Paolo Bonzini : >> >>> Il 16/07/2013 13:40, Peter Lieven ha scritto: The conflict with your block status patches can't be large. upstream/master ha

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Paolo Bonzini
Il 17/07/2013 12:23, Peter Lieven ha scritto: > > Am 16.07.2013 um 13:55 schrieb Paolo Bonzini : > >> Il 16/07/2013 13:40, Peter Lieven ha scritto: >>> >>> The conflict with your block status patches can't be large. >>> upstream/master has no >>> iscsi_co_is_allocated yet, so there should be no t

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread Peter Lieven
Am 16.07.2013 um 13:55 schrieb Paolo Bonzini : > Il 16/07/2013 13:40, Peter Lieven ha scritto: >> >> The conflict with your block status patches can't be large. >> upstream/master has no >> iscsi_co_is_allocated yet, so there should be no trouble. > > Yes, whoever goes second has to change it t

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:40, Peter Lieven ha scritto: > > The conflict with your block status patches can't be large. > upstream/master has no > iscsi_co_is_allocated yet, so there should be no trouble. Yes, whoever goes second has to change it to the new get_block_status API. Kevin and Stefan can decid

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Peter Lieven
On 16.07.2013 13:27, Paolo Bonzini wrote: Il 16/07/2013 13:18, Peter Lieven ha scritto: Looks good. Perhaps, as a followup, you can use max_unmap (which I'd rename to max_discard) in bdrv_co_discard to support splitting the request. You could also export the discard alignment in BlockDriverInf

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 13:18, Peter Lieven ha scritto: >> Looks good. Perhaps, as a followup, you can use max_unmap (which I'd >> rename to max_discard) in bdrv_co_discard to support splitting the >> request. You could also export the discard alignment in BlockDriverInfo. > I already did this in my previo

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Peter Lieven
On 16.07.2013 12:55, Paolo Bonzini wrote: Il 15/07/2013 12:49, Peter Lieven ha scritto: this adds the proposed solution to add a generic mechanism to zeroize a target in qemu-img if it has discard_zeroes but has_zero_init is 0. Peter Lieven (4): block: add discard_zeroes and max_unmap to Blo

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-16 Thread Paolo Bonzini
Il 15/07/2013 12:49, Peter Lieven ha scritto: > this adds the proposed solution to add a generic mechanism to zeroize > a target in qemu-img if it has discard_zeroes but has_zero_init is 0. > > Peter Lieven (4): > block: add discard_zeroes and max_unmap to BlockDriverInfo > iscsi: add .bdrv_ge

[Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-15 Thread Peter Lieven
this adds the proposed solution to add a generic mechanism to zeroize a target in qemu-img if it has discard_zeroes but has_zero_init is 0. Peter Lieven (4): block: add discard_zeroes and max_unmap to BlockDriverInfo iscsi: add .bdrv_get_info block/raw: add .bdrv_get_info qemu-img: conditi