Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2011-01-02 Thread Aurelien Jarno
On Sun, Jan 02, 2011 at 11:12:32AM +, Peter Maydell wrote: > On 2 January 2011 10:31, Aurelien Jarno wrote: > > On Sat, Jan 01, 2011 at 11:46:16PM +, Peter Maydell wrote: > >> Can it be applied please? (cc'd Aurelien since you seem to be > >> committing various missed patches at the moment

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2011-01-02 Thread Peter Maydell
On 2 January 2011 10:31, Aurelien Jarno wrote: > On Sat, Jan 01, 2011 at 11:46:16PM +, Peter Maydell wrote: >> Can it be applied please? (cc'd Aurelien since you seem to be >> committing various missed patches at the moment :-)) > > Sorry, I understood there was a conflict with another patch s

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2011-01-02 Thread Aurelien Jarno
On Sat, Jan 01, 2011 at 11:46:16PM +, Peter Maydell wrote: > On 17 December 2010 15:56, Peter Maydell wrote: > > The softfloat functions float*_is_nan() were badly misnamed, > > because they return true only for quiet NaNs, not for all NaNs. > > Rename them to float*_is_quiet_nan() to more acc

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2011-01-01 Thread Andreas Färber
Am 02.01.2011 um 00:46 schrieb Peter Maydell: On 17 December 2010 15:56, Peter Maydell wrote: The softfloat functions float*_is_nan() were badly misnamed, because they return true only for quiet NaNs, not for all NaNs. Rename them to float*_is_quiet_nan() to more accurately reflect what they

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2011-01-01 Thread Peter Maydell
On 17 December 2010 15:56, Peter Maydell wrote: > The softfloat functions float*_is_nan() were badly misnamed, > because they return true only for quiet NaNs, not for all NaNs. > Rename them to float*_is_quiet_nan() to more accurately reflect > what they do. > > This change was produced by: >  per

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread malc
On Sat, 18 Dec 2010, Andreas F?rber wrote: > Am 18.12.2010 um 11:39 schrieb Peter Maydell: > > > On 18 December 2010 02:30, Nathan Froyd wrote: > > > I wouldn't be too worried: > > > > > > typedef uint8_t flag; > > > typedef uint8_t uint8; > > > typedef int8_t int8; > > > typedef int uint16; >

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 13:31 schrieb Andreas Färber: Am 18.12.2010 um 13:15 schrieb Peter Maydell: On 18 December 2010 11:49, Andreas Färber wrote: IMO a lot of code in QEMU is cryptic because someone thinks that someone else must've thought something particular when doing it that way and is t

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Nathan Froyd
On Sat, Dec 18, 2010 at 10:39:05AM +, Peter Maydell wrote: > On 18 December 2010 02:30, Nathan Froyd wrote: > > So adding _t suffixes in appropriate places should be a no-op, except > > for uint16/int16--and those types are never used. > > Eh? If you comment out the int16 typedef you'll find

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 13:15 schrieb Peter Maydell: On 18 December 2010 11:49, Andreas Färber wrote: IMO a lot of code in QEMU is cryptic because someone thinks that someone else must've thought something particular when doing it that way and is thus reluctant to touch it... For a fact, [u]i

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Peter Maydell
On 18 December 2010 11:49, Andreas Färber wrote: > IMO a lot of code in QEMU is cryptic because someone thinks that someone > else must've thought something particular when doing it that way and is thus > reluctant to touch it... > For a fact, [u]int8 und [u]int64 remain unchanged width-wise. > F

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 11:39 schrieb Peter Maydell: On 18 December 2010 02:30, Nathan Froyd wrote: I wouldn't be too worried: typedef uint8_t flag; typedef uint8_t uint8; typedef int8_t int8; typedef int uint16; typedef int int16; typedef unsigned int uint32; typedef signed int int32; typedef uint

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Peter Maydell
On 18 December 2010 02:30, Nathan Froyd wrote: > I wouldn't be too worried: > > typedef uint8_t flag; > typedef uint8_t uint8; > typedef int8_t int8; > typedef int uint16; > typedef int int16; > typedef unsigned int uint32; > typedef signed int int32; > typedef uint64_t uint64; > typedef int64_t i

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Nathan Froyd
On Fri, Dec 17, 2010 at 11:32:03PM +, Peter Maydell wrote: > On 17 December 2010 17:54, Andreas Färber wrote: > > My patch does not touch the bits* types. I didn't notice any problem there. > > > > I replaced int32 by int32_t, int64 by int64_t etc. No sane code puts more > > than 32 bits into

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
On 17 December 2010 17:54, Andreas Färber wrote: > Am 17.12.2010 um 17:48 schrieb Peter Maydell: >> On the types issue, at the moment softfloat uses "int32" etc for >> "a handy type holding at least 32 bits", and "bits32" for "exactly >> 32 bits". So I guess changing the 'bits' types to the POSIX

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Andreas Färber
Am 17.12.2010 um 17:48 schrieb Peter Maydell: On 17 December 2010 16:19, Andreas Färber wrote: Can this patch be applied? (There are more ARM/softfloat patches in my queue which will break it again otherwise...) If we're engaging into refactoring the softfloat library, I still have a larg

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
On 17 December 2010 16:19, Andreas Färber wrote: >> Can this patch be applied? (There are more ARM/softfloat patches >> in my queue which will break it again otherwise...) > > If we're engaging into refactoring the softfloat library, I still have a > large'ish patch lying around to fix signature m

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Andreas Färber
Hello Peter, Am 17.12.2010 um 16:56 schrieb Peter Maydell: The softfloat functions float*_is_nan() were badly misnamed, because they return true only for quiet NaNs, not for all NaNs. Rename them to float*_is_quiet_nan() to more accurately reflect what they do. This change was produced by: per

[Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-17 Thread Peter Maydell
The softfloat functions float*_is_nan() were badly misnamed, because they return true only for quiet NaNs, not for all NaNs. Rename them to float*_is_quiet_nan() to more accurately reflect what they do. This change was produced by: perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan) (