[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8750/3

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8761 ) Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. Patch Set 1: Th

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 1: This is the cherry-pick required

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Kudu Jenkins. -- To vi

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8760 to review the following change. Change subject: [security] Make the kerberos principal configurable for Kudu servers

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Dan Burkert. -- To view

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Alexey Serbin. -- To

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8761 Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. IMPALA-6256: Inco

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. Patch Set 3: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-12-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 6: Build starte

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#6). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 6: Code-Review+2 (1 com

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 ) Change subject: IMPALA-6270: create Impala parent pom .. Patch Set 1: https://jenkins.impala.io/view/Utility/job/pre-review-test/83/

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8753 Change subject: IMPALA-6270: create Impala parent pom .. IMPALA-6270: create Impala parent pom This commit links together all the indi

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. IMPALA-6238: Enhance TErrorCode::

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-12-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. IMPALA-6210: Add query id to lineage graph logging Some tools use lin

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8758 Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. IMPALA-6190/6246: Add instances tab and event sequence This chan

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#3). Change subject: IMPALA-5993: Fix the file offset in value parsing error .. IMPALA-

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 2: Code-Review-1 (6 comments) Preparing a testcase

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#2). Change subject: IMPALA-5993: Fix the file offset in value parsing error .. IMPALA-

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. IMPALA-6068: Scale back fixing functional-types I re-created t

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 5: Code-Review+2 Rebased, carry the +2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: Finally! Anyone care to review? -- To view, visit http

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 5: Code-Review+2 (1 comment

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8754 Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. IMPALA-6081: Fix test_basic_filters runtime profi

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: Build started: https://jenk

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: Code-Review+2 Carry +2. -- To view,

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Hello Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8751 to look at the new patch set (#2). Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/875

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8750 to look at the new patch set (#2). Change subject: IMPALA-6232: Disable file handle cache by default ...

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 2: Verified+1 --

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. IMPALA-5987: LZ4 Cod

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 5: (5 comments) http:/

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#5). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 1: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-12-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has abandoned this change. ( http://gerrit.cloudera.org:8080/8545 ) Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. Abandoned Resubmitted merged with the changes for im

[Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations

2017-12-04 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8752 to review the following change. Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations ..

[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging

2017-12-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 ) Change subject: IMPALA-6210: Add query id to lineage graph logging .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7228 ) Change subject: IMPALA-1474: Add a metric for running queries .. Abandoned Seems like this is probably redundant now. Can always reopen. -- To v

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: Gabor, maybe you could take a look at this one

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 3: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (7 comments) Thank you for working on this. Plea

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: I still can't see anything that would actually change bas

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8751 Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TI

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 1: Code-Review+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8750 Change subject: IMPALA-6232: Disable file handle cache by default .. IMPALA-6232: Disable file handle cache by default There are scenari

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 4: (5 comments) What testi

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 2: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 1: (2 comments) Than

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8748 to look at the new patch set (#2). Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8713 ) Change subject: IMPALA-6265 Query cancellation test enhancements .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/8713

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 ) Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. Patch Set 1: Code-Review+2 (2 comme

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8690/4

[Impala-ASF-CR] IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs

2017-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8748 Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs .. IMPALA-5987: LZ4 Codec silently p

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-04 Thread Gabor Kaszab (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8713 to look at the new patch set (#2). Change subject: IMPALA-6265 Query cancellation test enhancements ...

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: Code-Review-1 (4 comments) As I commented, this

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8747 Change subject: IMPALA-5993: Fix the file offset in value parsing error .. IMPALA-5993: Fix the file offset in value parsing error This i

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 2: (5 comments) Thanks! http:

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Henry Robinson, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8684 to look at the new patch set (#3). Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners ...