[Impala-ASF-CR] IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping

2021-11-24 Thread Amogh Margoor (Code Review)
Amogh Margoor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18019 ) Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping .. IMPALA-11027: Adding flag to

[Impala-ASF-CR] IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping

2021-11-22 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18019 ) Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping

2021-11-22 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18019 ) Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupsMapping .. IMPALA-11027: Adding flag to enable

[Impala-ASF-CR] IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupMapping

2021-11-18 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18019 ) Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupMapping .. IMPALA-11027: Adding flag to enable

[Impala-ASF-CR] [WIP] IMPALA-10992 Planner changes for estimate peak memory

2021-11-17 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17994 ) Change subject: [WIP] IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7942: Add query hints for cardinalities and selectivities

2021-11-15 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 ) Change subject: IMPALA-7942: Add query hints for cardinalities and selectivities .. Patch Set 1: (5 comments)

[Impala-ASF-CR] [DONOT MERGE] Adding flag to enable support for ShellBasedUnixGroupMapping

2021-11-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18019 Change subject: [DONOT MERGE] Adding flag to enable support for ShellBasedUnixGroupMapping .. [DONOT MERGE] Adding flag to enable

[Impala-ASF-CR] IMPALA-10910, IMPALA-5509: Runtime filter: dictionary filter support

2021-11-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18017 ) Change subject: IMPALA-10910, IMPALA-5509: Runtime filter: dictionary filter support .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9873: (addendum) Fix test case for scratch tuple batch

2021-11-02 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17992 Change subject: IMPALA-9873: (addendum) Fix test case for scratch_tuple_batch .. IMPALA-9873: (addendum) Fix test case for

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-11-01 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-28 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materialization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 12: > Wrote the

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-26 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-26 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-26 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 12: > (5 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 12: Fix Jenkins

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 11: > (10

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 11: (10 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 10: > Uploaded

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 9: (24 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-19 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-18 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-13 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. IMPALA-10921 Add script to compare TPCDS runs. This script compares 2

[Impala-ASF-CR] IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever

2021-10-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 ) Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever .. Patch Set 19: (3 comments)

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. IMPALA-10921 Add script to compare TPCDS runs. This script compares 2

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. IMPALA-10921 Add script to compare TPCDS runs. This script compares 2

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. Patch Set 2: (28 comments)

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. IMPALA-10921 Add script to compare TPCDS runs. This script compares 2

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-08 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-08 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. IMPALA-9873: Avoid

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-06 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 5: (11

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-06 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 5: (44

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-06 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-06 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. Patch Set 3: Thanks

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-10-01 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-10862 Optimization of the code structure of TmpDir

2021-09-30 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17778 ) Change subject: IMPALA-10862 Optimization of the code structure of TmpDir .. Patch Set 4: Code-Review+1 LGTM...good cleanup here.

[Impala-ASF-CR] IMPALA-10862 Optimization of the code structure of TmpDir

2021-09-29 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17778 ) Change subject: IMPALA-10862 Optimization of the code structure of TmpDir .. Patch Set 3: (10 comments) Changes look good and code

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-09-28 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17860 ) Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table.

2021-09-20 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17860 Change subject: [WIP] IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. .. [WIP] IMPALA-9873: Avoid

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-09-19 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17855 Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. IMPALA-10921 Add script to compare TPCDS runs. This script compares

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch Set

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch Set

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-26 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 15: Thanks Zoltan and Qifan

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-25 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-24 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-24 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-24 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-23 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 11: > Uploaded patch set 11.

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-21 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-18 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 10: (43 comments)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-18 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-18 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 31:

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-16 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 29: (4

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-13 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 10: > Build failed:

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 27: (6

[Impala-ASF-CR] IMPALA-10429 Add Support for Spilling to HDFS Path Parsing

2021-08-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17711 ) Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing .. Patch Set 2: One general comment for better code

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-10 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 9: > > (1 comment) > So

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-10 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. IMPALA-10680: Replace

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-06 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 8: > (1 comment) So '-'

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-04 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 9: (2 comments) Benchmark

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-04 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-04 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-04 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 8: (11 comments) > (1

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-29 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-19 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-13 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-13 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. IMPALA-7635: Reducing HashTable size by

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-11 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. IMPALA-10680: Replace

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. IMPALA-10680: Replace

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17658 ) Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-09 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17658 ) Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. IMPALA-10703: Fix crash on

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-08 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-08 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 5: > (1 comment) > > I

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-07 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17658 ) Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. IMPALA-10703: Fix crash on

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-07 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17658 Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. IMPALA-10703: Fix crash on

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-05 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 6: > (4 comments) > > It

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-04 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 5: Benchmark Result:

  1   2   >