[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 5: Code-Review+1 (1 comment) Testing side LGTM. http://gerrit.clouder

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11331/2/be/src/com

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11331/1/be/src/rpc/

[Impala-ASF-CR] Add missing authorization in KRPC

2018-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 ) Change subject: Add missing authorization in KRPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11331/1/be/src/rpc/

[Impala-ASF-CR] WIP: IMPALA-4063

2018-08-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11185 Change subject: WIP: IMPALA-4063 .. WIP: IMPALA-4063 Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8 --- M be/src/runtime/coordina

[Impala-ASF-CR] IMPALA-7335: Add logs HdfsScanNode to debug the issue

2018-08-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11174 ) Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 15: Code-Review+1 (1 comment) Carry +1.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#16). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 15: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#15). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 14: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-08-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 13: (9 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#14). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-03 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#13). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 12: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost.

2018-08-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/3 ) Change subject: IMPALA-7390: Pin rpc-mgr-kerberized-test to localhost. .. Patch Set 1: Code-Review+2 Thanks for doing this! -- To vi

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 12: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#12). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#11). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-08-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 11: (10 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank

2018-08-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11096 ) Change subject: IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank .. Patch Set 3: Code-Review+2 (1 c

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 9: (9 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-31 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#10). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank

2018-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11096 Change subject: IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank .. IMPALA-7376: DCHECK hit if a frag

[Impala-ASF-CR] IMPALA-6644: Add recent heartbeat timestamp into Statestore metric

2018-07-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric .. Patch Set 2: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 9: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-30 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#9). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-3825: Distribute Runtime Filtering Aggregation

2018-07-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11055 ) Change subject: IMPALA-3825: Distribute Runtime Filtering Aggregation .. Patch Set 3: (40 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 8: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 8: (9 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-27 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#8). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries

2018-07-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11005 ) Change subject: [WIP] IMPALA-6153: Execute UpdateFilter() only for executing queries .. Patch Set 4: (8 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 7: (21 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-24 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#7). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

2018-07-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 5: Code-Review+2 -- To view, vi

[Impala-ASF-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined

2018-07-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10994 Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined .. KUDU-2492: Make the use of SO_REUSEPORT cond

[Impala-ASF-CR] IMPALA-3825: [WIP]Distributed RuntimeFiltering Work in progress patch for Distributing runtime filtering aggregation.

2018-07-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10937 ) Change subject: IMPALA-3825: [WIP]Distributed RuntimeFiltering Work in progress patch for Distributing runtime filtering aggregation. ..

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: Code-Review+2 Forgot to add +2

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: (1 comment) Patch LGTM. Thank

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298

2018-07-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298

2018-07-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 6: (15 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#6). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 8: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (37 comments) Did a first pass. Will have anothe

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: (5 comments) LGTM overall.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (19 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#4). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#6). Change subject: IMPALA-4784: Remove InProcessStatestore .

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 6: Code-Review+2 Hit a clang-tidy issue. Rebase, carry +2. --

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10843/3/be/s

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#4). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 3: This is ready for review now. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#3). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 2: Code-Review-1 Found a bug. Will upload a new patchset shortly.

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#2). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10843 Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove InProcessStatestore InProcessStatestore was only used by

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Some high level questions:

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#3). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (13 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 5: Code-Review+2 (4 comments) Thanks for the review

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#5). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#4). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 6: Code-R

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#3). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#2). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10827 Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215: Implement a templatized CountingBarrier Currently,

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 1: (1 co

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. IMPALA-7163: Implement a state machine for the QuerySt

[Impala-ASF-CR] IMPALA-7207: make Coordinator::exec state an atomic enum

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10811 ) Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7207: make Coordinator::exec state an atomic enum

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10811 ) Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7200: Fix missing FILESYSTEM PREFIX hitting local dataload

2018-06-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10803 ) Change subject: IMPALA-7200: Fix missing FILESYSTEM_PREFIX hitting local dataload .. Patch Set 1: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] WIP: IMPALA-7163

2018-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/10781 ) Change subject: WIP: IMPALA-7163 .. Abandoned Whoops, meant to push it as a draft to gerrit. This is not ready for review. Sorry for the noise

[Impala-ASF-CR] WIP: IMPALA-7163

2018-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10781 ) Change subject: WIP: IMPALA-7163 .. WIP: IMPALA-7163 Change-Id: I27158dae217b0e22445377e5935eb71a906688b5 --- M be/src/runtime/coordinat

[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 4: Code-Review+2 (1 comment) LGTM. Please als

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: (7 comments) Thanks for doing this. This a

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: > Ping I'll have a first pass at this by E

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 1: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: Code-Review+1 (1 comment) Sor

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Code-Review+2 Rebase,

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 7: Code-Review+1 (1 comment) One last comment. LG

[Impala-ASF-CR](asf-site) IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10687 ) Change subject: IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR](asf-site) IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10687 ) Change subject: IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from .. Patch Set 1: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 1: Code-Review+1 (2 comm

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10669 to look at the new patch set (#2). Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance ...

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.clo

  1   2   3   4   5   6   >