[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 ) Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) .. Patch Set 5: (1 comment) htt

[Impala-ASF-CR] IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables

2020-10-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 ) Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables .. Patch Set 7: Code-Review+1 Thanks! -- To view, visit ht

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16545 to look at the new patch set (#7). Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 ) Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) .. Patch Set 7: Fixed the test e

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 ) Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) .. Patch Set 7: (1 comment) htt

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16545 to look at the new patch set (#8). Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 ) Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) .. Patch Set 8: (1 comment) htt

[Impala-ASF-CR] IMPALA-10310 Fix couldn't skip rows in parquet file on NextRowGroup

2020-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16697 ) Change subject: IMPALA-10310 Fix couldn't skip rows in parquet file on NextRowGroup .. Patch Set 1: (1 comment) Thank you very m

[Impala-ASF-CR] IMPALA-10310 Fix couldn't skip rows in parquet file on NextRowGroup

2020-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16697 ) Change subject: IMPALA-10310 Fix couldn't skip rows in parquet file on NextRowGroup .. Patch Set 1: Thanks. Seems like one of my

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 6912987

2020-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16701 Change subject: Bump up CDP_BUILD_NUMBER to 6912987 .. Bump up CDP_BUILD_NUMBER to 6912987 This change bumps up the CDP_BUILD_NUMBE

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

2020-11-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 ) Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg .. Patch Set 1: Code-Review+2 T

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

2020-11-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 ) Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg .. Patch Set 1: (1 comment) ht

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 6912987

2020-11-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16701 to look at the new patch set (#2). Change subject: Bump up CDP_BUILD_NUMBER to 6912987 .. B

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

2020-11-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 ) Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg .. Patch Set 2: Code-Review+2 T

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

2020-11-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 ) Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg .. Patch Set 3: (1 comment) ht

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

2020-11-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 ) Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 5: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16721 Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. IMPALA-10152: Add support for Iceberg HiveCatalog HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#2). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: (16 comments) Thanks for the comments! http://

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16742 Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. IMPALA-10318: default_transactional_typ

[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 ) Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#3). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#4). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 4: PS4 is only a rebase. -- To view, visit http:/

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 1: Thanks

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#5). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#6). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 6: (3 comments) Thanks for the comments! http://g

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific situations

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 ) Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific situations .. Patch Set 1: Code-Review+2 (2 comments

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 ) Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases .. Patch Set 2: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#7). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 7: (2 comments) Thanks for the quick review! http

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 7: Thanks for the review! After +2 we can run the v

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16753 ) Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases .. IMPALA-10346: Rename Iceberg test ta

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. IMPALA-10152: Add support for Iceberg HiveCatalog Hiv

[Impala-ASF-CR] IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

2020-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16771 Change subject: IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h .. IMPALA-10345: Impala hits DCHECK in parquet-co

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 9: Code-Review+2 LGTM! -- To view, visi

[Impala-ASF-CR] IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

2020-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16771 ) Change subject: IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

2020-11-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16771 to look at the new patch set (#2). Change subject: IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

[Impala-ASF-CR] IMPALA-10325 Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2020-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325 Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 12

[Impala-ASF-CR] IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

2020-11-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16771 to look at the new patch set (#4). Change subject: IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

[Impala-ASF-CR] IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h

2020-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16771 ) Change subject: IMPALA-10345: Impala hits DCHECK in parquet-column-stats.inline.h .. Patch Set 4: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2020-11-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 1

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 3: (4 comm

[Impala-ASF-CR] IMPALA-10361: Supported using field id to resolve columns for Iceberg tables

2020-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Supported using field id to resolve columns for Iceberg tables .. Patch Set 2: (5 comments) Thanks

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16795 Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog .. IMPALA-10364: Set the re

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-12-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16795 ) Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog .. Patch Set 2: (1 commen

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-12-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16795 to look at the new patch set (#2). Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog ..

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-12-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16795 ) Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog .. Patch Set 3: (3 commen

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-12-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16795 to look at the new patch set (#3). Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog ..

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 7: (1 comm

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 5: Code-Review+1 (2 comments) Thank

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16825 Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. IMPALA-10380: INSERT INTO identity-partitioned Iceb

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#3). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 7: Code-Review+1 Thanks for the modi

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#4). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 4: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16846 Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables .. IMPALA-10386: Don't allow PARTITION BY SPEC f

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16850 Change subject: IMPALA-10384: Make partition names consistent between BE and FE .. IMPALA-10384: Make partition names consistent bet

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16850 to look at the new patch set (#2). Change subject: IMPALA-10384: Make partition names consistent between BE and FE

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#5). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#7). Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

[Impala-ASF-CR] IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables .. Patch Set 7: PS7 is a rebase that resolves the me

[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16850 to look at the new patch set (#3). Change subject: IMPALA-10384: Make partition names consistent between BE and FE .

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16851 Change subject: IMPALA-10358: Correct Iceberg type mappings .. IMPALA-10358: Correct Iceberg type mappings The Iceberg format spec

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10361: Use field id to resolve columns for Iceberg tables

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16788 ) Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables .. IMPALA-10361: Use field id to resolve c

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness .. Patch Set 2: Code-Review+2 Thanks for the fix, Mate!

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness .. Patch Set 3: I mean Tamas... :) -- To view, visit h

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#2). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16851

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#3). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#4). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 3: (2 comments) PS3 was a rebase. http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#8). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 8: (3 comments) Thanks for

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 8: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16873 Change subject: IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds .. IMPALA-10393: Iceberg field id-based

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16846 to look at the new patch set (#3). Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables ...

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 12: (13 comment

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16851 to look at the new patch set (#5). Change subject: IMPALA-10358: Correct Iceberg type mappings

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 5: (1 comment) Thanks for the comments! http://gerrit.c

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#9). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 9: PS9 was a rebase to reso

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#10). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 13: (2 comments

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#12). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16882 Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. IMPALA-10398: Altering an Iceberg table

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16825 to look at the new patch set (#13). Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only ...

[Impala-ASF-CR] IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 ) Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' partitions only .. Patch Set 12: (7 comments) Thanks fo

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 14: Code-Review+

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 2: (6 comments) Thanks

[Impala-ASF-CR] IMPALA-6434: Add support to decode RLE DICTIONARY encoded pages

2021-01-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16893 ) Change subject: IMPALA-6434: Add support to decode RLE_DICTIONARY encoded pages .. Patch Set 3: (6 comments) Few nits, but the co

<    1   2   3   4   5   6   7   8   9   10   >