[Impala-ASF-CR] IMPALA-6434: Add support to decode RLE DICTIONARY encoded pages

2021-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16893 ) Change subject: IMPALA-6434: Add support to decode RLE_DICTIONARY encoded pages .. Patch Set 4: Code-Review+2 (1 comment) An 'if'

[Impala-ASF-CR] IMPALA-10422: EXPLAIN statements leak ACID transactions and locks

2021-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16923 Change subject: IMPALA-10422: EXPLAIN statements leak ACID transactions and locks .. IMPALA-10422: EXPLAIN statements leak ACID tra

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 4: Code-Review+2 (1 com

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16939 Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. IMPALA-10432: INSERT INTO Iceberg tables with

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 4

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#2). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10426: Fix crash when inserting invalid timestamps

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16951 Change subject: IMPALA-10426: Fix crash when inserting invalid timestamps .. IMPALA-10426: Fix crash when inserting invalid timestam

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#3). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 3: (4 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16939 to look at the new patch set (#4). Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ..

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 4: (4 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 4

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 5: (6 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 5

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 2: Code-Review+1 Thanks for fixing this

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16979 Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. IMPALA-10452: CREATE Iceberg tables with old

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 5

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 1: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16979 to look at the new patch set (#2). Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax ...

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 ) Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. Patch Set 2: (1 comment) Thanks for the co

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16987 Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables .. IMPALA-10456: Implement TRUNCATE for Iceberg tables This pat

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16987 to look at the new patch set (#2). Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-01-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16993 Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests .. IMPALA-10460: Impala should write normal

[Impala-ASF-CR] IMPALA-10456: Implement TRUNCATE for Iceberg tables

2021-01-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16987 to look at the new patch set (#3). Change subject: IMPALA-10456: Implement TRUNCATE for Iceberg tables ...

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16993 to look at the new patch set (#2). Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests

[Impala-ASF-CR] IMPALA-10460: Impala should write normalized paths in Iceberg manifests

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16993 ) Change subject: IMPALA-10460: Impala should write normalized paths in Iceberg manifests .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17012 Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. IMPALA-10223: Implement INSERT OVERWRITE for Iceberg

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 1: (2 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17012 to look at the new patch set (#2). Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17012 to look at the new patch set (#3). Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17038 Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17039 Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. IMPALA-10485: part(1): m

[Impala-ASF-CR] IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17038 to look at the new patch set (#2). Change subject: IMPALA-10482: Select-star query on unrelative collection column of transactional table hit

[Impala-ASF-CR] IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: IMPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17038 to look at the new patch set (#3). Change subject: IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites ..

[Impala-ASF-CR] IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites

2021-02-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites .. Patch Set 1: (1 comment) http://g

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#2). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#3). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 ) Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. Patch Set 3: (4 commen

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17071 Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. IMPA

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#2). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 7

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17081 Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. IMPALA-10512: ALTER TABLE ADD P

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17039 to look at the new patch set (#4). Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 ) Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. Patch Set 4: (4 commen

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 1: (4 comments) ht

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#3). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Vihang Karajgaonkar, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17081 to look at the new patch set (#2). Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for AC

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 2: (1 comment) htt

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate

2021-02-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate ..

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Vihang Karajgaonkar, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17081 to look at the new patch set (#3). Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for AC

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 1: (2 comments) Th

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-02-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. Patch Set 18: Code-Review+1 (1 comment) Thanks for a

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-02-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17130 Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables .. IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified

2021-03-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17164 Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified .. IMPALA-10571: Imp

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-03-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 3: Hi, I've modifie

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-03-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17130 to look at the new patch set (#2). Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-03-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17130 ) Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables .. Patch Set 1: (7 comments) Thanks for the comments! ht

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-03-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17130 to look at the new patch set (#3). Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables

2021-03-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17130 ) Change subject: IMPALA-10222: CREATE TABLE AS SELECT for Iceberg tables .. Patch Set 2: (3 comments) Thanks for the comments! ht

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-03-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. Patch Set 22: Code-Review+2 Yeah, it probably was an

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-03-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Vihang Karajgaonkar, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17081 to look at the new patch set (#4). Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for AC

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-03-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 4: (1 comment) htt

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation

2021-03-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation .. IMPALA-10377: Improve the accuracy of resource

[Impala-ASF-CR] IMPALA-10494: Making use of the min/max column stats to improve min/max filters

2021-03-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17075 ) Change subject: IMPALA-10494: Making use of the min/max column stats to improve min/max filters .. Patch Set 19: (8 comments) Di

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8574 Change subject: IMPALA-5936: operator '%' overflows on large decimals .. IMPALA-5936: operator '%' overflows on large decimals Suppo

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 6: (1 comment) Thanks for the review, I uploade

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#7). Change subject: IMPALA-2248: Make idle_sess

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 1: (2 comments) Thanks! http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8574 to look at the new patch set (#2). Change subject: IMPALA-5936: operator '%' overflows on large decimals

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#8). Change subject: IMPALA-2248: Make idle_sess

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#9). Change subject: IMPALA-2248: Make idle_sess

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8621 Change subject: IMPALA-3703: Store query context in thread-local variables .. IMPALA-3703: Store query context in thread-local variab

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 1: (2 comments) Thanks for the review. I a

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#2). Change subject: IMPALA-3703: Store query context in thread-local variables

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8574 to look at the new patch set (#3). Change subject: IMPALA-5936: operator '%' overflows on large decimals .

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: (2 comments) Thanks. http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Philip Zeyliger, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#3). Change subject: IMPALA-3703: Store query context in thread-local variables .

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Philip Zeyliger, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#4). Change subject: IMPALA-3703: Store query context in thread-local variables .

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 4: (13 comments) Thanks all! http://gerri

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 9: (7 comments) Thanks! http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#10). Change subject: IMPALA-2248: Make idle_ses

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: Thanks! Could someone run the verification?

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 4: (9 comments) Thanks for the comments. I

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-11-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8684 Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. IMPALA-3804: Re-enable per-scan filtering f

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Henry Robinson, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8684 to look at the new patch set (#2). Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners ...

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 1: (2 comments) Thanks for the

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#11). Change subject: IMPALA-2248: Make idle_ses

<    1   2   3   4   5   6   7   8   9   10   >