[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-17 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#29). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-17 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (6 comments) > Patch Set 28: > > (25 comments) > > Hi

[Impala-ASF-CR] IMPALA-9053: DDLs should generate lineage graphs.

2019-10-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14458 ) Change subject: IMPALA-9053: DDLs should generate lineage graphs. .. Patch Set 1: Code-Review+1 I've touched lineage-related code in

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (1 comment) added some detail to the comment that

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (1 comment) I've implemented a simpler approach as

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#28). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-03 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 27: Ok, I've come up with a simpler timeout-monitor

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 26: (1 comment) Missed a nit...

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#27). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 26: (5 comments) Addressed some nits; still need to look

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#26). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#25). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#24). Change subject: IMPALA-8571: harden QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#22). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#23). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#21). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#20). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-19 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#19). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-19 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-19 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 18: (10 comments) Thanks for the feedback,

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-26 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#18). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-25 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#17). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-23 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#16). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-15 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 15: > Patch Set 15: > > Build Failed > >

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-15 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 15: (3 comments) Updated the review with metric

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-15 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#15). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-10 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 14: > Patch Set 14: > > (8 comments) > > > Patch Set

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-10 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 14: (8 comments) > Patch Set 14: > > (9 comments)

[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py

2019-07-08 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-08 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#14). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-08 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#13). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-07-07 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#12). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8572[WIP]: improve QueryEventHook execution

2019-07-07 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#11). Change subject: IMPALA-8572[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8572: improve QueryEventHook execution

2019-07-02 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#10). Change subject: IMPALA-8572: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8572: improve QueryEventHook execution

2019-07-02 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#9). Change subject: IMPALA-8572: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8572: improve QueryEventHook execution

2019-07-01 Thread radford nguyen (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#8). Change subject: IMPALA-8572: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8572: improve QueryEventHook execution

2019-07-01 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8572: improve QueryEventHook execution .. Patch Set 7: (2 comments) add comment where you should probably

[Impala-ASF-CR] IMPALA-8572: improve QueryEventHook execution

2019-07-01 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8572: improve QueryEventHook execution .. IMPALA-8572: improve QueryEventHook execution Description goes here

[Impala-ASF-CR] IMPALA-8473: Publish lineage info via hook

2019-05-24 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#26). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: Publish lineage info via hook .. IMPALA-8473: Publish lineage info via hook This commit introduces a

[Impala-ASF-CR] IMPALA-8473: Publish lineage info via hook

2019-05-24 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#24). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: Publish lineage info via hook .. IMPALA-8473: Publish lineage info via hook This commit introduces a

[Impala-ASF-CR] IMPALA-8473: Publish lineage info via hook

2019-05-23 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: Publish lineage info via hook .. IMPALA-8473: Publish lineage info via hook This commit introduces a

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 20: Fixed code-review checks, implemented minor feedback,

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#20). Change subject: IMPALA-8473: publish lineage info via

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 19: (2 comments) Thanks for +1; replied to your comments.

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 19: Think this is ready for final review now. Sorry about

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#19). Change subject: IMPALA-8473: publish lineage info via

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#18). Change subject: IMPALA-8473: publish lineage info via

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#17). Change subject: IMPALA-8473: publish lineage info via

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 17: (15 comments) still one more iteration needed

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment) As discussed in Slack, I've uploaded a

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#16). Change subject: IMPALA-8473: publish lineage info via

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (8 comments) Great feedback on PS14 and 15. I replied

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread radford nguyen (Code Review)
Hello Andrew Sherman, Anonymous Coward (498), Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#15). Change subject: IMPALA-8473: publish lineage info via hook

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. IMPALA-8473: publish lineage info via hook This commit introduces a

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Patch Set 12: (4 comments) answered some concerns around

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread radford nguyen (Code Review)
Hello Anonymous Coward (498), Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#12). Change subject: [WIP] IMPALA-8473: publish lineage info via hook

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread radford nguyen (Code Review)
Hello Anonymous Coward (498), Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13352 to look at the new patch set (#11). Change subject: [WIP] IMPALA-8473: publish lineage info via hook

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. [WIP] IMPALA-8473: publish lineage info via hook This commit

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Patch Set 7: (14 comments)

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Patch Set 5: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. [WIP] IMPALA-8473: publish lineage info via hook This commit

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-16 Thread radford nguyen (Code Review)
radford nguyen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13352 Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. [WIP] IMPALA-8473: publish lineage info via hook This commit

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-22 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#10). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-22 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 9: (19 comments)

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-21 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#9). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-17 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#8). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-17 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#6). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-17 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#7). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-17 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#5). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-10 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-10 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-10 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12935 to look at the new patch set (#2). Change subject: IMPALA-8363: Fix E2E start with impala_log_dir

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-09 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: > Patch Set 1: > > (1 comment) I think the kwargs

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-04 Thread radford nguyen (Code Review)
radford nguyen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12935 Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. IMPALA-8363: fix e2e start with impala_log_dir This commit fixes

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-04 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-04 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-03 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 4: (1 comment) Modified existing e2e tests to use

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-03 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#4). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-03 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#3). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-03 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 2: (8 comments) Addressed nits; adding e2e tests

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-01 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 2: (10 comments) > Patch Set 1: > > (8 comments)

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-01 Thread radford nguyen (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12901 to look at the new patch set (#2). Change subject: IMPALA-8309: add user authorization_provider flag

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-03-31 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 1: Hi guys, relatively simply ticket here to add a

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-03-31 Thread radford nguyen (Code Review)
radford nguyen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12901 Change subject: IMPALA-8309: add user authorization_provider flag .. IMPALA-8309: add user authorization_provider flag This commit

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-06 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 12: (1 comment) hi @fredy, just adding a teeny