[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded

2019-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 ) Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded .. Patch Set 1: (1 comment) Glad that ranger is

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12680 Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. IMPALA-8279: Revert IMPALA-6658 to avoid ETL

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 1: Thanks Csaba for the review

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12672 Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output

2019-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12732 ) Change subject: IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output .. Patch Set 3: Code-Review+1 (1 comment) This

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12702 Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. IMPALA-8288: avoid overflow causing DCHECK in

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12812 ) Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. Patch Set 1: (4 comments) Thanks Fredy

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12812 ) Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. IMPALA-8325: Leading Unicode comments cause

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 2: Code-Review+1 (2 comments) LGTM

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. IMPALA-8279: Revert IMPALA-6658 to avoid ETL

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (1 comment) I will try to get

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12837 Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. IMPALA-8332: Remove Impala Shell warnings part 1 In Thrift 0.9.3

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12837 ) Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8332: Remove Impala Shell warnings part 1

2019-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12837 ) Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 .. IMPALA-8332: Remove Impala Shell warnings part 1 In Thrift 0.9.3

[Impala-ASF-CR] IMPALA-8098: [DOCS] Port change for the SHUTDOWN command

2019-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12379 ) Change subject: IMPALA-8098: [DOCS] Port change for the SHUTDOWN command .. Patch Set 2: Code-Review+1 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 ) Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. Patch Set 1: Code-Review+1 (2 comments) LGTM

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

2019-02-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 ) Change subject: IMPALA-8189: Disable flaky scanner test on S3 .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.

2019-02-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12475 Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor. .. IMPALA-8194: wait longer to detect JVM pause in

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 3: (10 comments) Thanks Michael for comments

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (1 comment) This all looks good but I have

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 5: (4 comments) Thanks Michael for comments. I think in

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12360 Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. IMPALA-8103: In Analyzed Query use /* and */ to

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 1: (2 comments) Thanks for comments

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. IMPALA-8103: In Analyzed Query use /* and */ to

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 6: Patch set 6 is just to fix merge conflicts. -- To

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

2019-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. Patch Set 2: (3 comments) Thanks for the quick

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Patch Set 12: (4 comments) A few thoughts on things that can go

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 4: (22 comments) Thanks Tim and

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 5: It's actually easy (form a

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: (1 comment) I'm not happy

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 12: (5 comments) Thanks Michael, I believe I addressed the

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: In fact I am removing my

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: (21 comments) Addressing

[Impala-ASF-CR] IMPALA-8333: Remove Impala Shell warnings part 2

2019-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13404 ) Change subject: IMPALA-8333: Remove Impala Shell warnings part 2 .. Patch Set 2: No-one picked this up so I am picking on you

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 16: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 10: (17 comments) Thanks for

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 10: (1 comment) New patch

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 14: (32 comments) Thanks Lars

[Impala-ASF-CR] IMPALA-8584: Add cookie support to the HTTP HS2 server

2019-06-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13672 ) Change subject: IMPALA-8584: Add cookie support to the HTTP HS2 server .. Patch Set 2: (3 comments) Just nits

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13307 Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. WIP IMPALA-8536: Add Scalable Pool

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 2: (1 comment)

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. WIP IMPALA-8536: Add Scalable Pool

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 1: (6 comments) Thanks for

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 2: I have realized that

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 19: Code-Review+1 (3 comments) I left a few comments but

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 16: (3 comments) I added a few comments based on recent

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 18: (2 comments)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8333: Remove Impala Shell warnings part 2

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13404 Change subject: IMPALA-8333: Remove Impala Shell warnings part 2 .. IMPALA-8333: Remove Impala Shell warnings part 2 Set

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (1 comment) Patch set 11 uses the agreed approach.

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (7 comments) Thanks Radford for working through these

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment) Thanks Radford, I think you'e making

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment)

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13383 Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings. .. Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (12 comments) Thanks for the review. See patch set 10.

[Impala-ASF-CR] IMPALA-8689: test hive impala interop failing with "Timeout >7200s"

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13755 ) Change subject: IMPALA-8689: test_hive_impala_interop failing with "Timeout >7200s" .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 ) Change subject: IMPALA-8713: fix stack overflow in unhex() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-8484: Run queries on disjoint executor groups

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13550 ) Change subject: WIP IMPALA-8484: Run queries on disjoint executor groups .. Patch Set 7: (3 comments) a few early

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13078 Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Tim. I made fixes in

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Bikram, see patch set

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: One more fix to remove an 'inline' which

[Impala-ASF-CR] WIP IMPALA-8484: Run queries on disjoint executor groups

2019-06-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13550 ) Change subject: WIP IMPALA-8484: Run queries on disjoint executor groups .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 18: (11 comments) I think this going in the right

[Impala-ASF-CR] IMPALA-8862: Don't ship jetty and ant

2019-08-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14068 ) Change subject: IMPALA-8862: Don't ship jetty and ant .. Patch Set 4: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 1: This looks like the right approach. Would

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 2: (1 comment) A thing I thought of last night

<    1   2   3   4   5   6   7   >