[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: (15 comments) overall good cl

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull to use CASE

2018-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull to use CASE .. Patch Set 11: (13 comments) http://gerrit.cloudera.org:8080/#/c/11760/

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull to use CASE

2018-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull to use CASE .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/11760/1

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 5: (4 comments) While here, do y

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 6: Code-Review+2 lgtm from my end

[Impala-ASF-CR] IMPALA-7794: Rewrite flaky ownership authorization tests

2018-11-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11837 ) Change subject: IMPALA-7794: Rewrite flaky ownership authorization tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-5031: memcpy cannot take null arguments

2018-11-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11812 ) Change subject: IMPALA-5031: memcpy cannot take null arguments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11883 ) Change subject: IMPALA-7808: Refactor Analyzer for easier debugging .. Patch Set 1: (8 comments) thanks for the change and making it

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11883 ) Change subject: IMPALA-7808: Refactor Analyzer for easier debugging .. Patch Set 2: Code-Review+2 go ahead and apply the correct inden

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11883 ) Change subject: IMPALA-7808: Refactor Analyzer for easier debugging .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/1188

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11887

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. Patch Set 9: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11880/

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. Patch Set 5: (

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. Patch Set 6: (

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. Patch Set 7: Co

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/11880

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 6: Code-Review+2 (2 comments) just minor suggestions from

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10291/

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-09 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10291 to look at the new patch set (#6). Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests ...

[Impala-ASF-CR](2.x) IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10363 Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. IMPALA-6948,IMPALA-6962: add end-to-end tests Adds end-to-end tests to

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (1 comment) getting back to this change...

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-10 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#12). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ..

[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test

2018-05-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10397 Change subject: IMPALA-7017: deflake/fix test_catalog_restart test .. IMPALA-7017: deflake/fix test_catalog_restart test The custom_clu

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4025: Part 1: Add percentile disc aggregation function

2018-05-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 1: Add percentile_disc aggregation function .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-18 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#13). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ..

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-18 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#14). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ..

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 14: running more tests... -- To view, visit ht

[Impala-ASF-CR] PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode

2018-05-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode .. Patch Set 1: (10 comments) looks good... just s

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 14: Next change handles the merge. It was straig

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-22 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#15). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#16). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter

2018-05-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10495 ) Change subject: IMPALA-4025: Part 1: Generalize and cleanup StmtRewriter .. Patch Set 1: Code-Review+2 thanks for the cleanup -- To

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#17). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Code-Review+2 rebase and fix minor conflict.

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: hmm. looks like some dependency order for ge

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 17: Odd that this happens with gvo, but not for

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#18). Change subject: IMPALA-5931: Generates scan ranges

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 18: latest change explicitly adds a dep for flat

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10513 Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. IMPALA-6933: Avoids db name collisions for Kudu tests Kudu tes

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10513 to look at the new patch set (#2). Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. IMPALA

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 1: went with the pid idea so to distinguish the sam

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 1: (6 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-05-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-05-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 7: Code-Review+1 (1 comment) thx for the changes. l

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Same info, but its her

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 2: (3 comments) http://gerrit.cloud

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 3: (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs .. Patch Set 4: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Code-Review+2 tried -DreuseForks=false with

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 4: (3 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/10478/4

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (4 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10602 Change subject: IMPALA-6956: deflake and logging for query_expiration test .. IMPALA-6956: deflake and logging for query_expiration test

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10478/5

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment) thanks for the chan

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: Another idea that also came

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10602 to look at the new patch set (#2). Change subject: IMPALA-6956: deflake and logging for query_expiration test .. I

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/1047

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10471

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (14 comments) made an initia

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/106

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (3 comments) thanks for the

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 3: Code-Review+2 thanks for the

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 3: (5 comments) several small suggestions to make things

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 19: rebased (clean). re-ran s3 tests (pass). -

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1064

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/1064

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 20: Code-Review+2 carry +2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 1: (4 comments) looks good, mainly nits and

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs .. Patch Set 5: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 2: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 2: (9 comments) http://gerrit.cloudera.org

[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-11 Thread Vuk Ercegovac (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10692 to review the following change. Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ..

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 4: I think this needs to be reba

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 4: Code-Review+2 needs a rebase

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit

<    1   2   3   4   5   6   7   8   9   >