[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 24: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. IMPALA-5407: Fix crash in HdfsSequenceTableWriter The following use of sequence file writer

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7394 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/878/ -- To view, visit http

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/4/be/src/testutil/in-process-servers.h File be/src/t

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7445 to look at the new patch set (#5). Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. IMPALA-567

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/4/be/src/testutil/in-process-servers.h Fil

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 2: Code-Review+2 Included patch for IMPALA-5670 broke some tests. Rebased to remove it, carry +

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/877/ -- To vi

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/874/

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7445 to look at the new patch set (#4). Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. IMPALA-5670: Misc. tid

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7445/3/be/src/testutil/in-process-servers.h File be/src/

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7451 To unsubscribe, visit http://gerrit.cloud

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to f144d57 .. Bump Kudu version to f144d57 Change-Id: Iea7d94f9807fade7dca781814d795265e254b20e Reviewed-on: http://gerrit.clo

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 24: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/876/ --

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-18 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#24). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. IMPALA-5659: Begin standardizing treatment of thirdparty libraries If Impala was

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/875/ -- To view

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7394 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 3: (3 comments) Thanks for cleaning things up. Looks much better. http://gerrit.cloudera.org:8080/#/c/7445/3/be

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryr

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7418 To unsu

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7418 To

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dr

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/874/ -- To vi

[Impala-ASF-CR] IMPALA-5676: avoid expensive consistency checks in BTSv2

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7459 Change subject: IMPALA-5676: avoid expensive consistency checks in BTSv2 .. IMPALA-5676: avoid expensive consistency checks in BTSv2 Doi

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 2: Code-Review+2 Oops I mean to +2 -- To view, visit http://gerrit.cloudera.org:8080/5987 To u

[Impala-ASF-CR] IMPALA-4674: add new message to stress test

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: add new message to stress test .. Patch Set 1: Dan Hecht already reviewed this as part of the big patch https://gerrit.cloudera.org/#/c/5801/, but

[Impala-ASF-CR] IMPALA-4674: add new message to stress test

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7458 Change subject: IMPALA-4674: add new message to stress test .. IMPALA-4674: add new message to stress test The main IMPALA-4674 commit a

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/873/ -- To view, visit http://gerrit

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Code-Review+2 The GVO failure is definitely unrelated, as the test has nothing to do with Kudu. I filed: I

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 2: Thanks for the review - any other comments? -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] [DOCS] Update list of reserved words

2017-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: [DOCS] Update list of reserved words .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7452 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4905: Don't send empty insert status to coordinator

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7457 Change subject: IMPALA-4905: Don't send empty insert status to coordinator .. IMPALA-4905: Don't send empty insert status to coordinator

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/868/ -- To view, visit htt

[Impala-ASF-CR] IMPALA-5625: write profile when query times out

2017-07-18 Thread Matthew Mulder (Code Review)
Matthew Mulder has uploaded a new patch set (#2). Change subject: IMPALA-5625: write profile when query times out .. IMPALA-5625: write profile when query times out This change writes query profiles as text files for all of the

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) > I think we should do this for MemLimitExceeded() too: > > Joe poi

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-server

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7445 to look at the new patch set (#3). Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. IMPALA-5670: Misc. tid

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7445/2/be/src/runtime/exec-env.cc File be/src/runtime/ex

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/872/ -

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7445/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-e

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) This should be a good improvement! Just have a couple of comments. htt

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6898 To unsubscribe

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 4: (2 comments) LGTM aside from expanding the matrix of query options http://gerrit

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6898/2/fe/src/main/java/org

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. IMPALA-5167: Reduce the number of Kudu clients created (FE) Creating Kudu clients is very e

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/2/be/src/runtime/exec-env.cc File be/src/runtime/exe

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: I think we should do this for MemLimitExceeded() too: Joe pointed out on IMPALA-5598

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 6: (6 comments) I think the code would be cleaner if the metric always had the same name - d

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6898/2/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dr

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-serve

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7419 To

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 6: Fix a bug in the way HDFS libraries were linked for libfesupport.so (must a

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7418 to look at the new patch set (#6). Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/869/

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7454 To unsubscri

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7454 Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. IMPALA-5638: Fix Kudu table set tblproperties inconsist

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#3). Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. IMPALA-5407: Fix crash in HdfsSequenceTableWriter The following use of sequence file writer can lead to a crash

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 2: (2 comments) Added a test case to seq-writer.test and made sure that it crashes impalad if the

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-18 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#3). Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. IMPALA-5407: Fix crash in HdfsSequenceTableWriter The following use of sequence file writer can lead to a crash

[Impala-ASF-CR] [DOCS] Update list of reserved words

2017-07-18 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7452 Change subject: [DOCS] Update list of reserved words .. [DOCS] Update list of reserved words For 2.9, I believe the only new reserved key

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: (4 comments) None of these comments are must-dos, just things I've noticed. http://gerrit.cl

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: Code-Review+1 (1 comment) Not sure if can +2 this given the change isn't trivial, so +

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/868/ -- To view, visit http://gerrit

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to f144d57 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7451 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-07-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src/gut

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-07-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 1: (4 comments) Hi, Would you please review my code with comments? Thanks. I would like

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#6). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 33: Code-Review+2 Fixed a bug in the PHJ debug string where it didn't handle a closed build pa

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-18 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#33). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-467

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6898/1/fe/src/main/java/org

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. IMPALA-5167: Reduce the number of Kudu clients created (FE) Creating Kudu clients is very e

[Impala-ASF-CR] Bump Kudu version to f144d57

2017-07-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7451 Change subject: Bump Kudu version to f144d57 .. Bump Kudu version to f144d57 Change-Id: Iea7d94f9807fade7dca781814d795265e254b2

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread anujphadke (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#6). Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new change for review. http://gerrit.cloudera.org:8080/7450 Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. IMPALA-5529: Add additional function signatures for TRUNC()

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 5: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/