Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1240/
--
To view, visit
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 1: Code-Review+2
Looks simple enough to me. Hence +2'ing.
--
To view, visit http://gerrit.clo
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/p
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 1:
Matt manually submitted it thinking it was a spurious failure:
https://gerrit.cloudera.org/#/c/803
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7731
to look at the new patch set (#6).
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
..
I
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
..
Patch Set 5:
(27 comments)
http://gerrit.cloudera.org:8080/#/c/7731/5/be/src/catalog/c
Alex Behm has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 1:
How did the original IMPALA-5920 change pass GVO?
--
To view, visit http://gerrit.cloudera.org:8080/8
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1239/
--
To view, vi
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 12: Code-Review+2
rebase onto the rat check fix to unblock merging
--
To view, visit http://gerrit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8108
Change subject: IMPALA-5920: addendum - add missing RAT check
..
IMPALA-5920: addendum - add missing RAT check
Change-Id: I44654004bef74
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 7:
The rat-check job actually failed because of a file introduced here - it broke
m
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5416: Fix an impala-shell command recursion bug
..
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1238/
Alex Behm has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/Plan
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1237/
--
T
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 9:
This passes tests, so is ready to be reviewed.
--
To view, visit http://gerrit.cloude
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8098
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
IMPALA-5932: Improve transitive closure computation performance in FE
Lars Volker has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8049/3/bin/clean.sh
File bin/clean.sh:
Line 33: pushd ${I
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8049
to look at the new patch set (#4).
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
IMPALA-5927: Fix enab
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8049/3/bin/clean.sh
File bin/clean.sh:
Line 33: pushd $
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy
File .clang-tidy:
Line 27: -clang-analyze
Lars Volker has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG
Commit Message:
Line 12: This change m
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8049
to look at the new patch set (#3).
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
IMPALA-5927: Fix enab
Jim Apple has posted comments on this change.
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy
File .clang-tidy:
Line 27: -clang-analyzer-cp
Joe McDonnell has posted comments on this change.
Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala
..
Patch Set 1: Code-Review+1
I think this makes sense. At some point, should we add a test that
Tim Wood has posted comments on this change.
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for
Impala.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG
Commit Mess
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5416: Fix an impala-shell command recursion bug
..
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1238/
--
To vi
Alex Behm has posted comments on this change.
Change subject: IMPALA-5416: Fix an impala-shell command recursion bug
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8063
To unsubscribe, visit ht
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8069
To unsubscribe, visit http
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1237/
--
To view, vi
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8069
To unsubscribe, visit http://g
Alex Behm has posted comments on this change.
Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for
VIEW
..
Patch Set 2:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/7353/1/fe/src/main/java/org/apa
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 10: Code-Review+1
I went over the fix to AddTimeSeriesCounter, and it looks correct. This patch
LGT
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8076/2/be/src/service/impala-server.cc
File be/
Tim Wood has posted comments on this change.
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for
Impala.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG
Commit Mess
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7805/6/be/src/service/query
Lars Volker has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7805/6/be/src/service/quer
Michael Brown has posted comments on this change.
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for
Impala.
..
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG
Comm
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 10:
Fix wasn't totally trivial so would be good to have you check my work
--
To view, visit http:/
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/exec/data-source-scan-node.cc
Fil
Hello Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#10).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
David Knupp has posted comments on this change.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
Patch Set 4:
This was submitted by hand. I accidentally had clicked "dry_run" in
je
David Knupp has posted comments on this change.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8081
To u
David Knupp has submitted this change and it was merged.
Change subject: IMPALA-5941: Fix Metastore schema creation in
create-test-configuration.sh
..
IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
(5 comments)
Thanks for the detailed review. I'd like to discuss in person
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/
Alex Behm has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8098
To unsub
Vuk Ercegovac has posted comments on this change.
Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for
VIEW
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7353/2/fe/src/main/java/org/
Vuk Ercegovac has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8105
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false,
unknown.
..
IMPALA-1767 Adds predicate to test boolean va
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exec/CMakeLists.txt
File be/s
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
IMPALA-5920: Remove admission control dependency on YARN RM jar
Impala's admission c
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6: Verified+1
The job actually passed, cleaning up the workspace failed
21:19:36 E
Mostafa Mokhtar has posted comments on this change.
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for
Impala.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8102/1/testdata/workloa
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 9: Code-Review+1
(2 comments)
LGTM, except these 2 comments.
http://gerrit.cloudera.org:8080/#/c/8
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG
Commit Message:
Line 1
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryr
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8069/8//COMMIT_MSG
Commit Message:
Line 19:
>
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#9).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: cle
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8069/8//COMMIT_MSG
Commit Message:
Line 19:
C
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8098/2/fe/src/main/java/org
Tianyi Wang has uploaded a new patch set (#3).
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
IMPALA-5932: Improve transitive closure computation performance in FE
This patch implements
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc
File be/s
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8069
to look at the new patch set (#8).
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
IMPALA-5895: cle
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue
..
Patch Set 3:
(5 comments)
> (15 comments)
>
> > (15 comments)
> >
> > Do you plan to take care of the other c
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 7: Code-Review+2
Please let Sailesh finish his review as well.
--
To view, visit http://gerrit.clouder
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc
File be/src/ut
Tim Wood has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8102
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for
Impala.
..
IMPALA-5376: Implement all TPCDS test cases or alter
Lars Volker has posted comments on this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Patch Set 7:
(5 comments)
I'm still trying to see if there are ways to simplify the code
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
IMPALA-5927: Fix enable_distcc for zsh
enable_distcc didn't work on zsh anymore since it relies on automatic
variable split
Lars Volker has posted comments on this change.
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8049/1/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8070
to look at the new patch set (#9).
Change subject: IMPALA-5908: Allow SET to unset modified query options.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5736: Add impala-shell argument to set default query
options
..
Patch Set 1:
MJ, do you prefer one option with a comma separated list of key=value pairs, o
Philip Zeyliger has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8100
Change subject: IMPALA-5940. Avoid log spew by using Status::Expected.
..
IMPALA-5940. Avoid log spew by using Status::Expected.
In IM
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 8:
I'm still re-running tests. The Overlay function wasn't setting __is_set when
it shoul
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8070
to look at the new patch set (#8).
Change subject: IMPALA-5908: Allow SET to unset modified query options.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5895: clean up runtime profile lifecycle
..
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc
File be/s
Alex Behm has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8098/2/fe/src/main/java/org/a
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8098/1//COMMIT_MSG
Commit
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-5932: Improve transitive closure computation performance
in FE
..
IMPALA-5932: Improve transitive closure computation performance in FE
This patch implements
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1235/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6: Code-Review+2
I'll count the +1s from Tim and Zach, and no further comments from
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 5:
(2 comments)
Thanks for the detailed review, Zach. If nobody has further feedba
Zoram Thanga has uploaded a new patch set (#3).
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue
..
IMPALA-5599: Fix for mis-use of TimestampValue
The TimestampValue class is being used for non-database purposes
in
Zoram Thanga has posted comments on this change.
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue
..
Patch Set 2:
(15 comments)
> (15 comments)
>
> Do you plan to take care of the other cases noted in the jira
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 7:
I'm still fighting through some test failures in this latest iteration.
--
To view, v
85 matches
Mail list logo
