[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5815 Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. IMPALA-2518: DROP DATABASE

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: Thank you for looking into this. It would be nice to

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5729 To

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 22: Code-Review+1 (2 comments) Catalog changes look

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 7: (25 comments) http://gerrit.cloudera.org:8080/#/c/5649/7/docs/shared/impala_common.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/6/docs/shared/impala_common.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (15 comments) Another round of comments. I've seen that not all previous comments have been

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: John, do we have a pdf from these sources? It helps immensely the review process of docs --

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 5: Code-Review+2 Rebase and carry Marcel's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5710 to look at the new patch set (#5). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog ..

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (14 comments)

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5731 To

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: Marcel, can you plz look at patch set 2 instead. Several things changed and

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/5710/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 3: (1 comment) I see a comment about removing BlockMetadataLoadStats but this is not

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 3: (2 comments) To answer Alex's question for alternatives to logging approaches. I would

[Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.

2017-01-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. .. Patch Set 3: (2 comments) Overall, not a big fan of this change. There are better ways to generate

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5710 Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 4: Any progress on this? There is no activity for over a

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2016-12-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5507 Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. CDH-48291: Fix flaky test TestRequestPoolService This

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4611: Checking perms on S3 files is a very expensive no-op

2016-12-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-4614: Set eval cost of timestamp literals.

2016-12-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4614: Set eval cost of timestamp literals. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5404 To unsubscribe,

[Impala-ASF-CR] IMPALA-4619: Allow NULL as default value in Kudu tables

2016-12-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4619: Allow NULL as default value in Kudu tables .. Patch Set 3: Code-Review+2 (1 comment) Rebase. Carry Alex's +2

[Impala-ASF-CR] IMPALA-4619: Allow NULL as default value in Kudu tables

2016-12-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5405 to look at the new patch set (#2). Change subject: IMPALA-4619: Allow NULL as default value in Kudu tables ..

[Impala-ASF-CR] IMPALA-4614: Set eval cost of timestamp literals.

2016-12-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4614: Set eval cost of timestamp literals. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4619: Error when specifying NULL default values in Kudu tables

2016-12-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5405 Change subject: IMPALA-4619: Error when specifying NULL default values in Kudu tables .. IMPALA-4619: Error when specifying

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5382 To

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5317 to look at the new patch set (#5). Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 5: Code-Review+2 Fix test. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 3: Code-Review+2 Carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5364 to look at the new patch set (#3). Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. IMPALA-4584: Make alter table operations on Kudu tables synchronous This commit

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5364 Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. IMPALA-4584: Make alter table operations

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 4: Code-Review+2 Fix error in data loading caused by accidentally

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5317 to look at the new patch set (#4). Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

[Impala-ASF-CR] Fix typo in DDL statement for loading Kudu table in stress test

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has submitted this change and it was merged. Change subject: Fix typo in DDL statement for loading Kudu table in stress test .. Fix typo in DDL statement for loading Kudu table in stress test Change-Id:

[Impala-ASF-CR] Fix typo in DDL statement for loading Kudu table in stress test

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix typo in DDL statement for loading Kudu table in stress test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5158 To

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: Additional functional testing for default values on Kudu tables .. Additional functional testing for default values on Kudu tables This commit also fixes

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 3: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery

2016-12-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery .. Patch Set 3: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5337 Change subject: Additional functional testing for default values on Kudu tables .. Additional functional testing for default

[Impala-ASF-CR] IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery

2016-12-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery .. Patch Set 2: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery

2016-12-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5333 Change subject: IMPALA-4579: SHOW CREATE VIEW fails for view containing a subquery .. IMPALA-4579: SHOW CREATE VIEW fails for

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE Change-Id:

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5317 Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. IMPALA-4561: Replace DISTRIBUTE BY with

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5312 To

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5259 to look at the new patch set (#2). Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 15: Code-Review+2 (2 comments) Nice!

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 13: (13 comments)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 10: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5259 Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. IMPALA-4527: Columns in Kudu

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 9: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 8: Code-Review+2 Rebase and play gvo lottery. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5136 to look at the new patch set (#8). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 6: Code-Review+2 Fix test failure due to non-nullable columns. Rebase and

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5151 to look at the new patch set (#6). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

[Impala-ASF-CR] IMPALA-4523: Correct max VARCHAR size to 65535 (2^16 - 1).

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4523: Correct max VARCHAR size to 65535 (2^16 - 1). .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 7: Code-Review+2 Fix test. Rebase and carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-23 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5136 to look at the new patch set (#7). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 5: Code-Review+2 Test fix. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5151 to look at the new patch set (#5). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5151 to look at the new patch set (#4). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 6: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5136 to look at the new patch set (#6). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables ..

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 3: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: I think we should try to be consistent in the way we

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: functional_schema_template.sql seems to have tables

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. IMPALA-4283: Ensure Kudu-specific lineage and audit behavior With this commit we add

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 2: (19 comments)

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

<    1   2   3   4   5   >