[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1.

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. subprocess: use SIGKILL instead of SIGTERM death signal This addresses a potential source of

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#15). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4139 To unsubscribe, visit

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 3: the timeout/failures I was seeing before in RaftConsensusITest seemed to be pre-existing. rebased this on

[kudu-CR] raft consensus-itest: workaround flakiness due to KUDU-1580

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4142 to review the following change. Change subject: raft_consensus-itest: workaround flakiness due to KUDU-1580 ..

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3102/ -- To view, visit

[kudu-CR] client-test: remove an unnecessary manual leader election

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client-test: remove an unnecessary manual leader election .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3105/ -- To view, visit

[kudu-CR] subprocess: use SIGKILL instead of SIGTERM death signal

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: subprocess: use SIGKILL instead of SIGTERM death signal .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3103/ -- To view, visit

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#3). Change subject: WIP: cleanup/refactoring in consensus .. WIP:

[kudu-CR] raft consensus-itest: inserter thread should FATAL instead of FAIL

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4140 to review the following change. Change subject: raft_consensus-itest: inserter thread should FATAL instead of FAIL ..

[kudu-CR] client-test: remove an unnecessary manual leader election

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4141 to review the following change. Change subject: client-test: remove an unnecessary manual leader election ..

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#14). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/3101/ -- To view,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3823 To

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 5: Punted because the code was equivalent and was already tested -- To view, visit

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Actually support downgrade to version that has LocalConsensus .. Actually support downgrade to version that has LocalConsensus Commit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 12: (1 comment) Thanks again, updated along with std:: prefixes to keep

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 4: Code-Review+2 (1 comment) Feel free to punt.

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/3099/ -- To view,

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: updates to kudu_impala_integration.adoc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3098/ -- To view, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#12). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] docs: updates to kudu impala integration.adoc

2016-08-26 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4138 to review the following change. Change subject: docs: updates to kudu_impala_integration.adoc .. docs:

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4128 to look at the new patch set (#2). Change subject: docs: update installation with new OS support ..

[kudu-CR] docs: update installation with new OS support

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1. The

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 11: (3 comments)

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 10: (10 comments) TFTR Mike, updated new patch, and also responses inline

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3096/ -- To view,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#11). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4131 To unsubscribe, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: ksck: colorize and clean up output .. ksck: colorize and clean up output Dan and I were looking at some ksck output earlier and found it somewhat hard to

[kudu-CR] Predicate evaluation pushdown

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3095/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4131/1//COMMIT_MSG Commit Message: Line 15: server.

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3094/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#4). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: > One thing I noticed is that you have a newline separating tablet output, but > not tables. added > It

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4131 to look at the new patch set (#2). Change subject: master: include TS address in log messages ..

[kudu-CR] master: include TS address in log messages

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3093/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: hrm, appears I may have forgotten to commit or something :) trying again in a moment -- To view, visit

[kudu-CR] java: inherit from ASF parent pom

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: inherit from ASF parent pom .. java: inherit from ASF parent pom This removes the Cloudera distribution management section and adds the ASF parent

[kudu-CR] tools: wrap descriptions

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG Commit Message: PS2, Line 18: ksck Check the

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc:

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 10: (13 comments)

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4059 To

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: It would be really helpful to print the time that TABLET_DATA_COPYING operations started. Not sure if this is

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3090/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: One thing I noticed is that you have a newline separating tablet output, but not tables. EG: Table

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3089/ -- To view, visit

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-26 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#4). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add release notes for tablet history GC

2016-08-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc File

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3088/ -- To view, visit

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: WIP: cleanup/refactoring in consensus .. WIP: cleanup/refactoring in consensus This is a fairly invasive cleanup/refactor to consensus in preparation for

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4133 to review the following change. Change subject: WIP: cleanup/refactoring in consensus .. WIP: cleanup/refactoring in

[kudu-CR] WIP: cleanup/refactoring in consensus

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: cleanup/refactoring in consensus .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3087/ -- To view, visit

[kudu-CR] java: inherit from ASF parent pom

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: inherit from ASF parent pom .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4118 To unsubscribe, visit

[kudu-CR] tools: wrap descriptions

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG Commit Message: PS2, Line 18: ksck