[kudu-CR] [build-support] added IWYU filter script

2017-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 2: (12 comments) Thank you for the review! I'll post a new version as soon as I shorten the muted list

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7618/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (12 comments) http://gerrit.cloudera.org:8080/#/c/6968/9/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/9/src/kudu/consensus/consensus_meta.h

[kudu-CR] [build-support] added IWYU filter script

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/7604/2/build-support/iwyu/iwyu-filter.awk File

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/patches/llvm-iwyu-nocurses.patch File

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/download-thirdparty.sh File

[kudu-CR] WIP: [iwyu] first pass

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/4738/11/src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc File

[kudu-CR] python: restore setuptools requirement and employ different workaround

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: python: restore setuptools requirement and employ different workaround .. Patch Set 1: Verified+1 One test failed in test setup: INFO 42520

[kudu-CR] [java] Update outdated dependencies

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 5: Looks fine but the test failures look legit. -- To view, visit http://gerrit.cloudera.org:8080/7647 To

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 1: (9 comments)

[kudu-CR] [java] Remove double brackets from wrapper script

2017-08-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Remove double brackets from wrapper script .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7655/2//COMMIT_MSG Commit Message: Line 13:

[kudu-CR] [java] Update outdated dependencies

2017-08-11 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7647 to look at the new patch set (#5). Change subject: [java] Update outdated dependencies .. [java] Update outdated

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 1: (20 comments)

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG Commit Message: Line 21:

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG Commit Message: Line 21:

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7662 Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. KUDU-2091: Certificates with intermediate CA's

[kudu-CR] python: restore setuptools requirement and employ different workaround

2017-08-11 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7661 to review the following change. Change subject: python: restore setuptools requirement and employ different workaround

[kudu-CR] Allow tablet shutdown without completing txs

2017-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (11 comments) http://gerrit.cloudera.org:8080/#/c/7439/11/src/kudu/tablet/mvcc.h File

[kudu-CR] Run the gradle build as a part of the gerrit tests

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Run the gradle build as a part of the gerrit tests .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh

[kudu-CR] [WIP] Add BlockDeletionTransaction to Block Manager

2017-08-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP] Add BlockDeletionTransaction to Block Manager .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7656/1/src/kudu/fs/file_block_manager.cc File

[kudu-CR] [WIP] Add BlockDeletionTransaction to Block Manager

2017-08-11 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7656 to look at the new patch set (#2). Change subject: [WIP] Add BlockDeletionTransaction to Block Manager .. [WIP]

[kudu-CR] [java] Remove double brackets from wrapper script

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Remove double brackets from wrapper script .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7655/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: Reorder class declaration of LogWritableBlock .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7595 To

[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log block manager: Reorder class declaration of LogWritableBlock .. log block manager: Reorder class declaration of LogWritableBlock Reordered class

[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock

2017-08-11 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7595 to look at the new patch set (#3). Change subject: log block manager: Reorder class declaration of LogWritableBlock

[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock

2017-08-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: log block manager: Reorder class declaration of LogWritableBlock .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/block_manager-stress-test.cc

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-11 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#15). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] rpc: hook up a callback for libev fatal errors

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: hook up a callback for libev fatal errors .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7633/2//COMMIT_MSG Commit Message: PS2, Line 17:

[kudu-CR] disk failure: add persistent disk states

2017-08-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 9: (10 comments) Still working on updating this one. Note that there's now a dependency on a new patch to

[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: Reorder class declaration of LogWritableBlock .. Patch Set 2: (1 comment)

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#6). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 14: (4 comments)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (7 comments) Glanced through one of the tests. Will take a closer look today.