[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11414 ) Change subject: [jepsen] a bunch of minor updates on README.adoc .. [jepsen] a bunch of minor updates on README.adoc Added a

[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 ) Change subject: [jepsen] a bunch of minor updates on README.adoc .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] build: retry all failed tests

2018-09-10 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11374 ) Change subject: build: retry all failed tests .. Abandoned Ended up going down a different route -- To view, visit

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-10 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#8). Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings .. Patch Set 7: (3 comments) Couple more nits and

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-10 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#7). Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 ) Change subject: build: add option to ignore test failures .. Patch Set 3: Sure, tagging in Mike, since he might be the most immediately

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11417 ) Change subject: [blog] Data Pipelines Simplified with Kudu .. Patch Set 1: (2 comments) A couple of nits.

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 5: (1 comment)

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Anonymous Coward (Code Review)
Hello Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11333 to look at the new patch set (#5). Change subject: [KUDU-2521] Java Implementation for BloomFilter

[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 ) Change subject: [jepsen] a bunch of minor updates on README.adoc .. Patch Set 1: (1 comment)

[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11414 to look at the new patch set (#2). Change subject: [jepsen] a bunch of minor updates on README.adoc ..

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-10 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11417 Change subject: [blog] Data Pipelines Simplified with Kudu .. [blog] Data Pipelines Simplified with Kudu Change-Id:

[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 ) Change subject: [jepsen] a bunch of minor updates on README.adoc .. Patch Set 1: (1 comment)

[kudu-CR] Remove unnecessary friendship

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11416 Change subject: Remove unnecessary friendship .. Remove unnecessary friendship This commit removes unnecessary friendship and declaration in

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-10 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11413 to look at the new patch set (#3). Change subject: HMS integration: provide Java API to override owner during table create

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 4: (1 comment) Looks good, just a small typo to fix.

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 ) Change subject: move KUDU_NO_EXPORT attribute on methods .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11411 to look at the new patch set (#2). Change subject: [WIP] Add helper macro for tool invocations

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: [WIP] Add helper macro for tool invocations .. Patch Set 1: (1 comment)

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 ) Change subject: move KUDU_NO_EXPORT attribute on methods .. Patch Set 2: Interestingly this issue only cropped up with

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11415 to look at the new patch set (#2). Change subject: move KUDU_NO_EXPORT attribute on methods ..

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11398 to look at the new patch set (#5). Change subject: HMS integration: set table owner field in HMS table metadata

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-10 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11415 to review the following change. Change subject: move KUDU_NO_EXPORT attribute on methods .. move

[kudu-CR] [jepsen] a bunch of minor updates on README.adoc

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11414 Change subject: [jepsen] a bunch of minor updates on README.adoc .. [jepsen] a bunch of minor updates on README.adoc Added a link to

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 ) Change subject: build: add option to ignore test failures .. Patch Set 3: Code-Review+2 But you might want to get another set of eyes on

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-10 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11413 to review the following change. Change subject: HMS integration: provide Java API to override owner during table create

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11399 to look at the new patch set (#3). Change subject: build: add option to ignore test failures .. build:

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop coping string while querying

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop coping string while querying .. Patch Set 6: (5 comments)

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: [WIP] Add helper macro for tool invocations .. Patch Set 1: (1 comment)

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 ) Change subject: build: add option to ignore test failures .. Patch Set 2: (1 comment)

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 2 minutes .. [jepsen] set default admin operation timeout to 2

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 2 minutes .. Patch Set 2: (1 comment)

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 2 minutes .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11399 to look at the new patch set (#2). Change subject: build: add option to ignore test failures .. build:

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

2018-09-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11405 to look at the new patch set (#3). Change subject: [jepsen] set default admin operation timeout to 2 minutes

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 4: (1 comment)

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11398 to look at the new patch set (#4). Change subject: HMS integration: set table owner field in HMS table metadata

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 5 minutes .. Patch Set 2: (1 comment)

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 5 minutes .. Patch Set 2: (1 comment)

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. [gutil] add LookupOrEmplace() Added LookupOrEmplace() which is similar to

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

2018-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 ) Change subject: [jepsen] set default admin operation timeout to 5 minutes .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11373 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Abandoned Submitted in https://gerrit.cloudera.org/c/11360. -- To

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop coping string while querying

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop coping string while querying .. Patch Set 6: (6 comments)

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: [WIP] Add helper macro for tool invocations .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: [WIP] Add helper macro for tool invocations .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] updated warning message

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11402 ) Change subject: [catalog_manager] updated warning message .. [catalog_manager] updated warning message Updated the warning

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 3: > > The change looks fine with me, though I think Adar may the same >

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: [WIP] Add helper macro for tool invocations .. Patch Set 1: (1 comment)

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 3: Code-Review+2 > The change looks fine with me, though I think Adar may the

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 9: (7 comments)

[kudu-CR] [catalog manager] updated warning message

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11402 ) Change subject: [catalog_manager] updated warning message .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] build: add option to ignore test failures

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 ) Change subject: build: add option to ignore test failures .. Patch Set 1: (3 comments)

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11401/2//COMMIT_MSG

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11401 to look at the new patch set (#3). Change subject: [gutil] add LookupOrEmplace() ..

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 3: (1 comment)

[kudu-CR] Add modify external catalogs flag to table delete tool

2018-09-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 ) Change subject: Add modify_external_catalogs flag to table delete tool .. Patch Set 12: I think you missed my comments on PS6 regarding

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 2: Code-Review+2 (4 comments)

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 2: (2 comments)

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-10 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11398 to look at the new patch set (#3). Change subject: HMS integration: set table owner field in HMS table metadata

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: Not sure why it failed...it's hard to track that in the logs.

[kudu-CR] [WIP] Add helper macro for tool invocations

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11411 Change subject: [WIP] Add helper macro for tool invocations .. [WIP] Add helper macro for tool invocations Using `ASSERT_OK` to test

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. [docs] Add "one client only" best practice for

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 1: (1 comment)

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 1: (1 comment)

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 2: Verified+1 No precommit needed for a

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Removed reviewer Kudu Jenkins. -- To view, visit

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11409 to look at the new patch set (#2). Change subject: [docs] Add "one client only" best practice for kudu-spark

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 1: (1 comment)

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11409 ) Change subject: [docs] Add "one client only" best practice for kudu-spark .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [docs] Add "one client only" best practice for kudu-spark

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11409 Change subject: [docs] Add "one client only" best practice for kudu-spark .. [docs] Add "one client only" best practice for kudu-spark

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 ) Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. Patch Set 3: Code-Review+1 (2

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 1: (1 comment) Thank you for the review.

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11401 to look at the new patch set (#2). Change subject: [gutil] add LookupOrEmplace() ..

[kudu-CR] [gutil] add LookupOrEmplace()

2018-09-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 ) Change subject: [gutil] add LookupOrEmplace() .. Patch Set 1: (3 comments)

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 4: (1 comment)

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Anonymous Coward (Code Review)
Hello Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11333 to look at the new patch set (#4). Change subject: [KUDU-2521] Java Implementation for BloomFilter

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-10 Thread Anonymous Coward (Code Review)
Hello Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11333 to look at the new patch set (#3). Change subject: [KUDU-2521] Java Implementation for BloomFilter