[kudu-CR] replace nvml with memkind in block cache

2019-04-29 Thread ye yuqiang (Code Review)
ye yuqiang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13188 Change subject: replace nvml with memkind in block cache .. replace nvml with memkind in block cache Change-Id: I08855c62bc42b9e6f7a4b3bfa

[kudu-CR] [www] highlight primary key in tserver Web UI

2019-04-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13187 Change subject: [www] highlight primary key in tserver Web UI .. [www] highlight primary key in tserver Web UI Change-Id: I57dbcea938f9c6b436c

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 ) Change subject: [backup] Support column alterations between backups .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/131

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 ) Change subject: [backup] Support column alterations between backups .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/13

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13173 to look at the new patch set (#2). Change subject: [backup] Support column alterations between backups .

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [backup] Ensure the last metadata is restored

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: This is true, but the functionality is more correct. I bro

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13130/2/java/kudu-bac

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Removed reviewer Kudu Jenkins with the following votes

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 2: Verified+1 unrelated flake in: * org.apache.ku

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13174/2/src/kudu/t

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] command to reset authz cache in kudu CLI

2019-04-29 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 ) Change subject: [tools] command to reset authz cache in kudu CLI .. Patch Set 3: Code-Review+2 (1 comment) May want to wait for Andrew or A

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13175 to look at the new patch set (#2). Change subject: [util] modernize signature of Cache interface methods ...

[kudu-CR] WIP [master sentry-itest] a couple of yet disabled tests

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13138 ) Change subject: WIP [master_sentry-itest] a couple of yet disabled tests .. Patch Set 1: > Would you like a review on these tests? I k

[kudu-CR] [tools] command to reset authz cache in kudu CLI

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 ) Change subject: [tools] command to reset authz cache in kudu CLI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1313

[kudu-CR] WIP [master sentry-itest] a couple of yet disabled tests

2019-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13138 ) Change subject: WIP [master_sentry-itest] a couple of yet disabled tests .. Patch Set 1: Would you like a review on these tests? I know

[kudu-CR] [tools] command to reset authz cache in kudu CLI

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 ) Change subject: [tools] command to reset authz cache in kudu CLI .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13139/1

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 ) Change subject: [backup] Support column alterations between backups .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/131

[kudu-CR] [tools] command to reset authz cache in kudu CLI

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 ) Change subject: [tools] command to reset authz cache in kudu CLI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1313

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 ) Change subject: [backup] Support column alterations between backups .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/131

[kudu-CR] [backup] Hide scanLeaderOnly option

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13172 ) Change subject: [backup] Hide scanLeaderOnly option .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/1317

[kudu-CR] [backup] Ensure the last metadata is restored

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13130

[kudu-CR] [tools] command to reset authz cache in kudu CLI

2019-04-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 ) Change subject: [tools] command to reset authz cache in kudu CLI .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13139/

[kudu-CR] [backup] Ensure the last metadata is restored

2019-04-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 2: The logic looks OK to me, but AFAICT the test will pass wit

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13130/2/java/kudu-back

[kudu-CR] [backup] Hide scanLeaderOnly option

2019-04-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13172 ) Change subject: [backup] Hide scanLeaderOnly option .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1317

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. tserver: remove some duplicated code Change-Id: I950673eb0e54b08f52fdb2e

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. Patch Set 1: Verified+1 unrelated flakes in tests: * org.apache.kudu.backup.

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13174 ) Change subject: tserver: remove some duplicated code .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 b

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 ) Change subject: [util] modernize signature of Cache interface methods .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13130 To

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [backup] Add more metadata fields .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13130 To unsubscribe, visit http://ge

[kudu-CR] [util] modernize signature of Cache interface methods

2019-04-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13175 Change subject: [util] modernize signature of Cache interface methods .. [util] modernize signature of Cache interface methods Updated

[kudu-CR] tserver: remove some duplicated code

2019-04-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13174 Change subject: tserver: remove some duplicated code .. tserver: remove some duplicated code Change-Id: I950673eb0e54b08f52fdb2eb8ce4e16

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG

[kudu-CR] [backup] Hide scanLeaderOnly option

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13172 Change subject: [backup] Hide scanLeaderOnly option .. [backup] Hide scanLeaderOnly option Marks the scanLeaderOnly option as hidden give

[kudu-CR] [backup] Support column alterations between backups

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13173 Change subject: [backup] Support column alterations between backups .. [backup] Support column alterations between backups This patch add

[kudu-CR] [backup] Ensure the last metadata is restored

2019-04-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13132/1/

[kudu-CR] [backup] Ensure the last metadata is restored

2019-04-29 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13132 to look at the new patch set (#2). Change subject: [backup] Ensure the last metadata is restored ...

[kudu-CR] [backup] Add more metadata fields

2019-04-29 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13130 to look at the new patch set (#2). Change subject: [backup] Add more metadata fields .. [ba