[kudu-CR] KUDU-2975: Spread WAL across multiple directories

2020-01-07 Thread YangSong (Code Review)
YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14920 ) Change subject: KUDU-2975: Spread WAL across multiple directories .. Patch Set 5: (6 comments)

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: sorry, mistake when I reply above comment, please

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: > > I thought to make the building process

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: consensus: throttle warnings when quiescing server .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14989 To

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14989 ) Change subject: consensus: throttle warnings when quiescing server .. Patch Set 2: Verified+1 Failure seems unrelated, though I'm not

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14990 ) Change subject: KUDU-3011 p4: follow-up to 4619473 .. KUDU-3011 p4: follow-up to 4619473 This addresses feedback on commit

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14989 ) Change subject: consensus: throttle warnings when quiescing server .. consensus: throttle warnings when quiescing server When

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14990 ) Change subject: KUDU-3011 p4: follow-up to 4619473 .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14990 to look at the new patch set (#3). Change subject: KUDU-3011 p4: follow-up to 4619473 .. KUDU-3011

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14990 ) Change subject: KUDU-3011 p4: follow-up to 4619473 .. Patch Set 2: (1 comment)

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14989 ) Change subject: consensus: throttle warnings when quiescing server .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14990 to look at the new patch set (#2). Change subject: KUDU-3011 p4: follow-up to 4619473 .. KUDU-3011

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14990 ) Change subject: KUDU-3011 p4: follow-up to 4619473 .. Patch Set 1: (2 comments)

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14989 to look at the new patch set (#2). Change subject: consensus: throttle warnings when quiescing server

[kudu-CR] env: add common File base class

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14987 ) Change subject: env: add common File base class .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-3011 p4: follow-up to 4619473

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14990 Change subject: KUDU-3011 p4: follow-up to 4619473 .. KUDU-3011 p4: follow-up to 4619473 This addresses feedback on commit 4619473 left

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14989 ) Change subject: consensus: throttle warnings when quiescing server .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 4: (3 comments)

[kudu-CR] consensus: throttle warnings when quiescing server

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14989 Change subject: consensus: throttle warnings when quiescing server .. consensus: throttle warnings when quiescing server When an

[kudu-CR] file cache: unify across file types

2020-01-07 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14988 to review the following change. Change subject: file cache: unify across file types .. file cache:

[kudu-CR] env: add common File base class

2020-01-07 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14987 to review the following change. Change subject: env: add common File base class .. env: add common

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. KUDU-3011 p3: mechanism to quiesce scans This prevents new scans

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 3: > Patch Set 3: Code-Review+2 > > I can see the new error code

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 3: Code-Review+2 I can see the new error code as being useful if

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14986 to look at the new patch set (#3). Change subject: KUDU-3011 p3: mechanism to quiesce scans

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 3: (9 comments)

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14986 to look at the new patch set (#2). Change subject: KUDU-3011 p3: mechanism to quiesce scans

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 ) Change subject: KUDU-3011 p3: mechanism to quiesce scans .. Patch Set 1: (9 comments)

[kudu-CR] KUDU-3011 p3: mechanism to quiesce scans

2020-01-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14986 to review the following change. Change subject: KUDU-3011 p3: mechanism to quiesce scans .. KUDU-3011

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. Patch Set 2: (2 comments)

[kudu-CR] [java] retry to connect to the cluster when specifing a superset of masters

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14981 ) Change subject: [java] retry to connect to the cluster when specifing a superset of masters .. Patch Set 1: (3 comments) Could you

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. Patch Set 2: (3 comments)

[kudu-CR] [tools] Fix create table tool for VARCHAR and DATE columns

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14983 ) Change subject: [tools] Fix create table tool for VARCHAR and DATE columns .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: > I thought to make the building process

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14984 to look at the new patch set (#2). Change subject: KUDU-3005: Reduce size of kudu-python docker image

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. Patch Set 1: This will also be a good first step to help

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14984 Change subject: KUDU-3005: Reduce size of kudu-python docker image .. KUDU-3005: Reduce size of kudu-python docker image This patch

[kudu-CR] [tools] Fix create table tool for VARCHAR and DATE columns

2020-01-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14983 Change subject: [tools] Fix create table tool for VARCHAR and DATE columns .. [tools] Fix create table tool for VARCHAR and DATE columns

[kudu-CR] [wip] KUDU-2971 p3: concurrent requests support for subprocess

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14625 ) Change subject: [wip] KUDU-2971 p3: concurrent requests support for subprocess .. Patch Set 2: (6 comments) Just skimmed over.

[kudu-CR] KUDU-2791 p2: add basic protobuf msg

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2791 p2: add basic protobuf msg .. Patch Set 4: (2 comments)

[kudu-CR] [tools] Add 'run cleanup' option for 'kudu perf loadgen'

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14958 ) Change subject: [tools] Add 'run_cleanup' option for 'kudu perf loadgen' .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: (5 comments)

[kudu-CR] [util] Import FastHash hash function to util

2020-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14934 ) Change subject: [util] Import FastHash hash function to util .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-01-07 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007. Support building Kudu on aarch64 platform .. Patch Set 7: (5 comments) Hi Adar, Thanks for your review! I

[kudu-CR] tablet: detach metrics first in destructor

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14979 ) Change subject: tablet: detach metrics first in destructor .. tablet: detach metrics first in destructor Previously the

[kudu-CR] test: deflake RaftConsensusNumLeadersMetricTest TestNumLeadersMetric

2020-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14980 ) Change subject: test: deflake RaftConsensusNumLeadersMetricTest TestNumLeadersMetric .. test: deflake