[kudu-CR] [python] Update link and formatting in readme

2024-09-16 Thread Attila Bukor (Code Review)
Hello Marton Greber, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21806 to review the following change. Change subject: [python] Update link and formatting in readme .. [python] Update li

[kudu-CR] KUDU-3589 Wait until masters become voters

2024-09-11 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21636 ) Change subject: KUDU-3589 Wait until masters become voters .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/21636/4/src

[kudu-CR] KUDU-3589 Wait until masters become voters

2024-08-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21636 ) Change subject: KUDU-3589 Wait until masters become voters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21636/4/src

[kudu-CR] Add Prometheus HTTP service discovery

2024-08-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21723 ) Change subject: Add Prometheus HTTP service discovery .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21723/2//COMMIT

[kudu-CR] [log block manager] Write lock for deletion

2024-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20901 ) Change subject: [log_block_manager] Write lock for deletion .. Patch Set 17: > That looks a bit concerning. Did you try to figure out

[kudu-CR] [java] Various fixes

2024-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21547 ) Change subject: [java] Various fixes .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21547 To unsubscribe

[kudu-CR] [java] Various fixes

2024-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [java] Various fixes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21547 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] [build] KUDU-3551 Upgrade gradle to 7.6.4

2024-07-25 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 .. [build] KUDU-3551 Upgrade gradle to 7.6.4 The current version of g

[kudu-CR] [build] KUDU-3551 Upgrade gradle to 7.6.4

2024-07-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 29: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21610/1/src/kudu

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21610 to look at the new patch set (#2). Change subject: KUDU-3594 Fix scan_token-test on ASAN .. KUDU-359

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21610 to review the following change. Change subject: KUDU-3594 Fix scan_token-test on ASAN .. KUDU-3594 Fix scan_token-t

[kudu-CR] KUDU-3590 Update expired test certificates

2024-07-24 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21607 ) Change subject: KUDU-3590 Update expired test certificates .. KUDU-3590 Update expired test certificates Certificates generated

[kudu-CR] KUDU-3590 Update expired test certificates

2024-07-23 Thread Attila Bukor (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21607 to look at the new patch set (#2). Change subject: KUDU-3590 Update expired test certificates

[kudu-CR] KUDU-3590 Update expired test certificates

2024-07-23 Thread Attila Bukor (Code Review)
Hello Marton Greber, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21607 to review the following change. Change subject: KUDU-3590 Update expired test certificates .. KUDU-3

[kudu-CR] [KUDU-3583] Revert the default value of the flag --tablet history max age sec

2024-06-11 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21481 ) Change subject: [KUDU-3583] Revert the default value of the flag --tablet_history_max_age_sec .. Patch Set 2: (1 comment) How about

[kudu-CR] [build] KUDU-3551 Upgrade gradle to 7.6.4

2024-06-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 21: (6 comments) http://gerrit.cloudera.org:8080/#/c/21030/21//

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 4: (1 comment) http://gerrit.cloudera.org

[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list

2024-05-29 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21466 ) Change subject: Update build pattern for fetching flaky tests list .. Update build pattern for fetching flaky tests list During

[kudu-CR](branch-1.17.x) KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21465 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list

2024-05-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 ) Change subject: Update build pattern for fetching flaky tests list .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 3: (2 comments) http://gerrit.cloudera.or

[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list

2024-05-29 Thread Attila Bukor (Code Review)
Hello Marton Greber, Alexey Serbin, Ashwani Raina, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21466 to review the following change. Change subject: Update build pattern for fetching flaky tests list .

[kudu-CR] [alter table-test] Increase assertion timeout

2024-05-16 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21347 ) Change subject: [alter_table-test] Increase assertion timeout .. [alter_table-test] Increase assertion timeout On ubuntu 22.04

[kudu-CR] [alter table-test] Increase assertion timeout

2024-05-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21347 ) Change subject: [alter_table-test] Increase assertion timeout .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [alter table-test] Increase assertion timeout

2024-05-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21347 ) Change subject: [alter_table-test] Increase assertion timeout .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21347/2/

[kudu-CR] [common] switch from unique lock to lock guard

2024-05-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21414 ) Change subject: [common] switch from unique_lock to lock_guard .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21414/2

[kudu-CR] [tablet] update the severity level of some tablet metrics

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21384 ) Change subject: [tablet] update the severity level of some tablet metrics .. [tablet] update the severity level of some tablet m

[kudu-CR] [tablet] update the severity level of some tablet metrics

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 ) Change subject: [tablet] update the severity level of some tablet metrics .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit h

[kudu-CR] [tablet] update the severity level of some tablet metrics

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [tablet] update the severity level of some tablet metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21384 To uns

[kudu-CR] KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21397 ) Change subject: KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration .. KUDU-3216 fix flakiness in LeadershipChangeOnTskGe

[kudu-CR] KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21397 ) Change subject: KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21397 To un

[kudu-CR] [CmakeLists.txt] Fix typo

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. [CmakeLists.txt] Fix typo Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c Rev

[kudu-CR] [CmakeLists.txt] Fix typo

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubs

[kudu-CR] [CmakeLists.txt] Fix typo

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [CmakeLists.txt] Fix typo .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubscribe, visit http://gerrit.cl

[kudu-CR] [security-flags-itest] Fix missing command line flags

2024-05-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [CmakeLists.txt] Fix typo

2024-05-03 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21395 To uns

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21370 ) Change subject: [build] Fix RocksDB Snappy dependency. .. [build] Fix RocksDB Snappy dependency. RocksDB uses Snappy. When stat

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21370 ) Change subject: [build] Fix RocksDB Snappy dependency. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: [build] Fix RocksDB Snappy dependency. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21370 To unsubscribe, visit htt

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21370 ) Change subject: [build] Fix RocksDB Snappy dependency. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21360 ) Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor .. Patch Set 1: Code-Review+2 -- To view, visit htt

[kudu-CR] [Python] Update dependencies and 3.10 support

2024-05-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21380 ) Change subject: [Python] Update dependencies and 3.10 support .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21370 ) Change subject: [build] Fix RocksDB Snappy dependency. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21370/1//COMMIT

[kudu-CR] [docs] encryption-at-rest is now natively supported

2024-04-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21336 ) Change subject: [docs] encryption-at-rest is now natively supported .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [docs] encryption-at-rest is now natively supported

2024-04-25 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21336 ) Change subject: [docs] encryption-at-rest is now natively supported .. [docs] encryption-at-rest is now natively supported This

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. KUDU-3491 Destruct master before creating a new one Serv

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 6: Code-Review+2 Thanks -- To view, visit http://ger

[kudu-CR] KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] [master runner] Destruct server before new one

2024-01-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 ) Change subject: [master_runner] Destruct server before new one .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20913/

[kudu-CR] KUDU-3496 support spnego dedicated keytab

2024-01-15 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. KUDU-3496 support spnego dedicated keytab Add a --spnego_keytab_fi

[kudu-CR] KUDU-3496 support spnego dedicated keytab

2024-01-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-10 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. [compaction/flush] Cleanup of compaction and fl

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-10 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 8: Code-Review+2 -- To view, visit http://g

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 25: (2 comments) http://gerrit.cloud

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 23: (2 comments) http://gerrit.cloud

[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20861/1/

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: > Patch Set 7: Code-Review+1 > > LGTM, lo

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+2 -- To view, visit http://g

[kudu-CR] [compaction/test] Add tests to generate heavy rowset compaction

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction/test] Add tests to generate heavy rowset compaction .. Patch Set 6: (4 comments) http://gerrit.cloudera.or

[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana

2024-01-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 ) Change subject: Add blog post about Prometheus/Grafana .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20814/1/_posts

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-22 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18253/8/

[kudu-CR] KUDU-3496 support spnego dedicated keytab

2023-12-13 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/20278/9/src

[kudu-CR](branch-1.17.x) KUDU-3520 Fix file descriptor leak in encryption

2023-11-20 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20717 to review the following change. Change subject: KUDU-3520 Fix file descriptor leak in encryption .. K

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-13 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20631 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. KUDU-3520 Fix file descriptor leak in encryption In PosixEn

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-13 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20631 to look at the new patch set (#3). Change subject: KUDU-3520 Fix file descriptor leak in encryption

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-13 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2063

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-07 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18029 ) Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool .. [tools] KUDU-3337 Add unsafe_create_cmeta tool We've seen som

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-07 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 ) Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/18029/

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-07 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18029 to look at the new patch set (#8). Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 ) Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18029/

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18029 to look at the new patch set (#7). Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18029 to look at the new patch set (#6). Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18029 to look at the new patch set (#5). Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 ) Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/18029

[kudu-CR] [tools] KUDU-3337 Add unsafe create cmeta tool

2023-11-06 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18029 to look at the new patch set (#4). Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...

[kudu-CR] KUDU-3522 Fail early when encryption init fails

2023-11-04 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20651 ) Change subject: KUDU-3522 Fail early when encryption init fails .. KUDU-3522 Fail early when encryption init fails If encryptio

[kudu-CR] KUDU-3522 Fail early when encryption init fails

2023-11-03 Thread Attila Bukor (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20651 to review the following change. Change subject: KUDU-3522 Fail early when encryption init fails ..

[kudu-CR] KUDU-3519: List masters in /dump-entities

2023-11-03 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20628 ) Change subject: KUDU-3519: List masters in /dump-entities .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20628/1//CO

[kudu-CR] KUDU-3519: List masters in /dump-entities

2023-11-03 Thread Attila Bukor (Code Review)
Hello Marton Greber, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20628 to look at the new patch set (#2). Change subject: KUDU-3519: List masters in /dump-entities ..

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-02 Thread Attila Bukor (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20631 to look at the new patch set (#2). Change subject: KUDU-3520 Fix file descriptor leak in encryption

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2063

[kudu-CR] [fs] add redaction attribute for server key and its IV

2023-11-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20645 ) Change subject: [fs] add redaction attribute for server key and its IV .. Patch Set 1: Code-Review-1 looks like this causes a build fai

[kudu-CR] [util] check if EVP CIPHER CTX new() returns null

2023-11-02 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20642 ) Change subject: [util] check if EVP_CIPHER_CTX_new() returns null .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-10-30 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20631 Change subject: KUDU-3520 Fix file descriptor leak in encryption .. KUDU-3520 Fix file descriptor leak in encryption In PosixEnv, when c

[kudu-CR] KUDU-3519: List masters in /dump-entities

2023-10-26 Thread Attila Bukor (Code Review)
Hello Marton Greber, Abhishek Chennaka, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/20628 to review the following change. Change subject: KUDU-3519: List masters in /dump-entities .. KUD

[kudu-CR] Minor refactors on kudu-tool-test

2023-10-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 ) Change subject: Minor refactors on kudu-tool-test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2059

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-20 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20365 to look at the new patch set (#14). Change subject: KUDU-3504 Crash master on subprocess death ..

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-17 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20365 to look at the new patch set (#13). Change subject: KUDU-3504 Crash master on subprocess death ..

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20365 ) Change subject: KUDU-3504 Crash master on subprocess death .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/20365/11/

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-17 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20365 to look at the new patch set (#12). Change subject: KUDU-3504 Crash master on subprocess death ..

[kudu-CR] KUDU-3359 Allow multi-JAR cp for Ranger client

2023-08-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20346 ) Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client .. Patch Set 2: > Patch Set 1: Code-Review+1 > > Could you please add tw

[kudu-CR] KUDU-3359 Allow multi-JAR cp for Ranger client

2023-08-17 Thread Attila Bukor (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20346 to look at the new patch set (#3). Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client .

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-17 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20365 to look at the new patch set (#11). Change subject: KUDU-3504 Crash master on subprocess death ..

[kudu-CR] KUDU-3503 Allow extra JVM arguments

2023-08-17 Thread Attila Bukor (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20347 to look at the new patch set (#14). Change subject: KUDU-3503 Allow extra JVM arguments ...

[kudu-CR] KUDU-3504 Crash master on subprocess death

2023-08-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20365 ) Change subject: KUDU-3504 Crash master on subprocess death .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/20365/10/

  1   2   3   4   5   6   7   8   9   10   >