David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] notes for timestamp-related methods
..
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4569/5/src/kudu/client/client.h
File src
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] added basic test for RWYW behavior
..
Patch Set 2:
As I had suggested if you made so that the test always failed, we could merge
it disabled
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional
types
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4589/2/python/kudu/c
David Ribeiro Alves has posted comments on this change.
Change subject: [docs] Python updates for development page
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4586/1/docs/developing.adoc
File docs/developi
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Temporarily ignore row count regressions in
ITClient
..
Patch Set 1:
oh and don't forget to point to the umbrella jira (KUDU-430) there are
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Temporarily ignore row count regressions in
ITClient
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4597
T
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Temporarily ignore row count regressions in
ITClient
..
Patch Set 1:
After talking to JD and unserstanding how the test works, I actually ch
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] notes for timestamp-related methods
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4569/4/src/kudu/client/client.h
File src/
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 7:
looking good, only a few nits and one thing about metrics. thank you for your
perseverance .
--
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 7:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/client.cc
File src/kudu/c
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention
from target
..
Patch Set 4: Code-Review+1
My comment is more of a follow on. +1 "Keep Going" :
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention
from target
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4470/4//COMMIT_MS
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/tes
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] added few deprecation notes
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4569/3//COMMIT_MSG
Commit Message:
Line 18: Davi
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] added few deprecation notes
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4569/3//COMMIT_MSG
Commit Message:
Line 18: Davi
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] added few deprecation notes
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4569/3/src/kudu/client/client.h
File src/kudu/cl
David Ribeiro Alves has posted comments on this change.
Change subject: Python - Clean up distutils classifiers and package information
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
Fil
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1654 - [python] Python 3 Client Test Failure:
test_table_column
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4543
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/client.p
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] added basic test for RWYW behavior
..
Patch Set 1:
|The test loops when it sees timeout from a tablet replica catching-up, not
just to get e
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] added few deprecation notes
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4569/2/src/kudu/client/client.h
File src/kudu/cli
David Ribeiro Alves has posted comments on this change.
Change subject: Remove newlines from raft_consensus.cc state logging
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4580
To unsubscribe,
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Temporarily ignore row count regressions in
ITClient
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4597/1/java/kudu-clien
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] added basic test for RWYW behavior
..
Patch Set 1:
Btw, a more interesting test, perhaps, would be one that _always_ failed, i.e.
that made
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] added basic test for RWYW behavior
..
Patch Set 1:
I have an ambivalent opinion regarding this test.
Read Your Writes means that a client ca
David Ribeiro Alves has posted comments on this change.
Change subject: Remove newlines from raft_consensus.cc state logging
..
Patch Set 1:
(should say I don't fell super-strongly about it either way, mostly just
curious)
--
David Ribeiro Alves has posted comments on this change.
Change subject: Remove newlines from raft_consensus.cc state logging
..
Patch Set 1:
did you have a specific problem with the new lines? it seems like it helps with
findi
David Ribeiro Alves has posted comments on this change.
Change subject: Python - Clean up distutils classifiers and package information
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
Fil
David Ribeiro Alves has posted comments on this change.
Change subject: Python - Clean up distutils classifiers and package information
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4579
To un
David Ribeiro Alves has posted comments on this change.
Change subject: [c++ client] added few deprecation notes
..
Patch Set 2:
(1 comment)
I think that the get/set latest timestamp APIs can be marked with "unstable" or
"exp
David Ribeiro Alves has posted comments on this change.
Change subject: [tools] select only tablet leader for RWYW
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4571
To unsubscribe, visit http
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2642
to look at the new patch set (#7).
Change subject: Add a design doc for rpc retry/failover semantics
..
Add a desig
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2642
to look at the new patch set (#6).
Change subject: Add a design doc for rpc retry/failover semantics
..
Add a desig
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash
..
Patch Set 5: Code-Review+2
+2 from me, once Adar's nits get addressed. Thanks for adding
David Ribeiro Alves has posted comments on this change.
Change subject: build-and-test.sh: update gcovr location
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4567
To unsubscribe, visit http:/
David Ribeiro Alves has posted comments on this change.
Change subject: build-and-test.sh: update gcovr location
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4567
To unsubscribe, visit http:/
David Ribeiro Alves has posted comments on this change.
Change subject: [docs] Cleanup beta mentions, links
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4565
To unsubscribe, visit http://gerr
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash
..
Patch Set 2:
(1 comment)
that test is going to bit rot super quickly and this seems lik
David Ribeiro Alves has posted comments on this change.
Change subject: docs: add master permanent failure recovery workflow
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4436
To unsubscribe,
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: consensus: refactor tracking of received OpIds out of
ReplicaState
..
Patch Set 1:
I like the consolidation and, as I had said on the mailing list, I
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/tests/uti
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash
..
Patch Set 2:
why not include the test and only run it in slow mode? jenkins runs tests w
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 7:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4491/7/src/kudu/integration-tests/fuzz-itest.cc
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/client.p
David Ribeiro Alves has posted comments on this change.
Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4469
To unsubscribe, visi
David Ribeiro Alves has submitted this change and it was merged.
Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h
..
metrics: move SCOPED_LATENCY_METRIC to metrics.h
Addresses a simple TODO.
Change-Id: I1f1287a
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..
Patch Set 4:
i'm ok with doing the test elsewhere, what you said about test running times
make se
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe,
David Ribeiro Alves has posted comments on this change.
Change subject: consensus: fix some clang-tidy warnings
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4454
To unsubscribe, visit http://
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..
Patch Set 5:
nah, that all I wanted. thanks
--
To view, visit http://gerrit.cloudera.org:8080/4477
To
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visi
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..
Patch Set 4:
my point was that we should make sure to stress it a bit so that over time we
will h
David Ribeiro Alves has posted comments on this change.
Change subject: consensus: fix some clang-tidy warnings
..
Patch Set 2:
still missing some tidy warnings right?
--
To view, visit http://gerrit.cloudera.org:8080/4454
To
David Ribeiro Alves has posted comments on this change.
Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4469
To unsubscribe, visi
David Ribeiro Alves has posted comments on this change.
Change subject: Add a basic .clang-tidy configuration
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4453
To unsubscribe, visit http://ge
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..
Patch Set 5:
have you tried to run the demo app now?
--
To view, visit http://gerrit.cloudera.org:808
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Reinstate KUDU-1364's behavior, fix NPE
..
Patch Set 1: Code-Review+2
thanks for fixing this.
yeah, it'd be good to have directed tests for t
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1637 - [python] Add Support for < and > Predicates
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4524
To unsubscrib
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Improve and hide
OperationResponse#getWriteTimestamp
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4487
T
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..
Patch gperftools to be able to work on macOS Sierra/XCode 8
Apparently gperftools n
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4492/3/src/kudu/client/client-test.c
David Ribeiro Alves has uploaded a new patch set (#2).
Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..
Patch gperftools to be able to work on macOS Sierra/XCode 8
Apparently gperftools needs to be
David Ribeiro Alves has posted comments on this change.
Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-th
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4495
Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..
Patch gperftools to be able to work on macOS Sierra/
David Ribeiro Alves has posted comments on this change.
Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4471
To unsubscribe, visit
David Ribeiro Alves has posted comments on this change.
Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..
Patch Set 5:
(2 comments)
oops had a unpublished comment. my apologies.
http://gerrit.cloudera.org:8080
David Ribeiro Alves has posted comments on this change.
Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4492/1/src/kudu/client/client-test.c
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Improve and hide
OperationResponse#getWriteTimestamp
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4487/1/java/kudu-clien
David Ribeiro Alves has posted comments on this change.
Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 2:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/4491/2/java/kudu-client/src/main/java/org
David Ribeiro Alves has posted comments on this change.
Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 2:
At first glance I'd start by suggesting you split the patches for the various
clients. Diff
David Ribeiro Alves has posted comments on this change.
Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_type
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Add support for clang from XCode 8 in macOS
..
Add support for clang from XCode 8 in macOS
Since upgrading XCode to 8 (even in El Capitan), cmake
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4482
to look at the new patch set (#2).
Change subject: Add support for clang from XCode 8 in macOS
..
Add support for cl
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
..
Patch Set 1:
It seems this is missing a gperftools side update to work with tcmalloc:
https://github.com/gp
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
..
Patch Set 1: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/4482
To unsubscribe, visit http
David Ribeiro Alves has posted comments on this change.
Change subject: Add support for clang from XCode 8 in macOS
..
Patch Set 1: Code-Review-1
Hum, turns out there's a malloc issue with the new compiler. Sorting that out
fi
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4482
Change subject: Add support for clang from XCode 8 in macOS
..
Add support for clang from XCode 8 in macOS
Since upgrading XCode t
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..
Patch Set 3:
did you test this manually? I'm not sure whether jenkins even builds this
(needs oauth) a
David Ribeiro Alves has posted comments on this change.
Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/integration-tests/alter_ta
David Ribeiro Alves has posted comments on this change.
Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/client/client-test.cc
File
David Ribeiro Alves has posted comments on this change.
Change subject: Add a basic .clang-tidy configuration
..
Patch Set 1:
any docs on how to use this locally?
--
To view, visit http://gerrit.cloudera.org:8080/4453
To unsu
David Ribeiro Alves has posted comments on this change.
Change subject: consensus: remove some unimplemented methods
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4452
To unsubscribe, visit ht
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Improve the debuggability of
LogBlockContainer::CheckBlockRecord()
..
Improve the debuggability of LogBlockContainer::CheckBlockRecord()
We're ge
David Ribeiro Alves has posted comments on this change.
Change subject: Improve the debuggability of
LogBlockContainer::CheckBlockRecord()
..
Patch Set 2:
added printing out the file name
--
To view, visit http://gerrit.clou
Hello Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4451
to look at the new patch set (#2).
Change subject: Improve the debuggability of
LogBlockContainer::CheckBlockRecord()
..
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4451
Change subject: Improve the debuggability of
LogBlockContainer::CheckBlockRecord()
..
Improve the debuggability of LogBlockContain
David Ribeiro Alves has posted comments on this change.
Change subject: row_operations-test: reduce iterations in ASAN build
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4449
To unsubscribe,
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4441
To uns
David Ribeiro Alves has posted comments on this change.
Change subject: Python - Bump package version to 0.4.0
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/
To unsubscribe, visit http://g
David Ribeiro Alves has posted comments on this change.
Change subject: [c++client] performance optimizations
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://ge
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..
Change timestamp printing to ISO-8601 (with microseconds)
Dan raised the concern in a
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..
Patch Set 8: Code-Review+1
Leaving a +1 so that Todd can take one last look
--
To view, visit h
David Ribeiro Alves has posted comments on this change.
Change subject: [c++client] performance optimizations
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc
File src/kudu/clie
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4441/2/src/kudu/tablet/key
David Ribeiro Alves has posted comments on this change.
Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..
Patch Set 3:
Dan mentioned that it had already done it for java
--
To view, visit http://ger
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when
voting
..
Patch Set 1: Verified+1
unrelated flake
--
To view, visit http://gerrit.cloudera.o
David Ribeiro Alves has posted comments on this change.
Change subject: [client] performance optimizations
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc
File src/kudu/client
David Ribeiro Alves has posted comments on this change.
Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..
Patch Set 3: Verified+1
unrelated flake org.apache.kudu.client.ITClient.test
--
To view, vis
David Ribeiro Alves has posted comments on this change.
Change subject: [client] performance optimizations
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/batcher.cc
File src/kudu/client/
David Ribeiro Alves has posted comments on this change.
Change subject: Make tablet history GC itest less flaky
..
Patch Set 1: Verified+1
unrelated java flake
--
To view, visit http://gerrit.cloudera.org:8080/4433
To unsubsc
1601 - 1700 of 1777 matches
Mail list logo
