[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-16 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21295 to look at the new patch set (#2). Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing .. Patch Set 2: (11 comments)

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. KUDU-3371 Unify the 'rdb' directory name Change-Id:

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21298 ) Change subject: KUDU-3371 Unify the 'rdb' directory name .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-15 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yifan Zhang, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21298 to look at the new patch set (#2). Change subject: KUDU-3371 Unify the 'rdb' directory name

[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. Patch Set 1: > Patch Set 1: > > (1 comment) I

[kudu-CR] KUDU-3371 Unify the 'rdb' directory name

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21298 Change subject: KUDU-3371 Unify the 'rdb' directory name .. KUDU-3371 Unify the 'rdb' directory name Change-Id:

[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert

2024-04-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21296 ) Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing

2024-04-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21295 Change subject: KUDU-3371 Check whether the RocksDB dir incorrectly exist or missing .. KUDU-3371 Check whether the RocksDB dir

[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21287 Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. KUDU-3371 Fix the crash bug when run binaries on

[kudu-CR](branch-1.17.x) KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21272 ) Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks .. Patch Set 1: Code-Review+2 --

[kudu-CR](branch-1.17.x) KUDU-3326 correct error messages in tool usage instructions

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21273 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] one less memory allocation in CBTree::count()

2024-04-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Patch Set 2: Some tests failed, I'll fix them later. -- To

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 ) Change subject: Skip unhealthy directories when opening DirManager .. Patch Set 2: (1 comment)

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21275 to look at the new patch set (#2). Change subject: Skip unhealthy directories when opening DirManager .. Skip

[kudu-CR] Skip unhealthy directories when opening DirManager

2024-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21275 Change subject: Skip unhealthy directories when opening DirManager .. Skip unhealthy directories when opening DirManager If a directory

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: > Patch Set 6: > > Just a clarifying

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: Verified+1 The failed test is not related:

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21075 To

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#6). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#5). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#4). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-10 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#3). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-03-10 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21075 to look at the new patch set (#2). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) ..

[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually

2024-03-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 ) Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. Patch Set 14: (7 comments)

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)

2024-02-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21075 Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually

2024-02-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 ) Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. Patch Set 12: (7 comments)

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: Code-Review+2 > Patch Set 6: Code-Review+2 >

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 2: Thanks Marton, could you please create a

[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest

2024-02-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [Tool] KUDU-3318 Compact container metadata file manually

2024-01-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 ) Change subject: [Tool] KUDU-3318 Compact container metadata file manually .. Patch Set 8: (21 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. KUDU-3371 [fs] Use RocksDB to store LBM metadata Since the

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: > Patch Set 73: > > Thank you very much for the

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: (2 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#73). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] [rpc] validate security-related parameters earlier

2024-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20961 ) Change subject: [rpc] validate security-related parameters earlier .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 5: Code-Review+2 (2 comments)

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20930 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-23 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#72). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 71: (71 comments)

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 71: (16 comments) I've reduced some down_cast by

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-10 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#71). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20875 ) Change subject: Use GTEST_SKIP() to skip tests .. Use GTEST_SKIP() to skip tests GTEST_SKIP() is better than manually logging

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20875 ) Change subject: Use GTEST_SKIP() to skip tests .. Patch Set 3: Verified+1 Remove the un-related failed test:

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Use GTEST_SKIP() to skip tests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20875 To unsubscribe, visit

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20875 to look at the new patch set (#3). Change subject: Use GTEST_SKIP() to skip tests .. Use

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20875 to look at the new patch set (#2). Change subject: Use GTEST_SKIP() to skip tests .. Use

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20875 Change subject: Use GTEST_SKIP() to skip tests .. Use GTEST_SKIP() to skip tests GTEST_SKIP() is better than manually logging and

[kudu-CR] Add CLion build directories to .gitignore

2024-01-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20873 Change subject: Add CLion build directories to .gitignore .. Add CLion build directories to .gitignore Change-Id:

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-09 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#70). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-08 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#69). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-07 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#68). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-07 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#67). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#66). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#65). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#64). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] [Tool] Find file path where the block is located

2023-12-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is located .. [Tool] Find file path where the block is located

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2023-12-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20833 ) Change subject: [fs] Simplify the data directory inheritance hierarchy .. Patch Set 3: Verified+1 Remove un-related failed test

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2023-12-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [fs] Simplify the data directory inheritance hierarchy .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20833 To

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-12-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 62: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-12-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 62: (22 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-12-25 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#62). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2023-12-25 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20833 to look at the new patch set (#3). Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs]

[kudu-CR] [fs] Simplify the data directory inheritance hierarchy

2023-12-25 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20833 to look at the new patch set (#2). Change subject: [fs] Simplify the data directory inheritance hierarchy .. [fs]

[kudu-CR] WIP [fs] Simplify the data directory inheritance hierarchy

2023-12-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20833 Change subject: WIP [fs] Simplify the data directory inheritance hierarchy .. WIP [fs] Simplify the data directory inheritance hierarchy

[kudu-CR] [Tool] Find file path where the block is located

2023-12-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is located .. Patch Set 7: Code-Review+2 Good job! Thanks for the contribution.

[kudu-CR] [Tool] Find file path where the block is located

2023-12-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is located .. Patch Set 5: Code-Review+1 (3 comments)

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. [Refactor] Fix a memory leak warning The following is the warning

[kudu-CR] [Tool] Find file path where the block is stored on

2023-12-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is stored on .. Patch Set 4: (2 comments)

[kudu-CR] [Tool] Find file path where the block is stored on

2023-12-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is stored on .. Patch Set 4: (8 comments)

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 ) Change subject: [rpc] increase listened socket backlog up to 512 .. Patch Set 2: Code-Review+1 (2 comments)

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 4: Code-Review+1 (4 comments)

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [Refactor] Fix a memory leak warning .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20784 To unsubscribe, visit

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [Tool] Find the container by block id

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find the container by block id .. Patch Set 2: (7 comments)

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 ) Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 ) Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. Patch Set 1: (1 comment)

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 ) Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[kudu-CR] KUDU-3524 Fix core of sending keep-alive requests periodically

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically .. Patch Set 3: (1 comment)

[kudu-CR] [util] add a warning into 'heap sample every n bytes' flag description.

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description. .. Patch Set 7: (1 comment)

[kudu-CR] [compaction] Fix the incorrect memory budgeting condition

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20758 ) Change subject: [compaction] Fix the incorrect memory budgeting condition .. Patch Set 1: > Patch Set 1: Code-Review+1 > > The patch

[kudu-CR] [compaction] Fix the incorrect memory budgeting condition

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20758 ) Change subject: [compaction] Fix the incorrect memory budgeting condition .. [compaction] Fix the incorrect memory budgeting

[kudu-CR] [compaction] Fix the incorrect memory budgeting condition

2023-12-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20758 ) Change subject: [compaction] Fix the incorrect memory budgeting condition .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [cfile] remove redundant StringPrintf in status messages

2023-11-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20740 ) Change subject: [cfile] remove redundant StringPrintf in status messages .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] update lz4 up to 1.9.4 version

2023-11-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20722 ) Change subject: [thirdparty] update lz4 up to 1.9.4 version .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) KUDU-3520 Fix file descriptor leak in encryption

2023-11-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20717 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. KUDU-3520 Fix file descriptor leak in encryption In

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-11-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 61: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-11-16 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#61). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3520 Fix file descriptor leak in encryption

2023-11-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 ) Change subject: KUDU-3520 Fix file descriptor leak in encryption .. Patch Set 4: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   9   10   >