[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. [tablet] Support accurate count of rows A tablet is consisted of on

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#14). Change subject: [tablet] Support accurate count of rows ...

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/11/src/kudu/

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/11/src/ku

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 13: Code-Review+1 (2 comments) One last nit and this looks good to

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#13). Change subject: [tablet] Support accurate count of rows ...

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#12). Change subject: [tablet] Support accurate count of rows ...

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: (8 comments) http://gerrit.cloudera.org:8080/#/c/13456/11//COMMIT_M

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: (8 comments) Some nits and a testing suggestion, overall LGTM.

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#11). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/10/src/kudu/

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/13456/10/src/k

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#10). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#9). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#8). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MS

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMI

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#7). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT

[kudu-CR] [tablet] Support accurate count of rows

2019-06-01 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#6). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#5). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 4: (19 comments) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_MS

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 4: (19 comments) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMI

[kudu-CR] [tablet] Support accurate count of rows

2019-05-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#4). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#3). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/2//COMMIT_

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13456/2//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 2: (3 comments) I don http://gerrit.cloudera.org:8080/#/c/13456/2/

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#2). Change subject: [tablet] Support accurate count of rows .. [tablet] Support accu

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/1/src/kudu/tab

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13456 Change subject: [tablet] Support accurate count of rows .. [tablet] Support accurate count of rows For the MemRowSet and DeltaMemStore, there