On June 24, 2015, 7:17 a.m., Adam B wrote:
Looks good to me, but I'm no js expert. Matches what Brian suggested in the
ticket.
haosdent, did you do any (manual) testing on this? Maybe you could link to
a before/after screenshot?
Yes, I upload the screenshots to
On June 24, 2015, 8:04 a.m., Adam B wrote:
This seems like a positive step forward, since all volumes were previously
owned by root (or whatever user the slave was run as). However, if a
persistent volume is passed from one framework to another within the same
role, they might have
On June 24, 2015, 1:04 a.m., Adam B wrote:
This seems like a positive step forward, since all volumes were previously
owned by root (or whatever user the slave was run as). However, if a
persistent volume is passed from one framework to another within the same
role, they might have
On June 24, 2015, 8:04 a.m., Adam B wrote:
This seems like a positive step forward, since all volumes were previously
owned by root (or whatever user the slave was run as). However, if a
persistent volume is passed from one framework to another within the same
role, they might have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/#review89138
---
This seems like a positive step forward, since all volumes were
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review89141
---
Ship it!
Ship It!
- Adam B
On June 23, 2015, 3:14 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review89136
---
Looks good to me, but I'm no js expert. Matches what Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review89140
---
Looks great! We recently added validation lambdas to flag
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review89147
---
src/tests/docker_tests.cpp (line 333)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89275
---
Patch looks great!
Reviews applied: [35841]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89245
---
Ship it!
Ship It!
- Michael Park
On June 24, 2015, 8:15 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/#review89247
---
This is good, see my only comment, not even sure that's an issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89250
---
Patch looks great!
Reviews applied: [35843]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/
---
(Updated June 24, 2015, 9:14 p.m.)
Review request for mesos, Alexander
On June 18, 2015, 9:46 a.m., Bernd Mathiske wrote:
docs/mesos-c++-style-guide.md, line 555
https://reviews.apache.org/r/34835/diff/2/?file=984763#file984763line555
All , could be . here.
, before or missing.
I've switched to shorter sentances, but I don't see anything
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/
---
(Updated June 24, 2015, 10:01 p.m.)
Review request for mesos and Till
On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
Why do we use different approaches (emplace() and insert()) in c-tors? Is
it possible to unify them for clarity? If not, mind leaving a comment
explaining the reasoning?
Great idea, I added a comment as to why we use 'insert'
On June 23, 2015, 12:35 a.m., Till Toenshoff wrote:
src/tests/containerizer.cpp, lines 127-128
https://reviews.apache.org/r/35567/diff/2/?file=988913#file988913line127
Cant follow this one - are you saying that `executorEnvironment(..)`
should possibly set environment variables?
+michael, does this look good to you? If so, I can get this committed.
On Wed, Jun 24, 2015 at 12:35 AM, haosdent huang haosd...@gmail.com wrote:
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89260
---
src/tests/resources_tests.cpp (lines 936 - 944)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89261
---
Ship it!
Ship It!
- Ben Mahler
On June 24, 2015, 10:10 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/
---
(Updated June 24, 2015, 9:53 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/
---
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/
---
(Updated June 24, 2015, 10:10 p.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/#review89271
---
src/tests/slave_tests.cpp (lines 2109 - 2110)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/
---
(Updated June 24, 2015, 10 p.m.)
Review request for mesos and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review89265
---
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35837/#review89273
---
Ship it!
Please do a sweep across the other allocator files:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35848/#review89274
---
Ship it!
Ship It!
- Till Toenshoff
On June 24, 2015, 10:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35561/#review89268
---
3rdparty/libprocess/src/subprocess.cpp (line 367)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35568/
---
(Updated June 24, 2015, 2:56 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35353/#review89158
---
Ship it!
Lets get this properly rebased and shipped :)
On June 9, 2015, 12:32 a.m., Ben Mahler wrote:
3rdparty/libprocess/src/tests/process_tests.cpp, line 1930
https://reviews.apache.org/r/33295/diff/10/?file=980632#file980632line1930
Any reason you could't use initializer list construction for this?
Lets add a `TODO(arojas): Use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/#review89164
---
Ship it!
src/slave/main.cpp (line 68)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review89292
---
Patch looks great!
Reviews applied: [34835]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35816/#review89295
---
Thanks Michael! Did you see jie's comment on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review89305
---
Actually, we should think about one more thing, how does this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89306
---
Patch looks great!
Reviews applied: [35855, 35856, 35857, 35858]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/#review89288
---
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89297
---
Ship it!
Nice test!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89307
---
Bad patch!
Reviews applied: [35861]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35838/#review89291
---
Ship it!
src/master/allocator/mesos/hierarchical.hpp (lines 289 -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review89280
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 4:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89296
---
Patch looks great!
Reviews applied: [35849]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2928
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review89279
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 4:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35856/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/
---
(Updated June 25, 2015, 12:29 a.m.)
Review request for mesos, Benjamin
On June 25, 2015, 12:31 a.m., Ben Mahler wrote:
Thanks Michael! Did you see jie's comment on
[MESOS-1187](https://issues.apache.org/jira/browse/MESOS-1187)? Looks like
that will make these kinds of checks problematic.
Also, it's going to be possible for the slave to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/
---
(Updated June 25, 2015, 1:11 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/#review89303
---
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/
---
(Updated June 24, 2015, 5:06 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35816/
---
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 24, 2015, 3:39 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35568/#review89174
---
Ship it!
This doc is by no means finished. The purpose of this
On June 24, 2015, 12:44 a.m., Ben Mahler wrote:
src/master/allocator/mesos/hierarchical.hpp, lines 702-703
https://reviews.apache.org/r/35699/diff/1/?file=988943#file988943line702
Whoops, Jie just noticed that this isn't correct because
'updatedAllocation' is for the framework
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35568/#review89171
---
Patch looks great!
Reviews applied: [35363, 35568]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
---
(Updated June 25, 2015, 4:02 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35863/#review89316
---
Ship it!
Ship It!
- Michael Park
On June 25, 2015, 5:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89317
---
Patch looks great!
Reviews applied: [35861]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 4:29 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35863/
---
(Updated June 25, 2015, 1:47 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35863/
---
Review request for mesos.
Bugs: MESOS-2932
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/#review89227
---
include/mesos/slave/isolator.hpp (line 71)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35816/#review89179
---
Patch looks great!
Reviews applied: [35816]
All tests passed.
-
On June 22, 2015, 8:04 p.m., Ben Mahler wrote:
Adding this seems good since it's agnostic to how it is used. But for
reservations specifically, any reason not to use just BadRequest?
From what I can tell, this is generally used for conditional requests
(based on headers or some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/
---
(Updated June 24, 2015, 9:28 a.m.)
Review request for mesos.
Changes
---
On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
docs/home.md, line 22
https://reviews.apache.org/r/33241/diff/4/?file=956804#file956804line22
I would call this file monitoring because it talks about metrics and
alerts.
[Monitoring] /documentation/latest/monitoring/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35353/
---
(Updated June 24, 2015, 5:32 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/
---
(Updated June 24, 2015, 6:01 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35837/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2919
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89226
---
Ship it!
Ship It!
- Timothy Chen
On June 22, 2015, 4:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35838/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review89220
---
Ship it!
Ship It!
- Joe Smith
On June 24, 2015, 9:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review89222
---
+1 on Adam's comments.
src/master/master.hpp (lines 630 - 651)
On June 24, 2015, 2:21 a.m., haosdent huang wrote:
src/tests/master_contender_detector_tests.cpp, line 844
https://reviews.apache.org/r/35815/diff/2/?file=990950#file990950line844
Oh, you are follow the test case before.
this doesn't make it right :)
Fixed (both places)
- Marco
On June 23, 2015, 8:10 p.m., Till Toenshoff wrote:
src/tests/docker_tests.cpp, line 60
https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line60
Out of curiosity, why 30 seconds?
Good question, it's the same timeout I've used in docker containerizer tests
for just a
On June 24, 2015, 2:31 a.m., Anand Mazumdar wrote:
src/tests/master_contender_detector_tests.cpp, line 865
https://reviews.apache.org/r/35815/diff/2/?file=990950#file990950line865
Leaking here too. This can be wrapped in Owned
Thanks for catching this.
Clearly been doing too much
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review89191
---
Patch looks great!
Reviews applied: [33241]
All tests passed.
-
On June 24, 2015, 10:13 a.m., Bernd Mathiske wrote:
src/tests/docker_tests.cpp, line 374
https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line374
Use Flags::docker_sandbox_directory (or a constant that the flag also
uses for its default value) instead. Not only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review89230
---
Ship it!
LGTM. I'll get this committed.
- Vinod Kone
On June
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---
(Updated June 24, 2015, 7:14 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---
(Updated June 24, 2015, 7:13 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review89243
---
Ship it!
Ship It!
- Niklas Nielsen
On June 22, 2015, 3:03 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
---
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian
89 matches
Mail list logo
