Re: Review Request 35863: Fix a typo in docs/docker-containerizer.md file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35863/#review89326 --- Patch looks great! Reviews applied: [35863] All tests passed. - M

Re: Review Request 34137: Add support for container image provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review89227 --- include/mesos/slave/isolator.hpp (line 71)

Re: Review Request 35861: Correct include list errors for stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/#review89317 --- Patch looks great! Reviews applied: [35861] All tests passed. - M

Re: Review Request 35863: Fix a typo in docs/docker-containerizer.md file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35863/#review89316 --- Ship it! Ship It! - Michael Park On June 25, 2015, 5:47 a.m., Zh

Re: Review Request 35863: Fix a typo in docs/docker-containerizer.md file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35863/ --- (Updated June 25, 2015, 1:47 p.m.) Review request for mesos. Bugs: MESOS-2932

Review Request 35863: Fix a typo in docs/docker-containerizer.md file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35863/ --- Review request for mesos. Bugs: MESOS-2932 https://issues.apache.org/jira/b

Re: Review Request 35861: Correct include list errors for stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/ --- (Updated June 25, 2015, 4:29 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/ --- (Updated June 25, 2015, 4:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/ --- (Updated June 25, 2015, 4:02 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89310 --- Ship it! Sweetness! Thanks for that :) 3rdparty/libprocess/includ

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review89308 --- src/master/master.cpp (line 1653)

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/ --- (Updated June 25, 2015, 3:55 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35861: Correct include list errors for stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/#review89307 --- Bad patch! Reviews applied: [35861] Failed command: ./support/appl

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/#review89306 --- Patch looks great! Reviews applied: [35855, 35856, 35857, 35858] A

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review89305 --- Actually, we should think about one more thing, how does this intera

Re: Review Request 35743: flags: fixed const'ness of load

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review89303 --- 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (lines 341

Re: Review Request 35743: flags: fixed const'ness of load

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review89304 --- Patch looks great! Reviews applied: [35743] All tests passed. - M

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

> On June 25, 2015, 12:31 a.m., Ben Mahler wrote: > > Thanks Michael! Did you see jie's comment on > > [MESOS-1187](https://issues.apache.org/jira/browse/MESOS-1187)? Looks like > > that will make these kinds of checks problematic. > > > > Also, it's going to be possible for the slave to be ov

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35857/ --- (Updated June 25, 2015, 1:11 a.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- (Updated June 25, 2015, 1:11 a.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35836/#review89289 --- Ship it! Thanks! src/master/allocator/mesos/hierarchical.hpp (lin

Review Request 35861: Correct include list errors for stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2928 https://issues.ap

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

> On June 25, 2015, 12:31 a.m., Ben Mahler wrote: > > Thanks Michael! Did you see jie's comment on > > [MESOS-1187](https://issues.apache.org/jira/browse/MESOS-1187)? Looks like > > that will make these kinds of checks problematic. > > > > Also, it's going to be possible for the slave to be ov

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

> On June 25, 2015, 12:31 a.m., Ben Mahler wrote: > > Thanks Michael! Did you see jie's comment on > > [MESOS-1187](https://issues.apache.org/jira/browse/MESOS-1187)? Looks like > > that will make these kinds of checks problematic. > > > > Also, it's going to be possible for the slave to be ov

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/#review89297 --- Ship it! Nice test! src/tests/master_contender_detector_tests.cpp

Re: Review Request 35849: Added a precision test for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35849/#review89296 --- Patch looks great! Reviews applied: [35849] All tests passed. - M

Review Request 35858: Added Message call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35816/#review89295 --- Thanks Michael! Did you see jie's comment on [MESOS-1187](https://i

Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35857/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco

Re: Review Request 35743: flags: fixed const'ness of load

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/ --- (Updated June 25, 2015, 12:29 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 35856: Added Revive call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35856/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco

Review Request 35855: Added Decline call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco

Re: Review Request 35838: Added a TODO about RefusedFilter in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35838/#review89291 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (lines 289 -

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89292 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 35743: flags: fixed const'ness of load

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review89288 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/#review89281 --- Ship it! Ship It! - Till Toenshoff On June 20, 2015, 4:49 p.m.,

Re: Review Request 35286: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (libprocess)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/#review89280 --- Ship it! Ship It! - Till Toenshoff On June 20, 2015, 4:47 p.m.,

Re: Review Request 35287: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (stout)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/#review89279 --- Ship it! Ship It! - Till Toenshoff On June 20, 2015, 4:48 p.m.,

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89275 --- Patch looks great! Reviews applied: [35841] All tests passed. - M

Re: Review Request 35848: Fixed typo in getting started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35848/#review89274 --- Ship it! Ship It! - Till Toenshoff On June 24, 2015, 10:09 p.m.,

Re: Review Request 35837: Fixed right angle brackets in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35837/#review89273 --- Ship it! Please do a sweep across the other allocator files: src/m

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review89242 --- Ship it! Thanks Adam, looks good, just one suggestion related to na

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review89271 --- src/tests/slave_tests.cpp (lines 2109 - 2110)

Re: Review Request 35561: Updated process::subprocess to replace environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35561/#review89268 --- 3rdparty/libprocess/src/subprocess.cpp (line 367)

Re: Review Request 34943: Added validation to flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review89265 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (l

Re: Review Request 35849: Added a precision test for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35849/#review89260 --- src/tests/resources_tests.cpp (lines 936 - 944)

Re: Review Request 35849: Added a precision test for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35849/#review89261 --- Ship it! Ship It! - Ben Mahler On June 24, 2015, 10:10 p.m., Jie

Re: Review Request 35849: Added a precision test for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35849/ --- (Updated June 24, 2015, 10:10 p.m.) Review request for mesos, Ben Mahler, Micha

Review Request 35848: Fixed typo in getting started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35848/ --- Review request for mesos and Adam B. Repository: mesos Description --- F

Review Request 35849: Added a precision test for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35849/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

> On June 23, 2015, 12:35 a.m., Till Toenshoff wrote: > > src/tests/containerizer.cpp, lines 127-128 > > > > > > Cant follow this one - are you saying that `executorEnvironment(..)` > > should possibly set environmen

Re: Review Request 35694: Added helper constructors to hashmap.

> On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote: > > Why do we use different approaches (emplace() and insert()) in c-tors? Is > > it possible to unify them for clarity? If not, mind leaving a comment > > explaining the reasoning? Great idea, I added a comment as to why we use 'insert

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/ --- (Updated June 24, 2015, 10:01 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

+michael, does this look good to you? If so, I can get this committed. On Wed, Jun 24, 2015 at 12:35 AM, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32750/#revie

Re: Review Request 35694: Added helper constructors to hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35694/ --- (Updated June 24, 2015, 10 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35836/ --- (Updated June 24, 2015, 9:53 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 34835: Add constexpr to C++ whitelist

> On June 18, 2015, 9:46 a.m., Bernd Mathiske wrote: > > docs/mesos-c++-style-guide.md, line 555 > > > > > > All "," could be "." here. > > > > "," before "or" missing. I've switched to shorter sentances, but

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- (Updated June 24, 2015, 9:14 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 35843: Making markup doxygen-friendly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35843/#review89250 --- Patch looks great! Reviews applied: [35843] All tests passed. - M

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89247 --- This is good, see my only comment, not even sure that's an issue her

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/ --- (Updated June 24, 2015, 8:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89246 --- Ship it! Great catch! Thanks for these Paul, just minor comments re

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89245 --- Ship it! Ship It! - Michael Park On June 24, 2015, 8:15 p.m., Pa

Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian Downe

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review89243 --- Ship it! Ship It! - Niklas Nielsen On June 22, 2015, 3:03 a.m.,

Review Request 35843: Making markup doxygen-friendly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35843/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 7:14 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/ --- (Updated June 24, 2015, 7:13 p.m.) Review request for mesos and Vinod Kone. S

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review89230 --- Ship it! LGTM. I'll get this committed. - Vinod Kone On June 24,

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89226 --- Ship it! Ship It! - Timothy Chen On June 22, 2015, 4:42 p.m., Ia

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/#review89224 --- Patch looks great! Reviews applied: [35815] All tests passed. - M

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89222 --- +1 on Adam's comments. src/master/master.hpp (lines 630 - 651)

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review89220 --- Ship it! Ship It! - Joe Smith On June 24, 2015, 9:28 a.m., Ricar

Re: Review Request 33241: docs: Add documentation on observability metrics.

> On June 3, 2015, 11:03 a.m., Vinod Kone wrote: > > docs/metrics.md, line 417 > > > > > > There are also fine grained metrics about task lost reasons. > > > > e.g: > > > > master/task_failed/source

Review Request 35838: Added a TODO about RefusedFilter in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35838/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Review Request 35837: Fixed right angle brackets in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35837/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Review Request 35836: Replaced slave's 'available' with 'allocated' in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35836/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2919 https

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/ --- (Updated June 24, 2015, 6:01 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 35799: Support mounting relative paths with docker.

> On June 23, 2015, 8:10 p.m., Till Toenshoff wrote: > > src/tests/docker_tests.cpp, line 60 > > > > > > Out of curiosity, why 30 seconds? Good question, it's the same timeout I've used in docker containerizer tests f

Re: Review Request 35799: Support mounting relative paths with docker.

> On June 24, 2015, 10:13 a.m., Bernd Mathiske wrote: > > src/tests/docker_tests.cpp, line 374 > > > > > > Use Flags::docker_sandbox_directory (or a constant that the flag also > > uses for its default value) instead.

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

> On June 24, 2015, 2:31 a.m., Anand Mazumdar wrote: > > src/tests/master_contender_detector_tests.cpp, line 865 > > > > > > Leaking here too. This can be wrapped in Owned<> Thanks for catching this. Clearly been doin

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

> On June 24, 2015, 2:21 a.m., haosdent huang wrote: > > src/tests/master_contender_detector_tests.cpp, line 844 > > > > > > Oh, you are follow the test case before. this doesn't make it right :) Fixed (both places)

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review89191 --- Patch looks great! Reviews applied: [33241] All tests passed. - M

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

> On June 22, 2015, 8:04 p.m., Ben Mahler wrote: > > Adding this seems good since it's agnostic to how it is used. But for > > reservations specifically, any reason not to use just BadRequest? > > > > From what I can tell, this is generally used for conditional requests > > (based on headers o

Re: Review Request 33241: docs: Add documentation on observability metrics.

> On June 3, 2015, 11:03 a.m., Vinod Kone wrote: > > docs/home.md, line 22 > > > > > > I would call this file monitoring because it talks about metrics and > > alerts. > > > > [Monitoring] /documentation/lates

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated June 24, 2015, 9:28 a.m.) Review request for mesos. Changes ---

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35816/#review89179 --- Patch looks great! Reviews applied: [35816] All tests passed. - M

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

> On June 22, 2015, 10:21 p.m., Ben Mahler wrote: > > Till, will you be able to help Alex get these committed? If not, I'm happy > > to help out. Sry for the delay, we had some holiday / sick-day slowdown here :). Comitted them now. - Till --

Re: Review Request 35568: Remove html from libprocess Developer Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35568/#review89174 --- Ship it! This doc is by no means finished. The purpose of this inte

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 24, 2015, 3:39 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35568: Remove html from libprocess Developer Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35568/#review89171 --- Patch looks great! Reviews applied: [35363, 35568] All tests passe

Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35816/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos Descriptio

Re: Review Request 35699: Added an invariant CHECK_EQ for available resources in HierarchicalAllocator::updateAllocation.

> On June 24, 2015, 12:44 a.m., Ben Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 702-703 > > > > > > Whoops, Jie just noticed that this isn't correct because > > 'updatedAllocation' is for the

Re: Review Request 35353: Smaller fixes on libprocess firewall

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35353/ --- (Updated June 24, 2015, 5:32 p.m.) Review request for mesos, Ben Mahler and Til

Re: Review Request 35353: Smaller fixes on libprocess firewall

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35353/ --- (Updated June 24, 2015, 5:06 p.m.) Review request for mesos, Ben Mahler and Til

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35354/ --- (Updated June 24, 2015, 5:06 p.m.) Review request for mesos, Ben Mahler and Til

Re: Review Request 35568: Remove html from libprocess Developer Guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35568/ --- (Updated June 24, 2015, 2:56 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35354/#review89164 --- Ship it! src/slave/main.cpp (line 68)

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 9, 2015, 12:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1930 > > > > > > Any reason you could't use initializer list construction for this? Lets add a `TODO(arojas)

Re: Review Request 35353: Smaller fixes on libprocess firewall

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35353/#review89158 --- Ship it! Lets get this properly rebased and shipped :) 3rdparty/l

  1   2   >