Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- (Updated Oct. 8, 2015, 6:59 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 8, 2015, 7:01 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101881 --- Patch looks great! Reviews applied: [37024] All tests passed. -

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

Good call. Let’s change it! > On Oct 7, 2015, at 11:14 PM, Benjamin Mahler > wrote: > > Seems like os::strerror() would be more consistent with our other posix api > wrappers. > > On Wed, Oct 7, 2015 at 9:27 AM, Bernd Mathiske > wrote: > This is an automatically g

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101883 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (l

Re: Review Request 39008: Used thread-safe replacement for strerror.

> On Oct. 7, 2015, 2:18 p.m., Ben Mahler wrote: > > src/tests/script.cpp, line 101 > > > > > > malloc is not async-signal-safe, and may be used by the string > > implementation, and so we must not use os::strerror (

Re: Review Request 39008: Used thread-safe replacement for strerror.

> On Oct. 7, 2015, 9:18 p.m., Ben Mahler wrote: > > src/tests/script.cpp, line 101 > > > > > > malloc is not async-signal-safe, and may be used by the string > > implementation, and so we must not use os::strerror (

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review101816 --- Partial, entirely incomplete but maybe helpful review :) 3rdparty

Re: Review Request 39087: Added support for non-ascii chars to apply-review.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39087/#review101901 --- Ship it! Ship It! - Jan Schlicht On Oct. 7, 2015, 4:54 p.m., Ga

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/ --- (Updated Oct. 8, 2015, 1:27 p.m.) Review request for mesos, Alexander Rojas, Ja

Re: Review Request 39088: Made shell test locale-independent.

> On Oct. 8, 2015, 9:52 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 961 > > > > > > s/LANG/LC_ALL > > > > At https://help.ubuntu.com/community/Locale it is state

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 8, 2015, 2:29 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 28 > > > > > > Suggestion: "In contast to strerror(), this function is thread-safe." Documentat

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

> On Oct. 6, 2015, 5:09 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 37 > > > > > > When strerror_r() returns EINVAL, you return an empty string? > > Cong Wang wrote: >

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 2:31 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/ --- (Updated Oct. 8, 2015, 2:36 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101910 --- Patch looks great! Reviews applied: [39088] All tests passed. -

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Oct. 8, 2015, 2:38 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 2:39 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 8, 2015, 3:32 p.m.) Review request for mesos, Adam B and Neil Con

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 8, 2015, 6 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 104 > > > > > > Can we use a real json string which can map to above resources? Yea we can; I was worried about the readability of

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review101924 --- Patch looks great! Reviews applied: [39005, 39006] All tests pass

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 8, 2015, 5:05 p.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101934 --- Patch looks great! Reviews applied: [39102] All tests passed. -

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 8, 2015, 6:15 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/ --- (Updated Oct. 8, 2015, 6:15 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/ --- (Updated Oct. 8, 2015, 6:26 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 8, 2015, 11:26 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On Oct. 1, 2015, 6:12 a.m., Guangya Liu wrote: > > support/apply-reviews.py, line 2 > > > > > > The import should be in alpha order > > Artem Harutyunyan wrote: > I am happy to fix this, but could you please jus

Review Request 39135: Fixed teardown test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39135/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 8, 2015, 11:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing abs

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On Oct. 3, 2015, 7:46 a.m., haosdent huang wrote: > > IMHO, we keep both apply-reviews.py and apply-reviews.sh and call > > apply-reviews.sh in apply-reviews.py looks strange. It would be better we > > add this function to apply-review.sh. Or create apply-reviews.py and > > deprecated apply-

Review Request 39137: Local puller: fixed minor style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39137/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 39136: Fixed log message when untarring local image

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39136/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 39136: Fixed log message when untarring local image

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39136/#review101947 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 6:43 p.m., Jo

Re: Review Request 39137: Local puller: fixed minor style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39137/#review101948 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 6:43 p.m., Jo

Review Request 39138: Renamed libprocess tests to libprocess-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39138/ --- Review request for mesos, James Peach and Joris Van Remoortere. Bugs: MESOS-358

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/ --- (Updated Oct. 8, 2015, 3:29 p.m.) Review request for mesos, Cody Maloney, Joris

Re: Review Request 29550: Libprocess: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/ --- (Updated Oct. 8, 2015, 3:29 p.m.) Review request for mesos, Cody Maloney, Joris

Review Request 39141: Store: minor style changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101841 --- Ship it! Thanks for your patience! Committing this shortly. src/

Re: Review Request 39141: Store: minor style changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101951 --- src/slave/containerizer/provisioner/docker/store.cpp (line 202)

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review101953 --- Can you update the docs to mention this? Maybe just submitting-a-pa

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/ --- (Updated Oct. 8, 2015, 4:21 p.m.) Review request for mesos, Cody Maloney, Joris

Re: Review Request 29551: Added "tests" target for make.

> On Oct. 8, 2015, 4:15 p.m., Neil Conway wrote: > > Can you update the docs to mention this? Maybe just submitting-a-patch. Done! :-) - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/

Re: Review Request 39141: Store: minor style changes

> On Oct. 8, 2015, 7:40 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 202 > > > > > > In this particular case, `push_back` would also do a `std::move` for a > > temporary

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review101956 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39138/#review101957 --- You should also rename ```benchmarks``` and ```ssl-client```. - Ja

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

> On Oct. 8, 2015, 5:24 p.m., James Peach wrote: > > You should also rename ```benchmarks``` and ```ssl-client```. Good suggestion. But I think, it will be better to do that in a separate RR (just to keep this RR chain strictly relevant for `make tests`). - Kapil ---

Re: Review Request 39141: Store: minor style changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/ --- (Updated Oct. 8, 2015, 9:51 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39141: Store: minor style changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101964 --- Ship it! Ship It! - Anand Mazumdar On Oct. 8, 2015, 9:51 p.m.,

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101970 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39141: Store: minor style changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101971 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 9:51 p.m., Jo

Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39147/ --- Review request for mesos, Adam B, Artem Harutyunyan, and Timothy Chen. Reposito

Re: Review Request 38910: Added `-v` flag to `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101972 --- Ship it! Ship It! - Timothy Chen On Oct. 7, 2015, 5:34 p.m., Gr

Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39147/#review101975 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 10:31 p.m., J

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

> On Oct. 8, 2015, 9:24 p.m., James Peach wrote: > > You should also rename ```benchmarks``` and ```ssl-client```. > > Kapil Arya wrote: > Good suggestion. But I think, it will be better to do that in a separate > RR (just to keep this RR chain strictly relevant for `make tests`). It will

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/ --- (Updated Oct. 8, 2015, 11:06 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/ --- (Updated Oct. 8, 2015, 11:05 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review101988 --- Patch looks great! Reviews applied: [39005, 39007] All tests pass

Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-3553 https://issues.ap

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

> On Oct. 8, 2015, 5:24 p.m., James Peach wrote: > > You should also rename ```benchmarks``` and ```ssl-client```. > > Kapil Arya wrote: > Good suggestion. But I think, it will be better to do that in a separate > RR (just to keep this RR chain strictly relevant for `make tests`). > > Jame

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review101992 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 307) <

Review Request 39156: RegistryClient refactor: changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39156/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 12:57 a.m.) Review request for mesos and Kapil Arya. C

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 9, 2015, 12:58 a.m.) Review request for mesos and Ben Mahler. C

Review Request 39155: RegistryClient refactor: removed nested namespace references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39155/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 12:58 a.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

> On Oct. 9, 2015, 12:46 a.m., Neil Conway wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 307 > > > > > > Modifying the environment doesn't seem like a great thing for a test to > > be doing,

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:27 a.m.) Review request for mesos, Ben Mahler, Timothy

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:27 a.m.) Review request for mesos, Ben Mahler, Timothy

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 9, 2015, 1:28 a.m.) Review request for mesos, Ben Mahler, Timothy

Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/ --- Review request for mesos. Bugs: MESOS-1661 https://issues.apache.org/jira/b

Re: Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/#review101997 --- Patch looks great! Reviews applied: [39135, 39100] All tests pass

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review101996 --- Thanks for doing this, Jie! I have one nit and one question about

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102000 --- Patch looks great! Reviews applied: [38705, 38883] All tests pass

Re: Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102002 --- 3rdparty/libprocess/src/poll_socket.cpp (line 31)

Re: Review Request 39154: Log IP addresses together with failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102003 --- BTW, please add your shepherd into pepole field. - Klaus Ma On O

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review102004 --- Patch looks great! Reviews applied: [39138, 29550, 29551] All tes

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102006 --- include/mesos/mesos.proto (line 1119)

Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39147/#review102009 --- Patch looks great! Reviews applied: [39147] All tests passed. -