Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 24, 2015, 7:25 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 24, 2015, 3:24 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 24, 2015, 7:12 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

> On Nov. 23, 2015, 4:30 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 705 > > > > > > We need to do a check so that fs_layers size == history size firs

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review107727 --- Patch looks great! Reviews applied: [40339, 40524, 40529, 40532]

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/ --- (Updated Nov. 23, 2015, 10:52 p.m.) Review request for mesos, Jie Yu, Jojy Varg

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 24, 2015, 6:41 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107719 --- Bad patch! Reviews applied: [40431] Failed command: ./support/app

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107718 --- Ship it! Ship It! - Greg Mann On Nov. 23, 2015, 5:06 p.m., Neil

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十一月 24, 2015, 5:44 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十一月 24, 2015, 5:44 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40524: Enabled resources.cpp and resources.hpp use std::string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- (Updated 十一月 24, 2015, 5:42 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40529: Added helper function to get stateless resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 24, 2015, 5:42 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十一月 24, 2015, 5:40 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

> On Nov. 24, 2015, 4:19 a.m., Anand Mazumdar wrote: > > I am assuming this review is still being constantly worked on. Can you > > update the summary of this review to be a work in progress [WIP] ? Thanks for your reminder, I have updated the summary. - Yong Qiao --

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 24, 2015, 5:17 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 24, 2015, 5:13 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107709 --- I am assuming this review is still being constantly worked on. Can

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107707 --- Patch looks great! Reviews applied: [40424] Passed command: expor

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 24, 2015, 2:36 a.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 38989: Update docker-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38989/#review107702 --- Bad patch! Reviews applied: [38989] Failed command: ./support/app

Re: Review Request 40618: Include the header for boost::hash_combine explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40618/#review107699 --- Patch looks great! Reviews applied: [40618] Passed command: expor

Re: Review Request 31125: MESOS-2357 - Improve docker ps output parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31125/#review107698 --- I don't think this patch is being worked on, closing for now. - Ti

Re: Review Request 38989: Update docker-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38989/#review107697 --- Can you rebase your patch? - Timothy Chen On Oct. 5, 2015, 7:50

Re: Review Request 38989: Update docker-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38989/#review107696 --- Ship it! Ship It! - Timothy Chen On Oct. 5, 2015, 7:50 a.m., ha

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review107695 --- Ship it! Ship It! - Timothy Chen On Oct. 3, 2015, 3:55 p.m., ha

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review107694 --- src/tests/containerizer/docker_tests.cpp (line 298)

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

> On Nov. 24, 2015, 12:23 a.m., Guangya Liu wrote: > > Suggest change the description to "Added missing DiscoveryInfo.Visibility > > field to v1/mesos.proto." thx, added. - haosdent --- This is an automatically generated e-mail. To rep

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/ --- (Updated Nov. 24, 2015, 1:20 a.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107692 --- src/master/allocator/mesos/hierarchical.cpp (line 416)

Re: Review Request 37541: Add trace event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/#review107680 --- src/linux/perf.hpp (line 95)

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107690 --- Patch looks great! Reviews applied: [40497, 40506, 39415, 39416, 3

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On 十一月 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 191-193 > > > > > > Is there a ticket for this? I think we'll want to do this for the MVP. > > Thou

Re: Review Request 40497: Add hex number support to numify()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/#review107683 --- 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line 25

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107685 --- src/slave/containerizer/mesos/provisioner/docker/registry_client.c

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review107682 --- Ship it! Ship It! - Timothy Chen On Oct. 3, 2015, 9:09 a.m., ha

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/#review107681 --- Ship it! Suggest change the description to "Added missing Discover

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On 十一月 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? > > Joris Van Remoortere wrote: > We want to have ju

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? > > Guangya Liu wrote: > Another point is that can w

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

> On Nov. 23, 2015, 11:38 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3040 > > > > > > backticks for `statusUpdate()` ? There are multiple occurences in the present file that don't use backticks for stat

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107674 --- Patch looks great! Reviews applied: [39712] Passed command: expor

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107673 --- Ship it! src/slave/slave.cpp (line 3039)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 11:35 p.m.) Review request for mesos, Bernd Mathiske, J

Re: Review Request 40586: Corrected typos and formatting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40586/ --- (Updated Nov. 23, 2015, 11:33 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? > > Joris Van Remoortere wrote: > We want to have j

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 177-178 > > > > > > This first invariant is something we push on the user of the allocator > > API (i

Review Request 40618: Include the header for boost::hash_combine explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40618/ --- Review request for mesos, Bruno Mahé and Vinod Kone. Repository: mesos Descri

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 9:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 192 > > > > > > I think what we want to use should be master's flag: > > `slave_reregister_timeout`, so can we j

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107664 --- Patch looks great! Reviews applied: [39320] Passed command: expor

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 2:07 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 193 > > > > > > Can we add some comments for why using 0.8 as default? They should be exposed as parameters.

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 23, 2015, 10:33 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40506/ --- (Updated Nov. 23, 2015, 10:32 p.m.) Review request for mesos, Ben Mahler and Ia

Re: Review Request 40497: Add hex number support to numify()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 23, 2015, 10:32 p.m.) Review request for mesos, Ben Mahler and Ia

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/ --- (Updated Nov. 23, 2015, 2:16 p.m.) Review request for mesos, Jie Yu, Jojy Vargh

Re: Review Request 40115: Windows: [2/2] Changed gc.cpp to compile on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Nov. 23, 2015, 10:15 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review107653 --- src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (li

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Sept. 1, 2015, 2:52 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [36612, 36620] > > > > All tests passed. > > Timothy Chen wrote: > Jie does this look good to you? > > Jie Yu wrote: > Should we close this given https://reviews.apache.org/r/37967/?

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review107609 --- Patch looks great! Reviews applied: [40586, 40551, 40332, 39450]

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review107645 --- Ship it! Ship It! - Michael Park On Nov. 20, 2015, 11:17 a.m.,

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review107640 --- Ship it! src/tests/master_quota_tests.cpp (line 115)

Re: Review Request 40610: Changed getBlob invocation to use defer mechanism.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40610/#review107639 --- Ship it! Ship It! - Timothy Chen On Nov. 23, 2015, 8:18 p.m., J

Re: Review Request 40610: Changed getBlob invocation to use defer mechanism.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40610/#review107638 --- src/slave/containerizer/mesos/provisioner/docker/registry_client.c

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107637 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245, 4

Review Request 40610: Changed getBlob invocation to use defer mechanism.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40610/ --- Review request for mesos, Michael Park and Timothy Chen. Repository: mesos De

Re: Review Request 40512: Libprocess Reinitialization: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated Nov. 23, 2015, 12:14 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40264/ --- (Updated Nov. 23, 2015, 11:57 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39387: Make health check run outside for docker container task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/#review107635 --- src/docker/executor.cpp (line 324)

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review107634 --- Ship it! I'll add a comment as to why we use atomic before committ

Re: Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40264/#review107632 --- Ship it! 3rdparty/libprocess/include/process/clock.hpp (lines 53

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/#review107633 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 20, 2015, 7:16

Re: Review Request 39387: Make health check run outside for docker container task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/#review107630 --- Patch looks great! Reviews applied: [39387] Passed command: expor

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107625 --- An alternative would be to pause and advance the clock by the allo

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? We want to have just a single recover function, just li

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/#review107619 --- Ship it! Looks good, couple minor comments. Can you please also ad

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/#review107620 --- Patch looks great! Reviews applied: [40602] Passed command: expor

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107607 --- src/master/allocator/mesos/hierarchical.hpp (line 196)

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/ --- (Updated Nov. 23, 2015, 5:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40586: Corrected typos and a formatting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40586/ --- (Updated Nov. 23, 2015, 5:38 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39400: Quota: Implemented quota API.

> On Nov. 23, 2015, 8:07 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 391 > > > > > > For this newly added member `quotaRoleSorter`, I think we also need to > > initialize it in the

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Nov. 23, 2015, 5:24 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 23, 2015, 5:10 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 18, 2015, 10:36 p.m., Greg Mann wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 498-500 > > > > > > Is this behavior significant enough to create a JIRA to evaulate and > > possibly chang

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? > > Guangya Liu wrote: > Another point is that can

Re: Review Request 39387: Make health check run outside for docker container task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/ --- (Updated Nov. 23, 2015, 5:07 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 23, 2015, 5:06 p.m.) Review request for mesos, Greg Mann and Mich

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/ --- (Updated Nov. 23, 2015, 4:18 p.m.) Review request for mesos, Adam B, Bernd Math

Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/ --- Review request for mesos, Adam B and Neil Conway. Repository: mesos Descripti

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Nov. 23, 2015, 4:11 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 4:11 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review107604 --- I think keep the sync of these files when flags add or delete Proto

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

> On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1151 > > > > > > Also the simple case of correct behavior with several frameworks in one > > role would be inte

Re: Review Request 40586: Corrected a typo and a formatting issue.

> On Nov. 23, 2015, 4:35 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 367-377 > > > > > > Sorry, what is the update for this file? removed extra blank line - Alexander

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107595 --- Bad patch! Reviews applied: [40424] Failed command: ./support/app

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/#review107592 --- Ship it! Ship It! - Benjamin Hindman On Nov. 18, 2015, 4:05 p.m

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/#review107591 --- Ship it! Ship It! - Benjamin Hindman On Nov. 23, 2015, 1:05 p.m

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/#review107593 --- Ship it! Ship It! - Benjamin Hindman On Nov. 23, 2015, 1:05 p.m

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 23, 2015, 2:53 p.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 23, 2015, 2:55 p.m.) Review request for mesos, Adam B, Guangya Li

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107584 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245, 4

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Nov. 23, 2015, 1:05 p.m.) Review request for mesos, Alexander Rukletso

  1   2   >