Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113601 --- docs/quota.md (line 20)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-08 Thread Guangya Liu
> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113597 --- src/master/master.cpp (lines 3054 - 3059)

Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-08 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4258 https://issues.ap

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/ --- (Updated Jan. 8, 2016, 6:14 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 8, 2016, 5:58 p.m.) Review request for mesos, Ben Mahler, Artem H

Re: Review Request 42086: Updated master's Offer validation to handle InverseOffers.

2016-01-08 Thread Joseph Wu
> On Jan. 8, 2016, 4:09 p.m., Klaus Ma wrote: > > src/master/validation.cpp, line 597 > > > > > > There're several similar code: > > if (condition) { > > return Error(); > > } > >

Re: Review Request 40975: Document that libprocess ignores SIGPIPE.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review113589 --- Patch looks great! Reviews applied: [40975] Passed command: expor

Review Request 42096: Fixed race in persistent volume tests.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42096/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4318 https://issues.apache

Re: Review Request 42084: Fixed header order.

2016-01-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/#review113584 --- Ship it! Ship It! - Klaus Ma On Jan. 9, 2016, 4:08 a.m., Joseph

Re: Review Request 37703: Add docker exec command.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review113582 --- I just ran the CheckExec test and it failed for me, can you try it

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-08 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 --- Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/sto

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review113576 --- Ship it! Regarding the snake_case, my comment was regarding the fu

Re: Review Request 42093: Added proper handling of `None()` in the `CfsFilter`.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/#review113579 --- Ship it! Ship It! - Timothy Chen On Jan. 8, 2016, 11:42 p.m., G

Re: Review Request 42084: Fixed header order.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/#review113578 --- Patch looks great! Reviews applied: [42082, 42083, 42084] Passed

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Jojy Varghese
> On Jan. 6, 2016, 7:32 p.m., Jojy Varghese wrote: > > src/tests/container_logger_tests.cpp, line 158 > > > > > > Can we have this as : > > > > ``` > > Shared docker(new MockDocker(...)); > > > >

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 8, 2016, 4:24 p.m.) Review request for mesos, Benjamin Hindman, G

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Adam B
> On Jan. 6, 2016, 2:22 a.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > Let us doublecheck we actually need a deprecation cycle here: The > > critical scenario would be in my opinion if

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-08 Thread Jojy Varghese
> On Jan. 6, 2016, 7:21 p.m., Jojy Varghese wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > Do you need all the variables on the stack to be passed to the capture? > > Maybe just executorInfo ? >

Re: Review Request 42086: Updated master's Offer validation to handle InverseOffers.

2016-01-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113571 --- src/master/validation.cpp (line 597)

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113556 --- Ship it! Besides these two minor suggestions, I think this is comm

Re: Review Request 42093: Added proper handling of `None()` in the `CfsFilter`.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/ --- (Updated Jan. 8, 2016, 11:41 p.m.) Review request for mesos, Ben Mahler and Tim

Review Request 42093: Added proper handling of 'None()' in the 'CfsFilter'.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos Desc

Review Request 42086: Updated master's Offer validation to handle InverseOffers.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoorter

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review113565 --- Patch looks great! Reviews applied: [41002, 41003, 41004, 41061, 4

Review Request 42092: Add test for accept/decline offers and inverse offers.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42092/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoorter

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Joseph Wu
> On Jan. 8, 2016, 1:29 p.m., Timothy Chen wrote: > > src/tests/container_logger_tests.cpp, line 222 > > > > > > Do we need to check that the correct container id is passed? It wouldn't hurt. I'll add it to both te

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113532 --- Looks pretty good to me except for the potential bug in devolve (al

Re: Review Request 41461: Added SFINAE-friendly `result_of` to stout.

2016-01-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Jan. 8, 2016, 10:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113547 --- Patch looks great! Reviews applied: [42053] Passed command: expor

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/#review113546 --- Is this still relevant? - Timothy Chen On Aug. 5, 2015, 11:37 a.

Re: Review Request 34140: AppC image store

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review113545 --- Can we close this now? I don't think this is relevant anymore. - T

Re: Review Request 41810: Added credential to Docker image protobuf.

2016-01-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41810/#review113544 --- Ship it! include/mesos/mesos.proto (line 1318)

Re: Review Request 41956: Removed an unnecessary os::exists check in curl URI fetcher plugin.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41956/#review113543 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:31 a.m., Ji

Re: Review Request 41957: Style fix for curl URI fetcher plugin.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41957/#review113542 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:32 a.m., Ji

Re: Review Request 41960: Added the Docker URI fetcher plugin interface.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41960/#review113541 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:43 a.m., Ji

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113540 --- 3rdparty/libprocess/src/http.cpp (line 707)

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113539 --- 3rdparty/libprocess/include/process/http.hpp (line 718)

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/#review113538 --- src/tests/container_logger_tests.cpp (line 222)

Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113536 --- Ship it! Thank you! This is very helpful to the project. We'll get

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113535 --- Ship it! Ship It! - Timothy Chen On Jan. 8, 2016, 4:24 p.m., Gr

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113534 --- 3rdparty/libprocess/README.md (line 257)

Re: Review Request 40975: Document that libprocess ignores SIGPIPE.

2016-01-08 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 8, 2016, 9:19 p.m.) Review request for mesos and Ben Mahler. Su

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-08 Thread Joseph Wu
> On Jan. 7, 2016, 10:32 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40975] > > > > Failed command: ./support/apply-review.sh -n -r 40975 > > > > Error: > > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] > >

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-08 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 8, 2016, 8:58 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-08 Thread James Peach
> On Jan. 7, 2016, 6:32 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40975] > > > > Failed command: ./support/apply-review.sh -n -r 40975 > > > > Error: > > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] > >

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113529 --- Patch looks great! Reviews applied: [42030] Passed command: expor

Review Request 42084: Fixed header order.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository: m

Review Request 42083: Fixed header order in libprocess.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42083/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository: m

Review Request 42082: Fixed header order in stout.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42082/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository: m

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

2016-01-08 Thread Joseph Wu
> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote: > > src/tests/module.cpp, line 111 > > > > > > s/sandboxPath/sandboxDirectory/ > > > > ? This one points to the sandbox module (the default one). I'll

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41782/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

2016-01-08 Thread Joseph Wu
> On Jan. 7, 2016, 4:12 p.m., Benjamin Hindman wrote: > > src/tests/container_logger_tests.cpp, lines 28-30 > > > > > > How come these aren't pulled out since they are three levels? Looks like we're a bit inconsisten

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113510 --- Patch looks great! Reviews applied: [41429] Passed command: expor

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/ --- (Updated Jan. 8, 2016, 10:28 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-08 Thread Joseph Wu
> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

2016-01-08 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/ --- (Updated Jan. 8, 2016, 6:22 p.m.) Review request for mesos and Adam B. Change

Re: Review Request 41819: Added ContainerConfig to all isolators.

2016-01-08 Thread Gilbert Song
> On Jan. 7, 2016, 4:16 p.m., Jie Yu wrote: > > Fixed at `41816`. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/#review113372 ---

Re: Review Request 41817: Changed slave isolator interface and updated correspondings.

2016-01-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41817/ --- (Updated Jan. 8, 2016, 10:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

2016-01-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41814/ --- (Updated Jan. 8, 2016, 10:17 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41816: Generated ContainerConfig in mesos containerizer.

2016-01-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41816/ --- (Updated Jan. 8, 2016, 10:17 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

2016-01-08 Thread Neil Conway
> On Jan. 8, 2016, 9:08 a.m., Adam B wrote: > > Neil, do you want to rebase this or discard it, since you've discarded the > > parent patch? Will rebase! Sorry, didn't realize it was a child patch. - Neil --- This is an automatically g

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-08 Thread Neil Conway
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 226 > > > > > > Fix this link -- probably just link to roles.md. Although we don't > > really call the feature "implicit roles" in the user-f

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-08 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113496 --- docs/home.md (line 42)

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 8, 2016, 5:47 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/#review113494 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094, 3

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Neil Conway
> On Jan. 7, 2016, 11:21 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 323 > > > > > > Do we really have to look at all the code paths within `doHttpGet`? By > > the time `getBlob()` returns to th

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/ --- (Updated Jan. 8, 2016, 5:01 p.m.) Review request for mesos, Ben Mahler, Jojy Va

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Greg Mann
> On Jan. 7, 2016, 11:21 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 323 > > > > > > Do we really have to look at all the code paths within `doHttpGet`? By > > the time `getBlob()` returns to th

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/ --- (Updated Jan. 8, 2016, 4:55 p.m.) Review request for mesos, Ben Mahler, Jojy Va

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review113487 --- Bad patch! Reviews applied: [41096, 41185, 41108] Failed command:

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

2016-01-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/ --- (Updated Jan. 8, 2016, 4:24 p.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113483 --- Patch looks great! Reviews applied: [41649] Passed command: expor

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

2016-01-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/#review113481 --- Ship it! This does not only change 401 to 403 but also removes the

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-01-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 8, 2016, 3:29 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41876: Used List constructor from std::initializer_list.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/#review113473 --- Patch looks great! Reviews applied: [41875, 41876] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-01-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 8, 2016, 3 p.m.) Review request for mesos, Adam B, Neil Conway, a

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 8, 2016, 2:59 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-01-08 Thread Yongqiao Wang
> On Jan. 8, 2016, 10:36 a.m., Adam B wrote: > > src/master/weights_handler.cpp, lines 97-100 > > > > > > Why the ostringstream here? In order to convert double to string. > On Jan. 8, 2016, 10:36 a.m., Adam B wro

Re: Review Request 41936: Required role in set quota request explicitly.

2016-01-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41936/#review113477 --- Ship it! Ship It! - Joerg Schad On Jan. 5, 2016, 6:08 p.m., Ale

Re: Review Request 41949: Replaced `QuotaInfo` with `Quota` in allocator.

2016-01-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41949/#review113475 --- Ship it! Ship It! - Joerg Schad On Jan. 5, 2016, 11:43 p.m., Al

Re: Review Request 41856: Added helper functions to get allocation slack.

2016-01-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated Jan. 8, 2016, 10:10 p.m.) Review request for mesos, Ben Mahler, Guangy

Re: Review Request 41857: Got evictable executors.

2016-01-08 Thread Klaus Ma
> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3967 > > > > > > this check may not be necessary because resources cannot be negative? Yes; it won't be negative, but it'll return first r

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

2016-01-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/ --- (Updated Jan. 8, 2016, 2:48 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-01-08 Thread Benjamin Bannier
> On Nov. 30, 2015, 9:51 a.m., Benjamin Bannier wrote: > > src/tests/module_tests.cpp, line 123 > > > > > > None of these functions need to be (mutating!) member functions if you > > simply inject `libraryDirectory`

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-08 Thread Alexander Rukletsov
> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 97-99 > > > > > > Why this behaviour? I would expect if `set()` is not called, nothing

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

2016-01-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113462 --- Ship it! src/tests/environment.cpp (line 129)

Re: Review Request 42069: Porting libprocess on ppc64le.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42069/#review113464 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 41791: Updated allocation slack for dynamic reserve.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 8, 2016, 12:50 p.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 8, 2016, 12:46 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 8, 2016, 12:41 p.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 8, 2016, 12:40 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-08 Thread Till Toenshoff
> On Dec. 17, 2015, 3:42 a.m., Till Toenshoff wrote: > > Ship It! Sorry for the delay -- this patch now needs a rebase. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113457 --- Ship it! lgtm! src/master/master.cpp (line 1076)

Re: Review Request 42068: Porting Mesos on ppc64le.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review113460 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113455 --- Patch looks great! Reviews applied: [42040] Passed command: expor

Re: Review Request 41875: Provided List constructor from std::initializer_list.

2016-01-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- (Updated Jan. 8, 2016, 12:38 p.m.) Review request for mesos, Ben Mahler and Til

Re: Review Request 41876: Used List constructor from std::initializer_list.

2016-01-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/ --- (Updated Jan. 8, 2016, 12:29 p.m.) Review request for mesos, Ben Mahler and Til

  1   2   >