Re: Review Request 42278: Fixed volume paths for command tasks with image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42278/#review114820 --- Fix it, then Ship it! Sorry for being late on this review. Over

Re: Review Request 43039: Updated the release guide to include the link to the Apache repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43039/#review117183 --- Patch looks great! Reviews applied: [43039] Passed command: expo

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

> On Jan. 31, 2016, 1:43 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 173 > > > > > > This seems a little more subtle than is warranted. > > Michael Park wrote: >

Re: Review Request 43039: Updated the release guide to include the link to the Apache repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43039/#review117182 --- Ship it! Ship It! - Kapil Arya On Jan. 31, 2016, 10:57 p.m.,

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/ --- (Updated Feb. 1, 2016, 5:14 a.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/ --- (Updated Feb. 1, 2016, 4:07 a.m.) Review request for mesos and Benjamin Hindman

Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42543/ --- (Updated Feb. 1, 2016, 4:06 a.m.) Review request for mesos and Benjamin Hindman

Review Request 43039: Updated the release guide to include the link to the Apache repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43039/ --- Review request for mesos, Kapil Arya and Timothy Chen. Repository: mesos Desc

Re: Review Request 42993: [2 of 7] Support for multiple frameworks sharing the same resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/#review117177 --- It is better add some unit tests in `hierarchical_allocator_tests.

Re: Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review117100 --- src/master/master.hpp (lines 127 - 138)

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 1, 2016, 2:20 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleMgr class.

> On Feb. 1, 2016, 1:46 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 44 > > > > > > s/issue/issues Thanks for catching this. - Avinash ---

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117171 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117169 --- BTW: I think that you meant to have tim Chen as shephard, his id i

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117166 --- src/docker/docker.cpp (lines 535 - 536)

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117168 --- src/docker/docker.cpp (lines 517 - 522)

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review117165 --- Ship it! Ship It! - Till Toenshoff On Jan. 25, 2016, 2:35 p.

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/#review117160 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 31, 2016, 6

Re: Review Request 43024: Avoid unnecessary string copies in `json` for protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43024/#review117159 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 31, 2016, 1

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43023/#review117157 --- Fix it, then Ship it! + resolution with neil's comments. 3rdp

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/#review117158 --- Bad patch! Reviews applied: [42781] Failed command: ./support/ap

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/#review117156 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 31, 2016, 9

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/ --- (Updated Jan. 31, 2016, 9:44 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42543/#review117155 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 20, 2016, 5

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review117153 --- Bad patch! Reviews applied: [43033, 43034] Failed command: ./sup

Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117152 --- Should update configuration.md. - Neil Conway On Jan. 31, 2016,

Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Jan. 31, 2016, 8:10 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Jan. 31, 2016, 8:09 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Jan. 31, 2016, 8:08 p.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Jan. 31, 2016, 8:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Jan. 31, 2016, 8:06 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Jan. 31, 2016, 8:05 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Jan. 31, 2016, 8:04 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/#review117151 --- Patch looks great! Reviews applied: [43014] Passed command: expo

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Jan. 31, 2016, 7:46 p.m.) Review request for mesos and Joris Van Remoo

Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Review Request 43034: libprocess: Added EXPECT_NO_FUTURE_DISPATCHES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43034/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Review Request 43033: Cleaned up code style and fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43033/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/ --- (Updated Jan. 31, 2016, 1:41 p.m.) Review request for mesos, Ben Mahler and Jor

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/ --- (Updated Jan. 31, 2016, 1:37 p.m.) Review request for mesos, Ben Mahler and Jor

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/ --- (Updated Jan. 31, 2016, 6:21 p.m.) Review request for mesos, Jie Yu, Jojy Vargh

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/#review117149 --- Fix it, then Ship it! src/common/command_utils.cpp (line 188)

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Jan. 31, 2016, 6:04 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Jan. 31, 2016, 5:56 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Jan. 31, 2016, 5:45 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117148 --- Patch looks great! Reviews applied: [43032] Passed command: expo

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117147 --- src/docker/docker.cpp (line 533)

Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- Review request for mesos and Guangya Liu. Bugs: MESOS-4446 https://issues.a

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 172 > > > > > > On ubuntu, we don't have sha512sum but shasum (and sha512). > > > > Here is what I am thinking: > > 1)