Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 2, 2016, 6:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117461 --- Bad patch! Reviews applied: [43093] Failed command:

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 2, 2016, 6:16 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 440-443 > > > > > > Can you try to see if writing a decimal number if fine as well? If not, > > we

Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Feb. 2, 2016, 7:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43037: Support env var in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43037/#review117453 --- Fix it, then Ship it!

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 2, 2016, 6:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43022: Added protobuf fields for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43022/#review117442 --- include/mesos/slave/isolator.proto (line 85)

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

> On Feb. 1, 2016, 10:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 137-139 > > > > > > Hum, having two data fields here looks a little confusing to me. How > > about

Re: Review Request 43036: Plugged in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43036/#review117449 --- src/slave/containerizer/mesos/containerizer.cpp (lines 840 -

Re: Review Request 43020: Exposed accurate ProvisionInfo to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43020/#review117431 --- src/slave/containerizer/mesos/containerizer.cpp (line 724)

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 2, 2016, 6:25 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43021: Implemented docker runtime isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43021/#review117439 --- Ship it! Ship It! - Jie Yu On Feb. 2, 2016, 5:18 p.m.,

Re: Review Request 43021: Implemented docker runtime isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43021/#review117438 --- src/slave/containerizer/mesos/isolators/docker/runtime.hpp (line

Re: Review Request 42181: Added a Slave constructor to pass process ID manually.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42181/#review117492 --- src/tests/cluster.cpp (lines 409 - 430)

Re: Review Request 43075: Fixed definition of operator<< for `Call::Type` and `Event::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/#review117484 --- Ship it! Ship It! - Vinod Kone On Feb. 2, 2016, 9:33 p.m.,

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

> On Feb. 2, 2016, 7:54 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1801 > > > > > > The output stream operator overload for Call (unversioned) defined in > > "mesos/scheduler/scheduler.hpp". Not sure

Re: Review Request 42843: Ensure `ServiceUnavailable` is not received for `Subscribe` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42843/ --- (Updated Feb. 2, 2016, 9:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42844: Drop `404 NotFound` responses in the executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42844/#review117498 --- Ship it! Ship It! - Vinod Kone On Jan. 27, 2016, 4:14 a.m.,

Re: Review Request 43075: Fixed definition of operator<< for `Call::Type` and `Event::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/ --- (Updated Feb. 2, 2016, 9:33 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43075: Fixed definition of operator<< for `Call::Type` and `Event::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/ --- (Updated Feb. 2, 2016, 9:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 2, 2016, 5:06 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

> On Feb. 2, 2016, 7:54 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1801 > > > > > > The output stream operator overload for Call (unversioned) defined in > > "mesos/scheduler/scheduler.hpp". Not sure

Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4421

Review Request 43105: Ensured the allocator does not double account resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4344

Re: Review Request 42843: Ensure `ServiceUnavailable` is not received for `Subscribe` calls.

> On Feb. 2, 2016, 10:10 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 502 > > > > > > Looks like HttpProxy can send ServiceUnavailable too for some cases > >

Re: Review Request 42185: Added an example executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review117512 --- Ship it! Ship It! - Vinod Kone On Jan. 27, 2016, 4:13 a.m.,

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 2, 2016, 11:11 p.m.) Review request for mesos and Jie Yu.

Review Request 42982: Defined a virtual `status` method for Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4487

Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42983/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4487

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 2, 2016, 10:39 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42185: Added an example executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review117515 --- src/examples/test_http_executor.cpp (line 154)

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117513 --- src/tests/slave_recovery_tests.cpp (line 420)

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Feb. 2, 2016, 11:14 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 2, 2016, 11:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43082: Added new flag to command executor for command passing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43082/#review117472 --- src/launcher/executor.cpp (line 143)

Review Request 43121: Updated Doxygen main page to use relative links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43121/ --- Review request for mesos, Joseph Wu and Neil Conway. Bugs: MESOS-4584

Review Request 43122: Updated Rakefile to automatically generate doxygen pages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- Review request for mesos, Joseph Wu and Neil Conway. Bugs: MESOS-4584

Re: Review Request 43120: Removed site/Gemfile.lock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43120/#review117532 --- You can't just remove this file. It specifies the versions of

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 12:43 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 3, 2016, 12:44 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43120: Removed site/Gemfile.lock.

> On Feb. 2, 2016, 7:27 p.m., Kevin Klues wrote: > > You can't just remove this file. It specifies the versions of everything > > that should be installed in a fresh docker image upon calling 'bundle > > insgtall'. If you saw that it was being overwritten, it means you had a > > (possibly

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Feb. 3, 2016, 1:31 a.m.) Review request for Jie Yu. Repository:

Review Request 43127: Introduced Appc image cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4439 and MESOS-4575

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/ --- (Updated Feb. 3, 2016, 12:39 a.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 3, 2016, 12:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 3, 2016, 12:51 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43105: Ensured the allocator does not double account resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/#review117542 --- Patch looks great! Reviews applied: [42633, 42636, 42657, 42658,

Re: Review Request 43022: Added protobuf fields for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43022/#review117528 --- include/mesos/slave/isolator.proto (line 115)

Re: Review Request 43083: Supported working dir in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/#review117522 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1029 -

Re: Review Request 43019: Fixed non-camel case in protobuf field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/#review117533 --- include/mesos/slave/isolator.proto (lines 71 - 72)

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 3, 2016, 12:45 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Feb. 3, 2016, 12:49 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117534 --- Fix it, then Ship it!

Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 2, 2016, 7:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43083: Supported working dir in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/#review117448 --- Patch looks great! Reviews applied: [43019, 43020, 43021, 43022,

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review117571 --- Patch looks great! Reviews applied: [43118] Passed command:

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Feb. 2, 2016, 7:09 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43075/#review117459 --- src/master/master.cpp (line 1801)

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/#review117458 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 3, 2016, 7:47 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- (Updated Feb. 3, 2016, 7:47 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 3, 2016, 7:46 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117588 --- Primarily fly-by style comments.

Re: Review Request 42594: Introduced framework registry operations.

> On Feb. 1, 2016, 9:03 a.m., Jian Qiu wrote: > > src/master/master.hpp, line 1638 > > > > > > hashset* slaveIDs, bool strict Those parameters do not be used, so it does not need to name them. > On Feb. 1, 2016,

Re: Review Request 42594: Introduced framework registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/ --- (Updated Feb. 2, 2016, 8:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 2, 2016, 8:58 a.m.) Review request for mesos and Guangya Liu.

Review Request 43091: Renamed a variable and updated a comment for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43091/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4443

Re: Review Request 42222: Added a comment on allocator recovery.

> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > Thanks Alex! I ended up going over the structure of the recover code and > > left some higher level comments. There also appears to be a bug that will > > crash the master that I marked as an issue :) > > > > Have we convinced ourselves

Re: Review Request 42586: Defined the NetClsHandleMgr class.

> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 65-75 > > > > > > Why do we need this? Was using this data structure to pass on the usage of handles

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/ --- (Updated Feb. 2, 2016, 10:27 a.m.) Review request for mesos, Joris Van

Re: Review Request 42633: Corrected a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- (Updated Feb. 2, 2016, 10:28 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42637: Cleaned up formatting in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42637/ --- (Updated Feb. 2, 2016, 10:29 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42594: Introduced framework registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/#review117390 --- Patch looks great! Reviews applied: [42591, 42594] Passed

Re: Review Request 42971: Marked an unused function parameter appropriately in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42971/#review117415 --- Ship it! Ship It! - Jie Yu On Feb. 1, 2016, 10:08 p.m.,

Re: Review Request 42972: Fixed a minor bug in stout's Flags package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/#review117416 --- Ship it! Ship It! - Jie Yu On Feb. 2, 2016, 1:53 a.m., Neil

Re: Review Request 42973: Marked some unused function parameters in libprocess appropriately.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42973/#review117417 --- Ship it! Ship It! - Jie Yu On Feb. 1, 2016, 10:08 p.m.,

Re: Review Request 42974: Removed unused variable in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42974/#review117418 --- Ship it! Ship It! - Jie Yu On Feb. 1, 2016, 10:08 p.m.,

Re: Review Request 43091: Renamed a variable and updated a comment for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43091/#review117422 --- Patch looks great! Reviews applied: [43091] Passed command:

Re: Review Request 43083: Supported working dir in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43021: Implemented docker runtime isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43021/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43019: Fixed non-camel case in protobuf field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43020: Exposed accurate ProvisionInfo to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43020/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43036: Plugged in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43036/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43037: Support env var in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43037/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43082: Added new flag to command executor for command passing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43082/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43022: Added protobuf fields for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43022/ --- (Updated Feb. 2, 2016, 9:18 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117409 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 43019: Fixed non-camel case in protobuf field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/#review117428 --- So unfortunate that this didn't get into 0.27. We'll break the

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 2, 2016, 5:52 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleManager class.

> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 51-52 > > > > > > `s/majHandle/_major/` > > `s/minHandle/_minor/` > > > > Also, remove

Re: Review Request 42586: Defined the NetClsHandleManager class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 6:44 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 3, 2016, 6:46 a.m.) Review request for mesos and Jie Yu.

Review Request 43134: Added output operator for unversioned executor protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43134/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

  1   2   >