Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121670 --- Patch looks great! Reviews applied: [44266] Passed command:

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121672 --- Ship it! Ship It! - Anand Mazumdar On March 2, 2016, 1:09

Re: Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44243/#review121671 --- Fix it, then Ship it! LGTM. src/master/master.cpp (line

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121663 --- src/slave/containerizer/mesos/containerizer.cpp (lines 81 - 84)

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121661 --- docs/configuration.md (line 1305)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-272 > > > > > > Does it make sense to wrap framework-related metrics in a separate > > struct in

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/#review121660 --- Ship it! Thanks for fixing this -- so looking foward to see

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

> On March 2, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 147 > > > > > > I don't think we put non-empty function body on the same line. In fact we do

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, lines 872-874 > > > > > > Why not putting these onto the same line? > > Benjamin Bannier wrote: > Let's keep consistent

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 43 > > > > > > Is it what clnag-format suggest? I doubt it : ) Yes, that's indeed what it suggests, at

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121659 --- Patch looks great! Reviews applied: [44258] Passed command:

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121657 --- LGTM so far, but let's review this again after the changes

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121656 --- src/tests/mesos.hpp (line 133)

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/#review121655 --- src/uri/fetchers/copy.cpp (line 72)

Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-4583

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review121650 --- @jieyu ping? - Steve Niemitz On Feb. 20, 2016, 6:47 p.m.,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121643 --- src/master/http.cpp (lines 1999 - 2000)

Re: Review Request 43806: Add comments for rebalance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121641 --- src/master/allocator/mesos/hierarchical.cpp (lines 1066 - 1069)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review121637 --- src/tests/cluster.cpp (line 134)

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121640 --- Patch looks great! Reviews applied: [44254] Passed command:

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121639 --- src/master/allocator/mesos/metrics.hpp (line 46)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121638 --- src/master/allocator/mesos/metrics.hpp (line 37)

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/#review121635 --- Fix it, then Ship it!

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121633 --- src/master/allocator/mesos/hierarchical.cpp (line 1419)

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121628 --- Patch looks great! Reviews applied: [43684, 43685, 43686, 44250,

Re: Review Request 44221: Added runtime isolator check if docker is image provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44221/#review121627 --- src/slave/containerizer/mesos/provisioner/store.cpp (lines 72 -

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/#review121625 --- Bad patch! Reviews applied: [44196, 44122] Failed command:

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121624 --- src/master/allocator/mesos/metrics.hpp (line 23)

Re: Review Request 44179: Reintroduce deleted anchor in configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44179/#review121622 --- Ship it! Ship It! - Bernd Mathiske On Feb. 29, 2016, 4:36

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121619 --- Bad patch! Reviews applied: [44255] Failed command:

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > docs/monitoring.md, lines 872-874 > > > > > > Why not putting these onto the same line? > > Benjamin Bannier wrote: > Let's keep consistent

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review121616 --- Patch looks great! Reviews applied: [44247, 44087] Passed

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 1, 2016, 1:19 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 303 > > > > > > I'm even wondering whether `auto` here is a better idea than aliasing. Of the two possible

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

> On March 1, 2016, 12:56 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 276-282 > > > > > > As in previous reviews, let's go for: > > > > ```c++ > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 29, 2016, 11:48 p.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 413-418 > > > > > > This is really unreadable. I wasn't unsure of what it was happening > > here. I felt

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2406 > > > > > > I believe the actual value in JSON is double, right? This is actually a

Re: Review Request 43882: Added allocation metrics for allocation time.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2577 > > > > > > Why don't you need to convert to `JSON::Number` first? `time` is a `JSON::Number`;

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 12:29 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-271 > > > > > > As in the previous review, I find much more readable: > > > > ```c++ > >

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120985 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier

Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4718

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 27, 2016, 12:13 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2395 > > > > > > Not yours but we don't start function names with a capital letter and > > that threw me

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 11:35 a.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121255 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2391 > > > > > > This looks like a creation of an instance of some `Metrics` class. > > Let's rename

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 2, 2016, 11:35 a.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4721

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/#review121606 --- Patch looks great! Reviews applied: [44218, 44243, 44220]

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44250/#review121605 --- src/tests/resources_tests.cpp (line 2215)

<    1   2