Re: Review Request 44900: Update containerizer construction in slave_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44900/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44651: Cleaned up formatting in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/ --- (Updated March 17, 2016, 11:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44852: Documented existing allocator metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/#review124056 --- docs/monitoring.md (line 863)

Re: Review Request 44777: Added a flags parser for vector to src/common/parse.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/ --- (Updated March 18, 2016, 12:14 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/#review124293 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:46 p.m.

Re: Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 17, 2016, 6:54 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 18, 2016, 7:30 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 18, 2016, 6:32 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 18, 2016, 3:45 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 14, 2016, 9:38 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 63-64 > > > > > > Seems like you're changing the meaning of the parameters in > > `BasicAuthenticatorFa

Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44978/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45070/#review124386 --- Patch looks great! Reviews applied: [45070] Passed command: expo

Review Request 44996: Fixed how we detect C++11 compiler support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44996/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963 https:/

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review123857 --- Committed with the following formatting fixes. src/tests/mesos.c

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124289 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:33 p.m.

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

> On March 15, 2016, 10:25 p.m., Ben Mahler wrote: > > src/launcher/executor.cpp, lines 121-125 > > > > > > Ditto from previous review comments, could you adjust the comment and > > logic to reflect that it's not a

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 18, 2016, 5:08 p.m.) Review request for mesos, Alexander Ruklets

Review Request 44963: Added a missing include to a stout header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44963/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Review Request 45017: Updated C++ dialect macro in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45017/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hind

Review Request 44892: Remove `Fetcher` in `Containerizer::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44892/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123913 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp (line

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

> On March 19, 2016, 1:24 a.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 18, 2016, 2:47 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling Star

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 8:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 17, 2016, 11:55 a.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124097 --- src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 220) <

Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 17, 2016, 7:41 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 17, 2016, 7:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review124272 --- include/mesos/scheduler.hpp (line 220)

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/ --- (Updated March 17, 2016, 1:52 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 4:27 p.m., Jie Yu wrote: > > Ship It! Can you confirm that this patch works in your environment? - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123877

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 45017: Updated C++ dialect macro in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45017/#review124200 --- Ship it! Ship It! - Joris Van Remoortere On March 18, 2016,

Review Request 45005: Fixed minor spacing issue in the example test framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45005/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123969 --- src/cli/execute.cpp (lines 250 - 280)

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On 三月 18, 2016, 7:03 p.m., haosdent huang wrote: > > docs/versioning.md, line 85 > > > > > > Any reason we need change here? > > Yong Tang wrote: > Hi haosdent, the left is one unicode (U+2026) of "Horizontal E

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

> On March 17, 2016, 7:48 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 241 > > > > > > The default value of `containerizer` is `mesos`, do we need to check > > this? > > > > What about make the lo

Re: Review Request 45038: Fixed email address in Python build file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45038/#review124382 --- Ship it! Ship It! - haosdent huang On March 18, 2016, 4:44 p

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/ --- (Updated March 17, 2016, 9:57 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 44904: Update containerizer construction in mesos_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44904/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 18, 2016, 12:30 a.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

> On March 15, 2016, 6:39 p.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 113 > > > > > > If you'd like to add the `private` qualifier, why isn't `kill` left as > > protected? I do not know what is our general

Review Request 44999: Fixed m4 macro to enable strict C++11 conformance in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44999/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963 https:/

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 18, 2016, 12:48 a.m.) Review request for mesos and Jie Yu. Rep

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review124259 --- Sorry for the delay... As Vinod suggested, you might want to cons

Review Request 44971: MESOS-3902: Fix location header in redirect from non-leading master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44971/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 44547: Added functions in promises to the collect header.

> On March 18, 2016, 9:05 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/collect.hpp, line 260 > > > > > > Missed a couple extranous spaces here (i.e. `>* >*`). Thanks. I'm curious ... do you use a t

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123877 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2016, 6:47 p.m., Stev

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 17, 2016, 6:54 a.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124381 --- Patch looks great! Reviews applied: [45046] Passed command: expo

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

> On March 18, 2016, 9:07 a.m., Adam B wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines > > 56-57 > > > > > > Why are these quotes escaped, but the others aren't? Because they're >

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 16-17 > > > > > > You might have missed my earlier comment (because I didn't make it a RB > > "issue"). Are these two files delete

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

> On March 18, 2016, 3:47 p.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 677 > > > > > > Where is this coming from? I would expect this in slave/constants.hpp > > similar as for the master > > > >

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 18, 2016, 6:49 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review124257 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 74

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 16, 2016, 8:10 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated March 16, 2016, 11:21 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 17, 2016, 7:43 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124380 --- src/launcher/fetcher.cpp (line 77)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123984 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review123863 --- Ship it! src/tests/fetcher_cache_tests.cpp (lines 165 - 167) <

Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44985/#review124106 --- Fix it, then Ship it! src/tests/containerizer/provisioner_dock

<    1   2   3   4