Re: Review Request 48056: Windows: Added build and run instructions.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/#review135608 --- Bad review! Reviews applied: [48056] Error: No reviewers specifi

Re: Review Request 48053: Removed discarded handling from .repair() call.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48053/#review135607 --- Ship it! Ship It! - Michael Park On May 31, 2016, 1:06 a.m.,

Re: Review Request 47876: Updated comments for authorization::Object.

2016-05-30 Thread Adam B
> On May 30, 2016, 2:04 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, lines 38-40 > > > > > > I think we should aim for a more general comment here. Since we are not > > employing th

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
> On May 31, 2016, 12:06 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1205 > > > > > > I think we are trying to get leading master here, so should we return > > `master->leader.get()`? > > Anand Mazumdar

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- (Updated May 31, 2016, 6:32 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 47977: Added tests for `VIEW_*` authorization actions.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47977/#review135602 --- Ship it! Ship It! - Michael Park On May 31, 2016, 6:21 a.m.,

Re: Review Request 47559: Added authorization-based filtering to `/master/state-summary`.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/#review135599 --- Ship it! Ship It! - Michael Park On May 31, 2016, 6:20 a.m.,

Re: Review Request 47704: Added authorization-based filtering to `/master/state`.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/#review135600 --- Ship it! Ship It! - Michael Park On May 31, 2016, 6:20 a.m.,

Re: Review Request 47736: Added authorization-based filtering to `/master/tasks`.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/#review135601 --- Ship it! Ship It! - Michael Park On May 31, 2016, 6:21 a.m.,

Re: Review Request 47558: Added `ObjectApprover` interface to `Authorizer`.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review135598 --- Ship it! Ship It! - Michael Park On May 31, 2016, 6:19 a.m.,

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/ --- (Updated May 31, 2016, 6:22 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47977: Added tests for `VIEW_*` authorization actions.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47977/ --- (Updated May 31, 2016, 6:21 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47736: Added authorization-based filtering to `/master/tasks`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 31, 2016, 6:21 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Added authorization-based filtering to `/master/state`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 31, 2016, 6:20 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47559: Added authorization-based filtering to `/master/state-summary`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 31, 2016, 6:20 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47558: Added `ObjectApprover` interface to `Authorizer`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 31, 2016, 6:19 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/ --- (Updated May 31, 2016, 6:15 a.m.) Review request for mesos and Michael Park.

Review Request 48058: Added authorization based endpoint filtering documentation.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/ --- Review request for mesos. Repository: mesos Description --- Added author

Re: Review Request 47842: Point slave flags at programmatic temp path.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 31, 2016, 5:54 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 31, 2016, 5:49 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 31, 2016, 5:34 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review135595 --- Ship it! Ship It! - Joris Van Remoortere On May 30, 2016, 4:

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

2016-05-30 Thread Alex Clemmer
> On May 31, 2016, 5:12 a.m., Joris Van Remoortere wrote: > > src/slave/slave.cpp, lines 1032-1040 > > > > > > I still think you have changes accidentally merged together. This was intentional. One condition for th

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere
> On May 31, 2016, 5:08 a.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1233-1239 > > > > > > Do these get stored correctly since `launchFlags.pipe_xxx` is an int? > >

Review Request 48056: Windows: Added build and run instructions.

2016-05-30 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Va

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/#review135592 --- src/health-check/main.cpp (line 309)

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review135590 --- src/slave/containerizer/mesos/containerizer.cpp (line 1184)

Re: Review Request 48053: Removed discarded handling from .repair() call.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48053/#review135591 --- Patch looks great! Reviews applied: [48053] Passed command: expo

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review135588 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 48033: Fixed signed/unsigned comparison introduced in `f22af98`.

2016-05-30 Thread haosdent huang
> On May 30, 2016, 5:46 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 180 > > > > > > should we change the GetLoggingLevel::level to be int32 instead? not > > sure why glog chose FLAGS_v to be signed. >

Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review135586 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp (lin

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review135585 --- Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

2016-05-30 Thread Joris Van Remoortere
> On May 24, 2016, 11:07 p.m., Joris Van Remoortere wrote: > > src/CMakeLists.txt, line 259 > > > > > > Why here as opposed to alphabetical? > > Alex Clemmer wrote: > In `CMakeLists.txt`, we have making them alp

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review135583 --- Bad patch! Reviews applied: [47511] Failed command: ./support/ap

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/#review135582 --- Fix it, then Ship it! 3rdparty/stout/include/stout/os/windows/

Re: Review Request 47470: Stout: Added `os::temp`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/#review135581 --- Fix it, then Ship it! 3rdparty/stout/include/stout/posix/os.hp

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- (Updated May 31, 2016, 3:31 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 31, 2016, 3:31 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47942: Windows: Added pipe support functions.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/#review135580 --- Fix it, then Ship it! 3rdparty/stout/include/stout/posix/os.hp

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/#review135579 --- Patch looks great! Reviews applied: [37989] Passed command: expo

Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/#review135578 --- Patch looks great! Reviews applied: [46620, 46814, 46621, 47078,

Re: Review Request 48051: Expose auto refresh port in site docker.

2016-05-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135577 --- site/README.md (line 61)

Re: Review Request 47874: Windows: Added support for `--ip_discovery_command` parameter.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47874/#review135576 --- Ship it! Ship It! - Joris Van Remoortere On May 26, 2016, 5:

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/#review135575 --- Ship it! Ship It! - Joris Van Remoortere On May 30, 2016, 10

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/#review135574 --- src/exec/exec.cpp (line 652)

Review Request 48053: Removed discarded handling from .repair() call.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48053/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
> On May 31, 2016, 12:06 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1205 > > > > > > I think we are trying to get leading master here, so should we return > > `master->leader.get()`? We won't ever reach

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/#review135573 --- Ship it! Ship It! - Joris Van Remoortere On May 20, 2016, 1:

Re: Review Request 47489: Windows: Symplified `os::exists`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/#review135571 --- Ship it! Ship It! - Joris Van Remoortere On May 23, 2016, 9:

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47474/#review135570 --- src/logging/logging.cpp (line 202)

Re: Review Request 47486: Windows: Escaped command line arguments.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/#review135569 --- Ship it! Ship It! - Joris Van Remoortere On May 30, 2016, 10

Re: Review Request 47473: Windows: Added logging for `WSTRINGIFY` calls.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47473/#review135568 --- Ship it! - Joris Van Remoortere On May 19, 2016, 10:19 p.m.,

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 31, 2016, 12:50 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47736: Used TaskObjectApprover to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 31, 2016, 12:49 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated May 31, 2016, 12:49 a.m.) Review request for mesos, David vonThenen, G

Re: Review Request 47977: Added tests for VIEW_* authorization actions.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47977/ --- (Updated May 31, 2016, 12:49 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 31, 2016, 12:46 a.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/#review135566 --- Bad patch! Reviews applied: [48052, 47558, 47875, 46613, 47069, 4

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review135564 --- Bad patch! Reviews applied: [47511] Failed command: ./support/ap

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/ --- (Updated May 31, 2016, 12:09 a.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135563 --- src/master/http.cpp (line 1205)

Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/ --- (Updated May 30, 2016, 11:54 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated May 30, 2016, 11:54 p.m.) Review request for mesos, David vonThenen, G

Re: Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/#review135562 --- Ship it! Ship It! - Joerg Schad On May 30, 2016, 11:46 p.m.,

Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

2016-05-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/ --- Review request for mesos, Alexander Rukletsov and Joerg Schad. Repository: meso

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 30, 2016, 11:44 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-30 Thread Guangya Liu
> On May 30, 2016, 5:42 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 45-55 > > > > > > Or it seems to me that you should merge this to the 'without' paragraph. I have removed the `without` sect

Re: Review Request 45562: Edited `--work_dir` configuration docs.

2016-05-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated May 30, 2016, 11:24 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46004: Updated master '--work_dir' help string.

2016-05-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- (Updated May 30, 2016, 11:23 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/ --- (Updated May 30, 2016, 11:21 p.m.) Review request for mesos, Benjamin Mahler, M

Re: Review Request 45562: Edited `--work_dir` configuration docs.

2016-05-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated May 30, 2016, 11:20 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46003: Removed the default value for agent work_dir.

2016-05-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated May 30, 2016, 11:18 p.m.) Review request for mesos, Michael Park and V

Re: Review Request 46038: Added recommended production config to the docs.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/#review135559 --- Fix it, then Ship it! docs/operational-guide.md (line 55)

Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/#review135560 --- Ship it! Ship It! - Vinod Kone On April 12, 2016, 5:52 p.m.,

Re: Review Request 47952: Added a stout test for missing required flags.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47952/#review135558 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 11:56 a.m.,

Re: Review Request 45562: Edited `--work_dir` configuration docs.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review135557 --- Fix it, then Ship it! docs/configuration.md (lines 878 - 883)

Re: Review Request 46004: Updated master '--work_dir' help string.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/#review135556 --- Fix it, then Ship it! src/master/flags.cpp (line 59)

Re: Review Request 46003: Removed the default value for agent work_dir.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/#review13 --- Fix it, then Ship it! src/local/local.cpp (line 351)

Re: Review Request 47078: Added checking for required flags to FlagsBase.

2016-05-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/#review135553 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 11:29 a.m.,

Re: Review Request 46093: Enhanced the error message for invalid duration unit.

2016-05-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/#review135551 --- Fix it, then Ship it! I'll fix the issue and commit it for you.

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

2016-05-30 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/ --- (Updated May 30, 2016, 10:39 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47486: Windows: Escaped command line arguments.

2016-05-30 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/ --- (Updated May 30, 2016, 10:38 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47842: Point slave flags at programmatic temp path.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 30, 2016, 10:28 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 30, 2016, 10:19 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 48051: Expose auto refresh port in site docker.

2016-05-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135552 --- Patch looks great! Reviews applied: [48051] Passed command: expo

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 10:09 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47736: Used TaskObjectApprover to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 30, 2016, 10:08 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47736: Used TaskObjectApprover to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 30, 2016, 10:08 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/ --- (Updated May 30, 2016, 10:08 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 10:08 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added ObjectApprover interface to authorizer.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 30, 2016, 10:07 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 30, 2016, 10:05 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 10:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 30, 2016, 10:05 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 30, 2016, 10:04 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47821: Remove SASL dependency for Windows builds.

2016-05-30 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47821/ --- (Updated May 30, 2016, 10:03 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135550 --- Fix it, then Ship it! src/master/http.cpp (lines 1203 - 1205)

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-05-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/#review135549 --- src/master/master.hpp

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-05-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/#review135548 --- src/authorizer/local/authorizer.cpp (line 349)

  1   2   >