Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139017 --- Bad patch! Reviews applied: [48751] Failed command:

Review Request 49064: Implement v1 operator update weights API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49064/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Review Request 48940: Extract public logic of updating weights into _updateWeights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 49054: Fix ContainerizerTest.ROOT_CGROUPS_BalloonFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49054/#review139015 --- Patch looks great! Reviews applied: [49054] Passed command:

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

> On June 21, 2016, 3:25 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 368 > > > > > > Instead of using a counter I think the following is equivalent but > > simpler: > > > >

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/ --- (Updated June 22, 2016, 4:32 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 49053: Updated upgrades.md about persistent volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49053/#review139012 --- Patch looks great! Reviews applied: [49045, 49051, 49053]

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 12:02 p.m., Joris Van Remoortere wrote: > > > > Yanyan Hu wrote: > Hi, Joris, so sorry for this late reply. I have made some further > benchmarking and no negative impact was found when evaluating this change on > other existing test cases, especially those for

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 12:02 p.m., Joris Van Remoortere wrote: > > Hi, Joris, so sorry for this late reply. I have made some further benchmarking and no negative impact was found when evaluating this change on other existing test cases, especially those for resource and allocator. And I have

Re: Review Request 48989: Fixed broken cni isolator test on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48989/#review139009 --- src/tests/containerizer/cni_isolator_tests.cpp (line 185)

Re: Review Request 48906: Added helper function to get non-scarce resources.

> On 六月 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just use

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 22, 2016, 1:53 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/ --- (Updated 六月 22, 2016, 1:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49044: Made the long lived framework abort on receiving an `ERROR` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49044/#review139005 --- Patch looks great! Reviews applied: [49044] Passed command:

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review139004 --- Ship it! Ship It! - haosdent huang On June 22, 2016, 12:53

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review139003 --- Ship it! Ship It! - haosdent huang On June 22, 2016, 12:53

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

> On June 22, 2016, 12:36 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 1191-1192 > > > > > > why do you use a MockSlave? since you are not setting any expectations > > on the slave, just use

Re: Review Request 49045: Used non recursive chown for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49045/#review139001 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 11:04

Re: Review Request 48986: Updated the comments for GPU_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48986/#review139000 --- Ship it! Ship It! - Benjamin Mahler On June 22, 2016, 12:07

Re: Review Request 48906: Added helper function to get non-scarce resources.

> On June 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just

Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/ --- Review request for mesos, Joerg Schad and Michael Park. Repository: mesos

Review Request 49062: Fixed lambda capture list for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49062/ --- Review request for mesos, Joerg Schad and Michael Park. Repository: mesos

Review Request 49061: Removed the unused copy of an `ObjectApprover` in a lambda.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49061/ --- Review request for mesos, Joerg Schad and Michael Park. Repository: mesos

Review Request 49060: Removed unused approver from tasks authorization continuation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49060/ --- Review request for mesos, Joerg Schad and Michael Park. Repository: mesos

Review Request 49059: Fixed the test suite build for Apple clang-600.0.54.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49059/ --- Review request for mesos, Jie Yu, Michael Park, and Till Toenshoff.

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48926/ --- (Updated June 22, 2016, 12:55 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/ --- (Updated June 22, 2016, 12:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- (Updated June 22, 2016, 12:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

> On June 22, 2016, 12:36 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 1277 > > > > > > I think the SEGFAULT and SIGABRT issues you are seeing is because you > > are not waiting for the MockSlave to

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

> On June 21, 2016, 1:40 a.m., Vinod Kone wrote: > > src/master/master.hpp, line 1065 > > > > > > move this handler to the outer Master class for consistency with other > > v1 API handlers. > > zhou xing wrote: >

Re: Review Request 49057: Updated a CHECK in Subprocess to include the failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49057/#review138992 --- Ship it! Ship It! - Joseph Wu On June 21, 2016, 5:40 p.m.,

Re: Review Request 49057: Updated a CHECK in Subprocess to include the failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49057/ --- (Updated June 22, 2016, 12:40 a.m.) Review request for mesos and Joseph Wu.

Review Request 49057: Updated a CHECK in Subprocess to include the failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49057/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 49056: Added the missing evolutions in `GetMetrics` operator APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49056/#review138990 --- Ship it! Ship It! - Vinod Kone On June 22, 2016, 12:34

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/#review138971 --- src/slave/http.cpp (line 671)

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

> On June 21, 2016, 9:45 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 620 > > > > > > hmm.. We forgot evolving the response here? My bad when rebasing this chain, post a follow patch at

Review Request 49056: Added the missing evolutions in `GetMetrics` operator APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49056/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay

Re: Review Request 48906: Added helper function to get non-scarce resources.

> On 六月 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just use

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

> On 六月 21, 2016, 1:40 a.m., Vinod Kone wrote: > > src/master/master.hpp, line 1065 > > > > > > move this handler to the outer Master class for consistency with other > > v1 API handlers. Vinod, this method

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

> On June 21, 2016, 10:05 p.m., Benjamin Mahler wrote: > > Can you describe why you made this change? > > > > This follows the same pattern as other isolators (e.g. cpushare.cpp, > > mem.cpp), so it's hard to tell what the issue is here. > > Qian Zhang wrote: > I think for

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

> On June 22, 2016, 6:05 a.m., Benjamin Mahler wrote: > > Can you describe why you made this change? > > > > This follows the same pattern as other isolators (e.g. cpushare.cpp, > > mem.cpp), so it's hard to tell what the issue is here. I think for `cgroups/devices` isolator, we need to

Re: Review Request 48986: Updated a typo for GPU_RESOURCES.

> On 六月 21, 2016, 8:22 p.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto, line 281 > > > > > > We don't want to occupy a GPU agent and prevent GPU workloads from > > running, this adjustments looks

Re: Review Request 48986: Updated the comments for GPU_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48986/ --- (Updated 六月 22, 2016, 12:07 a.m.) Review request for mesos, Alexander

Re: Review Request 49041: Removed `launcher` from the Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49041/#review138982 --- src/launcher/CMakeLists.txt (lines 39 - 41)

Re: Review Request 49051: Updated CHANGELOG about the persistent volume ownership change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49051/#review138981 --- Ship it! CHANGELOG (lines 168 - 169)

Review Request 49054: Fix ContainerizerTest.ROOT_CGROUPS_BalloonFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49054/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 49053: Updated upgrades.md about persistent volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49053/#review138980 --- Ship it! Ship It! - Gilbert Song On June 21, 2016, 4:53

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/#review138978 --- Ship it! Ship It! - Jiang Yan Xu On June 21, 2016, 2:37

Re: Review Request 49041: Removed `launcher` from the Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49041/#review138979 --- Bad review! Reviews applied: [49041, 49040, 49039, 49038, 49037,

Re: Review Request 49051: Updated CHANGELOG about the persistent volume ownership change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49051/ --- (Updated June 21, 2016, 11:53 p.m.) Review request for mesos, Gilbert Song and

Review Request 49053: Updated upgrades.md about persistent volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49053/ --- Review request for mesos, Gilbert Song and Jiang Yan Xu. Repository: mesos

Re: Review Request 49051: Updated CHANGELOG about the persistent volume ownership change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49051/#review138974 --- Ship it! Ship It! - Gilbert Song On June 21, 2016, 4:18

Re: Review Request 49045: Used non recursive chown for persistent volumes.

> On June 21, 2016, 11:10 p.m., Jiang Yan Xu wrote: > > Consider document this behavior change. Sure. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49045/#review138966

Re: Review Request 48910: Highlight disconnected frameworks in webui.

> On Cze 21, 2016, 9:32 po południu, Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? > > Tomasz Janiszewski wrote: > How about adding "Connected" column with plain

Review Request 49051: Updated CHANGELOG about the persistent volume ownership change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49051/ --- Review request for mesos, Gilbert Song and Jiang Yan Xu. Repository: mesos

Re: Review Request 49049: Restored the continuation logic fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49049/#review138969 --- Ship it! Ship It! - Adam B On June 21, 2016, 4 p.m.,

Re: Review Request 49045: Used non recursive chown for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49045/#review138968 --- Ship it! Yeah, same as Yan. A followup patch for `upgrade.md`

Re: Review Request 48910: Highlight disconnected frameworks in webui.

> On June 21, 2016, 9:32 p.m., Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? > > Tomasz Janiszewski wrote: > How about adding "Connected" column with plain

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/#review138955 --- include/mesos/agent/agent.proto (line 168)

Re: Review Request 49045: Used non recursive chown for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49045/#review138966 --- Ship it! Consider document this behavior change. - Jiang Yan

Review Request 49045: Used non recursive chown for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49045/ --- Review request for mesos, Adam B, Gilbert Song, haosdent huang, and Jiang Yan

Re: Review Request 48910: Highlight disconnected frameworks in webui.

> On June 21, 2016, 9:32 p.m., Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? How about adding "Connected" column with plain true/false or status icon? - Tomasz

Re: Review Request 49049: Restored the continuation logic fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49049/#review138962 --- Ship it! Ship It! - Vinod Kone On June 21, 2016, 10:48

Review Request 49049: Restored the continuation logic fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49049/ --- Review request for mesos, Jay Guo, Joerg Schad, and Vinod Kone. Repository:

Re: Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46026/#review138960 --- Ship it! Thanks! Looks good modulo the setence on different

Re: Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.

> On June 17, 2016, 10:07 p.m., Benjamin Mahler wrote: > > While it's nice to document that this is internally only doing a > > receive-side shutdown, I'm left wondering why. And now that it's > > documented, the restriction looks intentional but the intention is absent. > > It would be of

Re: Review Request 48906: Added helper function to get non-scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48906/#review138958 --- include/mesos/resources.hpp (lines 252 - 256)

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46182/#review138957 --- Bad patch! Reviews applied: [46182] Failed command:

Re: Review Request 49044: Made the long lived framework abort on receiving an `ERROR` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49044/#review138954 --- Ship it! Ship It! - Vinod Kone On June 21, 2016, 9:22 p.m.,

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/#review138951 --- Can you describe why you made this change? This follows the same

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review138950 --- src/master/http.cpp (line 1462)

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review138949 --- Bad patch! Reviews applied: [46107] Failed command:

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review138948 --- src/slave/http.cpp (line 620)

Re: Review Request 48911: Show orphan tasks in WebUI.

> On June 21, 2016, 9:39 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 151-154 > > > > > > This still looks incorrect, we need to set the stopped time only if the > > last state

Re: Review Request 48911: Show orphan tasks in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138946 --- Fix it, then Ship it! Looks good, thank you! Can you please

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/ --- (Updated June 21, 2016, 9:37 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48751: Implement GetState response for master API.

> On June 21, 2016, 1:29 a.m., Vinod Kone wrote: > > include/mesos/v1/master.proto, lines 181-193 > > > > > > How about defining *top level* `Framework` and maybe `Executor` > > message? I think it could be reused

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/ --- (Updated June 21, 2016, 9:37 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

> On June 21, 2016, 5:33 p.m., Jiang Yan Xu wrote: > > 3rdparty/stout/include/stout/os/empty.hpp, line 37 > > > > > > Looks like the Windows version of `readdir` and its internal calls do > > set errno > >

Re: Review Request 48910: Highlight disconnected frameworks in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138945 --- Very nice, however the meaning of the color doesn't seem

Re: Review Request 48455: Some cleanup for sorter.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/#review138944 --- Ship it! - Benjamin Mahler On June 11, 2016, 8:27 a.m.,

Review Request 49044: Made the long lived framework abort on receiving an `ERROR` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49044/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 48579: Reset "dirty" to false in sort().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review138939 --- Ship it! src/master/allocator/sorter/drf/sorter.cpp (lines

Re: Review Request 49042: Removed GET_RESOURCE_STATISTICS call from agent.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49042/#review138942 --- Ship it! LGTM! - Anand Mazumdar On June 21, 2016, 9:02

Review Request 49042: Removed GET_RESOURCE_STATISTICS call from agent.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49042/ --- Review request for mesos, Anand Mazumdar, Jay Guo, and haosdent huang. Bugs:

Re: Review Request 49003: Added a Contributing to Mesos blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49003/#review138937 --- Bad patch! Reviews applied: [49003] Failed command:

Re: Review Request 48579: Reset "dirty" to false in sort().

> On June 21, 2016, 8:35 p.m., Benjamin Mahler wrote: > > It looks like dirty is not being set to true in all cases. For example, > > when the weights are updated, why aren't we setting dirty to true? Just saw that you fixed this in your next patch, I'll go through this again shortly, should

Re: Review Request 48062: Recalculated share when weight was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48062/#review138931 --- Ship it! Ah great, this should come before the `dirty = false`

Re: Review Request 49037: Removed mesos-Containerizer-memory_test in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49037/ --- (Updated June 21, 2016, 8:36 p.m.) Review request for mesos and Joris Van

Re: Review Request 49041: Removed `launcher` from the Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49041/ --- (Updated June 21, 2016, 8:36 p.m.) Review request for mesos and Joris Van

Re: Review Request 48579: Reset "dirty" to false in sort().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review138928 --- It looks like dirty is not being set to true in all cases. For

Re: Review Request 48455: Some cleanup for sorter.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/#review138926 --- I did a scan of the file and left comments for missing includes

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

> On June 21, 2016, 10:33 a.m., Jiang Yan Xu wrote: > > 3rdparty/stout/include/stout/os/empty.hpp, line 37 > > > > > > Looks like the Windows version of `readdir` and its internal calls do > > set errno > >

Re: Review Request 48986: Updated a typo for GPU_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48986/#review138925 --- include/mesos/mesos.proto (line 281)

Re: Review Request 49027: Removed dangling reference error in a lambda capture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49027/#review138922 --- Patch looks great! Reviews applied: [49027] Passed command:

Re: Review Request 49038: Fixed store.cpp break.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49038/#review138917 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138914 --- Ship it! Can you rebase? - Vinod Kone On June 21, 2016,

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review138913 --- Ship it! Ship It! - Vinod Kone On June 21, 2016, 12:11

Review Request 49037: Removed mesos-Containerizer-memory_test in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49037/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 49038: Fixed store.cpp break.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49038/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

  1   2   >