Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/#review139434 --- Patch looks great! Reviews applied: [49206] Passed command:

Re: Review Request 49171: Added a `Networking` section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/#review139433 --- Bad patch! Reviews applied: [49171] Failed command:

Review Request 49223: WIP: enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- Review request for mesos. Repository: mesos Description --- WIP:

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/#review139432 --- Patch looks great! Reviews applied: [48902, 49118] Passed

Re: Review Request 48908: Added test case for exclude scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/ --- (Updated 六月 25, 2016, 1:58 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 49201: Added validation for the `get_endpoints` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/#review139429 --- Patch looks great! Reviews applied: [49196, 49201] Passed

Re: Review Request 49201: Added validation for the `get_endpoints` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/#review139422 --- Looks great, but you're missing a couple of the libprocess

Re: Review Request 48904: Updated allocator initialize().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48904/ --- (Updated 六月 25, 2016, 12:49 a.m.) Review request for mesos and Benjamin

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/ --- (Updated June 25, 2016, midnight) Review request for mesos, Gilbert Song and

Re: Review Request 48371: Added `NvidiaGpuAllocator` component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48371/#review139416 --- Fix it, then Ship it! Great, thanks! I did some re-working of

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 24, 2016, 11:20 p.m.) Review request for mesos, Gilbert Song and

Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4778

Re: Review Request 49211: Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49211/#review139414 --- Ship it! docs/submitting-a-patch.md (line 11)

Review Request 49211: Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49211/ --- Review request for mesos. Summary (updated) - Renamed and

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review139413 --- include/mesos/master/master.proto (lines 284 - 290)

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

> On June 21, 2016, 11:10 p.m., Vinod Kone wrote: > > src/slave/http.cpp, line 660 > > > > > > hmm. looks like this is not reusing any code from `_containers()`. can > > you extract the common code from

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139410 --- Patch looks great! Reviews applied: [49136, 49137] Passed

Re: Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 24, 2016, 9:57 p.m.) Review request for mesos. Repository:

Review Request 49207: Added proto message definitions to support appc runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- Review request for mesos. Repository: mesos Description --- Added proto

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139409 --- src/master/master.hpp (line 1103)

Review Request 49208: Modified tests to check is appc spec with app object is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4778

Re: Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139406 --- include/mesos/master/master.proto (lines 291 - 295)

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139404 --- include/mesos/master/master.proto (line 150)

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/#review139405 --- Ship it! Ship It! - Vinod Kone On June 24, 2016, 9:13 p.m.,

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

> On June 24, 2016, 8:49 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, lines 2038-2054 > > > > > > are all these available on all tye OSses we support? OSX, Windows and > > Linux? If not, some of these

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/ --- (Updated June 24, 2016, 9:13 p.m.) Review request for mesos, Abhishek

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139402 --- Fix it, then Ship it! include/mesos/master/master.proto (line

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/#review139401 --- Ship it! Ship It! - Vinod Kone On June 24, 2016, 3:24 p.m.,

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/#review139400 --- include/mesos/mesos.proto (lines 2038 - 2054)

Re: Review Request 49178: Configured single output binary folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/#review139399 --- src/CMakeLists.txt (line 462)

Re: Review Request 49186: Added test for file volume from host sandbox mountpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49186/#review139396 --- Patch looks great! Reviews applied: [49184, 49185, 49186]

Review Request 49214: Added `FileInfo` protobuf for describing a File.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/ --- Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone. Bugs:

Review Request 49210: Fixed typo in JIRA user for bbannier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49210/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/ --- (Updated June 24, 2016, 12:19 p.m.) Review request for mesos, Artem

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/#review139395 --- src/master/quota_handler.cpp (lines 215 - 230)

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

> On June 24, 2016, 1:43 a.m., Guangya Liu wrote: > > @Gilbert, I saw that there is no test case for containers without rootfs > > against your code change, are you planning to add those cases in this patch > > chain? Thanks for pointing that out. I considered whether adding those tests or

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

> On June 24, 2016, 1:11 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 404-420 > > > > > > Can you please add some comments here for why not handling the case for

Re: Review Request 49122: Added a MAC parse function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139178 --- Fix it, then Ship it! 3rdparty/stout/include/stout/mac.hpp

Re: Review Request 49171: Added a `Networking` section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/#review139386 --- Fix it, then Ship it! docs/networking.md (lines 5 - 8)

Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review139382 --- Ship it! LGTM. Caught two styling issues which I will fix when

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/#review139381 --- Ship it! Ship It! - Jiang Yan Xu On June 23, 2016, 10:32

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/ --- (Updated June 24, 2016, 4:06 p.m.) Review request for mesos, Joris Van

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/ --- (Updated June 24, 2016, 4:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review139379 --- include/mesos/master/master.proto (lines 284 - 286)

Re: Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139377 --- include/mesos/master/master.proto (line 310)

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/ --- (Updated June 24, 2016, 3:24 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49201: Added validation for the `get_endpoints` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/ --- Review request for mesos, Adam B, Jan Schlicht, and Till Toenshoff.

Re: Review Request 49196: Disabled authorization from the `/flags` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49196/ --- (Updated June 24, 2016, 4:19 p.m.) Review request for mesos, Adam B, Jan

Re: Review Request 48908: Added test case for scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/ --- (Updated 六月 24, 2016, 2:09 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 49190: Enabled calculateShare() to ignore the fairnessExcludeResourceNames.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49190/ --- (Updated 六月 24, 2016, 2:08 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 49190: Enabled calculateShare() to ignore the fairnessExcludeResourceNames.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49190/ --- Review request for mesos. Repository: mesos Description --- Enabled

Re: Review Request 48907: Enabled allocator transfer the fairnessExcludeResourceNames to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48907/ --- (Updated 六月 24, 2016, 2:02 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 49196: Disabled authorization from the `/flags` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49196/ --- Review request for mesos, Adam B, Jan Schlicht, and Till Toenshoff.

Re: Review Request 49095: Enabled fine-grained authorization in the master's frameworks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/ --- (Updated June 24, 2016, 5 a.m.) Review request for mesos, Adam B, Joerg Schad,

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48895/ --- (Updated 六月 24, 2016, 9:31 a.m.) Review request for mesos and Benjamin Mahler.

Review Request 49181: Fixed a typo in hierarchical.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49181/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 46686: Allowed to pass lambda in `dispatch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46686/ --- (Updated June 24, 2016, 8:56 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46687: Updated legacy `dispatch` calls to use lambda.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/ --- (Updated June 24, 2016, 8:57 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review139359 --- @Gilbert, I saw that there is no test case for containers without

Re: Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review139358 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/ --- (Updated 六月 24, 2016, 8:11 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/#review139354 --- Ship it! Ship It! - Neil Conway On June 23, 2016, 9:29

Re: Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/ --- (Updated 六月 24, 2016, 7:21 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49088: Replaced default capture by value by explicit capture by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49088/#review139352 --- Ship it! Ship It! - Jay Guo On June 22, 2016, 2:22 p.m.,

Re: Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/ --- (Updated 六月 24, 2016, 7:05 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139350 --- src/master/http.cpp (line 1290)

Review Request 49185: Added test for file volume from host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49185/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang

Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang

Review Request 49186: Added test for file volume from host sandbox mountpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49186/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang