Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4778 https:/

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 6, 2016, 6:32 a.m.) Review request for mesos. Bugs: MESOS-4778

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 6, 2016, 6:32 a.m.) Review request for mesos, Gilbert Song and Ji

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 6, 2016, 6:31 a.m.) Review request for mesos. Repository: mesos

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 3:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was taking mesos::Request and giving compiler er

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140944 --- Fix it, then Ship it! Would fix these minor style nits while co

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140945 --- Fix it, then Ship it! Would fix these minor style nits while co

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140948 --- Fix it, then Ship it! Would fix this before committing. inclu

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140950 --- Fix it, then Ship it! Would fix these minor style nits while co

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140952 --- Fix it, then Ship it! Would be committing it shortly with the f

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140951 --- Fix it, then Ship it! Would fix these minor style nits while co

Re: Review Request 49245: Implement READ_FILE for agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/ --- (Updated 七月 6, 2016, 5:23 a.m.) Review request for mesos, Anand Mazumdar, haosd

Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792 http

Re: Review Request 49244: Implement READ_FILE for master operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/ --- (Updated 七月 6, 2016, 5:22 a.m.) Review request for mesos, Anand Mazumdar, haosd

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/ --- (Updated 七月 6, 2016, 5:21 a.m.) Review request for mesos, Anand Mazumdar, haosd

Re: Review Request 49242: Add ReadFile protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/ --- (Updated 七月 6, 2016, 5:19 a.m.) Review request for mesos, Anand Mazumdar, haosd

Review Request 49679: Updated v1 operator Call::ReadFile message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49679/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: mesos-5515 h

Re: Review Request 49674: Fixed the docker executor to handle inspect failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49674/#review140949 --- Patch looks great! Reviews applied: [49670, 49671, 49673, 49674]

Re: Review Request 49674: Fixed the docker executor to handle inspect failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49674/#review140946 --- Fix it, then Ship it! src/docker/executor.cpp (lines 211 - 219

Re: Review Request 49673: Fixed a bug in JSON::Object.find: array subscript is dropped.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49673/#review140943 --- 3rdparty/stout/tests/json_tests.cpp (line 340)

Re: Review Request 49673: Fixed a bug in JSON::Object.find: array subscript is dropped.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49673/#review140942 --- Ship it! Ship It! - Kevin Klues On July 6, 2016, 12:34 a.m.,

Re: Review Request 49671: Minor cleanups in JsonTest.Find.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49671/#review140941 --- Ship it! Ship It! - Kevin Klues On July 6, 2016, 12:34 a.m.,

Re: Review Request 49670: Updated JSON::Value.find to return None when a Null is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49670/#review140940 --- Ship it! Ship It! - Kevin Klues On July 6, 2016, 12:34 a.m.,

Re: Review Request 49678: Added unit test to verify GPU isolation inside a docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49678/#review140939 --- Ship it! Ship It! - Benjamin Mahler On July 6, 2016, 3:55 a.

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49609/#review140938 --- src/master/http.cpp (line 2511)

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/#review140936 --- src/master/http.cpp (line 1501)

Re: Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49686/#review140937 --- src/master/http.cpp (line 3491)

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review140935 --- src/master/http.cpp (line 1396)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 6, 2016, 3:58 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review140933 --- src/master/http.cpp (line 1396)

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 6, 2016, 3:56 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review140932 --- include/mesos/master/master.proto (line 331)

Re: Review Request 49678: Added unit test to verify GPU isolation inside a docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49678/ --- (Updated July 6, 2016, 3:55 a.m.) Review request for mesos and Benjamin Mahler.

Review Request 49686: Added filtering for orphaned tasks in `GET_TASKS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49686/ --- Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao Li

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/ --- (Updated July 6, 2016, 3:43 a.m.) Review request for mesos, Anand Mazumdar, Joe

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/ --- (Updated July 6, 2016, 3:43 a.m.) Review request for mesos, Anand Mazumdar, Joe

Re: Review Request 49680: Adjust the format of allocator slack channel for working group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49680/#review140929 --- Ship it! Ship It! - Benjamin Mahler On July 6, 2016, 1:46 a.

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/ --- (Updated July 6, 2016, 3:31 a.m.) Review request for mesos, Anand Mazumdar, Joe

Review Request 49685: Added filtering for orphaned executors in `master::Call::GET_EXECUTORS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49685/ --- Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao Li

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140928 --- Patch looks great! Reviews applied: [49600] Passed command: expo

Re: Review Request 49223: Enhance value parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 6, 2016, 10:40 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140927 --- src/master/http.cpp (lines 1551 - 1552)

Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/ --- Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li. Repository

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 6, 2016, 1:49 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 6, 2016, 1:48 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/ --- (Updated July 6, 2016, 1:47 a.m.) Review request for mesos, Anand Mazumdar, hao

Review Request 49680: Adjust the format of allocator slack channel for working group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49680/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/ --- (Updated July 6, 2016, 1:46 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/ --- (Updated July 6, 2016, 1:45 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 6, 2016, 1:44 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 6, 2016, 1:43 a.m.) Review request for mesos, Anand Mazumdar, hao

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review140926 --- Patch looks great! Reviews applied: [49616] Passed command: expo

Re: Review Request 49657: Added ability to set framework capabilities in 'mesos-execute'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49657/#review140925 --- Ship it! Ship It! - Benjamin Mahler On July 6, 2016, 1:22 a.

Re: Review Request 49657: Added ability to set framework capabilities in 'mesos-execute'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49657/ --- (Updated July 6, 2016, 1:22 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 49669: Integrated the 'NvidiaVolume' component into the 'NvidiaGpuIsolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49669/ --- (Updated July 6, 2016, 1:22 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 49678: Added unit test to verify GPU isolation inside a docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49678/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5401 https://issu

Re: Review Request 49668: Added Nvidia devices as default devices to inject into every container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49668/ --- (Updated July 6, 2016, 1:22 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 49517: Implement GetState V1 master API.

> On July 6, 2016, 12:30 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, line 537 > > > > > > Just execDriver->sendXX would suffice. > > > > Would be a good idea to do a sweep across this file and r

Re: Review Request 49669: Integrated the 'NvidiaVolume' component into the 'NvidiaGpuIsolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49669/#review140917 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140920 --- Ship it! Similar cleanup comments to the getFrameworks review (

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140918 --- Fix it, then Ship it! include/mesos/master/master.proto (line

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140915 --- Fix it, then Ship it! src/master/http.cpp (line 1339)

Re: Review Request 49517: Implement GetState V1 master API.

> On July 6, 2016, 12:30 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, line 537 > > > > > > Just execDriver->sendXX would suffice. > > > > Would be a good idea to do a sweep across this file and r

Re: Review Request 49668: Added Nvidia devices as default devices to inject into every container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49668/#review140914 --- Fix it, then Ship it! src/linux/fs.cpp (line 523)

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140912 --- Fix it, then Ship it! src/master/http.cpp (line 2081)

Re: Review Request 49658: Updated elfio-3.1.patch to fix alignment bug properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49658/#review140913 --- Ship it! Ship It! - Benjamin Mahler On July 5, 2016, 9:25 p.

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 6, 2016, 12:38 a.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/#review140911 --- Ship it! Ship It! - Anand Mazumdar On July 1, 2016, 11:32 p.

Review Request 49673: Fixed a bug in JSON::Object.find: array subscript is dropped.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49673/ --- Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos Descri

Review Request 49671: Minor cleanups in JsonTest.Find.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49671/ --- Review request for mesos and Kevin Klues. Repository: mesos Description -

Review Request 49674: Fixed the docker executor to handle inspect failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49674/ --- Review request for mesos, Gilbert Song, Joseph Wu, and Kevin Klues. Repository:

Review Request 49670: Updated JSON::Value.find to return None when a Null is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49670/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos Des

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140901 --- Fix it, then Ship it! Some minor style nits. Also if you have

Re: Review Request 49672: Skipped terminated executors in statistics endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49672/#review140909 --- Ship it! Ship It! - Benjamin Mahler On July 6, 2016, 12:14 a

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 6, 2016, 12:27 a.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 6, 2016, 12:26 a.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 49668: Added Nvidia devices as default devices to inject into every container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49668/#review140908 --- Fix it, then Ship it! Please make sure to run a sudo make check

Re: Review Request 49672: Skipped terminated executors in statistics endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49672/#review140907 --- Ship it! Ship It! - Gilbert Song On July 5, 2016, 5:14 p.m.,

Review Request 49672: Skipped terminated executors in statistics endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49672/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Vinod Kone. Bugs:

Review Request 49668: Added Nvidia devices as default devices to inject into every container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49668/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5793 http

Re: Review Request 49660: Added #allocator slack channel to Resource Allocation group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49660/#review140906 --- Ship it! Ship It! - Benjamin Mahler On July 5, 2016, 11:57 p

Review Request 49669: Integrated the 'NvidiaVolume' component into the 'NvidiaGpuIsolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49669/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5401 http

Re: Review Request 49623: Fixed a no-longer-correct comment in `Master::shutdownSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49623/#review140903 --- Ship it! Ship It! - Vinod Kone On July 5, 2016, 12:22 p.m.,

Re: Review Request 49660: Added #allocator slack channel to Resource Allocation group.

> On 七月 5, 2016, 11:30 p.m., Benjamin Mahler wrote: > > docs/working-groups.md, lines 98-99 > > > > > > Can you also link to the archives? > > > > http://mesos.slackarchive.io/allocator/ > > > > I'll

Re: Review Request 49660: Added #allocator slack channel to Resource Allocation group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49660/ --- (Updated 七月 5, 2016, 11:57 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 5, 2016, 11:41 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 598 > > > > > > s/executod/executed > > s/Note/NOTE > > > > Also, this looks more like a TODO than a NOTE? This is a no

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140894 --- Looks very good! Just some minor style nit-picks. include/mesos/

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 3:04 a.m., Adam B wrote: > > src/files/files.hpp, line 65 > > > > > > Shame we have to perpetuate these naked pointers. Any chance we could > > use a `shared_ptr`? > > Abhishek Dasgupta wrote: >

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 12:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49660: Added #allocator slack channel to Resource Allocation group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49660/#review140897 --- docs/working-groups.md (lines 98 - 99)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 5, 2016, 11:08 p.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 49661: Ignore null entries for Docker inspect's 'HostConfig.Devices' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49661/#review140892 --- src/docker/docker.cpp (line 365)

Re: Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.

> On July 5, 2016, 10:42 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/mesos/isolators/gpu/volume.cpp, lines 387-393 > > > > > > You don't need either of these checks > > Kevin Klues wrote: > Why don'

Re: Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.

> On July 5, 2016, 10:42 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/mesos/isolators/gpu/volume.cpp, lines 387-393 > > > > > > You don't need either of these checks Why don't I need these checks? The fi

Re: Review Request 49661: Ignore null entries for Docker inspect's 'HostConfig.Devices' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49661/#review140886 --- Do you think we should add a failure handler to the docker executo

Re: Review Request 49661: Ignore null entries for Docker inspect's 'HostConfig.Devices' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49661/#review140888 --- Ship it! Did you double check with the Centos 6 CI that it pass

Re: Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49615/#review140885 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Review Request 49661: Ignore null entries for Docker inspect's 'HostConfig.Devices' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49661/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos Des

Re: Review Request 49649: Libprocess: Fixed 'make dist'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49649/#review140884 --- Ship it! Ship It! - Till Toenshoff On July 5, 2016, 8:21 p.m

Re: Review Request 49648: Stout: Fixed 'make dist'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49648/#review140883 --- Ship it! Ship It! - Till Toenshoff On July 5, 2016, 8:21 p.m

  1   2   3   >