Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141750 --- Ship it! Ship It! - Isabel Jimenez On July 11, 2016, 4:31 p.

Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141748 --- Ship it! Thanks for improving the logging Alex - I am a great f

Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5725 h

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141305 --- Partial review. Let's discuss first. src/master/master.cpp (line

Re: Review Request 49907: Added Timothy Chen to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49907/#review141737 --- Ship it! Ship It! - Jie Yu On July 11, 2016, 5:49 p.m., Timo

Review Request 49907: Added Timothy Chen to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49907/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 49906: Add lawrencew to contributors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49906/#review141735 --- Ship it! Ship It! - Jie Yu On July 11, 2016, 5:47 p.m., Lawr

Review Request 49906: Add lawrencew to contributors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49906/ --- Review request for mesos and Ian Downes. Repository: mesos Description --

Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141730 --- Patch looks great! Reviews applied: [49903] Passed command: expo

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141726 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016, 11:57

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/#review141649 --- src/launcher/executor.cpp (line 90)

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

> On July 11, 2016, 2:46 p.m., Qian Zhang wrote: > > So even we reorganize the routing tests into basic and advanced groups, all > > these tests are still in the same file (routing_tests.cpp which is > > currently guarded by `WITH_NETWORK_ISOLATOR` in Makefile.am) which means > > they will be

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

> On July 11, 2016, 3:42 p.m., Avinash sridharan wrote: > > src/tests/containerizer/routing_tests.cpp, line 258 > > > > > > Instead of failing over here should we be disabling these tests if the > > libnl version is

Re: Review Request 49883: Renamed and lambda-ified a function in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49883/#review141721 --- Ship it! Ship It! - Alexander Rukletsov On July 11, 2016, 9:

Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.

> On July 11, 2016, 2:10 p.m., Qian Zhang wrote: > > So the main purposal of this patch is to remove the dependency (e.g., > > `nl_has_capability()`) of higher version of libnl from `routing::socket()` > > which can then work with lower version of libnl, right? Yeah. - Jie

Re: Review Request 49880: Fixed typos in comments in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49880/#review141719 --- Ship it! Ship It! - Alexander Rukletsov On July 11, 2016, 8:

Review Request 49903: Printed empty set if `Resources` instance is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/ --- Review request for mesos, Isabel Jimenez, Michael Park, and Till Toenshoff. Rep

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review141657 --- Fix it, then Ship it! src/slave/slave.cpp (line 2506)

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/#review141712 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 49840: Fixed the right angle brackets in routing tests.

> On July 11, 2016, 4:15 p.m., Qian Zhang wrote: > > Is this (">>") the coding convention of Mesos? If so, we may need to > > mention it in > > https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md. > > And I see there are still a lot of code in Mesos using "> >" now, maybe w

Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- Review request for mesos. Bugs: MESOS-5792 https://issues.apache.org/jira/b

Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- Review request for mesos. Bugs: MESOS-5792 https://issues.apache.org/jira/b

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated July 11, 2016, 3:47 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 11, 2016, 3:47 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 11, 2016, 3:46 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141706 --- src/tests/containerizer/routing_tests.cpp (line 207)

Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/#review141702 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016, 11:57

Re: Review Request 49840: Fixed the right angle brackets in routing tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49840/#review141704 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016, 11:57

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141700 --- Ship it! Ship It! - Neil Conway On July 11, 2016, 2:04 p.m.,

Re: Review Request 49835: Moved netlink cleanup functions to separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49835/#review141697 --- Ship it! Ship It! - Qian Zhang On July 9, 2016, 6:44 a.m., J

Re: Review Request 49835: Moved netlink cleanup functions to separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49835/#review141696 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016, 10:44

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141694 --- Patch looks great! Reviews applied: [49892] Passed command: expo

Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141691 --- So even we reorganize the routing tests into basic and advanced gr

Re: Review Request 49840: Fixed the right angle brackets in routing tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49840/#review141689 --- Ship it! Is this (">>") the coding convention of Mesos? If so,

Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/#review141688 --- Ship it! So the main purposal of this patch is to remove the de

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/ --- (Updated July 11, 2016, 2:04 p.m.) Review request for mesos and Vinod Kone. R

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141683 --- Patch looks great! Reviews applied: [49892] Passed command: expo

Re: Review Request 32079: added a few more presentations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32079/#review141680 --- I really like the idea of updating the list with new presentations

Re: Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141679 --- src/tests/master_slave_reconciliation_tests.cpp (line 600)

Re: Review Request 49692: Removed an unnecessary `Clock::settle` from a test case.

> On July 8, 2016, 5:23 p.m., Vinod Kone wrote: > > src/tests/master_slave_reconciliation_tests.cpp, line 620 > > > > > > not yours. > > > > @joerg: can you remind me why you do AWAIT_READY(status) here inst

Review Request 49892: Removed unnecessary await from test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 49883: Renamed and lambda-ified a function in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49883/#review141668 --- Patch looks great! Reviews applied: [49610, 49612, 49880, 49883]

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141654 --- Patch looks great! Reviews applied: [48593] Passed command: expo

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that `AWAIT

Re: Review Request 49883: Renamed and lambda-ified a function in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49883/ --- (Updated July 11, 2016, 9:41 a.m.) Review request for mesos and Alexander Rukle

Review Request 49883: Renamed a function in allocator tests for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49883/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Review Request 49880: Fixed typos in comments in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49880/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 49610: Added test case for quota allocation with reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49610/ --- (Updated July 11, 2016, 8:47 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/ --- (Updated July 11, 2016, 7:52 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48593: Refactor Ranges Subtraction.

> On July 11, 2016, 7:43 a.m., Joris Van Remoortere wrote: > > Let's use full, and meaningful words for our names. Yes, will rename res variable to ranges as Joseph suggested. Thanks. - Yanyan --- This is an automatically generated e-ma

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141645 --- Let's use full, and meaningful words for our names. src/common/v

<    1   2