Re: Review Request 49616: Add suppression benchmark.

> On 七月 23, 2016, 1:37 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3574-3575 > > > > > > We use size_t as the type of "size" / "count" / "index" variables in > > general, as

Re: Review Request 49616: Add suppression benchmark.

> On July 23, 2016, 1:37 a.m., Benjamin Mahler wrote: > > Thanks Jacob! I left some comments here around style and readability of the > > code. It looks like much of this was copied and so I realize that you > > weren't the one to introduce many of these patterns. Nonetheless, would be > >

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 26, 2016, 5:29 a.m.) Review request for mesos, James Peach,

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/#review143478 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 50216: Updated filesystem linux isolator script to be partially non-shell.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50216/ --- (Updated July 25, 2016, 8:20 p.m.) Review request for mesos, Artem

Re: Review Request 50215: Updated pre exec commands as non-shell in docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50215/ --- (Updated July 25, 2016, 8:19 p.m.) Review request for mesos, Artem

Re: Review Request 50214: Supported non-shell command in MesosLaunch to avoid arbitrary commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50214/ --- (Updated July 25, 2016, 8:19 p.m.) Review request for mesos, Artem

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/#review143466 --- src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 25, 2016, 1:46 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 82-86 > > > > > > I think besides preparing the hierarchy, we also need to ensure no > > other

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review143470 --- Patch looks great! Reviews applied: [50421] Passed command:

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 25, 2016, 9:46 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 82-86 > > > > > > I think besides preparing the hierarchy, we also need to ensure no > > other

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143465 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49849: Implemented `CpuSubsystem`.

> On July 25, 2016, 2:03 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 47-63 > > > > > > I would suggest to slightly change these code to: > > ``` > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143397 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 50413: Minor cleanups to the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50413/#review143456 --- Patch looks great! Reviews applied: [50410, 50411, 50412, 50413]

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 25, 2016, 9:46 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 82-86 > > > > > > I think besides preparing the hierarchy, we also need to ensure no > > other

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 25, 2016, 4:59 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 50217: Added disk full framework to example frameworks unit test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50217/#review143447 --- Fix it, then Ship it! Reviewbot failed because the test script

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review143444 --- Fix it, then Ship it! I'm going to modify your commit

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/#review143443 --- Patch looks great! Reviews applied: [50414, 50415] Passed

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated July 25, 2016, 10:31 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50423: Avoided using integers as booleans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50423/#review143442 --- Ship it! Ship It! - Gilbert Song On July 25, 2016, 3:26

Review Request 50423: Avoided using integers as booleans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50423/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu.

Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/ --- (Updated July 25, 2016, 9:53 p.m.) Review request for mesos, Alex Clemmer and

Review Request 50417: Improved consistency of test code for partitioning an agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50412: Removed a no longer valid comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50412/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5103

Re: Review Request 50365: Removed `C` framework support from framework developer guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50365/#review143435 --- Ship it! Ship It! - Anand Mazumdar On July 22, 2016, 10:59

Review Request 50410: Added helpers evolve/devolve functions for executor calls/events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50410/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5901

Review Request 50411: Made the command executor use the unversioned protobufs internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50411/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50418: Cleaned up comments in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50418/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50416: Added more assertions to master code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50416/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50413: Minor cleanups to the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50413/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 49926: Added Windows build batch script.

> On July 12, 2016, 9:40 p.m., Alex Clemmer wrote: > > support/windows-build.bat, line 44 > > > > > > Heh. Do we want to actually explain that this is a bug? This comment > > seems more like an inside joke right

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review143433 --- Ship it! Ship It! - Alex Clemmer On July 12, 2016, 11:16

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated July 25, 2016, 9:29 p.m.) Review request for mesos, Alex Clemmer and

Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Re: Review Request 50217: Added disk full framework to example frameworks unit test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50217/ --- (Updated July 25, 2016, 12:22 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 25, 2016, 12:22 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/#review143411 --- Patch looks great! Reviews applied: [50398] Passed command:

Re: Review Request 50329: Added readonly/readwrite authentication support to endpoint help.

> On July 22, 2016, 9:09 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 82 > > > > > > Let's make this Realm, and then we can include "mesos-master-scheduler" > > for `/v1/scheduler` Ah

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review143085 --- Thanks Ammar! Patches look good to me; Vinod is going to take a

Review Request 50398: Added libz to Ubuntu build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/ --- Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review143392 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated July 25, 2016, 3:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/#review143385 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/#review143383 --- Patch looks great! Reviews applied: [50380] Passed command:

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 25, 2016, 2:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 25, 2016, 2:47 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

> On July 25, 2016, 2:03 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 47-63 > > > > > > I would suggest to slightly change these code to: > > ``` > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143379 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/#review143378 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review143334 --- Fix it, then Ship it!

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 25, 2016, 1:46 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 82-86 > > > > > > I think besides preparing the hierarchy, we also need to ensure no > > other

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/#review143375 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5898

Re: Review Request 50338: Fixed flakiness in SlaveAuthorizerTest.ViewFlags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50338/#review143371 --- Ship it! on Ubuntu 16.04: `./mesos-tests

Re: Review Request 50387: Updated allocated number of range to 100 for sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50387/#review143360 --- Patch looks great! Reviews applied: [50387] Passed command:

Re: Review Request 50387: Updated allocated number of range to 100 for sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50387/ --- (Updated 七月 25, 2016, 9:21 a.m.) Review request for mesos and Benjamin Mahler.

Review Request 50387: Updated port range fragments to 100.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50387/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review143355 --- >From the following result, the validation consumed about `8s`,

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

> On July 25, 2016, 3:08 a.m., zhou xing wrote: > > is that possible to add one more test case to send a request with > > "application/json; charset=UTF-8" content-type to our operator API? Yeah, certainly we can add. I will ask Vinod or Anand if they are okay with that. - Abhishek

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

> On July 25, 2016, 3:06 a.m., zhou xing wrote: > > src/master/http.cpp, line 491 > > > > > > just wonder if we can just use regexp to extract string > > 'application/json' or 'application/x-protobuf' from

Re: Review Request 50181: Fixed the flaky test case `MasterAPITest.GetTasks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/#review143352 --- Patch looks great! Reviews applied: [50181] Passed command:

Re: Review Request 50181: Fixed the flaky test case `MasterAPITest.GetTasks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/ --- (Updated July 25, 2016, 6:17 a.m.) Review request for mesos, Anand Mazumdar,