Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53083/ --- (Updated Oct. 28, 2016, 5:15 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53082/ --- (Updated Oct. 28, 2016, 5:14 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Oct. 28, 2016, 5:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 28, 2016, 5:13 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 53252: Added `hashset` constructor for type that supports `begin()/end()`.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53252/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.

Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53253/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.

Re: Review Request 53058: Added tests for whole protobuf message based authorization.

2016-10-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53058/ --- (Updated Oct. 28, 2016, 6:11 a.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 52600: Enable multiple field based authorization in the authorizer interface.

2016-10-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/ --- (Updated Oct. 28, 2016, 6:08 a.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-27 Thread haosdent huang
> On Oct. 25, 2016, 7:28 p.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 135-150 > > > > > > We might need to cleanup this part. It's likely that `baseHierarchy` is > > not the parent of

Re: Review Request 52765: Populated `recovered_slaves` in master `/state` endpoint.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/#review154091 --- src/master/http.cpp (lines 2652 - 2655)

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/#review154089 --- Ship it! Ship It! - Anand Mazumdar On Oct. 21, 2016, 6:39

Re: Review Request 52637: Added `recovered_agents` in `GetAgents` response.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/#review154087 --- Ship it! Ship It! - Anand Mazumdar On Oct. 21, 2016, 9:01

Re: Review Request 53095: Make `slaves.recovered` in master a hashmap.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53095/#review154086 --- Ship it! Ship It! - Anand Mazumdar On Oct. 21, 2016, 6:38

Re: Review Request 53116: Removed `ProvisionerProcess::__provision()`.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53116/#review154085 --- Ship it! Ship It! - Jie Yu On Oct. 25, 2016, 3:47 a.m.,

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/#review154084 --- src/slave/containerizer/mesos/provisioner/backends/copy.cpp

Review Request 53249: Added MESOS-5788 to 1.1.0 CHANGELOG.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53249/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

2016-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52880/#review154083 --- Patch looks great! Reviews applied: [52878, 53084, 53196, 53197,

Re: Review Request 53245: Added `MasterInfo` to the subscribed event.

2016-10-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53245/#review154077 --- Fix it, then Ship it!

Re: Review Request 53245: Added `MasterInfo` to the subscribed event.

2016-10-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53245/#review154076 --- Ship it! Ship It! - Vinod Kone On Oct. 27, 2016, 11:11

Review Request 53245: Added `MasterInfo` to the subscribed event.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53245/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 53246: Populated `MasterInfo` evolving from v0 framework registered message.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53246/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 53247: Populated `MasterInfo` in the v0 Java adapter.

2016-10-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53247/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Re: Review Request 53239: Changed master to make use of "retired" agent IDs.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53239/ --- (Updated Oct. 27, 2016, 10:46 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53227: Added the '--launcher_dir' flag to the default executor.

2016-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53227/#review154072 --- Patch looks great! Reviews applied: [53227] Passed command:

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53202/#review154070 --- Ship it! Ship It! - Jiang Yan Xu On Oct. 27, 2016, 2:11

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53202/ --- (Updated Oct. 27, 2016, 9:11 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

2016-10-27 Thread Anindya Sinha
> On Oct. 17, 2016, 6:22 p.m., Neil Conway wrote: > > docs/shared-resources.md, line 168 > > > > > > I think we should discuss what happens if you try to write to a > > read-only volume. > > Jiang Yan Xu wrote: >

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

2016-10-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/ --- (Updated Oct. 27, 2016, 1:27 p.m.) Review request for mesos,

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

2016-10-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/#review154068 --- Ship it! Ship It! - Anindya Sinha On Oct. 27, 2016, 7:06

Re: Review Request 53161: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/#review154050 --- Fix it, then Ship it! src/slave/containerizer/mesos/utils.hpp

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

2016-10-27 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Oct. 27, 2016, 7:32 p.m.) Review request for mesos, James Peach,

Re: Review Request 53230: Added test cases for HTTPS health check.

2016-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53230/#review154067 --- Patch looks great! Reviews applied: [53230] Passed command:

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

2016-10-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/ --- (Updated Oct. 27, 2016, 12:06 p.m.) Review request for mesos,

Review Request 53239: Changed master to make use of "retired" agent IDs.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53239/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53238: Changed agent to report "retired" agent IDs on registration.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53238/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53237: Improved slave recovery tests to check reconciliation, metrics.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53237/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53236: Cleaned up Master::markUnreachableAfterFailover.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53236/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53235: Cleaned up header includes and `using`.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53235/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53234: Logged warning message if reading previous boot ID fails.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53234/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Review Request 53233: Simplified `State::recover` interface in the agent.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53233/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5396

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Jiang Yan Xu
> On Oct. 26, 2016, 2:43 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 6036-6037 > > > > > > Assuming frameworks are not partition-aware based on the agent verison > > doesn't feel right. > > > >

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52880/ --- (Updated Oct. 27, 2016, 5:34 p.m.) Review request for mesos, Alexander

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Oct. 27, 2016, 5:34 p.m.) Review request for mesos, Alexander

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/ --- (Updated Oct. 27, 2016, 5:32 p.m.) Review request for mesos, Alexander

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

2016-10-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/ --- (Updated Oct. 27, 2016, 10:27 a.m.) Review request for mesos,

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/#review154049 --- Ship it! Ship It! - Jie Yu On Oct. 25, 2016, 3:43 a.m.,

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53202/ --- (Updated Oct. 27, 2016, 5:16 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Neil Conway
> On Oct. 26, 2016, 9:54 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, line 6047 > > > > > > If neither of the above is true, can we log a warning? We recommend > > aganist this situation but in operations

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

2016-10-27 Thread Aaron Wood
> On Oct. 17, 2016, 3:39 p.m., James Peach wrote: > > 3rdparty/stout/tests/ip_tests.cpp, line 50 > > > > > > Probably better to just use the same type here. Since > > ``network.get().prefix()`` returns ``int``,

Re: Review Request 53042: Added `FsTest.Xattr` test.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53042/#review154043 --- Fix it, then Ship it!

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review154042 --- Fix it, then Ship it!

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

2016-10-27 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 27, 2016, 4:51 p.m.) Review request for mesos, James Peach,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

2016-10-27 Thread James Peach
> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > > > > > Can you just make ``length`` type ``ssize_t``? > > Aaron Wood wrote: > `length` is

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Oct. 27, 2016, 4:21 p.m.) Review request for mesos, Alexander

Re: Review Request 52878: Removed outdated TODO in stout::flags.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52878/ --- (Updated Oct. 27, 2016, 4:20 p.m.) Review request for mesos, Alexander

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/ --- (Updated Oct. 27, 2016, 4:20 p.m.) Review request for mesos, Alexander

Re: Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53197/ --- (Updated Oct. 27, 2016, 4:19 p.m.) Review request for mesos, Alexander

Re: Review Request 53227: Added the '--launcher_dir' flag to the default executor.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53227/#review154031 --- The idea of this patch is to resolve MESOS-6288 and to unblock

Review Request 53227: Added the '--launcher_dir' flag to the default executor.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53227/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6288

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

2016-10-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review154028 --- src/launcher/default_executor.cpp (line 1033)

Re: Review Request 53230: Added test cases for HTTPS health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53230/ --- (Updated Oct. 27, 2016, 4:06 p.m.) Review request for mesos, Alexander

Review Request 53230: Added test cases for HTTPS health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53230/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Re: Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53197/ --- (Updated Oct. 27, 2016, 3:51 p.m.) Review request for mesos, Alexander

Re: Review Request 53196: Fixed a typo in 'tests/containerizer.cpp'.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53196/ --- (Updated Oct. 27, 2016, 3:50 p.m.) Review request for mesos, Alexander

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/ --- (Updated Oct. 27, 2016, 3:49 p.m.) Review request for mesos, Alexander

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

2016-10-27 Thread Yubo Li
> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 700 > > > > > > I would reword this to explicitly mention that tasks launched with the > > docker containerizer require

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

2016-10-27 Thread Neil Conway
> On Oct. 26, 2016, 9:43 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 6036-6037 > > > > > > Assuming frameworks are not partition-aware based on the agent verison > > doesn't feel right. > > > >

Re: Review Request 53226: Fixed HealthyTaskViaHTTPWithoutType test.

2016-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53226/#review154014 --- Bad patch! Reviews applied: [53226] Failed command:

Re: Review Request 53226: Fixed HealthyTaskViaHTTPWithoutType test.

2016-10-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53226/#review154013 --- Ship it! Ship It! - Gastón Kleiman On Oct. 27, 2016, 2:09

Re: Review Request 53226: Fixed HealthyTaskViaHTTPWithoutType test.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53226/#review154011 --- Ship it! Ship It! - haosdent huang On Oct. 27, 2016, 2:09

Re: Review Request 53084: Updated the env variable used to enable SSL.

2016-10-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review154012 --- src/launcher/default_executor.cpp (line 1037)

Review Request 53226: Fixed HealthyTaskViaHTTPWithoutType test.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53226/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Bugs: MESOS-6293

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 1:51 p.m.) Review request for mesos, Alexander

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 1:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 1:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review154005 --- Ship it! I'll fix the outstanding issues and will commit this

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review154004 --- src/tests/health_check_tests.cpp (lines 357 - 361)

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review154003 --- src/webui/master/static/js/controllers.js (lines 327 - 337)

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/#review154002 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/#review154001 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review154000 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153999 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153998 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 12:14 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:14 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 27, 2016, 12:14 p.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 27, 2016, 12:07 p.m.) Review request for mesos, Alexander

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- (Updated Oct. 27, 2016, 12:06 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 27, 2016, 12:05 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:05 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:03 p.m.) Review request for mesos, Alexander

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 12:02 p.m.) Review request for mesos, Alexander

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review153993 --- src/tests/health_check_tests.cpp (line 1463)

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153994 --- src/tests/health_check_tests.cpp (lines 1636 - 1637)

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153989 --- src/tests/health_check_tests.cpp (line 1388)

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

2016-10-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153988 --- Patch looks great! Reviews applied: [53193, 53172] Passed