Review Request 61237: Updated docker executor to return IPv6 address of a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61237/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7807

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61030/#review181747 --- Patch looks great! Reviews applied: [61034, 61031, 61032, 61033,

Re: Review Request 60765: Added basic `network/ports` isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60765/ --- (Updated July 29, 2017, 12:02 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated July 29, 2017, 12:01 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 61033: Added missing metrics to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181743 --- Ship it! Ship It! - Vinod Kone On July 28, 2017, 2:40 p.m.,

Re: Review Request 61218: Adjusted the style in metrics tests for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61218/#review181744 --- Ship it! Ship It! - Vinod Kone On July 28, 2017, 2:39 p.m.,

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review181736 --- src/slave/slave.cpp Lines 833 (patched)

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review181734 --- src/resource_provider/message.hpp Lines 29 (patched)

Re: Review Request 61181: Stored subscribed resources in resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61181/#review181733 --- src/resource_provider/manager.cpp Lines 270-274 (patched)

Re: Review Request 61180: Added a resource providers total resources to the subscribe call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61180/#review181732 --- Ship it! Ship It! - Jie Yu On July 27, 2017, 2:49 p.m.,

Re: Review Request 61179: Added 'devolve' overload for 'ResourceProviderID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61179/#review181726 --- Fix it, then Ship it! src/internal/devolve.hpp Lines 69

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181723 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 130-133

Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61220/#review181722 --- Can we also add it to upgrades.md? It's not a new flag but the

Re: Review Request 60002: Added ENUM preprocessor macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60002/#review181719 --- Ship it! Ship It! - Michael Park On July 17, 2017, 4:41

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review181717 --- Looks good overall!

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/#review181712 --- Fix it, then Ship it! Nice tests!

Re: Review Request 61123: Added regression test for sandbox volume ownership issue.

> On July 26, 2017, 11:08 a.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > > > > > Why do we need Docker for this test? The problem should be

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/ --- (Updated July 28, 2017, 12:24 p.m.) Review request for mesos, Greg Mann, Ilya

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181713 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 43 (patched)

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181682 --- Fix it, then Ship it!

Re: Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/#review181691 --- src/common/http.cpp Lines 1005-1009 (patched)

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/#review181694 --- Ship it! Ship It! - James Peach On July 28, 2017, 1:42

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/#review181693 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Review Request 61222: Added V1 teardown call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61222/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-6846

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181684 --- src/linux/cgroups.hpp Lines 458 (patched)

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60934/#review181687 --- I don't see any tests for this? - James Peach On July 26,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181683 --- include/mesos/mesos.proto Lines 2920 (patched)

Review Request 61220: Added MESOS-5116 to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61220/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

> On July 28, 2017, 12:35 a.m., Avinash sridharan wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4357 (patched) > > > > > > Can we have a test for checking validation error on setting

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

> On July 28, 2017, 8:41 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1226 (patched) > > > > > > Similar to the `DockerContainerizer` can we add a test for the flags

Re: Review Request 61032: Fixed slaves_unreachable metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61032/ --- (Updated July 28, 2017, 2:40 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 61033: Added missing metrics to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/ --- (Updated July 28, 2017, 2:40 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61030/ --- (Updated July 28, 2017, 2:39 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 61218: Adjusted the style in metrics tests for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61218/ --- Review request for mesos, Armand Grillet and Vinod Kone. Repository: mesos

Re: Review Request 61029: Added metric for connected API subscribers in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61029/ --- (Updated July 28, 2017, 2:39 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61028: Added metric for API subscribe calls in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61028/ --- (Updated July 28, 2017, 2:39 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

> On July 28, 2017, 8:35 a.m., Avinash sridharan wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4357 (patched) > > > > > > Can we have a test for checking validation error on setting up

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61031/ --- (Updated July 28, 2017, 2:37 p.m.) Review request for mesos, Armand Grillet

Review Request 61219: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNSWildcardMatch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61219/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- (Updated July 28, 2017, 10:34 p.m.) Review request for mesos, Avinash

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61031/ --- (Updated July 28, 2017, 2:32 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 61034: Minor style cleanups in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61034/ --- (Updated July 28, 2017, 2:33 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

> On July 28, 2017, 8:48 a.m., Avinash sridharan wrote: > > src/docker/docker.cpp > > Lines 755 (patched) > > > > > > I think we need to add the wild card `*` match for `USER` network here. > > Basically if mode is

Re: Review Request 61075: Set container DNS with `--default_container_dns` in DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61075/ --- (Updated July 28, 2017, 10:32 p.m.) Review request for mesos, Avinash

Re: Review Request 61034: Minor style cleanups in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61034/ --- (Updated July 28, 2017, 2:32 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 28, 2017, 10:32 p.m.) Review request for mesos, Avinash

Re: Review Request 61033: Added missing metrics to tests.

> On July 25, 2017, 10:12 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp > > Line 1364 (original), 1365 (patched) > > > > > > I see that you sneaked in a style fix here. Please avoid when possible. I felt

Re: Review Request 61032: Fixed slaves_unreachable metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61032/ --- (Updated July 28, 2017, 2:10 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 61032: Fixed slaves_unreachable metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61032/ --- (Updated July 28, 2017, 2:07 p.m.) Review request for mesos, Armand Grillet

Review Request 61212: Added CLI utility functions to check IPs and ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7840

Review Request 61213: Added 'mesos task list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7840

Review Request 61211: Added default configuration file for CLI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61211/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7840

Review Request 61210: Renamed constants for CLI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61210/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7840

Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61121/#review181661 --- Ship it! Ship It! - Ilya Pronin On July 28, 2017, 2:43

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/#review181659 --- Ship it! LGTM! - Ilya Pronin On July 28, 2017, 2:42 a.m.,

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/ --- (Updated July 28, 2017, 12:54 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/ --- (Updated July 28, 2017, 1:57 p.m.) Review request for mesos, Adam B, Greg

Re: Review Request 61123: Added regression test for sandbox volume ownership issue.

> On July 26, 2017, 7:08 p.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > > > > > Why do we need Docker for this test? The problem should be

Re: Review Request 61089: Logged each container state transition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61089/#review181648 --- Ship it! Ship It! - Gilbert Song On July 26, 2017, 12:18