Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 15, 2016, 3:51 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 275-280 > > > > > > I would pull this into a helper in `Metrics` similar to > > `createGaugesForResou

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review122053 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-272 > > > > > > Does it make sense to wrap framework-related metrics in a separate > > struct in

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-272 > > > > > > Does it make sense to wrap framework-related metrics in a separate > > struct in

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 12:29 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-271 > > > > > > As in the previous review, I find much more readable: > > > > ```c++ > >

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121434 --- src/tests/hierarchical_allocator_tests.cpp (lines 2449 - 2455)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121421 --- src/master/allocator/mesos/hierarchical.hpp (lines 289 - 290)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 29, 2016, 5:08 p.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2498-2502 > > > > > > This is my fault, I don't know how I missed this, but here you can even > > reused t

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121360 --- src/master/allocator/mesos/hierarchical.cpp (lines 268 - 271)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121343 --- src/tests/hierarchical_allocator_tests.cpp (line 2481)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 29, 2016, 6:08 p.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2498-2502 > > > > > > This is my fault, I don't know how I missed this, but here you can even > > reused t

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121254 --- src/tests/hierarchical_allocator_tests.cpp (lines 2498 - 2502)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 25, 2016, 5:30 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framework

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2432-2436 > > > > > > This looks rather hard to read. I think a better solution would look > > like this:

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framewor

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121001 --- As with the previous one, I don't know whether this metric will he

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 25, 2016, 5:30 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framework

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 26, 2016, 6:02 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120716 --- src/master/allocator/mesos/hierarchical.hpp (line 376)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 25, 2016, 12:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1204 > > > > > > Even though I really like the anonymous namespace, we don't use it for > > some reasons

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 25, 2016, 12:37 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120597 --- src/master/allocator/mesos/hierarchical.cpp (line 1204)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 9:37 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1354 > > > > > > The counter may count twice for some cases, one framework may get > > resource allocation in b

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 11:49 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 24, 2016, 1:53 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1354 > > > > > > The counter may count twice for some cases, one framework may get > > resource allocation in

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2369-2370 > > > > > > What about following format? > > > > allocator->setQuota( > > framework1.

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 24, 2016, 10:18 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 24, 2016, 1:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2369-2370 > > > > > > What about following format? > > > > allocator->setQuota( > > framework1

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120422 --- src/master/allocator/mesos/hierarchical.cpp (line 1197)

Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4719